sharpe [Mon, 27 Oct 2003 01:35:53 +0000 (01:35 +0000)]
Add filter button support to FibreChannel stats and DCERPC stats.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8785
f5534014-38df-0310-8fa8-
9805f1628bb7
sharpe [Mon, 27 Oct 2003 01:20:16 +0000 (01:20 +0000)]
Add Filter Button support for onc-rpc as well ...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8784
f5534014-38df-0310-8fa8-
9805f1628bb7
sharpe [Mon, 27 Oct 2003 01:09:32 +0000 (01:09 +0000)]
Make sure that Clicking OK in the filter creation dialog box does not act
as an OK to the dialog box it is called from.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8783
f5534014-38df-0310-8fa8-
9805f1628bb7
sharpe [Mon, 27 Oct 2003 00:54:02 +0000 (00:54 +0000)]
This changes the Filter: label in the SMB Service Response Time dialog box to
a button that brings up the Create Filter dialog box. While it works, the
problem is that it also acts as an Enter keypress as far as the start_stat
button is concerned.
Probably needs a small fix.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8782
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sun, 26 Oct 2003 03:09:03 +0000 (03:09 +0000)]
Update to cf_get_display_name()
return "<no file>" if there is no file loaded yet instead of crashing in io-stat
io-stat only print the label for the top tick on the y axis to make it look less cluttered
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8781
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 25 Oct 2003 07:17:28 +0000 (07:17 +0000)]
Add a new WTAP_ENCAP_CHDLC_WITH_PHDR type, to distinguish Cisco HDLC
captures with packet direction information from captures without it.
Use them appropriately.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8780
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 25 Oct 2003 06:49:45 +0000 (06:49 +0000)]
In restricted character strings, deal with character values that are
greater than the alphabet length.
Just use "proto_tree_add_item()" if you have a range of bytes, of known
length, that are to be added as an item - that handles both FT_STRING
and FT_BYTES, including null-terminating the string value.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8779
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 25 Oct 2003 06:19:04 +0000 (06:19 +0000)]
Add one more Cisco protocol type.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8778
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 25 Oct 2003 06:10:21 +0000 (06:10 +0000)]
Add some additional Cisco Protocol ID values, and URLs for documents
that contain them.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8777
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 25 Oct 2003 06:07:36 +0000 (06:07 +0000)]
Update comments to give a URL that defines some additional CDP type
values, and to use the names from the URL and to refer to it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8776
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 25 Oct 2003 00:25:38 +0000 (00:25 +0000)]
Update / cleanup to tcp sequence number analysis and new features
moved some variables to the structure where they belonged instead of where they
currently were and reduced the complexity of the code
Fast Retransmission:
Ethereal not tries to detect and flag FastRetransmissions:
The heuristics for this check is:
>=3 dupacks in other direction
this semgent is what the dupacks are asking for
it arrived within 10ms of the last dupack (10ms should be short enough to not confuse with real RTOs)
OutOfOrder segments
Previously all segments that did not advance the right edge of the window was flagged as retransmission now ethereal will try to flag segments that are merely reordered as OutOfOrder segments insteaD
tHE HEURISTICS ARE:
it has not been ACKed yet
we have not seen it before
it arrived within 4ms of the segment immediately to the right in the window
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8775
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 24 Oct 2003 23:55:34 +0000 (23:55 +0000)]
Move the version number checking for libpcap files, to see whether to
swap the "captured length" and "length" fields, to the open-file code;
store a tri-state (definitely swapped, definitely not swapped, maybe
swapped) value in the per-capture-file-format information for libpcap
format, and use that when processing packets.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8774
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 24 Oct 2003 22:59:37 +0000 (22:59 +0000)]
From Taisuke Sasaki: fix offsets of metrics in Inter-Area-Prefix-LSAs
and Inter-Area-Router-LSAs.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8773
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 24 Oct 2003 10:52:04 +0000 (10:52 +0000)]
The capture tools for DGUX has swapped the included/original packet lengths of the frame header.
they specify the pcap version as 543.0
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8772
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 24 Oct 2003 10:46:43 +0000 (10:46 +0000)]
Fix all the issues Michael Oliveras reported
1, TunnellingProtocol_id is a CHOICE not a SEQUENCE
2, change some values to be FT_STRING instead of FT_BYTES
3, update dissect_per_octet_String to always 0 terminate all FT_STRINGs
(if necessary in a temporary buffer) before passing them on to proto_tree_add_string() since that function did not want to handle FT_STRING or FT_STRINGZ othervise.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8771
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 24 Oct 2003 00:50:39 +0000 (00:50 +0000)]
From Anders Broman: make it possible to filter on only address or tag in
the SIP address fields.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8770
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 24 Oct 2003 00:42:16 +0000 (00:42 +0000)]
From Jean-Baptiste Marchand: add more MAPI procedure names.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8769
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 24 Oct 2003 00:38:34 +0000 (00:38 +0000)]
From Michael Lum: get rid of an unused value_string table.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8768
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 24 Oct 2003 00:36:06 +0000 (00:36 +0000)]
From Jim McDonough: add one more nt status code to
packet-dcerpc-smb.c that is often returned from the winreg abortshutdown
operation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8767
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 24 Oct 2003 00:35:29 +0000 (00:35 +0000)]
From Jim McDonough: add dissection of the shutdown, shutdownex, and
abortshutdown commands within the winreg pipe.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8766
f5534014-38df-0310-8fa8-
9805f1628bb7
ashokn [Thu, 23 Oct 2003 18:49:50 +0000 (18:49 +0000)]
Added support for LMP draft version -09. Support for older draft
versions -02 and -03 is still present (since they are in use),
selectable by a protocol preference.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8765
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 23 Oct 2003 08:40:56 +0000 (08:40 +0000)]
The ACL revision field is one byte, not 2 bytes.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8764
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 23 Oct 2003 08:16:50 +0000 (08:16 +0000)]
Non-NCP_SERVICE_REQUEST packets don't have a subfunction.
The group for a request isn't part of the packet, so give it an offset
and length of 0, so if you select it we doesn't highlight some part of
the packet.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8763
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 23 Oct 2003 07:52:56 +0000 (07:52 +0000)]
Treat NCP 0x5555 packets as NCP requests, so we store them in the hash
table and can identify replies to them.
Clean up white space.
Note that the "is_signed" hack doesn't work with Ethereal.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8762
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 23 Oct 2003 07:14:21 +0000 (07:14 +0000)]
Fix a call to "dissect_dcerpc_cn()" to handle the new return value.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8761
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 23 Oct 2003 05:58:57 +0000 (05:58 +0000)]
Catch exceptions in "dissect_dcerpc_cn_bs()", so that if we get an
exception dissecting stuff past the DCE RPC header, we still drive on
and dissect the next PDU, if any.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8760
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 23 Oct 2003 05:23:41 +0000 (05:23 +0000)]
Get rid of the "offset" argument to "dcerpc_try_handoff()" - it's always
0.
In "dcerpc_try_handoff()", remove the authentication padding from the
stub data handed to the subdissector - that's not really stub data for
the subdissector, and it should throw an exception if the request or
response would go into the authentication padding. Don't even try to
dissect the remaining stub data if the authentication padding value
consumes all the stub data or would consume even more than that.
Show any "Long frame" data before the authentication padding, and show
the authentication padding as the stuff at the very end of the stub
data, after the "Long frame" data.
Catch all exceptions when dissecting authentication information, so that
even if it's bad or we don't have all of it, we still dissect the stub
data.
Try dissecting authentication trailer information even if we don't have
all of it in the tvbuff - we want an exception to be thrown if we don't.
Don't try to dissect it if it eats into the stub data, however.
Don't bother catching exceptions in "dissect_auth_verf()" - we now
always catch exceptions in above it in the DCE RPC dissector call tree.
Use CATCH_ALL and "show_exception()" when calling the sub-dissector for
a connection-oriented PDU; that means we won't have to worry about
adding new exception types unless they're types that we should rethrow.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8759
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 23 Oct 2003 05:01:39 +0000 (05:01 +0000)]
Add a "show_exception()" routine that takes an exception code as an
argument, and puts the appropriate exception indication into the tree.
In "dissect_frame()", do a CATCH_ALL for exceptions, and pass the
exception code to "show_exception()".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8758
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 23 Oct 2003 04:59:46 +0000 (04:59 +0000)]
Add a new EXCEPT_CODE macro to get the exception code for the current
exception, for use in CATCH_ALL handlers, so you can catch all
exceptions and then pass the exception code on to a routine that handles
different exceptions differently.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8757
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 23 Oct 2003 04:57:46 +0000 (04:57 +0000)]
Use -1 rather than "tvb_length(tvb)" to specify a length that covers the
entire tvbuff for Secure Channel bind credentials.
Use -1 rather than 0 to have the top-level item for Secure Channel ACK
credentials cover the entire tvbuff.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8756
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 23 Oct 2003 00:16:20 +0000 (00:16 +0000)]
From Michael Lum: register with the ANSI A-interface dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8755
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 22 Oct 2003 22:13:13 +0000 (22:13 +0000)]
From Ulf Lamping: add a preference to control whether to show or hide
the main toolbar (currently no GUI to set it; that's in progress).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8754
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 22 Oct 2003 21:26:40 +0000 (21:26 +0000)]
From Yaniv Kaul: if there's more than one context item in a BIND PDU, show
the number of context items before showing the first one.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8753
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 22 Oct 2003 21:21:05 +0000 (21:21 +0000)]
From Yaniv Kaul:
remove the check on 3 ports only - since Yahoo! Messenger can
stream on any port;
remove the check that will not dissect if the packet is not big
enough - as partial dissection is also helpful sometimes;
the version is 2 bytes, not 4 bytes.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8752
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 22 Oct 2003 20:59:02 +0000 (20:59 +0000)]
From Michael Lum:
BSSAP (GSM 08.06)/BSAP (IOS 4.0.1) support
IOS 4.0.1 support
Add Transport Layer support to ANSI IS-637-A dissector
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8751
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 22 Oct 2003 20:12:02 +0000 (20:12 +0000)]
From Michael Lum: add new SSN values for RANAP, IOS, and BSSAP/BSAP, and
add a heuristic subdissector list.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8750
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 22 Oct 2003 02:24:14 +0000 (02:24 +0000)]
Get rid of C++ comment.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8749
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 22 Oct 2003 02:22:21 +0000 (02:22 +0000)]
Get rid of carriage returns.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8748
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 22 Oct 2003 02:07:39 +0000 (02:07 +0000)]
From Jaime Fournier
New protocol DCERPC/RS_BIND
Added stub dissector for the RS_BIND protocol
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8747
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 22 Oct 2003 02:03:44 +0000 (02:03 +0000)]
From Jaime Fournier
New protocol DCERPC BUTC
Stub dissector for the BUTC interface
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8746
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 22 Oct 2003 01:55:04 +0000 (01:55 +0000)]
From Jean-Baptiste Marchand
add function names for the TAPI interface
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8745
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 22 Oct 2003 01:28:12 +0000 (01:28 +0000)]
Fix to dissection of Mike's problem reported on ethereal-users
We did align to byte a bit too frequently inside dissect_per_octet_string
Also change GroupIP.group from being a FT_BYTES into being FT_STRING
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8744
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 21 Oct 2003 07:17:16 +0000 (07:17 +0000)]
Catch exceptions when dissecting a verifier, so we still dissect the
stub data even if there's a problem dissecting the verifier.
Show stub data as "Encrypted stub data" if it's encrypted, "Decrypted
stub data" if it was encrypted but we decrypted it, and "Stub data" if
it wasn't encrypted.
Don't attempt to decrypt data unless it was encrypted (i.e., the
authentication level is "Packet privacy".
Get rid of "decrypted_data" member of "packet_info" structure - we don't
need it any more.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8743
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 20 Oct 2003 23:07:43 +0000 (23:07 +0000)]
Warn about Yet Another GCCism.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8742
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 20 Oct 2003 23:05:41 +0000 (23:05 +0000)]
From Jesper Peterson: get rid of GCCism/C++ism - C89 doesn't allow
variables to be declared in the middle of executable code.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8741
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 20 Oct 2003 22:28:22 +0000 (22:28 +0000)]
If a tap menu item doesn't have a "selected_packet_enabled()" or
"selected_tree_row_enabled()" routine, enable it by default, so that
tap windows can be popped up even if you have no capture file.
Assorted code cleanups.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8740
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 20 Oct 2003 20:18:52 +0000 (20:18 +0000)]
From Jim McDonough: add the text sservice name for a UUID/version string
at the top level of a floor, falling back to the UUID/version strings
themselves if the service isn't found.
Use #defines for protocol IDs.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8739
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 20 Oct 2003 19:25:48 +0000 (19:25 +0000)]
From Brad Hards: support TCP desegmentation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8738
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 20 Oct 2003 19:13:17 +0000 (19:13 +0000)]
From Anders Broman:
added decoding of Element IWFA(NSAP address) in IANA ICP format;
fixed decoding of CODEC LIST.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8737
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 20 Oct 2003 19:07:18 +0000 (19:07 +0000)]
From Ulf Lamping:
put toolbar separators in the right places;
get rid of the "Capture Stop" button in Win32.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8736
f5534014-38df-0310-8fa8-
9805f1628bb7
oabad [Mon, 20 Oct 2003 06:06:26 +0000 (06:06 +0000)]
In fileopen_dir_changed_cb() :
- return FALSE immediately if the text entry is empty ;
- return FALSE at the end of the function so that the signal is sent to
the entry. It avoids a Gtk-ERROR (and an abort) :
file: gtkentry.c: line 4338 (blink_cb): assertion failed:
GTK_WIDGET_HAS_FOCUS(entry))
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8735
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 19 Oct 2003 17:30:43 +0000 (17:30 +0000)]
From Emanuele Caratti:
add support for multiple encryption keys, one per conversation,
in a single capture;
add some fields in the accounting dissection.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8734
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 18 Oct 2003 18:46:37 +0000 (18:46 +0000)]
From Emanuele Caratti:
add the dissection of RIPv2 packets with Keyed Message Disest
Authentication (RFC2082);
fix a small bug - the Auth entry must be the first of the RTE in
a RIP packet.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8733
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 17 Oct 2003 23:44:06 +0000 (23:44 +0000)]
Fix a URL.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8732
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 17 Oct 2003 23:43:21 +0000 (23:43 +0000)]
Fix up some comments.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8731
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 17 Oct 2003 22:59:18 +0000 (22:59 +0000)]
From Greg Morris: don't add zero-length items to the tree, add some
missing alignment adjustments, fix a call to "address_item()" to set the
offset to its return value rather than adding its return value to the
offset, handle an object type of 2 (counted list of objects) in an event
handling profile, advance the offset past length values after processing
the length value.
Fix some additional "address_item()" calls, and put the aforementioned
length values into the protocol tree.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8730
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 17 Oct 2003 21:28:02 +0000 (21:28 +0000)]
Update credits for Shinsuke Suzuki.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8729
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 17 Oct 2003 21:27:34 +0000 (21:27 +0000)]
From Shinsuke Suzuki: support Address List Option, newly introduced in
draft-ietf-pim-sm-v2-new-08.txt.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8728
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 17 Oct 2003 21:26:56 +0000 (21:26 +0000)]
From Shinsuke Suzuki:
- support RFC3319
- update the RFC/i-d name
- change the DHCPv6 option numbers to catch up with the
latest IANA's assignment status
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8727
f5534014-38df-0310-8fa8-
9805f1628bb7
oabad [Fri, 17 Oct 2003 17:28:38 +0000 (17:28 +0000)]
From Olivier Biot : remove packet capture code when compiling without
libpcap.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8726
f5534014-38df-0310-8fa8-
9805f1628bb7
oabad [Fri, 17 Oct 2003 17:20:32 +0000 (17:20 +0000)]
Use gtk_tree_view_expand_to_path() in gtk2 code to expand a node, as it
also expands parent nodes if necessary.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8725
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 17 Oct 2003 08:14:19 +0000 (08:14 +0000)]
Further expand a comment.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8724
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 17 Oct 2003 08:01:51 +0000 (08:01 +0000)]
destinationType is an EndPointType and NOT an EndPoint
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8723
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 17 Oct 2003 07:45:20 +0000 (07:45 +0000)]
change the h225 emailid from a sequence of bytes to a string
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8722
f5534014-38df-0310-8fa8-
9805f1628bb7
oabad [Fri, 17 Oct 2003 06:06:04 +0000 (06:06 +0000)]
Change the comments about toolbar elements resizing as it is not
necessary in GTK+ 2.x
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8721
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 16 Oct 2003 21:19:12 +0000 (21:19 +0000)]
From Ulf Lamping: add a GUI preference item to control the toolbar
style.
Make the style text arrays static, as nobody uses them outside prefs.c.
Use FALSE and TRUE for the values for the Boolean controlling the
highlighting style.
Note that we're now using stock icons in the toolbar in GTK+ 2.x.
Put back the resizing of elements in the top-level container, at least
for GTK+ 1.2[.x]; otherwise, the toolbar's height never gets smaller,
even if you change the style in such a way as to reduce the height of
the elements (icons+text -> icons or text, icons -> text).
Make some routines and variables not used outside gtk/toolbar.c static.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8720
f5534014-38df-0310-8fa8-
9805f1628bb7
oabad [Thu, 16 Oct 2003 21:04:20 +0000 (21:04 +0000)]
Put back Guy's changes from r1.3 (print callback, and "Find frame..."
tooltip).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8719
f5534014-38df-0310-8fa8-
9805f1628bb7
oabad [Thu, 16 Oct 2003 20:56:07 +0000 (20:56 +0000)]
- use stock icons in the toolbar when using GTK2
- use GTK1/2 compatibility macros [GS]ET_OBJECT_DATA where needed
- add a set_toolbar_object_data() function which associates the display
filter entry (from the main window) with the E_DFILTER_TE_KEY for the
open and reload buttons (it is needed by the open and reload
callbacks). The function is called in create_main_window()
- reindent
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8718
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 16 Oct 2003 18:15:54 +0000 (18:15 +0000)]
From Michael Lum: fixed some formatting and removed unused code.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8717
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 16 Oct 2003 18:14:32 +0000 (18:14 +0000)]
From Michael Lum: add missing g_free() calls.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8716
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 16 Oct 2003 09:55:10 +0000 (09:55 +0000)]
From Michal Melerowicz:
merge gtpv0 and gtpv1 dissectors into one;
fix up XXX_to_str routines.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8715
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 16 Oct 2003 06:47:47 +0000 (06:47 +0000)]
Get rid of a value_string table that was used by now-deleted code.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8714
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 16 Oct 2003 00:45:12 +0000 (00:45 +0000)]
There doesn't seem to be any need to set "cfile.dfilter" to the contents
of the filter text entry when reloading the file, and:
1) that doesn't work with the toolbar "reload" button (the
widget passed in for that button doesn't have a
E_DFILTER_TE_KEY data item pointing to the text entry);
2) that causes the Tools > Summary dialog box to report what
you've typed in that box, not the filter that's actually in
effect (i.e., it causes "cfile.dfilter" to reflect what's
been typed, not what's been applied);
so don't bother doing so. That also means that the "/File/Reload" menu
item doesn't need a E_DFILTER_TE_KEY data item, so don't give it one.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8713
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 15 Oct 2003 22:37:19 +0000 (22:37 +0000)]
"Find frame" can do more than search with a display filter.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8712
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 15 Oct 2003 22:34:58 +0000 (22:34 +0000)]
Note that we might want to use the GTK+ 2.x stock icon mechanism when
building for GTK+ 2.x.
Fix the callback for the "Print" button.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8711
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 15 Oct 2003 22:00:02 +0000 (22:00 +0000)]
From Giles Scott: make some items in the ICMP protocol tree named fields.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8710
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 15 Oct 2003 20:07:51 +0000 (20:07 +0000)]
Put back a missing comment.
Get rid of some extra blanks at the end of the text for some protocol
tree items.
Use %u, not %d, to format unsigned quantities.
Make the "Client Authentication Methods" item's length cover all the
authentication methods, not just the count of methods.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8709
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 15 Oct 2003 19:57:27 +0000 (19:57 +0000)]
From David E. Weekly: move the code to put the SOCKS version up, so it's
done in common code.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8708
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 15 Oct 2003 19:40:42 +0000 (19:40 +0000)]
From Ulf Lamping: toolbar.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8707
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 15 Oct 2003 13:10:54 +0000 (13:10 +0000)]
Client LOAD measurement for io-stat
See manpage (hopefully manpage does not reformat my nice ascii graph)
While Service Response Times and the MIN/MAX/AVG thing in io-stat are measurements on the server load. The new measurement type LOAD is a measurement of Client LOAD.
Or rather, it is an attempt to measure client LOAD by measuring how much concurrency in its requests the client generates. It the client is slow in starting new i/o when a previous i/o has completed, this willb e indicated by the concurrency being lowered.
it is an experiment. i am not aware of any other attempts in deducing client workload from looking at captures.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8706
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 15 Oct 2003 09:18:33 +0000 (09:18 +0000)]
Fix the XXX_to_str routines
1) not to rely on their static buffers being initialized;
2) not to bother checking whether a BCD digit is a valid digit
or not (index into a 16-element array, instead);
3) to work correctly, in the case of "id_to_str()".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8705
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 15 Oct 2003 08:41:41 +0000 (08:41 +0000)]
Remove the unnecassary HashTable and use gtk_object_[get|set]_data
to keep track of which io structure a certain draw area is associated with.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8704
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 15 Oct 2003 08:25:29 +0000 (08:25 +0000)]
remove an extra ';' to keep visual studio happy
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8703
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 15 Oct 2003 08:08:28 +0000 (08:08 +0000)]
We got rid of the wrong hf_devmode_driver_extra; bring the wrong one
back, and get rid of the one that shouldn't be kept around.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8702
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 15 Oct 2003 02:13:33 +0000 (02:13 +0000)]
Move the filter syntax description to the ethereal-filter pod page.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8701
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 14 Oct 2003 23:42:19 +0000 (23:42 +0000)]
Clean up the stuff that fills in the starting directory.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8700
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 14 Oct 2003 23:20:17 +0000 (23:20 +0000)]
From Ian Schorr:
Add a preference to control whether the "File > Open" dialog box
should start out in the last directory in which it looked - and
save that in the preferences file across invocations - or should
always start out in a user-specified directory, and add another
preference to specify that directory.
Write out section name comments into the preferences file.
Clean up white space a bit.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8699
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 14 Oct 2003 21:26:37 +0000 (21:26 +0000)]
Add a comment for (maybe) later connection handling
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8698
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 14 Oct 2003 21:24:57 +0000 (21:24 +0000)]
Update list of SIP RFCs
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8697
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 14 Oct 2003 17:50:01 +0000 (17:50 +0000)]
From Jeff Morriss: note in the Protocol column that we're assuming the
ITU dialect of ISUP.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8696
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 14 Oct 2003 10:34:58 +0000 (10:34 +0000)]
update to iostat,
added new plot style: filled bar
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8695
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 14 Oct 2003 10:01:00 +0000 (10:01 +0000)]
remove the redundant count_type structure as part of the iostat cleanup
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8694
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 14 Oct 2003 09:55:40 +0000 (09:55 +0000)]
further cleanup
remove redundant structure for yscale_max
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8693
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 14 Oct 2003 09:27:42 +0000 (09:27 +0000)]
further cleanup
remove the redundant pixels_per_tick structure
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8692
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 14 Oct 2003 09:15:51 +0000 (09:15 +0000)]
Simplify handling of tick val
remove unnessecary code and structures cleanup
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8691
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 14 Oct 2003 09:11:53 +0000 (09:11 +0000)]
From Motonori Shindo: Key Information dissection in EAPOL-Key messages.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8690
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 14 Oct 2003 09:03:03 +0000 (09:03 +0000)]
update to iostat
add different styles to draw the plot
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8689
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 14 Oct 2003 08:56:30 +0000 (08:56 +0000)]
Add a .cvsignore file.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8688
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 14 Oct 2003 07:36:39 +0000 (07:36 +0000)]
Do the tests for various extra "-L" and "-l" flags that might be needed
with "-lsnmp" in a loop; this fixes up the configure script's operation
on Solaris.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8687
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 14 Oct 2003 01:18:11 +0000 (01:18 +0000)]
From Erwin Rol: ACN support.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8686
f5534014-38df-0310-8fa8-
9805f1628bb7