r25306: Add tests for string_sub().

(This used to be commit 2d37ddcbd1243f48d81af17d8ea3cdd6e8e35b8d)

diff --git a/.bzrignore b/.bzrignore
index 00ae9572e27040ac9c88b25b7792bd14bcd8ea52..39f306eabdfcfe66f5a19a589972336c068d0782 100644 (file)
--- a/.bzrignore
+++ b/.bzrignore
@@ -200,3 +200,5 @@ test-results
 source/lib/ldb-samba/ldif_handlers.h
 rpc_server/lsa/proto.h
 torture/winbind/proto.h
 source/lib/ldb-samba/ldif_handlers.h
 rpc_server/lsa/proto.h
 torture/winbind/proto.h

+source/rpc_server/lsa/proto.h
+source/torture/winbind/proto.h

diff --git a/source4/lib/util/tests/file.c b/source4/lib/util/tests/file.c
index 0fe117a300e32631083eb5ac78f0a8a2b7e22b0f..fe87293671ec82613e646e4257e42a37da580e5a 100644 (file)
--- a/source4/lib/util/tests/file.c
+++ b/source4/lib/util/tests/file.c
@@ -88,10 +88,10 @@ struct torture_suite *torture_local_util_file(TALLOC_CTX *mem_ctx)
        struct torture_suite *suite = torture_suite_create(mem_ctx, "FILE");
 
        torture_suite_add_simple_test(suite, "file_load_save", 
        struct torture_suite *suite = torture_suite_create(mem_ctx, "FILE");
 
        torture_suite_add_simple_test(suite, "file_load_save", 

-                                                                  test_file_load_save);
+                                     test_file_load_save);

 
        torture_suite_add_simple_test(suite, "afdgets", 
 
        torture_suite_add_simple_test(suite, "afdgets", 

-                                                                  test_afdgets);
+                                     test_afdgets);

 
        return suite;
 }
 
        return suite;
 }

diff --git a/source4/lib/util/tests/str.c b/source4/lib/util/tests/str.c
new file mode 100644 (file)
index 0000000..4a964af
--- /dev/null
+++ b/source4/lib/util/tests/str.c
@@ -0,0 +1,78 @@
+/* 
+   Unix SMB/CIFS implementation.
+
+   util_str testing
+
+   Copyright (C) Jelmer Vernooij <jelmer@samba.org> 2007
+   
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+   
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+   
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
+*/
+
+#include "includes.h"
+#include "torture/ui.h"
+
+static bool test_string_sub_simple(struct torture_context *tctx)
+{
+       char tmp[100];
+       safe_strcpy(tmp, "foobar", sizeof(tmp));
+       string_sub(tmp, "foo", "bar", sizeof(tmp));
+       torture_assert_str_equal(tctx, tmp, "barbar", "invalid sub");
+       return true;
+}
+
+static bool test_string_sub_multiple(struct torture_context *tctx)
+{
+       char tmp[100];
+       safe_strcpy(tmp, "fooblafoo", sizeof(tmp));
+       string_sub(tmp, "foo", "bar", sizeof(tmp));
+       torture_assert_str_equal(tctx, tmp, "barblabar", "invalid sub");
+       return true;
+}
+
+static bool test_string_sub_longer(struct torture_context *tctx)
+{
+       char tmp[100];
+       safe_strcpy(tmp, "foobla", sizeof(tmp));
+       string_sub(tmp, "foo", "blie", sizeof(tmp));
+       torture_assert_str_equal(tctx, tmp, "bliebla", "invalid sub");
+       return true;
+}
+
+static bool test_string_sub_shorter(struct torture_context *tctx)
+{
+       char tmp[100];
+       safe_strcpy(tmp, "foobla", sizeof(tmp));
+       string_sub(tmp, "foo", "bl", sizeof(tmp));
+       torture_assert_str_equal(tctx, tmp, "blbla", "invalid sub");
+       return true;
+}
+
+struct torture_suite *torture_local_util_str(TALLOC_CTX *mem_ctx)
+{
+       struct torture_suite *suite = torture_suite_create(mem_ctx, "STR");
+
+       torture_suite_add_simple_test(suite, "string_sub_simple", 
+                                     test_string_sub_simple);
+
+       torture_suite_add_simple_test(suite, "string_sub_multiple", 
+                                     test_string_sub_multiple);
+
+       torture_suite_add_simple_test(suite, "string_sub_shorter", 
+                                     test_string_sub_shorter);
+
+       torture_suite_add_simple_test(suite, "string_sub_longer", 
+                                     test_string_sub_longer);
+
+       return suite;
+}

diff --git a/source4/lib/util/util_str.c b/source4/lib/util/util_str.c
index 0f1f2d5a1c180555669072ab89cdf73200a0390e..e9f81dbd9b83a1cc6990670c6166316a26e52a24 100644 (file)
--- a/source4/lib/util/util_str.c
+++ b/source4/lib/util/util_str.c
@@ -274,7 +274,7 @@ _PUBLIC_ char *hex_encode_talloc(TALLOC_CTX *mem_ctx, const unsigned char *buff_
 _PUBLIC_ void string_sub(char *s, const char *pattern, const char *insert, size_t len)
 {
        char *p;
 _PUBLIC_ void string_sub(char *s, const char *pattern, const char *insert, size_t len)
 {
        char *p;

-       ssize_t ls,lp,li, i;
+       ssize_t ls, lp, li, i;

 
        if (!insert || !pattern || !*pattern || !s)
                return;
 
        if (!insert || !pattern || !*pattern || !s)
                return;


@@ -286,7 +286,7 @@ _PUBLIC_ void string_sub(char *s, const char *pattern, const char *insert, size_
        if (len == 0)
                len = ls + 1; /* len is number of *bytes* */
 
        if (len == 0)
                len = ls + 1; /* len is number of *bytes* */
 

-       while (lp <= ls && (p = strstr(s,pattern))) {
+       while (lp <= ls && (p = strstr(s, pattern))) {

                if (ls + (li-lp) >= len) {
                        DEBUG(0,("ERROR: string overflow by %d in string_sub(%.50s, %d)\n", 
                                 (int)(ls + (li-lp) - len),
                if (ls + (li-lp) >= len) {
                        DEBUG(0,("ERROR: string overflow by %d in string_sub(%.50s, %d)\n", 
                                 (int)(ls + (li-lp) - len),

diff --git a/source4/torture/local/config.mk b/source4/torture/local/config.mk
index 1364028ab7e1c7f124282cefb66a71eed606d52d..e3ea9e44ef44bd85b3f615079ec008596bee9131 100644 (file)
--- a/source4/torture/local/config.mk
+++ b/source4/torture/local/config.mk
@@ -28,6 +28,7 @@ OBJ_FILES = \
                ../../lib/registry/tests/registry.o \
                resolve.o \
                ../../lib/util/tests/strlist.o \
                ../../lib/registry/tests/registry.o \
                resolve.o \
                ../../lib/util/tests/strlist.o \

+               ../../lib/util/tests/str.o \

                ../../lib/util/tests/file.o \
                ../../lib/util/tests/genrand.o \
                ../../lib/compression/testsuite.o \
                ../../lib/util/tests/file.o \
                ../../lib/util/tests/genrand.o \
                ../../lib/compression/testsuite.o \

diff --git a/source4/torture/local/local.c b/source4/torture/local/local.c
index 90c3c0d3d9ee88fdca365d32bb3b0d09f16a4ec5..a52f5d2f7d5d2ab8a74a36ea968ec35af1f8dc05 100644 (file)
--- a/source4/torture/local/local.c
+++ b/source4/torture/local/local.c
@@ -33,6 +33,7 @@
        torture_local_irpc, 
        torture_local_util_strlist, 
        torture_local_util_file, 
        torture_local_irpc, 
        torture_local_util_strlist, 
        torture_local_util_file, 

+       torture_local_util_str, 

        torture_local_idtree, 
        torture_local_genrand, 
        torture_local_iconv,
        torture_local_idtree, 
        torture_local_genrand, 
        torture_local_iconv,