s4:objectclass LDB module - "ldb_msg_sanity_check" call not really needed

This call should only be performed at the beginning of a request.
"ldb_msg_sanity_check" checks for DN validity (which should already have been
done at the beginning of the request) and empty attributes (which should
be done by the "objectclass_attrs" LDB module).

Hence it is superflous here.

Reviewed-by: abartlet

diff --git a/source4/dsdb/samdb/ldb_modules/objectclass.c b/source4/dsdb/samdb/ldb_modules/objectclass.c
index 4107c9cd7cc2f24becb062c36cd91c44dcd1b9ec..fd39937bc95d5d9a3b53784804ef26ba7497a557 100644 (file)
--- a/source4/dsdb/samdb/ldb_modules/objectclass.c
+++ b/source4/dsdb/samdb/ldb_modules/objectclass.c
@@ -762,11 +762,6 @@ static int objectclass_do_add(struct oc_context *ac)
                }
        }
 
-       ret = ldb_msg_sanity_check(ldb, msg);
-       if (ret != LDB_SUCCESS) {
-               return ret;
-       }
-
        ret = ldb_build_add_req(&add_req, ldb, ac,
                                msg,
                                ac->req->controls,