s4:auth: move make_server_info_netlogon_validation() function arround
authorStefan Metzmacher <metze@samba.org>
Wed, 21 Jan 2009 09:43:15 +0000 (10:43 +0100)
committerStefan Metzmacher <metze@samba.org>
Wed, 21 Jan 2009 12:36:11 +0000 (13:36 +0100)
metze

source4/auth/auth_sam_reply.c
source4/auth/gensec/gensec_krb5.c
source4/auth/ntlm/auth_winbind.c
source4/auth/session.c
source4/auth/session.h
source4/smbd/service_named_pipe.c
source4/torture/auth/pac.c

index 839553632ed4d3a3166fe365e03ddd0467cf89dd..dfa76234b4b631c1a09f2a9c1736ee624fad2647 100644 (file)
@@ -147,3 +147,142 @@ NTSTATUS auth_convert_server_info_saminfo3(TALLOC_CTX *mem_ctx,
        return NT_STATUS_OK;
 }      
 
+/**
+ * Make a server_info struct from the info3 returned by a domain logon 
+ */
+NTSTATUS make_server_info_netlogon_validation(TALLOC_CTX *mem_ctx,
+                                             const char *account_name,
+                                             uint16_t validation_level,
+                                             union netr_Validation *validation,
+                                             struct auth_serversupplied_info **_server_info)
+{
+       struct auth_serversupplied_info *server_info;
+       struct netr_SamBaseInfo *base = NULL;
+       int i;
+
+       switch (validation_level) {
+       case 2:
+               if (!validation || !validation->sam2) {
+                       return NT_STATUS_INVALID_PARAMETER;
+               }
+               base = &validation->sam2->base;
+               break;
+       case 3:
+               if (!validation || !validation->sam3) {
+                       return NT_STATUS_INVALID_PARAMETER;
+               }
+               base = &validation->sam3->base;
+               break;
+       case 6:
+               if (!validation || !validation->sam6) {
+                       return NT_STATUS_INVALID_PARAMETER;
+               }
+               base = &validation->sam6->base;
+               break;
+       default:
+               return NT_STATUS_INVALID_LEVEL;
+       }
+
+       server_info = talloc(mem_ctx, struct auth_serversupplied_info);
+       NT_STATUS_HAVE_NO_MEMORY(server_info);
+
+       /*
+          Here is where we should check the list of
+          trusted domains, and verify that the SID 
+          matches.
+       */
+       server_info->account_sid = dom_sid_add_rid(server_info, base->domain_sid, base->rid);
+       NT_STATUS_HAVE_NO_MEMORY(server_info->account_sid);
+
+
+       server_info->primary_group_sid = dom_sid_add_rid(server_info, base->domain_sid, base->primary_gid);
+       NT_STATUS_HAVE_NO_MEMORY(server_info->primary_group_sid);
+
+       server_info->n_domain_groups = base->groups.count;
+       if (base->groups.count) {
+               server_info->domain_groups = talloc_array(server_info, struct dom_sid*, base->groups.count);
+               NT_STATUS_HAVE_NO_MEMORY(server_info->domain_groups);
+       } else {
+               server_info->domain_groups = NULL;
+       }
+
+       for (i = 0; i < base->groups.count; i++) {
+               server_info->domain_groups[i] = dom_sid_add_rid(server_info, base->domain_sid, base->groups.rids[i].rid);
+               NT_STATUS_HAVE_NO_MEMORY(server_info->domain_groups[i]);
+       }
+
+       /* Copy 'other' sids.  We need to do sid filtering here to
+          prevent possible elevation of privileges.  See:
+
+           http://www.microsoft.com/windows2000/techinfo/administration/security/sidfilter.asp
+         */
+
+       if (validation_level == 3) {
+               struct dom_sid **dgrps = server_info->domain_groups;
+               size_t sidcount = server_info->n_domain_groups + validation->sam3->sidcount;
+               size_t n_dgrps = server_info->n_domain_groups;
+
+               if (validation->sam3->sidcount > 0) {
+                       dgrps = talloc_realloc(server_info, dgrps, struct dom_sid*, sidcount);
+                       NT_STATUS_HAVE_NO_MEMORY(dgrps);
+
+                       for (i = 0; i < validation->sam3->sidcount; i++) {
+                               dgrps[n_dgrps + i] = talloc_reference(dgrps, validation->sam3->sids[i].sid);
+                       }
+               }
+
+               server_info->n_domain_groups = sidcount;
+               server_info->domain_groups = dgrps;
+
+               /* Where are the 'global' sids?... */
+       }
+
+       if (base->account_name.string) {
+               server_info->account_name = talloc_reference(server_info, base->account_name.string);
+       } else {
+               server_info->account_name = talloc_strdup(server_info, account_name);
+               NT_STATUS_HAVE_NO_MEMORY(server_info->account_name);
+       }
+
+       server_info->domain_name = talloc_reference(server_info, base->domain.string);
+       server_info->full_name = talloc_reference(server_info, base->full_name.string);
+       server_info->logon_script = talloc_reference(server_info, base->logon_script.string);
+       server_info->profile_path = talloc_reference(server_info, base->profile_path.string);
+       server_info->home_directory = talloc_reference(server_info, base->home_directory.string);
+       server_info->home_drive = talloc_reference(server_info, base->home_drive.string);
+       server_info->logon_server = talloc_reference(server_info, base->logon_server.string);
+       server_info->last_logon = base->last_logon;
+       server_info->last_logoff = base->last_logoff;
+       server_info->acct_expiry = base->acct_expiry;
+       server_info->last_password_change = base->last_password_change;
+       server_info->allow_password_change = base->allow_password_change;
+       server_info->force_password_change = base->force_password_change;
+       server_info->logon_count = base->logon_count;
+       server_info->bad_password_count = base->bad_password_count;
+       server_info->acct_flags = base->acct_flags;
+
+       server_info->authenticated = true;
+
+       /* ensure we are never given NULL session keys */
+
+       if (all_zero(base->key.key, sizeof(base->key.key))) {
+               server_info->user_session_key = data_blob(NULL, 0);
+       } else {
+               server_info->user_session_key = data_blob_talloc(server_info, base->key.key, sizeof(base->key.key));
+               NT_STATUS_HAVE_NO_MEMORY(server_info->user_session_key.data);
+       }
+
+       if (all_zero(base->LMSessKey.key, sizeof(base->LMSessKey.key))) {
+               server_info->lm_session_key = data_blob(NULL, 0);
+       } else {
+               server_info->lm_session_key = data_blob_talloc(server_info, base->LMSessKey.key, sizeof(base->LMSessKey.key));
+               NT_STATUS_HAVE_NO_MEMORY(server_info->lm_session_key.data);
+       }
+
+       ZERO_STRUCT(server_info->pac_srv_sig);
+       ZERO_STRUCT(server_info->pac_kdc_sig);
+
+       *_server_info = server_info;
+       return NT_STATUS_OK;
+}
+
index 16867366a4890d08959bdf0cc5ed19e6941dbd64..6c6b9289177af7796f0d362518c5c6eb4a65daee 100644 (file)
@@ -30,7 +30,6 @@
 #include "auth/auth.h"
 #include "lib/ldb/include/ldb.h"
 #include "auth/auth_sam.h"
-#include "system/network.h"
 #include "lib/socket/socket.h"
 #include "librpc/rpc/dcerpc.h"
 #include "auth/credentials/credentials.h"
@@ -39,6 +38,7 @@
 #include "auth/gensec/gensec_proto.h"
 #include "param/param.h"
 #include "auth/session_proto.h"
+#include "auth/auth_sam_reply.h"
 
 enum GENSEC_KRB5_STATE {
        GENSEC_KRB5_SERVER_START,
index ac63b242e49901d3c43ce8699c5646eabbe4c018..bf75ad9eca5f99022cb2aefe1ff515240da934c2 100644 (file)
@@ -24,7 +24,7 @@
 #include "includes.h"
 #include "auth/auth.h"
 #include "auth/ntlm/auth_proto.h"
-#include "auth/session_proto.h"
+#include "auth/auth_sam_reply.h"
 #include "nsswitch/winbind_client.h"
 #include "librpc/gen_ndr/ndr_netlogon.h"
 #include "librpc/gen_ndr/ndr_winbind.h"
index 885b2b96c2e404c410dd87217c099249c6e4efd9..ef5646fd37e10dda0ba6282bde5e8f9ea40ed62d 100644 (file)
@@ -201,143 +201,3 @@ void auth_session_info_debug(int dbg_lev,
        security_token_debug(dbg_lev, session_info->security_token);
 }
 
-/**
- * Make a server_info struct from the info3 returned by a domain logon 
- */
-_PUBLIC_ NTSTATUS make_server_info_netlogon_validation(TALLOC_CTX *mem_ctx,
-                                             const char *account_name,
-                                             uint16_t validation_level,
-                                             union netr_Validation *validation,
-                                             struct auth_serversupplied_info **_server_info)
-{
-       struct auth_serversupplied_info *server_info;
-       struct netr_SamBaseInfo *base = NULL;
-       int i;
-
-       switch (validation_level) {
-       case 2:
-               if (!validation || !validation->sam2) {
-                       return NT_STATUS_INVALID_PARAMETER;
-               }
-               base = &validation->sam2->base;
-               break;
-       case 3:
-               if (!validation || !validation->sam3) {
-                       return NT_STATUS_INVALID_PARAMETER;
-               }
-               base = &validation->sam3->base;
-               break;
-       case 6:
-               if (!validation || !validation->sam6) {
-                       return NT_STATUS_INVALID_PARAMETER;
-               }
-               base = &validation->sam6->base;
-               break;
-       default:
-               return NT_STATUS_INVALID_LEVEL;
-       }
-
-       server_info = talloc(mem_ctx, struct auth_serversupplied_info);
-       NT_STATUS_HAVE_NO_MEMORY(server_info);
-
-       /*
-          Here is where we should check the list of
-          trusted domains, and verify that the SID 
-          matches.
-       */
-       server_info->account_sid = dom_sid_add_rid(server_info, base->domain_sid, base->rid);
-       NT_STATUS_HAVE_NO_MEMORY(server_info->account_sid);
-
-
-       server_info->primary_group_sid = dom_sid_add_rid(server_info, base->domain_sid, base->primary_gid);
-       NT_STATUS_HAVE_NO_MEMORY(server_info->primary_group_sid);
-
-       server_info->n_domain_groups = base->groups.count;
-       if (base->groups.count) {
-               server_info->domain_groups = talloc_array(server_info, struct dom_sid*, base->groups.count);
-               NT_STATUS_HAVE_NO_MEMORY(server_info->domain_groups);
-       } else {
-               server_info->domain_groups = NULL;
-       }
-
-       for (i = 0; i < base->groups.count; i++) {
-               server_info->domain_groups[i] = dom_sid_add_rid(server_info, base->domain_sid, base->groups.rids[i].rid);
-               NT_STATUS_HAVE_NO_MEMORY(server_info->domain_groups[i]);
-       }
-
-       /* Copy 'other' sids.  We need to do sid filtering here to
-          prevent possible elevation of privileges.  See:
-
-           http://www.microsoft.com/windows2000/techinfo/administration/security/sidfilter.asp
-         */
-
-       if (validation_level == 3) {
-               struct dom_sid **dgrps = server_info->domain_groups;
-               size_t sidcount = server_info->n_domain_groups + validation->sam3->sidcount;
-               size_t n_dgrps = server_info->n_domain_groups;
-
-               if (validation->sam3->sidcount > 0) {
-                       dgrps = talloc_realloc(server_info, dgrps, struct dom_sid*, sidcount);
-                       NT_STATUS_HAVE_NO_MEMORY(dgrps);
-
-                       for (i = 0; i < validation->sam3->sidcount; i++) {
-                               dgrps[n_dgrps + i] = talloc_reference(dgrps, validation->sam3->sids[i].sid);
-                       }
-               }
-
-               server_info->n_domain_groups = sidcount;
-               server_info->domain_groups = dgrps;
-
-               /* Where are the 'global' sids?... */
-       }
-
-       if (base->account_name.string) {
-               server_info->account_name = talloc_reference(server_info, base->account_name.string);
-       } else {
-               server_info->account_name = talloc_strdup(server_info, account_name);
-               NT_STATUS_HAVE_NO_MEMORY(server_info->account_name);
-       }
-
-       server_info->domain_name = talloc_reference(server_info, base->domain.string);
-       server_info->full_name = talloc_reference(server_info, base->full_name.string);
-       server_info->logon_script = talloc_reference(server_info, base->logon_script.string);
-       server_info->profile_path = talloc_reference(server_info, base->profile_path.string);
-       server_info->home_directory = talloc_reference(server_info, base->home_directory.string);
-       server_info->home_drive = talloc_reference(server_info, base->home_drive.string);
-       server_info->logon_server = talloc_reference(server_info, base->logon_server.string);
-       server_info->last_logon = base->last_logon;
-       server_info->last_logoff = base->last_logoff;
-       server_info->acct_expiry = base->acct_expiry;
-       server_info->last_password_change = base->last_password_change;
-       server_info->allow_password_change = base->allow_password_change;
-       server_info->force_password_change = base->force_password_change;
-       server_info->logon_count = base->logon_count;
-       server_info->bad_password_count = base->bad_password_count;
-       server_info->acct_flags = base->acct_flags;
-
-       server_info->authenticated = true;
-
-       /* ensure we are never given NULL session keys */
-
-       if (all_zero(base->key.key, sizeof(base->key.key))) {
-               server_info->user_session_key = data_blob(NULL, 0);
-       } else {
-               server_info->user_session_key = data_blob_talloc(server_info, base->key.key, sizeof(base->key.key));
-               NT_STATUS_HAVE_NO_MEMORY(server_info->user_session_key.data);
-       }
-
-       if (all_zero(base->LMSessKey.key, sizeof(base->LMSessKey.key))) {
-               server_info->lm_session_key = data_blob(NULL, 0);
-       } else {
-               server_info->lm_session_key = data_blob_talloc(server_info, base->LMSessKey.key, sizeof(base->LMSessKey.key));
-               NT_STATUS_HAVE_NO_MEMORY(server_info->lm_session_key.data);
-       }
-
-       ZERO_STRUCT(server_info->pac_srv_sig);
-       ZERO_STRUCT(server_info->pac_kdc_sig);
-
-       *_server_info = server_info;
-       return NT_STATUS_OK;
-}
-
-
index bdb63ec4a2b04346f0007efdc05d249abed823e5..15570c4414f752507b9d24ae97c69869f9ce2261 100644 (file)
@@ -53,11 +53,6 @@ NTSTATUS auth_generate_session_info(TALLOC_CTX *mem_ctx,
                                    struct auth_serversupplied_info *server_info, 
                                    struct auth_session_info **_session_info) ;
 
-NTSTATUS make_server_info_netlogon_validation(TALLOC_CTX *mem_ctx,
-                                             const char *account_name,
-                                             uint16_t validation_level,
-                                             union netr_Validation *validation,
-                                             struct auth_serversupplied_info **_server_info);
 NTSTATUS auth_anonymous_session_info(TALLOC_CTX *parent_ctx, 
                                     struct tevent_context *ev_ctx,
                                     struct loadparm_context *lp_ctx,
index 02b71de7c3f17231c0261b93e69550c67b237814..e3c0908a150d7a0332dc7f3b80f858810172eafb 100644 (file)
@@ -25,6 +25,7 @@
 #include "smbd/service.h"
 #include "param/param.h"
 #include "auth/session.h"
+#include "auth/auth_sam_reply.h"
 #include "lib/stream/packet.h"
 #include "librpc/gen_ndr/ndr_named_pipe_auth.h"
 #include "system/passwd.h"
index f6f2fcb498988848d0933c4a1d610e9f84e93a0a..fd54863686ca323d4b774e6d9e74bfe7d30aac0e 100644 (file)
@@ -28,7 +28,7 @@
 #include "samba3/samba3.h"
 #include "libcli/security/security.h"
 #include "torture/torture.h"
-#include "auth/session_proto.h"
+#include "auth/auth_sam_reply.h"
 
 static bool torture_pac_self_check(struct torture_context *tctx)
 {