smbd:smb2: remove an unnecessary !! cast.
authorMichael Adam <obnox@samba.org>
Thu, 3 Mar 2016 15:57:45 +0000 (16:57 +0100)
committerMichael Adam <obnox@samba.org>
Mon, 14 Mar 2016 22:01:31 +0000 (23:01 +0100)
Casting to bool is done implcitly upon assignment.
Thanks to Ralph for pointing this out!

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Mon Mar 14 23:01:31 CET 2016 on sn-devel-144

source3/smbd/smb2_create.c

index 17bddc1266a9b0403273fd3537d26e675a2d0e3a..9dbed68ecdeaa7601249c7c8ff28135af3025238 100644 (file)
@@ -836,7 +836,7 @@ static struct tevent_req *smbd_smb2_create_send(TALLOC_CTX *mem_ctx,
                        hdr = SMBD_SMB2_IN_HDR_PTR(smb2req);
                        flags = IVAL(hdr, SMB2_HDR_FLAGS);
                        replay_operation =
-                               !!(flags & SMB2_HDR_FLAG_REPLAY_OPERATION);
+                               flags & SMB2_HDR_FLAG_REPLAY_OPERATION;
 
                        status = smb2srv_open_lookup_replay_cache(
                                        smb2req->xconn, create_guid,