fixed signed / unsigned warnings spotted by tim winders. also fixed

unnecessary "address of" warnings.

diff --git a/source/passdb/passdb.c b/source/passdb/passdb.c
index 396781d2f0862bde1a36d37fe7f7dbe627af2c9e..4a86e095dafcfdbf7e1b7e7598912da2a7523b5d 100644 (file)
--- a/source/passdb/passdb.c
+++ b/source/passdb/passdb.c
@@ -811,7 +811,7 @@ static BOOL read_sid_from_file(int fd, char *sid_file)
 {   
   fstring fline;
     
-  if(read(fd, &fline, sizeof(fline) -1 ) < 0) {
+  if(read(fd, fline, sizeof(fline) -1 ) < 0) {
     DEBUG(0,("read_sid_from_file: unable to read file %s. Error was %s\n",
            sid_file, strerror(errno) ));
     return False;

diff --git a/source/passdb/smbpass.c b/source/passdb/smbpass.c
index 633a527be1940332c4a5733ae129c729b381041a..4d446c65c2da5a7e56ba446fccf5fc4979169f2e 100644 (file)
--- a/source/passdb/smbpass.c
+++ b/source/passdb/smbpass.c
@@ -475,7 +475,7 @@ Error was %s\n", newpwd->smb_name, pfile, strerror(errno)));
 
   new_entry_length = strlen(newpwd->smb_name) + 1 + 15 + 1 + 32 + 1 + 32 + 1 + 5 + 1 + 13 + 2;
 
-  if((new_entry = (char *)malloc( new_entry_length )) == NULL) {
+  if((new_entry = (unsigned char *)malloc( new_entry_length )) == NULL) {
     DEBUG(0, ("add_smbfilepwd_entry(malloc): Failed to add entry for user %s to file %s. \
 Error was %s\n", newpwd->smb_name, pfile, strerror(errno)));
     endsmbfilepwent(fp);

diff --git a/source/rpc_server/srv_samr.c b/source/rpc_server/srv_samr.c
index d1503a762ed8db7e215a505d70ff113c21c7b5b6..d0304d0dd6a8e458cd9d951ddbe3bf9651263de4 100644 (file)
--- a/source/rpc_server/srv_samr.c
+++ b/source/rpc_server/srv_samr.c
@@ -107,7 +107,7 @@ static void samr_reply_close_hnd(SAMR_Q_CLOSE_HND *q_u,
        SAMR_R_CLOSE_HND r_u;
 
        /* set up the SAMR unknown_1 response */
-       bzero(&(r_u.pol.data), POL_HND_SIZE);
+       bzero(r_u.pol.data, POL_HND_SIZE);
 
        /* close the policy handle */
        if (close_lsa_policy_hnd(&(q_u->pol)))
@@ -795,7 +795,7 @@ static void samr_reply_open_user(SAMR_Q_OPEN_USER *q_u,
        BOOL pol_open = False;
 
        /* set up the SAMR open_user response */
-       bzero(&(r_u.user_pol.data), POL_HND_SIZE);
+       bzero(r_u.user_pol.data, POL_HND_SIZE);
 
        r_u.status = 0x0;
 
@@ -1105,7 +1105,7 @@ static void samr_reply_unknown_32(SAMR_Q_UNKNOWN_32 *q_u,
        SAMR_R_UNKNOWN_32 r_u;
 
        /* set up the SAMR unknown_32 response */
-       bzero(&(r_u.pol.data), POL_HND_SIZE);
+       bzero(r_u.pol.data, POL_HND_SIZE);
        if (status == 0)
        {
                for (i = 4; i < POL_HND_SIZE; i++)