s4:torture/rpc/handles: try to make all assoc_group tests less flakey

Just incrementing the assoc_group_id makes it too likely to hit
a number that is already in use.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Mon Nov 26 13:53:22 CET 2012 on sn-devel-104

diff --git a/source4/torture/rpc/handles.c b/source4/torture/rpc/handles.c
index 3fdce5672e28e0f4ba82aff3669895146ada8af0..5c08a5f371ae62cc8b66fb39360182b35a1e3830 100644 (file)
--- a/source4/torture/rpc/handles.c
+++ b/source4/torture/rpc/handles.c
@@ -471,6 +471,11 @@ static bool test_handles_mixed_shared(struct torture_context *torture)
        torture_assert_ntstatus_equal(torture, status, NT_STATUS_UNSUCCESSFUL,
                                      "opening lsa pipe4");
 
+       /*
+        * We use ~assoc_group_id instead of p1->assoc_group_id, because
+        * this way we are less likely to use an id which is already in use.
+        */
+       assoc_group_id = ~assoc_group_id;
        torture_comment(torture, "connect samr pipe5 with assoc_group_id[0x%08X]- should fail\n", ++assoc_group_id);
        status = torture_rpc_connection_transport(torture, &p5, &ndr_table_samr,
                                                  transport,