r16383: Klocwork #1086. No null deref.
authorJeremy Allison <jra@samba.org>
Tue, 20 Jun 2006 01:03:04 +0000 (01:03 +0000)
committerGerald (Jerry) Carter <jerry@samba.org>
Wed, 10 Oct 2007 16:18:50 +0000 (11:18 -0500)
Jeremy.
(This used to be commit 7b68a2acfc583d1559c02461cab13419185bcd74)

source3/passdb/pdb_interface.c

index 94adebe23277623b6cb32f11d6cbdc40aeb33a79..5d70c2c1227933904da3da4892bb065467bab773 100644 (file)
@@ -1470,6 +1470,11 @@ static BOOL lookup_global_sam_rid(TALLOC_CTX *mem_ctx, uint32 rid,
 
                unbecome_root();                /* -----> EXIT BECOME_ROOT() */
                *name = talloc_strdup(mem_ctx, pdb_get_username(sam_account));
+               if (!*name) {
+                       TALLOC_FREE(sam_account);
+                       return False;
+               }
+
                *psid_name_use = SID_NAME_USER;
 
                TALLOC_FREE(sam_account);