Revert "libcli/security: Remove a call to strncasecmp"

This reverts commit 7c687665eaf16b0c6f83c130f6d9e5459e0b2a32.

diff --git a/libcli/security/dom_sid.c b/libcli/security/dom_sid.c
index 7cb50c926c4bdeef9a576ac4d308c8c74bd6c716..0c8890079af7e8d99305fe4e83391e20f8a6af1b 100644 (file)
--- a/libcli/security/dom_sid.c
+++ b/libcli/security/dom_sid.c
@@ -85,12 +85,16 @@ bool dom_sid_equal(const struct dom_sid *sid1, const struct dom_sid *sid2)
        return dom_sid_compare(sid1, sid2) == 0;
 }
 
+/* Yes, I did think about multibyte issues here, and for all I can see there's
+ * none of those for parsing a SID. */
+#undef strncasecmp
+
 bool dom_sid_parse(const char *sidstr, struct dom_sid *ret)
 {
        uint_t rev, ia, num_sub_auths, i;
        char *p;
 
-       if ((sidstr[0] != 'S' && sidstr[0] != 's') || sidstr[1] != '-') {
+       if (strncasecmp(sidstr, "S-", 2)) {
                return false;
        }