torture:smb2: use assert, not warning in error case in durable-open.reopen1a
authorMichael Adam <obnox@samba.org>
Tue, 15 Mar 2016 08:35:03 +0000 (09:35 +0100)
committerJeremy Allison <jra@samba.org>
Mon, 21 Mar 2016 23:23:21 +0000 (00:23 +0100)
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source4/torture/smb2/durable_open.c

index fe0a326110e3f3db19d2392fba68429a5fcc1e68..11388ef3828e45397652bca60b664cf79bc01ed7 100644 (file)
@@ -464,13 +464,9 @@ static bool test_durable_open_reopen1a(struct torture_context *tctx,
 
        previous_session_id = smb2cli_session_current_id(tree->session->smbXcli);
 
-       if (!torture_smb2_connection_ext(tctx, previous_session_id,
-                                        &options, &tree2))
-       {
-               torture_warning(tctx, "couldn't reconnect, bailing\n");
-               ret = false;
-               goto done;
-       }
+       ret = torture_smb2_connection_ext(tctx, previous_session_id,
+                                         &options, &tree2);
+       torture_assert_goto(tctx, ret, ret, done, "could not reconnect");
 
        /*
         * check that this has deleted the old session