s4-regsitry: Check return value of ldb_msg_add_empty().
authorAndreas Schneider <asn@samba.org>
Thu, 13 Dec 2012 16:48:45 +0000 (17:48 +0100)
committerGünther Deschner <gd@samba.org>
Fri, 21 Dec 2012 12:55:59 +0000 (13:55 +0100)
Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
source4/lib/registry/ldb.c

index 0f0ddf915412897419e4935892259dc8078dbf43..d1a8963fa25f35d2766725ff4bcb308f17eb5c98 100644 (file)
@@ -646,8 +646,14 @@ static WERROR ldb_del_value(TALLOC_CTX *mem_ctx, struct hive_key *key,
                W_ERROR_HAVE_NO_MEMORY(msg);
                msg->dn = ldb_dn_copy(msg, kd->dn);
                W_ERROR_HAVE_NO_MEMORY(msg->dn);
-               ldb_msg_add_empty(msg, "data", LDB_FLAG_MOD_DELETE, NULL);
+               ret = ldb_msg_add_empty(msg, "data", LDB_FLAG_MOD_DELETE, NULL);
+               if (ret != LDB_SUCCESS) {
+                       return WERR_FOOBAR;
+               }
                ldb_msg_add_empty(msg, "type", LDB_FLAG_MOD_DELETE, NULL);
+               if (ret != LDB_SUCCESS) {
+                       return WERR_FOOBAR;
+               }
 
                ret = ldb_modify(kd->ldb, msg);