r5156: started on test driven development of the nbt server. This adds a

NBT-REGISTER test that tests that a server correctly defends its name
against broadcast name registrations.

Jeremy, you might like to look at this. Samba3 nmbd fails to respond.
(This used to be commit bb1298a2eb192ec2cd547a299334cc82a63a5acc)

diff --git a/source4/torture/config.mk b/source4/torture/config.mk
index 41268ece5a5387da76d408111216432fdc210993..15661eb7854ba33c0fe04cae32a9c2bc163ba2b9 100644 (file)
--- a/source4/torture/config.mk
+++ b/source4/torture/config.mk
@@ -170,7 +170,8 @@ REQUIRED_SUBSYSTEMS = \
 # Start SUBSYSTEM TORTURE_NBT
 [SUBSYSTEM::TORTURE_NBT]
 ADD_OBJ_FILES = \
-               torture/nbt/query.o
+               torture/nbt/query.o \
+               torture/nbt/register.o
 REQUIRED_SUBSYSTEMS = \
                LIBSMB
 # End SUBSYSTEM TORTURE_NBT

diff --git a/source4/torture/nbt/register.c b/source4/torture/nbt/register.c
new file mode 100644 (file)
index 0000000..90ecc7a
--- /dev/null
+++ b/source4/torture/nbt/register.c
@@ -0,0 +1,174 @@
+/* 
+   Unix SMB/CIFS implementation.
+
+   NBT name registration testing
+
+   Copyright (C) Andrew Tridgell 2005
+   
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 2 of the License, or
+   (at your option) any later version.
+   
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+   
+   You should have received a copy of the GNU General Public License
+   along with this program; if not, write to the Free Software
+   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+*/
+
+#include "includes.h"
+#include "libcli/nbt/libnbt.h"
+#include "librpc/gen_ndr/ndr_nbt.h"
+
+#define CHECK_VALUE(v, correct) do { \
+       if ((v) != (correct)) { \
+               printf("(%s) Incorrect value %s=%d - should be %d\n", \
+                      __location__, #v, v, correct); \
+               ret = False; \
+       }} while (0)
+
+#define CHECK_STRING(v, correct) do { \
+       if (StrCaseCmp(v, correct) != 0) { \
+               printf("(%s) Incorrect value %s='%s' - should be '%s'\n", \
+                      __location__, #v, v, correct); \
+               ret = False; \
+       }} while (0)
+
+#define BOGUS_ADDRESS1 "255.255.255.254"
+#define BOGUS_ADDRESS2 "255.255.255.253"
+
+/*
+  test that a server responds correctly to attempted registrations of its name
+*/
+static BOOL nbt_register_own(TALLOC_CTX *mem_ctx, struct nbt_name *name, 
+                            const char *address)
+{
+       struct nbt_name_register io;
+       NTSTATUS status;
+       struct nbt_name_socket *nbtsock = nbt_name_socket_init(mem_ctx, NULL);
+       BOOL ret = True;
+
+       printf("Testing name defense to name registration\n");
+
+       io.in.name = *name;
+       io.in.dest_addr = address;
+       io.in.address = BOGUS_ADDRESS1;
+       io.in.nb_flags = NBT_NODE_B | NBT_NM_ACTIVE;
+       io.in.register_demand = False;
+       io.in.broadcast = True;
+       io.in.ttl = 1234;
+       io.in.timeout = 3;
+       
+       status = nbt_name_register(nbtsock, mem_ctx, &io);
+       if (NT_STATUS_EQUAL(status, NT_STATUS_IO_TIMEOUT)) {
+               printf("No response from %s for name register\n", address);
+               return False;
+       }
+       if (!NT_STATUS_IS_OK(status)) {
+               printf("Bad response from %s for name register - %s\n",
+                      address, nt_errstr(status));
+               return False;
+       }
+       
+       CHECK_STRING(io.out.name.name, name->name);
+       CHECK_VALUE(io.out.name.type, name->type);
+       CHECK_VALUE(io.out.rcode, NBT_RCODE_ACT);
+
+       /* check a register demand */
+       io.in.address = BOGUS_ADDRESS2;
+       io.in.register_demand = True;
+
+       status = nbt_name_register(nbtsock, mem_ctx, &io);
+       if (NT_STATUS_EQUAL(status, NT_STATUS_IO_TIMEOUT)) {
+               printf("No response from %s for name register\n", address);
+               return False;
+       }
+       if (!NT_STATUS_IS_OK(status)) {
+               printf("Bad response from %s for name register - %s\n",
+                      address, nt_errstr(status));
+               return False;
+       }
+       
+       CHECK_STRING(io.out.name.name, name->name);
+       CHECK_VALUE(io.out.name.type, name->type);
+       CHECK_VALUE(io.out.rcode, NBT_RCODE_ACT);
+
+       return ret;
+}
+
+
+/*
+  test that a server responds correctly to attempted name refresh requests
+*/
+static BOOL nbt_refresh_own(TALLOC_CTX *mem_ctx, struct nbt_name *name, 
+                           const char *address)
+{
+       struct nbt_name_refresh io;
+       NTSTATUS status;
+       struct nbt_name_socket *nbtsock = nbt_name_socket_init(mem_ctx, NULL);
+       BOOL ret = True;
+
+       printf("Testing name defense to name refresh\n");
+
+       io.in.name = *name;
+       io.in.dest_addr = address;
+       io.in.address = BOGUS_ADDRESS1;
+       io.in.nb_flags = NBT_NODE_B | NBT_NM_ACTIVE;
+       io.in.broadcast = True;
+       io.in.ttl = 1234;
+       io.in.timeout = 3;
+       
+       status = nbt_name_refresh(nbtsock, mem_ctx, &io);
+       if (NT_STATUS_EQUAL(status, NT_STATUS_IO_TIMEOUT)) {
+               printf("No response from %s for name refresh\n", address);
+               return False;
+       }
+       if (!NT_STATUS_IS_OK(status)) {
+               printf("Bad response from %s for name refresh - %s\n",
+                      address, nt_errstr(status));
+               return False;
+       }
+       
+       CHECK_STRING(io.out.name.name, name->name);
+       CHECK_VALUE(io.out.name.type, name->type);
+       CHECK_VALUE(io.out.rcode, NBT_RCODE_ACT);
+
+       return ret;
+}
+
+
+/*
+  test name registration to a server
+*/
+BOOL torture_nbt_register(void)
+{
+       const char *address;
+       struct nbt_name name;
+       TALLOC_CTX *mem_ctx = talloc_new(NULL);
+       NTSTATUS status;
+       BOOL ret = True;
+       
+       name.name = lp_parm_string(-1, "torture", "host");
+       name.type = NBT_NAME_SERVER;
+       name.scope = NULL;
+
+       /* do an initial name resolution to find its IP */
+       status = resolve_name(&name, mem_ctx, &address);
+       if (!NT_STATUS_IS_OK(status)) {
+               printf("Failed to resolve %s - %s\n",
+                      name.name, nt_errstr(status));
+               talloc_free(mem_ctx);
+               return False;
+       }
+
+       ret &= nbt_register_own(mem_ctx, &name, address);
+       ret &= nbt_refresh_own(mem_ctx, &name, address);
+
+       talloc_free(mem_ctx);
+
+       return ret;
+}

diff --git a/source4/torture/torture.c b/source4/torture/torture.c
index 60f39cdac769ec8414ef60de42a929812f92eeeb..8fd9d9f1eff8c2b28382decb78d3d63fd9dc50c2 100644 (file)
--- a/source4/torture/torture.c
+++ b/source4/torture/torture.c
@@ -2428,6 +2428,9 @@ static struct {
        /* ldap testers */
        {"LDAP-BASIC", torture_ldap_basic, 0},
 
+       /* nbt tests */
+       {"NBT-REGISTER", torture_nbt_register, 0},
+
        {NULL, NULL, 0}};