nbt_server: Avoid a talloc call
authorVolker Lendecke <vl@samba.org>
Sat, 17 Feb 2018 19:06:36 +0000 (20:06 +0100)
committerAndreas Schneider <asn@cryptomilk.org>
Tue, 27 Feb 2018 08:14:18 +0000 (09:14 +0100)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
source4/nbt_server/dgram/netlogon.c

index 4753ca88a3dadb2d89a7e14201ca1bbd33f57cd6..3a7b1d0e4ad674d1439a5fea8034d6b799ccf127 100644 (file)
@@ -143,9 +143,11 @@ static NTSTATUS nbtd_netlogon_samlogon(
                netlogon->req.logon.nt_version, nbtsrv->task->lp_ctx,
                &response->data.samlogon, false);
        if (!NT_STATUS_IS_OK(status)) {
+               char buf[DOM_SID_STR_BUFLEN];
+               dom_sid_string_buf(sid, buf, sizeof(buf));
+
                DBG_NOTICE("NBT netlogon query failed domain=%s sid=%s "
-                          "version=%d - %s\n", dst_name->name,
-                          dom_sid_string(response, sid),
+                          "version=%d - %s\n", dst_name->name, buf,
                           netlogon->req.logon.nt_version, nt_errstr(status));
                TALLOC_FREE(response);
                return status;