mit-kdb: Do not overwrite the error code in failure case.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Sumit Bose <sbose@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/source4/kdc/mit-kdb/kdb_samba_policies.c b/source4/kdc/mit-kdb/kdb_samba_policies.c
index 75c8c837a27f7660beade80976444367a7481cbb..2e9f9ef0c5a9af0792ca4b1c751e060233d399cf 100644 (file)
--- a/source4/kdc/mit-kdb/kdb_samba_policies.c
+++ b/source4/kdc/mit-kdb/kdb_samba_policies.c
@@ -127,17 +127,19 @@ krb5_error_code kdb_samba_db_check_policy_as(krb5_context context,
                                             netbios_name,
                                             password_change,
                                             &int_data);
-       if (code) {
-               goto done;
-       }
 
-       d = ks_make_data(int_data.data, int_data.length);
+       if (int_data.length && int_data.data) {
 
-       code = decode_krb5_padata_sequence(&d, &e_data);
-       if (code == 0) {
-               *e_data_out = e_data;
-       }
+               /* make sure the mapped return code is returned - gd */
+               int code_tmp;
 
+               d = ks_make_data(int_data.data, int_data.length);
+
+               code_tmp = decode_krb5_padata_sequence(&d, &e_data);
+               if (code_tmp == 0) {
+                       *e_data_out = e_data;
+               }
+       }
 done:
        free(realm);
        free(server_name);