wrap group enuemration in brcome/unbecome_root() (bug #110)

(This used to be commit 3918fffc7f07202f4c0b940f877184eea7561135)

diff --git a/source3/rpc_server/srv_util.c b/source3/rpc_server/srv_util.c
index 5040b094a8ce3716ddc508cdc6edfc29ad2e2538..03e53118a89afe18bc4c912caf0f84dabb26e8c2 100644 (file)
--- a/source3/rpc_server/srv_util.c
+++ b/source3/rpc_server/srv_util.c
@@ -147,6 +147,8 @@ NTSTATUS get_alias_user_groups(TALLOC_CTX *ctx, DOM_SID *sid, int *numgroups, ui
                return NT_STATUS_UNSUCCESSFUL;
        }
 
+       become_root();
+       
        for (i=0;i<num_groups;i++) {
 
                if (!get_group_from_gid(groups[i], &map)) {
@@ -195,6 +197,8 @@ NTSTATUS get_alias_user_groups(TALLOC_CTX *ctx, DOM_SID *sid, int *numgroups, ui
                break;
        }
 
+       unbecome_root();
+       
        if(num_groups) free(groups);
 
        /* now check for the user's gid (the primary group rid) */
@@ -209,11 +213,15 @@ NTSTATUS get_alias_user_groups(TALLOC_CTX *ctx, DOM_SID *sid, int *numgroups, ui
 
        DEBUG(10,("get_alias_user_groups: looking for gid %d of user %s\n", (int)gid, user_name));
 
+       become_root();
+
        if(!get_group_from_gid(gid, &map)) {
                DEBUG(0,("get_alias_user_groups: gid of user %s doesn't exist. Check your /etc/passwd and /etc/group files\n", user_name));
                goto done;
        }       
 
+       unbecome_root();
+
        /* the primary group isn't an alias */
        if (map.sid_name_use!=SID_NAME_ALIAS) {
                DEBUG(10,("get_alias_user_groups: not returing %s, not an ALIAS group.\n", map.nt_name));
@@ -281,11 +289,17 @@ BOOL get_domain_user_groups(TALLOC_CTX *ctx, int *numgroups, DOM_GID **pgids, SA
 
        DEBUG(10,("get_domain_user_groups: searching domain groups [%s] is a member of\n", user_name));
 
+       /* we must wrap this is become/unbecome root for ldap backends */
+       become_root();
+
        /* first get the list of the domain groups */
        if (!pdb_enum_group_mapping(SID_NAME_DOM_GRP, &map, &num_entries, ENUM_ONLY_MAPPED))
                return False;
        DEBUG(10,("get_domain_user_groups: there are %d mapped groups\n", num_entries));
 
+       unbecome_root();
+       /* end wrapper for group enumeration */
+
        /* 
         * alloc memory. In the worse case, we alloc memory for nothing.
         * but I prefer to alloc for nothing