Coverity 280334
authorMartin Kaiser <wireshark@kaiser.cx>
Wed, 8 Jan 2014 11:06:31 +0000 (11:06 -0000)
committerMartin Kaiser <wireshark@kaiser.cx>
Wed, 8 Jan 2014 11:06:31 +0000 (11:06 -0000)
check the return value of gtk_tree_selection_get_selected()

if there was no selected item, wireshark would crash
but this is very unlikely in practice

svn path=/trunk/; revision=54656

ui/gtk/proto_hier_stats_dlg.c

index edaca5f4ed0002f1d960c69d43ba5678a373fbd1..b872e5409d8419dc0412974199ee2c93b0703113 100644 (file)
@@ -80,7 +80,8 @@ proto_hier_select_filter_cb(GtkWidget *widget _U_, gpointer callback_data _U_, g
     GtkTreePath *path;
 
     sel = gtk_tree_view_get_selection (GTK_TREE_VIEW(tree));
-    gtk_tree_selection_get_selected (sel, &model, &iter);
+    if (!gtk_tree_selection_get_selected(sel, &model, &iter))
+        return;
     path = gtk_tree_model_get_path(model,&iter);
 
     gtk_tree_model_get (model, &iter, FILTER_NAME, &filter, -1);