Andrew Tridgell [Sat, 27 Mar 2010 01:44:20 +0000 (12:44 +1100)]
s4-selftest: use CONFIG_H environment variable to find config.h
Andrew Bartlett [Sat, 27 Mar 2010 08:13:28 +0000 (19:13 +1100)]
s4:heimdal Use correct variable to advance past -- options in kpasswd
This bug was introduced when kpasswd was migrated to a local getarg()
call, in Heimdal commit
7dd146072cd9b56d660a01f4aa20f8d81be356e8
Andrew Bartlett
Andrew Bartlett [Sat, 27 Mar 2010 08:12:33 +0000 (19:12 +1100)]
s4:heimdal_build Remove forced HAVE_STRERROR_R
This just causes warnings, now upstream has a more complete fix.
Andrew Bartlett [Sat, 27 Mar 2010 01:24:00 +0000 (12:24 +1100)]
s4:heimal Update generated files (cp from Heimdal)
Andrew Bartlett [Sat, 27 Mar 2010 01:23:21 +0000 (12:23 +1100)]
s4:testprogs Update test to match current Heimdal
Andrew Bartlett [Sat, 27 Mar 2010 00:55:22 +0000 (11:55 +1100)]
Andrew Bartlett [Sat, 27 Mar 2010 00:48:05 +0000 (11:48 +1100)]
s4:testprogs Fix kinit test for updated Heimdal
Andrew Bartlett [Tue, 12 Jan 2010 02:24:33 +0000 (13:24 +1100)]
s4:heimdal New files and supporting logic for heimdal update
Andrew Bartlett [Tue, 12 Jan 2010 07:16:45 +0000 (18:16 +1100)]
Jeremy Allison [Sat, 27 Mar 2010 00:09:58 +0000 (17:09 -0700)]
Fix bug #7240 - Net usershare is not case sensitive.
Updates usershare files in a backwards compatible way.
I don't intend to back port this fix to 3.5.x as it
depends on a version upgrade in the share_info.tdb share security database.
Jeremy.
Günther Deschner [Fri, 26 Mar 2010 21:59:29 +0000 (22:59 +0100)]
s3-selftest: set "lpq cache time = 0" in server configuration.
This fixes currently broken spoolss tests.
(make test variant).
Guenther
Günther Deschner [Fri, 26 Mar 2010 21:58:42 +0000 (22:58 +0100)]
s3-selftest: set "lpq cache time = 0" in server configuration.
This fixes currently broken spoolss tests.
Guenther
Günther Deschner [Fri, 26 Mar 2010 14:23:34 +0000 (15:23 +0100)]
s4-smbtorture: more JobInfo testing.
Guenther
Kai Blin [Thu, 25 Mar 2010 21:22:56 +0000 (22:22 +0100)]
s3 ntlm_auth: Don't malloc data that will be talloc_free()d
This fixes bug #7290
Thanks to Mohan <mohann@silver-peak.com> for the bug report.
Simo Sorce [Fri, 26 Mar 2010 19:21:15 +0000 (15:21 -0400)]
tdb: update exports and signatures files
Volker Lendecke [Fri, 26 Mar 2010 12:18:33 +0000 (13:18 +0100)]
tdb: Add a non-blocking version of tdb_transaction_start
Matthias Dieter Wallnöfer [Fri, 26 Mar 2010 09:08:47 +0000 (10:08 +0100)]
s4:auth/credentials/credentials.c - initialise more content
Now all data should be initialised
Jeremy Allison [Fri, 26 Mar 2010 16:32:40 +0000 (09:32 -0700)]
Revert the part of bug fix #7233 - print fails with jobs >4GB from Win7 clients.
Submitter reports print file corruption after 2GB when SMBwrite etc.
always write at EOF. Still working on the fix.
Jeremy.
Karolin Seeger [Fri, 26 Mar 2010 14:14:35 +0000 (15:14 +0100)]
s3-util_sock: Rise debug level for getpeername failed messages.
Don't show all getpeername failed messages in debug level 0 and 1.
Karolin
Signed-off-by: Volker Lendecke <vl@samba.org>
Andreas Schneider [Fri, 26 Mar 2010 10:17:37 +0000 (11:17 +0100)]
s3-smbd: Don't close stdout if we want to log to stdout.
Günther Deschner [Fri, 26 Mar 2010 12:37:42 +0000 (13:37 +0100)]
s4-smbtorture: fail spoolss test on SetJob failure.
Guenther
Günther Deschner [Fri, 26 Mar 2010 12:36:00 +0000 (13:36 +0100)]
s3-spoolss: return info for the correct printjob in _spoolss_GetJob().
Guenther
Günther Deschner [Fri, 26 Mar 2010 12:17:49 +0000 (13:17 +0100)]
s3-printing: avoid mixing cups backend code with nt_printing code in cups_pull_comment_location.
Guenther
Andrew Tridgell [Fri, 26 Mar 2010 11:07:50 +0000 (22:07 +1100)]
s3-event: switch s3 to using tevent_re_initialise()
This correctly initialises the event backend, and checks for errors
(thanks to Metze for suggesting this)
Andrew Tridgell [Fri, 26 Mar 2010 10:13:55 +0000 (21:13 +1100)]
s4-smbd: use tevent_re_initialise()
This fixes a crash bug on startup
Andrew Tridgell [Fri, 26 Mar 2010 10:13:27 +0000 (21:13 +1100)]
tevent: added tevent_re_initialise()
This allows us to re-initialise a tevent context without destroying
the pointer. That means that if someone keeps a long term ptr to the
event context across a fork it will still work.
This also brings the memory handling in single and standard process
models much closer together, which means less bugs that we don't find
with make test.
Andrew Tridgell [Fri, 26 Mar 2010 08:03:22 +0000 (19:03 +1100)]
util: on FreeBSD true is in /usr/bin. Use execvp to find it
Andrew Tridgell [Fri, 26 Mar 2010 06:36:02 +0000 (17:36 +1100)]
libutil: moved the networking defines to util_net.h
These were causing thousands of warnings on solaris8
Andrew Tridgell [Fri, 26 Mar 2010 05:50:24 +0000 (16:50 +1100)]
libreplace: strerror_r() is needed by heimdal on solaris8
Eduardo Lima [Wed, 24 Mar 2010 19:21:15 +0000 (16:21 -0300)]
s4-drs: replmd_delete with the 3 stage deletion recycle bin
Andrew Tridgell [Thu, 25 Mar 2010 05:42:19 +0000 (16:42 +1100)]
tsocket: not all systems have IPV6_V6ONLY
Jeremy Allison [Fri, 26 Mar 2010 01:20:33 +0000 (18:20 -0700)]
Second part of bug #7288 - SMB job IDs in CUPS job names wrong.
Forgot to delete the overload of the smbjob bool.
Jeremy.
Jeremy Allison [Fri, 26 Mar 2010 00:36:47 +0000 (17:36 -0700)]
Fix bug #7288 - SMB job IDs in CUPS job names wrong.
Based on a patch from Michael Karcher <samba@mkarcher.dialup.fu-berlin.de>.
I think this is the correct fix. It causes cups_job_submit to use
print_parse_jobid(), which I've moved into printing/lpq_parse.c (to allow the
link to work).
It turns out the old print_parse_jobid() was *broken*, in that the pjob
filename was set as an absolute path - not relative to the sharename (due to it
not going through the VFS calls).
This meant that the original code doing a strncmp on the first part of the
filename would always fail - it starts with a "/", not the relative pathname of
PRINT_SPOOL_PREFIX ("smbprn.").
This fix could fix some other mysterious printing bugs - probably the ones
Guenther noticed where job control fails on non-cups backends.
Guenther PLEASE CHECK !
Jeremy.
Jeremy Allison [Fri, 26 Mar 2010 00:09:23 +0000 (17:09 -0700)]
Fix bug 7297 - smbd crashes with CUPS printers and no [printers] share defined.
Ensure we don't dereference an array with an index of -1.
Jeremy.
Holger Hetterich [Mon, 22 Mar 2010 14:05:33 +0000 (15:05 +0100)]
s3: vfs_smb_traffic_analyzer.c: remove warnings from developer build
This patch should remove all warnings coming up when compiling
traffic analyzer with configure.developer.
Re-activate the smb_traffic_analyzer_rmdir function by adding it's
vfs_fn_pointer to vfs_smb_traffic_analyzer_fns.
Copy the mode_t used in smb_traffic_analyzer_open to the corresponding
data structure.
Stefan Metzmacher [Thu, 25 Mar 2010 19:59:49 +0000 (20:59 +0100)]
s3:passdb: avoid sid_to_gid() if the sid is "domain users"
If the call fails we would use the "domain users" sid anyway.
metze
Stefan Metzmacher [Thu, 25 Mar 2010 16:58:19 +0000 (17:58 +0100)]
s4:libcli/wrepl: correctly remove the tstream_context when the connection is dead
metze
Günther Deschner [Thu, 25 Mar 2010 17:36:12 +0000 (18:36 +0100)]
s4-smbtorture: fix include of proto header in main RAP test.
Guenther
Torsten Kurbad [Thu, 25 Mar 2010 16:58:27 +0000 (17:58 +0100)]
s3: Fix a missing </listitem> in vfs_crossrename.8.xml
Volker Lendecke [Thu, 25 Mar 2010 15:45:02 +0000 (16:45 +0100)]
s3: Add a comment to notify_internal_parent_init, this is pretty confusing
Volker Lendecke [Thu, 25 Mar 2010 15:44:41 +0000 (16:44 +0100)]
s3: Add a comment to serverid_parent_init, this is pretty confusing
Volker Lendecke [Thu, 25 Mar 2010 15:44:02 +0000 (16:44 +0100)]
s3: Add a comment to messaging_tdb_parent_init, this is pretty confusing
Volker Lendecke [Thu, 25 Mar 2010 15:02:54 +0000 (16:02 +0100)]
s3: Make sure our CLEAR_IF_FIRST optimization works for serverid.tdb
In the child, we fully re-open serverid.tdb, which leads to one fcntl lock for
CLEAR_IF_FIRST detection per smbd. This opens the tdb in the parent and holds
it, so that tdb_reopen_all correctly catches the CLEAR_IF_FIRST bit.
Volker Lendecke [Thu, 25 Mar 2010 15:01:54 +0000 (16:01 +0100)]
s3: Make sure our CLEAR_IF_FIRST optimization works for the notify tdbs
The notify tdb files are opened at tconX time, which leads to one fcntl lock
for CLEAR_IF_FIRST detection per smbd. This opens the tdbs in the parent and
holds it, so that tdb_reopen_all correctly catches the CLEAR_IF_FIRST bit.
Volker Lendecke [Thu, 25 Mar 2010 14:59:41 +0000 (15:59 +0100)]
s3: Make sure our CLEAR_IF_FIRST optimization works for messaging.tdb
In the child, we fully re-open messaging.tdb, which leads to one fcntl lock for
CLEAR_IF_FIRST detection per smbd. This opens the tdb in the parent and holds
it, so that tdb_reopen_all correctly catches the CLEAR_IF_FIRST bit.
Volker Lendecke [Thu, 25 Mar 2010 14:43:47 +0000 (15:43 +0100)]
s3: Fix some nonempty blank lines
Günther Deschner [Thu, 25 Mar 2010 13:40:40 +0000 (14:40 +0100)]
s3-selftest: enable RAP-RPC test against s3.
Guenther
Günther Deschner [Thu, 25 Mar 2010 12:17:05 +0000 (13:17 +0100)]
s3-selftest: add RAP-RPC testsuite for crosschecking RAP and DCERPC calls.
Guenther
Günther Deschner [Thu, 25 Mar 2010 10:02:33 +0000 (11:02 +0100)]
s4-smbtorture: fix drsblobs ndr torture test.
Guenther
Günther Deschner [Thu, 25 Mar 2010 10:02:10 +0000 (11:02 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Thu, 25 Mar 2010 09:56:15 +0000 (10:56 +0100)]
drsblobs: remove utf8string2 from ForestTrustData.
Simo, it's not really worth to add a new idl type just for being able to omit
the size field. The size field is part of the spec in MS-ADTS 7.1.6.9.3.1 so we
should have it as well.
Guenther
Günther Deschner [Thu, 25 Mar 2010 09:20:14 +0000 (10:20 +0100)]
s4-smbtorture: activate job control tests against s3 in spoolss tests.
Spoolss job control commands work for cups in s3 now but not for other
backends. We need to investigate why.
Guenther
Volker Lendecke [Thu, 25 Mar 2010 09:29:41 +0000 (10:29 +0100)]
tdb: Fix indentation in tdb_new_database()
Volker Lendecke [Thu, 25 Mar 2010 09:19:48 +0000 (10:19 +0100)]
Fix some nonempty blank lines
Andrew Bartlett [Thu, 25 Mar 2010 05:30:54 +0000 (16:30 +1100)]
s4:selftest Add testing of kpasswd password set on servicePrincipalName
Andrew Bartlett [Thu, 25 Mar 2010 05:27:40 +0000 (16:27 +1100)]
s4:kdc Add support for changing password of a servicePrincipalName
Apparently AD supports setting a password on a servicePrincipalName,
not just a user principal name. This should fix (part of) the join of
OpenSolaris's internal CIFS server to Samba4 as reported by Bug #7273
Andrew Bartlett
Andrew Tridgell [Thu, 25 Mar 2010 04:45:08 +0000 (15:45 +1100)]
s4-ldb: fixed command line parsing in oLschema2ldif
It really doesn't make sense to use the ldb command line code
Andrew Tridgell [Thu, 25 Mar 2010 04:06:40 +0000 (15:06 +1100)]
s4-ldb: removed unused command line options -I and -O
These are not used anywehere, so they just confuse people
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Fernando J V da Silva [Wed, 24 Mar 2010 16:02:36 +0000 (13:02 -0300)]
s4-drs: If we are a RODC then do not send DSReplicaSync messages
Andrew Tridgell [Wed, 24 Mar 2010 05:50:50 +0000 (16:50 +1100)]
python: use '#!/usr/bin/env python' to cope with varying install locations
this should be much more portable
Michael Karcher [Thu, 25 Mar 2010 00:33:21 +0000 (17:33 -0700)]
Fix bug #7269 - Job management commands don't work for CUPS queues.
Samba needs to retrieve pjob->sysjob from the CUPS response (as
is done in the iprint backend).
Günther Deschner [Wed, 24 Mar 2010 23:55:32 +0000 (00:55 +0100)]
s3-selftest: move printing config to global section.
"make test" variant.
Guenther
Günther Deschner [Wed, 24 Mar 2010 23:55:13 +0000 (00:55 +0100)]
s3-selftest: move printing config to global section.
Guenther
Günther Deschner [Wed, 24 Mar 2010 23:49:38 +0000 (00:49 +0100)]
s4-smbtorture: add print test to RPC-SPOOLSS-PRINTER as well.
Guenther
Günther Deschner [Wed, 24 Mar 2010 23:37:45 +0000 (00:37 +0100)]
s4-smbtorture: create several printjobs during print test in RPC-SPOOLSS.
Guenther
Günther Deschner [Wed, 24 Mar 2010 23:48:55 +0000 (00:48 +0100)]
s4-smbtorture: mention job id in GetJob test output in RPC-SPOOLSS.
Guenther
Günther Deschner [Wed, 24 Mar 2010 23:33:35 +0000 (00:33 +0100)]
s4-smbtorture: mention job id in SetJob test output in RPC-SPOOLSS.
Guenther
Jeremy Allison [Wed, 24 Mar 2010 19:47:01 +0000 (12:47 -0700)]
Fix bug #7233 - print fails with jobs >4GB from Win7 clients.
Ensure we always write at end-of-file for older write calls.
Jeremy.
Jeremy Allison [Wed, 24 Mar 2010 19:20:03 +0000 (12:20 -0700)]
Missing include guard in source4/libcli/security/security.h
Jeremy.
Jeremy Allison [Wed, 24 Mar 2010 17:31:43 +0000 (10:31 -0700)]
Fix bug #7283 - vfs_acl_tdb does not work as expected.
both vfs_acl_common.c and vfs_acl_tdb.c were using the connection
handle, thus conflicted. Fix this.
Jeremy.
Jeremy Allison [Wed, 24 Mar 2010 17:31:14 +0000 (10:31 -0700)]
Fix valgrind warning when source and dest stat are identical.
Jeremy.
Günther Deschner [Wed, 24 Mar 2010 17:08:21 +0000 (18:08 +0100)]
s4-smbtorture: add drsblobs ndr torture test.
Guenther
Günther Deschner [Wed, 24 Mar 2010 17:29:52 +0000 (18:29 +0100)]
s4-smbtorture: move up torture_assert_sid_equal at least to the torture/ndr level.
Guenther
Günther Deschner [Wed, 24 Mar 2010 16:37:07 +0000 (17:37 +0100)]
s4-selftest: use correct test names.
Guenther
Stefan Metzmacher [Sat, 16 Jan 2010 08:32:35 +0000 (09:32 +0100)]
s3:ntlmssp: use c99 types
metze
Signed-off-by: Günther Deschner <gd@samba.org>
Stefan Metzmacher [Wed, 30 Dec 2009 15:53:08 +0000 (16:53 +0100)]
s3:ntlmssp: use client.netbios_name instead of workstation
metze
Signed-off-by: Günther Deschner <gd@samba.org>
Stefan Metzmacher [Wed, 30 Dec 2009 13:20:31 +0000 (14:20 +0100)]
s3:ntlmssp: remove unused ntlmssp_set_workstation()
metze
Signed-off-by: Günther Deschner <gd@samba.org>
Stefan Metzmacher [Sat, 9 Jan 2010 13:38:35 +0000 (14:38 +0100)]
s3:ntlmssp: move sign/seal states to a private ntlmssp_crypt_state union
metze
Signed-off-by: Günther Deschner <gd@samba.org>
Stefan Metzmacher [Sat, 9 Jan 2010 10:30:39 +0000 (11:30 +0100)]
s3:ntlmssp: add const for *sig in ntlmssp_unseal_packet()
metze
Signed-off-by: Günther Deschner <gd@samba.org>
Stefan Metzmacher [Wed, 6 Jan 2010 16:14:25 +0000 (17:14 +0100)]
s3:ntlmssp: make whole_pdu const for ntlmssp_[un]seal_packet()
Only data needs to be non-const.
metze
Signed-off-by: Günther Deschner <gd@samba.org>
Stefan Metzmacher [Thu, 7 Jan 2010 09:43:23 +0000 (10:43 +0100)]
s3:ntlmssp: use a 'bool ok' variable to make the code more readable
metze
Signed-off-by: Günther Deschner <gd@samba.org>
Stefan Metzmacher [Sat, 9 Jan 2010 13:06:27 +0000 (14:06 +0100)]
s3:ntlmssp: fix some formating
metze
Signed-off-by: Günther Deschner <gd@samba.org>
Stefan Metzmacher [Wed, 6 Jan 2010 14:45:38 +0000 (15:45 +0100)]
s3:ntlmssp: inline ntlmssp_weaken_keys()
metze
Signed-off-by: Günther Deschner <gd@samba.org>
Stefan Metzmacher [Wed, 6 Jan 2010 14:22:24 +0000 (15:22 +0100)]
s3:ntlmssp: make send_seal_key and recv_seal_key local variables
metze
Signed-off-by: Günther Deschner <gd@samba.org>
Stefan Metzmacher [Wed, 30 Dec 2009 13:53:08 +0000 (14:53 +0100)]
s3:ntlmssp: rename void *auth_context; into void *callback_private;
metze
Signed-off-by: Günther Deschner <gd@samba.org>
Stefan Metzmacher [Wed, 30 Dec 2009 14:23:16 +0000 (15:23 +0100)]
s3:ntlmssp: add some consts
metze
Signed-off-by: Günther Deschner <gd@samba.org>
Stefan Metzmacher [Wed, 30 Dec 2009 13:17:51 +0000 (14:17 +0100)]
s3:ntlmssp: remove unused get_global_myname() and get_domain() from ntlmssp_state
Inspired by the NTLMSSP merge work by Andrew Bartlett.
metze
Signed-off-by: Günther Deschner <gd@samba.org>
Stefan Metzmacher [Wed, 30 Dec 2009 13:13:45 +0000 (14:13 +0100)]
s3:ntlmssp: pass names and use_ntlmv2 to ntlmssp_client_start() and store them
Inspired by the NTLMSSP merge work by Andrew Bartlett.
metze
Signed-off-by: Günther Deschner <gd@samba.org>
Stefan Metzmacher [Wed, 30 Dec 2009 12:29:54 +0000 (13:29 +0100)]
s3:ntlmssp: remove server_name from ntlmssp_state and fill the server.* fields also for the client
Inspired by the NTLMSSP merge work by Andrew Bartlett.
metze
Signed-off-by: Günther Deschner <gd@samba.org>
Stefan Metzmacher [Wed, 30 Dec 2009 10:55:23 +0000 (11:55 +0100)]
s3:ntlmssp: pass names to ntlmssp_server_start() and store them in ntlmssp_state
Inspired by the NTLMSSP merge work by Andrew Bartlett.
metze
Signed-off-by: Günther Deschner <gd@samba.org>
Stefan Metzmacher [Wed, 30 Dec 2009 09:07:32 +0000 (10:07 +0100)]
s3:ntlmssp: replace server_role by a server.is_standalone in ntlmssp_state
Inspired by the NTLMSSP merge work by Andrew Bartlett.
metze
Signed-off-by: Günther Deschner <gd@samba.org>
Stefan Metzmacher [Tue, 29 Dec 2009 16:25:47 +0000 (17:25 +0100)]
s3:ntlmssp: make use of C99 types in ntlmssp_sign.c
metze
Signed-off-by: Günther Deschner <gd@samba.org>
Stefan Metzmacher [Tue, 29 Dec 2009 16:25:20 +0000 (17:25 +0100)]
s3:ntlmssp: use uint8_t in calc_ntlmv2_key()
metze
Signed-off-by: Günther Deschner <gd@samba.org>
Stefan Metzmacher [Thu, 7 Jan 2010 09:10:13 +0000 (10:10 +0100)]
s4:ntlmssp: move sign/seal states to a private ntlmssp_crypt_state union
metze
Signed-off-by: Günther Deschner <gd@samba.org>
Stefan Metzmacher [Fri, 8 Jan 2010 21:11:10 +0000 (14:11 -0700)]
s4:ntlmssp: make use of dump_arc4_state()
metze
Signed-off-by: Günther Deschner <gd@samba.org>
Stefan Metzmacher [Wed, 6 Jan 2010 15:59:35 +0000 (16:59 +0100)]
s4:ntlmssp: copy dump_arc4_state() from source3
metze
Signed-off-by: Günther Deschner <gd@samba.org>
Stefan Metzmacher [Fri, 8 Jan 2010 20:58:42 +0000 (13:58 -0700)]
s4:ntlmssp: avoid usage of calc_ntlmv2_key_talloc()
metze
Signed-off-by: Günther Deschner <gd@samba.org>
Stefan Metzmacher [Fri, 8 Jan 2010 20:49:54 +0000 (13:49 -0700)]
s4:ntlmssp: make use of calc_ntlmv2_key() for seal keys
metze
Signed-off-by: Günther Deschner <gd@samba.org>
Stefan Metzmacher [Fri, 8 Jan 2010 20:37:43 +0000 (13:37 -0700)]
s4:ntlmssp: add calc_ntlmv2_key() from source3
metze
Signed-off-by: Günther Deschner <gd@samba.org>
Stefan Metzmacher [Fri, 8 Jan 2010 20:36:37 +0000 (13:36 -0700)]
s4:ntlmssp: rename calc_ntlmv2_key => calc_ntlmv2_key_talloc
metze
Signed-off-by: Günther Deschner <gd@samba.org>