SEGV in acl_validate_spn_value: dnsHostName NULL

This patch addresses a segfault in acl_validate_spn_value which occurs
when the "dnsHostName" attribute is missing. This seems to be the case
in domains migrated with samba3upgrade. Looks similar to MS KB 817543.

Signed-off-by: Nadezhda Ivanova <nivanova@drizzit.(none)>
Autobuild-User: Nadezhda Ivanova <nivanova@samba.org>
Autobuild-Date: Fri Mar  2 21:26:40 CET 2012 on sn-devel-104

diff --git a/source4/dsdb/samdb/ldb_modules/acl.c b/source4/dsdb/samdb/ldb_modules/acl.c
index abde85f682c65b633b630ce4f3cec90608501af3..6aed6825cb4b39537a59607693885e1b7c5e262e 100644 (file)
--- a/source4/dsdb/samdb/ldb_modules/acl.c
+++ b/source4/dsdb/samdb/ldb_modules/acl.c
@@ -516,7 +516,7 @@ static int acl_validate_spn_value(TALLOC_CTX *mem_ctx,
        if (strlen(instanceName) == (strlen(samAccountName) - 1)
            && strncasecmp(instanceName, samAccountName, strlen(samAccountName) - 1) == 0) {
                goto success;
-       } else if (strcasecmp(instanceName, dnsHostName) == 0) {
+       } else if (dnsHostName != NULL && strcasecmp(instanceName, dnsHostName) == 0) {
                goto success;
        } else if (is_dc) {
                const char *guid_str;