KCC: clarify setup-vertices docstring, remove TODO

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/python/samba/kcc/graph.py b/python/samba/kcc/graph.py
index 41f94b4606494bd13ba1d1558813501586b81fdf..ef261294b80f5e596eb54dda06b8b521a8700305 100644 (file)
--- a/python/samba/kcc/graph.py
+++ b/python/samba/kcc/graph.py
@@ -329,6 +329,14 @@ def create_edge_set(graph, transport, site_link_bridge):
 def setup_vertices(graph):
     """Initialise vertices in the graph for the Dijkstra's run.
 
+    Part of MS-ADTS 6.2.2.3.4.4
+
+    The schedule and options are set to all-on, so that intersections
+    with real data defer to that data.
+
+    Refer to the convert_schedule_to_repltimes() docstring for an
+    explanation of the repltimes schedule values.
+
     :param graph: an IntersiteGraph object
     :return: None
     """
@@ -344,7 +352,8 @@ def setup_vertices(graph):
 
         v.repl_info.interval = 0
         v.repl_info.options = 0xFFFFFFFF
-        v.repl_info.schedule = None  # TODO highly suspicious
+        # repl_info.schedule == None means "always".
+        v.repl_info.schedule = None
         v.repl_info.duration = 84 * 8
         v.demoted = False