tests/samba_tool/provision_password_check: follow super inheritance
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Sat, 27 Oct 2018 21:43:42 +0000 (10:43 +1300)
committerDouglas Bagnall <dbagnall@samba.org>
Thu, 1 Nov 2018 04:08:09 +0000 (05:08 +0100)
We were skipping a level in the inheritance chain, which had no effect
in this case (no .setUps or .tearDowns were missed) but it would be
confusing if the parents ever changed.

Note: in python 3, you just call super() with no args, and it works
out the right thing.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <noel.power@suse.com>
python/samba/tests/samba_tool/provision_password_check.py

index b2a88699ab4c103e4898348c83393e574227a803..a8fb8578ecc6c98ba0248c82aaaddb387aeebfde 100644 (file)
@@ -24,7 +24,7 @@ class ProvisionPasswordTestCase(SambaToolCmdTest):
     """Test for password validation in domain provision subcommand"""
 
     def setUp(self):
-        super(SambaToolCmdTest, self).setUp()
+        super(ProvisionPasswordTestCase, self).setUp()
         self.tempsambadir = os.path.join(self.tempdir, "samba")
         os.mkdir(self.tempsambadir)
 
@@ -53,5 +53,5 @@ class ProvisionPasswordTestCase(SambaToolCmdTest):
         self.assertCmdSuccess(result, out, err)
 
     def tearDown(self):
-        super(SambaToolCmdTest, self).tearDown()
+        super(ProvisionPasswordTestCase, self).tearDown()
         shutil.rmtree(self.tempsambadir)