s3-winbind: DON'T PANIC if we couldn't find the domain.
authorAndreas Schneider <asn@samba.org>
Tue, 4 Sep 2012 12:30:38 +0000 (14:30 +0200)
committerAndreas Schneider <asn@cryptomilk.org>
Tue, 4 Sep 2012 16:16:06 +0000 (18:16 +0200)
If we don't have a connection to a trusted domain but still try to do a
lookup we shouldn't segfault.

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Sep  4 18:16:06 CEST 2012 on sn-devel-104

source3/winbindd/winbindd_group.c

index 2f8ba6a02368f57a1eadef24c78566035d532dd0..ae461bf37486fe240c5d9b3d5bd4712c3239e651 100644 (file)
@@ -35,9 +35,17 @@ bool fill_grent(TALLOC_CTX *mem_ctx, struct winbindd_gr *gr,
 {
        fstring full_group_name;
        char *mapped_name = NULL;
-       struct winbindd_domain *domain = find_domain_from_name_noinit(dom_name);
+       struct winbindd_domain *domain;
        NTSTATUS nt_status = NT_STATUS_UNSUCCESSFUL;
 
+       domain = find_domain_from_name_noinit(dom_name);
+       if (domain == NULL) {
+               DEBUG(0, ("Failed to find domain '%s'. "
+                         "Check connection to trusted domains!\n",
+                         dom_name));
+               return false;
+       }
+
        nt_status = normalize_name_map(mem_ctx, domain, gr_name,
                                       &mapped_name);