samba-tool: let 'samba-tool user syncpasswords' report deletions immediately
authorStefan Metzmacher <metze@samba.org>
Tue, 25 Apr 2017 11:25:57 +0000 (13:25 +0200)
committerStefan Metzmacher <metze@samba.org>
Thu, 4 May 2017 19:36:23 +0000 (21:36 +0200)
We need to use the show-recycled control in addition to the
notification control in order to get notifications about deletions.

There's no real problem as the next modification will report the deletion.
But it might be delayed a few minutes.

Note that show-recycled is a superset of show-deleted, so we only need one.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12767

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
python/samba/netcmd/user.py

index fbb98a13d87b677e4526e69b53c0e78c75ffa4fa..47d958d6104c2ceed9cf4441c52dd74c25a80b24 100644 (file)
@@ -1861,7 +1861,7 @@ samba-tool user syncpasswords --terminate \\
 
         def sync_loop(wait):
             notify_attrs = ["name", "uSNCreated", "uSNChanged", "objectClass"]
-            notify_controls = ["notification:1"]
+            notify_controls = ["notification:1", "show_recycled:1"]
             notify_handle = self.samdb.search_iterator(expression="objectClass=*",
                                                        scope=ldb.SCOPE_SUBTREE,
                                                        attrs=notify_attrs,