r22474: If ldb does not return sucess, then the res variable may not be valid.

It *should* just be NULL from the initialisation above, but I've had
this not be the case...

Andrew Bartlett

diff --git a/source/lib/ldb/common/ldb.c b/source/lib/ldb/common/ldb.c
index 5b3520766dd17480573071d6c2579b3e93e33f71..c317fe57faff77316143a32d1db34c98135b2df7 100644 (file)
--- a/source/lib/ldb/common/ldb.c
+++ b/source/lib/ldb/common/ldb.c
@@ -970,8 +970,6 @@ int ldb_search_exp_fmt(struct ldb_context *ldb, TALLOC_CTX *mem_ctx, struct ldb_
        if (ret == LDB_SUCCESS) {
                talloc_steal(mem_ctx, res);
                *result = res;
-       } else {
-               talloc_free(res);
        }
 
        talloc_free(expression);