dsdb/partition: Remove teardown of data->metadata on partition_metadata_set_sequence_...

This changes variables that are not the responsiblity of this function, the unlock
implied by partition_del_trans() needs to be done carefully in the right spot.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>

diff --git a/source4/dsdb/samdb/ldb_modules/partition_metadata.c b/source4/dsdb/samdb/ldb_modules/partition_metadata.c
index c0800f5e506b6631f5a84fcc40f38c0b91a639f2..02e56e175a36f323bfd0ab771d07960d86d84ee3 100644 (file)
--- a/source4/dsdb/samdb/ldb_modules/partition_metadata.c
+++ b/source4/dsdb/samdb/ldb_modules/partition_metadata.c
@@ -406,8 +406,6 @@ int partition_metadata_sequence_number_increment(struct ldb_module *module, uint
                 */
                ret = partition_metadata_set_sequence_number(module);
                if (ret != LDB_SUCCESS) {
-                       TALLOC_FREE(data->metadata);
-                       partition_del_trans(module);
                        return ret;
                }