smbd: explain that/why we use the raw tevent_context for oplock_timeout_handler()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

diff --git a/source3/smbd/oplock.c b/source3/smbd/oplock.c
index b13aae888202437cf523fd4072d606ab43fb5cf1..f7654176a88081bece5ef97616988abd3c11a997 100644 (file)
--- a/source3/smbd/oplock.c
+++ b/source3/smbd/oplock.c
@@ -727,6 +727,11 @@ static void oplock_timeout_handler(struct tevent_context *ctx,
 {
        files_struct *fsp = (files_struct *)private_data;
 
+       /*
+        * Note this function doesn't run under any specific impersonation and
+        * is not expected to call any SMB_VFS operation!
+        */
+
        SMB_ASSERT(fsp->sent_oplock_break != NO_BREAK_SENT);
 
        /* Remove the timed event handler. */
@@ -761,8 +766,15 @@ static void add_oplock_timeout_handler(files_struct *fsp)
                          "around\n"));
        }
 
+       /*
+        * For now we keep the logic and use the
+        * raw event context. We're called from
+        * the messaging system from a raw event context.
+        * Also oplock_timeout_handler doesn't invoke
+        * SMB_VFS calls.
+        */
        fsp->oplock_timeout =
-               tevent_add_timer(fsp->conn->sconn->ev_ctx, fsp,
+               tevent_add_timer(fsp->conn->sconn->raw_ev_ctx, fsp,
                                 timeval_current_ofs(OPLOCK_BREAK_TIMEOUT, 0),
                                 oplock_timeout_handler, fsp);