lib/util: clang: Fix 'Null pointer passed as an argument...' warning
authorNoel Power <noel.power@suse.com>
Fri, 24 May 2019 13:32:09 +0000 (13:32 +0000)
committerNoel Power <npower@samba.org>
Tue, 11 Jun 2019 12:10:17 +0000 (12:10 +0000)
Fixes:

lib/util/debug.c:705:7: warning: Null pointer passed as an argument to a 'nonnull' parameter <--[clang]

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer gary@catalyst.net.nz
lib/util/debug.c

index d2fbab12414d5c17c2e6f77f2600ebe5881b9581..c42022ec9bbae4440b4bd84a9288e85969075054 100644 (file)
@@ -699,11 +699,15 @@ static int debug_lookup_classname_int(const char* classname)
 {
        size_t i;
 
-       if (!classname) return -1;
+       if (classname == NULL) {
+               return -1;
+       }
 
        for (i=0; i < debug_num_classes; i++) {
-               if (strcmp(classname, classname_table[i])==0)
+               char *entry = classname_table[i];
+               if (entry != NULL && strcmp(classname, entry)==0) {
                        return i;
+               }
        }
        return -1;
 }
@@ -780,7 +784,7 @@ static int debug_lookup_classname(const char *classname)
 {
        int ndx;
 
-       if (!classname || !*classname)
+       if (classname == NULL || !*classname)
                return -1;
 
        ndx = debug_lookup_classname_int(classname);