libcli/smb: clang: Fix 'array access results in a null pointer deref'

Fixes:

smbXcli_base.c:1239:9: warning: Array access (via field 'pending') results in a null pointer dereference <--[clang]
                req = conn->pending[0];
                      ^

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>

diff --git a/libcli/smb/smbXcli_base.c b/libcli/smb/smbXcli_base.c
index 2f5fac081282a13cf89a35b59072ba1f8aa5c737..37ae0a0e0e11bb2d1578536ced260132993edeb9 100644 (file)
--- a/libcli/smb/smbXcli_base.c
+++ b/libcli/smb/smbXcli_base.c
@@ -1229,7 +1229,8 @@ void smbXcli_conn_disconnect(struct smbXcli_conn *conn, NTSTATUS status)
         * conn->pending because that array changes in
         * smbXcli_req_unset_pending.
         */
-       while (talloc_array_length(conn->pending) > 0) {
+       while (conn->pending != NULL &&
+              talloc_array_length(conn->pending) > 0) {
                struct tevent_req *req;
                struct smbXcli_req_state *state;
                struct tevent_req **chain;