testprogs: Correctly expand shell parameters

The old behaviour is:

  for var in $*
  do
    echo "$var"
  done

And you get this:

$ sh test.sh 1 2 '3 4'
1
2
3
4

Changing it to:

  for var in "$@"
  do
    echo "$var"
  done

will correctly expand to:

$ sh test.sh 1 2 '3 4'
1
2
3 4

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Mar 15 05:26:17 CET 2017 on sn-devel-144

diff --git a/testprogs/blackbox/subunit.sh b/testprogs/blackbox/subunit.sh
index 0791d775d275892d6dbec2adc1def06a073d8f7e..5c81ce20a118f45cd6a5db7b5a775257666baf05 100755 (executable)
--- a/testprogs/blackbox/subunit.sh
+++ b/testprogs/blackbox/subunit.sh
@@ -78,7 +78,7 @@ subunit_skip_test () {
 testit () {
        name="$1"
        shift
-       cmdline="$*"
+       cmdline="$@"
        subunit_start_test "$name"
        output=`$cmdline 2>&1`
        status=$?
@@ -93,7 +93,7 @@ testit () {
 testit_expect_failure () {
        name="$1"
        shift
-       cmdline="$*"
+       cmdline="$@"
        subunit_start_test "$name"
        output=`$cmdline 2>&1`
        status=$?