r3464: split out registry.h, rap.h and ldap_server.h
[ab/samba.git/.git] / source4 / ldap_server / ldap_simple_ldb.c
index c7ebd0b237f01645033b6abe61ef5376a042c8c8..8f40636a5c3e8120f9bc4ef7050e8ac5e9fbba3d 100644 (file)
@@ -2,6 +2,7 @@
    Unix SMB/CIFS implementation.
    LDAP server SIMPLE LDB implementation
    Copyright (C) Stefan Metzmacher 2004
+   Copyright (C) Simo Sorce 2004
    
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
@@ -19,6 +20,8 @@
 */
 
 #include "includes.h"
+#include "ldap_server/ldap_server.h"
+#include "ldap_parse.h"
 
 /* TODO: samdb_context is not a pulblic struct */
 struct samdb_context {
@@ -33,34 +36,56 @@ struct samdb_context {
        }\
 } while(0)
 
+#define VALID_DN_SYNTAX(dn,i) do {\
+       if (!(dn)) {\
+               return NT_STATUS_NO_MEMORY;\
+       } else if ((dn)->comp_num < (i)) {\
+               result = LDAP_INVALID_DN_SYNTAX;\
+               errstr = "Invalid DN (" #i " components needed for '" #dn "')";\
+               goto reply;\
+       }\
+} while(0)
+
 static NTSTATUS sldb_Search(struct ldapsrv_partition *partition, struct ldapsrv_call *call,
                                     struct ldap_SearchRequest *r)
 {
        NTSTATUS status;
+       void *local_ctx;
+       struct ldap_dn *basedn;
        struct ldap_Result *done;
        struct ldap_SearchResEntry *ent;
        struct ldapsrv_reply *ent_r, *done_r;
-       int result = 80;
+       int result = LDAP_SUCCESS;
        struct samdb_context *samdb;
        struct ldb_message **res;
        int i, j, y, count;
-       struct ldb_context *ldb;
        enum ldb_scope scope = LDB_SCOPE_DEFAULT;
        const char **attrs = NULL;
+       const char *errstr = NULL;
+
+       local_ctx = talloc_named(call, 0, "sldb_Search local memory context");
+       ALLOC_CHECK(local_ctx);
 
-       DEBUG(0, ("sldb_Search: %s\n", r->filter));
+       samdb = samdb_connect(local_ctx);
+       ALLOC_CHECK(samdb);
 
-       samdb = samdb_connect(call);
-       ldb = samdb->ldb;
+       basedn = ldap_parse_dn(local_ctx, r->basedn);
+       VALID_DN_SYNTAX(basedn,0);
+
+       DEBUG(10, ("sldb_Search: basedn: [%s]\n", basedn->dn));
+       DEBUG(10, ("sldb_Search: filter: [%s]\n", r->filter));
 
        switch (r->scope) {
                case LDAP_SEARCH_SCOPE_BASE:
+                       DEBUG(10,("sldb_Search: scope: [BASE]\n"));
                        scope = LDB_SCOPE_BASE;
                        break;
                case LDAP_SEARCH_SCOPE_SINGLE:
+                       DEBUG(10,("sldb_Search: scope: [ONE]\n"));
                        scope = LDB_SCOPE_ONELEVEL;
                        break;
                case LDAP_SEARCH_SCOPE_SUB:
+                       DEBUG(10,("sldb_Search: scope: [SUB]\n"));
                        scope = LDB_SCOPE_SUBTREE;
                        break;
        }
@@ -70,21 +95,14 @@ static NTSTATUS sldb_Search(struct ldapsrv_partition *partition, struct ldapsrv_
                ALLOC_CHECK(attrs);
 
                for (i=0; i < r->num_attributes; i++) {
+                       DEBUG(10,("sldb_Search: attrs: [%s]\n",r->attributes[i]));
                        attrs[i] = r->attributes[i];
                }
                attrs[i] = NULL;
        }
 
-       ldb_set_alloc(ldb, talloc_ldb_alloc, samdb);
-       count = ldb_search(ldb, r->basedn, scope, r->filter, attrs, &res);
-
-       if (count > 0) {
-               result = 0;
-       } else if (count == 0) {
-               result = 32;
-       } else if (count == -1) {
-               result = 1;
-       }
+       ldb_set_alloc(samdb->ldb, talloc_realloc_fn, samdb);
+       count = ldb_search(samdb->ldb, basedn->dn, scope, r->filter, attrs, &res);
 
        for (i=0; i < count; i++) {
                ent_r = ldapsrv_init_reply(call, LDAP_TAG_SearchResultEntry);
@@ -95,7 +113,7 @@ static NTSTATUS sldb_Search(struct ldapsrv_partition *partition, struct ldapsrv_
                ent->num_attributes = 0;
                ent->attributes = NULL;
                if (res[i]->num_elements == 0) {
-                       continue;
+                       goto queue_reply;
                }
                ent->num_attributes = res[i]->num_elements;
                ent->attributes = talloc_array_p(ent_r, struct ldap_attribute, ent->num_attributes);
@@ -117,72 +135,487 @@ static NTSTATUS sldb_Search(struct ldapsrv_partition *partition, struct ldapsrv_
                                                                        res[i]->elements[j].values[y].data);
                        }
                }
-
+queue_reply:
                status = ldapsrv_queue_reply(call, ent_r);
                if (!NT_STATUS_IS_OK(status)) {
                        return status;
                }
        }
 
-       talloc_free(samdb);
-
+reply:
        done_r = ldapsrv_init_reply(call, LDAP_TAG_SearchResultDone);
        ALLOC_CHECK(done_r);
 
+       if (result == LDAP_SUCCESS) {
+               if (count > 0) {
+                       DEBUG(10,("sldb_Search: results: [%d]\n",count));
+                       result = LDAP_SUCCESS;
+                       errstr = NULL;
+               } else if (count == 0) {
+                       DEBUG(10,("sldb_Search: no results\n"));
+                       result = LDAP_NO_SUCH_OBJECT;
+                       errstr = ldb_errstring(samdb->ldb);
+               } else if (count == -1) {
+                       DEBUG(10,("sldb_Search: error\n"));
+                       result = LDAP_OTHER;
+                       errstr = ldb_errstring(samdb->ldb);
+               }
+       }
+
        done = &done_r->msg.r.SearchResultDone;
-       done->resultcode = result;
        done->dn = NULL;
-       done->errormessage = NULL;
+       done->resultcode = result;
+       done->errormessage = (errstr?talloc_strdup(done_r,errstr):NULL);
        done->referral = NULL;
 
+       talloc_free(local_ctx);
+
        return ldapsrv_queue_reply(call, done_r);
 }
 
-static NTSTATUS sldb_Delete(struct ldapsrv_partition *partition, struct ldapsrv_call *call,
-                                    struct ldap_DeleteRequest *r)
+static NTSTATUS sldb_Add(struct ldapsrv_partition *partition, struct ldapsrv_call *call,
+                                    struct ldap_AddRequest *r)
 {
-       struct ldap_Result *delete_result;
-       struct ldapsrv_reply *delete_reply;
+       void *local_ctx;
+       struct ldap_dn *dn;
+       struct ldap_Result *add_result;
+       struct ldapsrv_reply *add_reply;
        int ldb_ret;
        struct samdb_context *samdb;
-       struct ldb_context *ldb;
+       struct ldb_message *msg;
+       int result = LDAP_SUCCESS;
+       const char *errstr = NULL;
+       int i,j;
+
+       local_ctx = talloc_named(call, 0, "sldb_Add local memory context");
+       ALLOC_CHECK(local_ctx);
+
+       samdb = samdb_connect(local_ctx);
+       ALLOC_CHECK(samdb);
+
+       dn = ldap_parse_dn(local_ctx, r->dn);
+       VALID_DN_SYNTAX(dn,1);
+
+       DEBUG(10, ("sldb_add: dn: [%s]\n", dn->dn));
+
+       msg = talloc_p(local_ctx, struct ldb_message);
+       ALLOC_CHECK(msg);
+
+       msg->dn = dn->dn;
+       msg->private_data = NULL;
+       msg->num_elements = 0;
+       msg->elements = NULL;
+
+       if (r->num_attributes > 0) {
+               msg->num_elements = r->num_attributes;
+               msg->elements = talloc_array_p(msg, struct ldb_message_element, msg->num_elements);
+               ALLOC_CHECK(msg->elements);
+
+               for (i=0; i < msg->num_elements; i++) {
+                       msg->elements[i].name = discard_const_p(char, r->attributes[i].name);
+                       msg->elements[i].flags = 0;
+                       msg->elements[i].num_values = 0;
+                       msg->elements[i].values = NULL;
+                       
+                       if (r->attributes[i].num_values > 0) {
+                               msg->elements[i].num_values = r->attributes[i].num_values;
+                               msg->elements[i].values = talloc_array_p(msg, struct ldb_val, msg->elements[i].num_values);
+                               ALLOC_CHECK(msg->elements[i].values);
+
+                               for (j=0; j < msg->elements[i].num_values; j++) {
+                                       if (!(r->attributes[i].values[j].length > 0)) {
+                                               result = LDAP_OTHER;
+                                               errstr = "Empty attribute values are not allowed";
+                                               goto reply;
+                                       }
+                                       msg->elements[i].values[j].length = r->attributes[i].values[j].length;
+                                       msg->elements[i].values[j].data = r->attributes[i].values[j].data;                      
+                               }
+                       } else {
+                               result = LDAP_OTHER;
+                               errstr = "No attribute values are not allowed";
+                               goto reply;
+                       }
+               }
+       } else {
+               result = LDAP_OTHER;
+               errstr = "No attributes are not allowed";
+               goto reply;
+       }
+
+reply:
+       add_reply = ldapsrv_init_reply(call, LDAP_TAG_AddResponse);
+       ALLOC_CHECK(add_reply);
+
+       if (result == LDAP_SUCCESS) {
+               ldb_set_alloc(samdb->ldb, talloc_realloc_fn, samdb);
+               ldb_ret = ldb_add(samdb->ldb, msg);
+               if (ldb_ret == 0) {
+                       result = LDAP_SUCCESS;
+                       errstr = NULL;
+               } else {
+                       /* currently we have no way to tell if there was an internal ldb error
+                        * or if the object was not found, return the most probable error
+                        */
+                       result = LDAP_OPERATIONS_ERROR;
+                       errstr = ldb_errstring(samdb->ldb);
+               }
+       }
+
+       add_result = &add_reply->msg.r.AddResponse;
+       add_result->dn = NULL;
+       add_result->resultcode = result;
+       add_result->errormessage = (errstr?talloc_strdup(add_reply,errstr):NULL);
+       add_result->referral = NULL;
+
+       talloc_free(local_ctx);
+
+       return ldapsrv_queue_reply(call, add_reply);
+}
+
+static NTSTATUS sldb_Del(struct ldapsrv_partition *partition, struct ldapsrv_call *call,
+                                    struct ldap_DelRequest *r)
+{
+       void *local_ctx;
+       struct ldap_dn *dn;
+       struct ldap_Result *del_result;
+       struct ldapsrv_reply *del_reply;
+       int ldb_ret;
+       struct samdb_context *samdb;
+       const char *errstr = NULL;
+       int result = LDAP_SUCCESS;
+
+       local_ctx = talloc_named(call, 0, "sldb_Del local memory context");
+       ALLOC_CHECK(local_ctx);
+
+       samdb = samdb_connect(local_ctx);
+       ALLOC_CHECK(samdb);
+
+       dn = ldap_parse_dn(local_ctx, r->dn);
+       VALID_DN_SYNTAX(dn,1);
+
+       DEBUG(10, ("sldb_Del: dn: [%s]\n", dn->dn));
+
+reply:
+       del_reply = ldapsrv_init_reply(call, LDAP_TAG_DelResponse);
+       ALLOC_CHECK(del_reply);
+
+       if (result == LDAP_SUCCESS) {
+               ldb_set_alloc(samdb->ldb, talloc_realloc_fn, samdb);
+               ldb_ret = ldb_delete(samdb->ldb, dn->dn);
+               if (ldb_ret == 0) {
+                       result = LDAP_SUCCESS;
+                       errstr = NULL;
+               } else {
+                       /* currently we have no way to tell if there was an internal ldb error
+                        * or if the object was not found, return the most probable error
+                        */
+                       result = LDAP_NO_SUCH_OBJECT;
+                       errstr = ldb_errstring(samdb->ldb);
+               }
+       }
+
+       del_result = &del_reply->msg.r.DelResponse;
+       del_result->dn = NULL;
+       del_result->resultcode = result;
+       del_result->errormessage = (errstr?talloc_strdup(del_reply,errstr):NULL);
+       del_result->referral = NULL;
+
+       talloc_free(local_ctx);
+
+       return ldapsrv_queue_reply(call, del_reply);
+}
+
+static NTSTATUS sldb_Modify(struct ldapsrv_partition *partition, struct ldapsrv_call *call,
+                                    struct ldap_ModifyRequest *r)
+{
+       void *local_ctx;
+       struct ldap_dn *dn;
+       struct ldap_Result *modify_result;
+       struct ldapsrv_reply *modify_reply;
+       int ldb_ret;
+       struct samdb_context *samdb;
+       struct ldb_message *msg;
+       int result = LDAP_SUCCESS;
+       const char *errstr = NULL;
+       int i,j;
 
-       DEBUG(0, ("sldb_Delete: %s\n", r->dn));
+       local_ctx = talloc_named(call, 0, "sldb_Modify local memory context");
+       ALLOC_CHECK(local_ctx);
 
-       samdb = samdb_connect(call);
-       ldb = samdb->ldb;
+       samdb = samdb_connect(local_ctx);
+       ALLOC_CHECK(samdb);
 
-       ldb_set_alloc(ldb, talloc_ldb_alloc, samdb);
-       ldb_ret = ldb_delete(ldb, r->dn);
+       dn = ldap_parse_dn(local_ctx, r->dn);
+       VALID_DN_SYNTAX(dn,1);
 
-       delete_reply = ldapsrv_init_reply(call, LDAP_TAG_DeleteResponse);
+       DEBUG(10, ("sldb_modify: dn: [%s]\n", dn->dn));
 
-       delete_result = &delete_reply->msg.r.DeleteResponse;
-       delete_result->dn = talloc_steal(delete_reply, r->dn);
+       msg = talloc_p(local_ctx, struct ldb_message);
+       ALLOC_CHECK(msg);
 
-       if (ldb_ret != 0) {
-               /* currently we have no way to tell if there was an internal ldb error
-                * or if the object was not found, return the most probable error
-                */
-               delete_result->resultcode = LDAP_NO_SUCH_OBJECT;
-               delete_result->errormessage = ldb_errstring(ldb);
-               delete_result->referral = NULL;
-       } else {        
-               delete_result->resultcode = LDAP_SUCCESS;
-               delete_result->errormessage = NULL;
-               delete_result->referral = NULL;
+       msg->dn = dn->dn;
+       msg->private_data = NULL;
+       msg->num_elements = 0;
+       msg->elements = NULL;
+
+       if (r->num_mods > 0) {
+               msg->num_elements = r->num_mods;
+               msg->elements = talloc_array_p(msg, struct ldb_message_element, r->num_mods);
+               ALLOC_CHECK(msg->elements);
+
+               for (i=0; i < msg->num_elements; i++) {
+                       msg->elements[i].name = discard_const_p(char, r->mods[i].attrib.name);
+                       msg->elements[i].num_values = 0;
+                       msg->elements[i].values = NULL;
+
+                       switch (r->mods[i].type) {
+                       default:
+                               result = LDAP_PROTOCOL_ERROR;
+                               errstr = "Invalid LDAP_MODIFY_* type";
+                               goto reply;
+                       case LDAP_MODIFY_ADD:
+                               msg->elements[i].flags = LDB_FLAG_MOD_ADD;
+                               break;
+                       case LDAP_MODIFY_DELETE:
+                               msg->elements[i].flags = LDB_FLAG_MOD_DELETE;
+                               break;
+                       case LDAP_MODIFY_REPLACE:
+                               msg->elements[i].flags = LDB_FLAG_MOD_REPLACE;
+                               break;
+                       }
+
+                       if (r->mods[i].attrib.num_values > 0) {
+                               msg->elements[i].num_values = r->mods[i].attrib.num_values;
+                               msg->elements[i].values = talloc_array_p(msg, struct ldb_val, msg->elements[i].num_values);
+                               ALLOC_CHECK(msg->elements[i].values);
+
+                               for (j=0; j < msg->elements[i].num_values; j++) {
+                                       if (!(r->mods[i].attrib.values[j].length > 0)) {
+                                               result = LDAP_OTHER;
+                                               errstr = "Empty attribute values are not allowed";
+                                               goto reply;
+                                       }
+                                       msg->elements[i].values[j].length = r->mods[i].attrib.values[j].length;
+                                       msg->elements[i].values[j].data = r->mods[i].attrib.values[j].data;                     
+                               }
+                       } else {
+                               /* TODO: test what we should do here 
+                                *
+                                *       LDAP_MODIFY_DELETE is ok to pass here
+                                */
+                       }
+               }
+       } else {
+               result = LDAP_OTHER;
+               errstr = "No mods are not allowed";
+               goto reply;
+       }
+
+reply:
+       modify_reply = ldapsrv_init_reply(call, LDAP_TAG_ModifyResponse);
+       ALLOC_CHECK(modify_reply);
+
+       if (result == LDAP_SUCCESS) {
+               ldb_set_alloc(samdb->ldb, talloc_realloc_fn, samdb);
+               ldb_ret = ldb_modify(samdb->ldb, msg);
+               if (ldb_ret == 0) {
+                       result = LDAP_SUCCESS;
+                       errstr = NULL;
+               } else {
+                       /* currently we have no way to tell if there was an internal ldb error
+                        * or if the object was not found, return the most probable error
+                        */
+                       result = LDAP_OPERATIONS_ERROR;
+                       errstr = ldb_errstring(samdb->ldb);
+               }
+       }
+
+       modify_result = &modify_reply->msg.r.AddResponse;
+       modify_result->dn = NULL;
+       modify_result->resultcode = result;
+       modify_result->errormessage = (errstr?talloc_strdup(modify_reply,errstr):NULL);
+       modify_result->referral = NULL;
+
+       talloc_free(local_ctx);
+
+       return ldapsrv_queue_reply(call, modify_reply);
+}
+
+static NTSTATUS sldb_Compare(struct ldapsrv_partition *partition, struct ldapsrv_call *call,
+                                    struct ldap_CompareRequest *r)
+{
+       void *local_ctx;
+       struct ldap_dn *dn;
+       struct ldap_Result *compare;
+       struct ldapsrv_reply *compare_r;
+       int result = LDAP_SUCCESS;
+       struct samdb_context *samdb;
+       struct ldb_message **res;
+       const char *attrs[1];
+       const char *errstr = NULL;
+       const char *filter;
+       int count;
+
+       local_ctx = talloc_named(call, 0, "sldb_Compare local_memory_context");
+       ALLOC_CHECK(local_ctx);
+
+       samdb = samdb_connect(local_ctx);
+       ALLOC_CHECK(samdb);
+
+       dn = ldap_parse_dn(local_ctx, r->dn);
+       VALID_DN_SYNTAX(dn,1);
+
+       DEBUG(10, ("sldb_Compare: dn: [%s]\n", dn->dn));
+       filter = talloc_asprintf(local_ctx, "(%s=%*s)", r->attribute, r->value.length, r->value.data);
+       ALLOC_CHECK(filter);
+
+       DEBUGADD(10, ("sldb_Compare: attribute: [%s]\n", filter));
+
+       attrs[0] = NULL;
+
+reply:
+       compare_r = ldapsrv_init_reply(call, LDAP_TAG_CompareResponse);
+       ALLOC_CHECK(compare_r);
+
+       if (result == LDAP_SUCCESS) {
+               ldb_set_alloc(samdb->ldb, talloc_realloc_fn, samdb);
+               count = ldb_search(samdb->ldb, dn->dn, LDB_SCOPE_BASE, filter, attrs, &res);
+               if (count == 1) {
+                       DEBUG(10,("sldb_Compare: matched\n"));
+                       result = LDAP_COMPARE_TRUE;
+                       errstr = NULL;
+               } else if (count == 0) {
+                       DEBUG(10,("sldb_Compare: doesn't matched\n"));
+                       result = LDAP_COMPARE_FALSE;
+                       errstr = NULL;
+               } else if (count > 1) {
+                       result = LDAP_OTHER;
+                       errstr = "too many objects match";
+                       DEBUG(10,("sldb_Compare: %d results: %s\n", count, errstr));
+               } else if (count == -1) {
+                       result = LDAP_OTHER;
+                       errstr = ldb_errstring(samdb->ldb);
+                       DEBUG(10,("sldb_Compare: error: %s\n", errstr));
+               }
+       }
+
+       compare = &compare_r->msg.r.CompareResponse;
+       compare->dn = NULL;
+       compare->resultcode = result;
+       compare->errormessage = (errstr?talloc_strdup(compare_r,errstr):NULL);
+       compare->referral = NULL;
+
+       talloc_free(local_ctx);
+
+       return ldapsrv_queue_reply(call, compare_r);
+}
+
+NTSTATUS sldb_ModifyDN(struct ldapsrv_partition *partition, struct ldapsrv_call *call, struct ldap_ModifyDNRequest *r)
+{
+       void *local_ctx;
+       struct ldap_dn *olddn, *newrdn, *newsuperior;
+       struct ldap_Result *modifydn;
+       struct ldapsrv_reply *modifydn_r;
+       int ldb_ret;
+       struct samdb_context *samdb;
+       const char *errstr = NULL;
+       int result = LDAP_SUCCESS;
+       const char *newdn;
+       char *parentdn = NULL;
+
+       local_ctx = talloc_named(call, 0, "sldb_ModifyDN local memory context");
+       ALLOC_CHECK(local_ctx);
+
+       samdb = samdb_connect(local_ctx);
+       ALLOC_CHECK(samdb);
+
+       olddn = ldap_parse_dn(local_ctx, r->dn);
+       VALID_DN_SYNTAX(olddn,2);
+
+       newrdn = ldap_parse_dn(local_ctx, r->newrdn);
+       VALID_DN_SYNTAX(newrdn,1);
+
+       DEBUG(10, ("sldb_ModifyDN: olddn: [%s]\n", olddn->dn));
+       DEBUG(10, ("sldb_ModifyDN: newrdn: [%s]\n", newrdn->dn));
+
+       /* we can't handle the rename if we should not remove the old dn */
+       if (!r->deleteolddn) {
+               result = LDAP_UNWILLING_TO_PERFORM;
+               errstr = "Old RDN must be deleted";
+               goto reply;
+       }
+
+       if (newrdn->comp_num > 1) {
+               result = LDAP_NAMING_VIOLATION;
+               errstr = "Error new RDN invalid";
+               goto reply;
+       }
+
+       if (r->newsuperior) {
+               newsuperior = ldap_parse_dn(local_ctx, r->newsuperior);
+               VALID_DN_SYNTAX(newsuperior,0);
+               DEBUG(10, ("sldb_ModifyDN: newsuperior: [%s]\n", newsuperior->dn));
+               
+               if (newsuperior->comp_num < 1) {
+                       result = LDAP_AFFECTS_MULTIPLE_DSAS;
+                       errstr = "Error new Superior DN invalid";
+                       goto reply;
+               }
+               parentdn = newsuperior->dn;
+       }
+
+       if (!parentdn) {
+               int i;
+               parentdn = talloc_strdup(local_ctx, olddn->components[1]->component);
+               ALLOC_CHECK(parentdn);
+               for(i=2; i < olddn->comp_num; i++) {
+                       char *old = parentdn;
+                       parentdn = talloc_asprintf(local_ctx, "%s,%s", old, olddn->components[i]->component);
+                       ALLOC_CHECK(parentdn);
+                       talloc_free(old);
+               }
+       }
+       newdn = talloc_asprintf(local_ctx, "%s,%s", newrdn->dn, parentdn);
+       ALLOC_CHECK(newdn);
+
+reply:
+       modifydn_r = ldapsrv_init_reply(call, LDAP_TAG_ModifyDNResponse);
+       ALLOC_CHECK(modifydn_r);
+
+       if (result == LDAP_SUCCESS) {
+               ldb_set_alloc(samdb->ldb, talloc_realloc_fn, samdb);
+               ldb_ret = ldb_rename(samdb->ldb, olddn->dn, newdn);
+               if (ldb_ret == 0) {
+                       result = LDAP_SUCCESS;
+                       errstr = NULL;
+               } else {
+                       /* currently we have no way to tell if there was an internal ldb error
+                        * or if the object was not found, return the most probable error
+                        */
+                       result = LDAP_NO_SUCH_OBJECT;
+                       errstr = ldb_errstring(samdb->ldb);
+               }
        }
 
-       ldapsrv_queue_reply(call, delete_reply);
+       modifydn = &modifydn_r->msg.r.ModifyDNResponse;
+       modifydn->dn = NULL;
+       modifydn->resultcode = result;
+       modifydn->errormessage = (errstr?talloc_strdup(modifydn_r,errstr):NULL);
+       modifydn->referral = NULL;
 
-       talloc_free(samdb);
+       talloc_free(local_ctx);
 
-       return NT_STATUS_OK;
+       return ldapsrv_queue_reply(call, modifydn_r);
 }
 
 static const struct ldapsrv_partition_ops sldb_ops = {
        .Search         = sldb_Search,
-       .Delete         = sldb_Delete
+       .Add            = sldb_Add,
+       .Del            = sldb_Del,
+       .Modify         = sldb_Modify,
+       .Compare        = sldb_Compare,
+       .ModifyDN       = sldb_ModifyDN
 };
 
 const struct ldapsrv_partition_ops *ldapsrv_get_sldb_partition_ops(void)