obnox/wireshark/wip.git
20 years agoFrom Matthijs Melchior: check whether the ring buffer timeout has
guy [Thu, 25 Sep 2003 00:08:58 +0000 (00:08 +0000)]
From Matthijs Melchior: check whether the ring buffer timeout has
expired *before* writing a packet, rather than *after* writing a packet,
so that if you get no packets for a sufficiently long period that the
timeout expires before you get a new packet, the new packet is in the
beginning of a new file (as you might get more packets right after that,
and want them to be in the new file, rather than have the first packet
at the end of one file and the rest of the packets in another file).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8536 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom packet steve: update to give the correct name for "file_access.c",
guy [Wed, 24 Sep 2003 23:53:11 +0000 (23:53 +0000)]
From packet steve: update to give the correct name for "file_access.c",
and add a discussion of how data_offset works.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8535 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom David Frascone: have an 802.11 dissector that byte-swaps the frame
guy [Wed, 24 Sep 2003 23:35:39 +0000 (23:35 +0000)]
From David Frascone: have an 802.11 dissector that byte-swaps the frame
control field, and have a preference in the LWAPP dissector to specify
whether to use it or the regular 802.11 dissector, as some hardware
sends out LWAPP-encapsulated 802.11 packets with a byte-swapped FC field.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8534 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Anders Broman: fix a crash, and fix trailing whitespace on
guy [Wed, 24 Sep 2003 18:41:37 +0000 (18:41 +0000)]
From Anders Broman: fix a crash, and fix trailing whitespace on
Transaction ID.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8533 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Tomas Kukosa:
guy [Wed, 24 Sep 2003 18:35:58 +0000 (18:35 +0000)]
From Tomas Kukosa:

Remove the internal packet-per.c functions
"dissect_per_length_determinant()" and
"dissect_per_normally_small_nonnegative_whole_number()" from the
plugin API, as they shouldn't be used outside the PER dissector.

Remove the H.225/H.245 functions
"dissect_h225_TransportAddress()" and
"dissect_h245_NonStandardParameter()" from the plugin API until
we really need them in plugins.

Add the string dissector table functions to the plugin API.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8532 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAdd a "file_selection_new()" routine that does all the positioning (GTK+
guy [Wed, 24 Sep 2003 08:43:34 +0000 (08:43 +0000)]
Add a "file_selection_new()" routine that does all the positioning (GTK+
2.x) and transient-for setting that's done for other dialogs, and use it
for dialogs that come from the main window or from children of the main
window.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8531 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Yaniv Kaul: DCERPC OXID operation #5 dissection.
guy [Wed, 24 Sep 2003 08:05:50 +0000 (08:05 +0000)]
From Yaniv Kaul: DCERPC OXID operation #5 dissection.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8530 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Lars Ruoff: rewritten RTP analysis module.
guy [Wed, 24 Sep 2003 07:48:12 +0000 (07:48 +0000)]
From Lars Ruoff: rewritten RTP analysis module.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8529 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoIn packet_list_button_pressed_cb (gtk2 version) :
oabad [Wed, 24 Sep 2003 06:18:20 +0000 (06:18 +0000)]
In packet_list_button_pressed_cb (gtk2 version) :
- put back the event_button->window == GTK_CLIST(w)->clist_window test
  now that we use the correct structure definition for GtkCList (from
  the right include file, not from our version of gtkclist.h).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8528 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoRenamed gktclist.[ch] to gtkclist_v12.[ch] to avoid conflicts with the
oabad [Wed, 24 Sep 2003 06:15:53 +0000 (06:15 +0000)]
Renamed gktclist.[ch] to gtkclist_v12.[ch] to avoid conflicts with the
real gtkclist.h file when building the gtk+ v2 gui.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8527 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoCreate a protocol tree if we don't have one, we're constructing the Info
guy [Wed, 24 Sep 2003 03:34:00 +0000 (03:34 +0000)]
Create a protocol tree if we don't have one, we're constructing the Info
column, and we need stuff from the protocol tree for the Info column.

Go back to the previous scheme for constructing the Info column; the
previous change fixes the problems for which the Info column changes
were fixes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8526 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoPass a pointer to a "capture_file" structure to
guy [Wed, 24 Sep 2003 02:36:35 +0000 (02:36 +0000)]
Pass a pointer to a "capture_file" structure to
"set_menus_for_selected_packet()" and
"set_menus_for_selected_tree_row()", and have them decide whether to
enable or disable menu items based on whether that structure indicates
that a packet or field is selected and, if one is, on its properties.

Pass to the "selected packet enabled" routine for a menu item the
"frame_data" and "edt" members of the "capture_file" structure, and pass
to the "selected tree row enabled" routine the "field_info" member of
that structure.

Clear "cf->current_frame" if no packet is selected.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8525 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoMake "finfo_selected" a member of a "capture_file" structure rather than
guy [Wed, 24 Sep 2003 00:47:37 +0000 (00:47 +0000)]
Make "finfo_selected" a member of a "capture_file" structure rather than
an independent global variable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8524 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Greg Morris: get the request data before using it, if we don't
guy [Tue, 23 Sep 2003 22:04:02 +0000 (22:04 +0000)]
From Greg Morris: get the request data before using it, if we don't
already have it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8523 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAs doc/README.developer's "Portability" section says:
guy [Tue, 23 Sep 2003 21:37:11 +0000 (21:37 +0000)]
As doc/README.developer's "Portability" section says:

Don't use "bzero()", "bcopy()", or "bcmp()"; instead, use the
ANSI C routines

[memset, memcpy, memcmp] ...

Not all platforms necessarily have "bzero()"/"bcopy()"/"bcmp()",
and those that do might not declare them in the header file on
which they're declared on your platform.

Make it so.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8522 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Graeme Reid: H.450 support.
guy [Tue, 23 Sep 2003 18:59:50 +0000 (18:59 +0000)]
From Graeme Reid: H.450 support.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8521 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Graeme Reid: H.450 support.
guy [Tue, 23 Sep 2003 18:40:54 +0000 (18:40 +0000)]
From Graeme Reid: H.450 support.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8520 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Graeme Reid: modified PER choice dissector to correctly handle
guy [Tue, 23 Sep 2003 18:36:49 +0000 (18:36 +0000)]
From Graeme Reid: modified PER choice dissector to correctly handle
numbered choices starting with non-zero values (eg X.880 ROS).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8519 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Greg Morris: properly initialize request_value->info_string using
guy [Tue, 23 Sep 2003 18:22:19 +0000 (18:22 +0000)]
From Greg Morris: properly initialize request_value->info_string using
"strcpy()", not "strcat()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8518 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoThe relation list is always displayed (that's been true for a while) -
guy [Tue, 23 Sep 2003 18:09:36 +0000 (18:09 +0000)]
The relation list is always displayed (that's been true for a while) -
we don't need to support making it visible or not depending on the
selected field.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8517 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom JBM
sahlberg [Tue, 23 Sep 2003 12:06:20 +0000 (12:06 +0000)]
From JBM
Update all names for SAMR and LSA functions so they match the function names
in the API

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8516 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoTemporary patch for the packet_list column resize problem in gtk2.
oabad [Tue, 23 Sep 2003 06:25:10 +0000 (06:25 +0000)]
Temporary patch for the packet_list column resize problem in gtk2.

We should use the same test (event_button->window == GTK_CLIST(w)->clist_window)
we already use in gtk v1.2 code but in doesn't seem to work in gtk2.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8515 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Emanuele Caratti: fix a leak in md5_xor.
guy [Tue, 23 Sep 2003 03:18:30 +0000 (03:18 +0000)]
From Emanuele Caratti: fix a leak in md5_xor.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8514 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoGet rid of some unnecessary includes.
guy [Tue, 23 Sep 2003 02:35:59 +0000 (02:35 +0000)]
Get rid of some unnecessary includes.

Instead of using "dissect_vendor_specific_ie()" to dissect the WPA key
data, turn the code to dissect a collection of 802.11 tagged parameters
into a routine, use that routine when dissecting 802.11 management
frames, and also use it to dissect the key data.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8513 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoUpdate the menu text for Time Reference and give it a hot-key : ctrl-T
sahlberg [Mon, 22 Sep 2003 09:08:42 +0000 (09:08 +0000)]
Update the menu text for Time Reference  and give it a hot-key : ctrl-T

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8512 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAdd filterable field for REF TIME frames so it is easy to search for them
sahlberg [Mon, 22 Sep 2003 09:06:10 +0000 (09:06 +0000)]
Add filterable field for REF TIME frames so it is easy to search for them

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8511 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoA bunch of fixups for the NETLOGON sam database synchronisation
tpot [Mon, 22 Sep 2003 00:59:47 +0000 (00:59 +0000)]
A bunch of fixups for the NETLOGON sam database synchronisation
dissector:

  - some rids marked as user are actually groups

  - decorate some strings higher up in the tree

  - dissect the delta id as such and add value string text item

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8510 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoRemove a bunch of duplicate semicolons.
gerald [Sun, 21 Sep 2003 20:06:02 +0000 (20:06 +0000)]
Remove a bunch of duplicate semicolons.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8509 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoPut back the AM_PROG_LIBTOOL call, as some older versions of the auto*
guy [Sat, 20 Sep 2003 10:06:40 +0000 (10:06 +0000)]
Put back the AM_PROG_LIBTOOL call, as some older versions of the auto*
tools and/or libtool require it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8508 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoArrange to free the buffer allocated for the decrypted tvbuff.
guy [Sat, 20 Sep 2003 09:54:11 +0000 (09:54 +0000)]
Arrange to free the buffer allocated for the decrypted tvbuff.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8507 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Emanuele Caratti: full TACACS+ dissection.
guy [Sat, 20 Sep 2003 09:41:48 +0000 (09:41 +0000)]
From Emanuele Caratti: full TACACS+ dissection.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8506 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Jean-Baptiste Marchand: initial DRSUAPI (Active Directory directory
guy [Sat, 20 Sep 2003 08:56:56 +0000 (08:56 +0000)]
From Jean-Baptiste Marchand: initial DRSUAPI (Active Directory directory
replication) support.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8505 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoYou can't safely return from a routine a pointer to an automatic
guy [Sat, 20 Sep 2003 08:56:28 +0000 (08:56 +0000)]
You can't safely return from a routine a pointer to an automatic
variable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8504 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Giles Scott:
guy [Sat, 20 Sep 2003 04:59:43 +0000 (04:59 +0000)]
From Giles Scott:

in GTK+ 2.x, center dialogs on the parent;

make the file selection dialogs transient for the main window,
just as other dialogs are.

Update Gerald's e-mail address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8503 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Greg Morris: update the Info column even if we're not building a
guy [Sat, 20 Sep 2003 04:25:11 +0000 (04:25 +0000)]
From Greg Morris: update the Info column even if we're not building a
protocol tree.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8502 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Richie:
guy [Sat, 20 Sep 2003 03:48:23 +0000 (03:48 +0000)]
From Richie:

the units for output power are dBm, not dbi;

decode multiple start channel/number of channels/output power
combinations;

display the output power as a signed value.

Additional change from Martijn Schipper to fix the display of the output
power.

Pass the tagged data value pointer to "dissect_vendor_specific_ie()".

Don't special-case unknown tag values - use "val_to_str()" even for
unknown tag values, and handle the value in the "default:" case.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8501 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Akira Endoh: handle the NLPID for PPP.
guy [Sat, 20 Sep 2003 03:31:25 +0000 (03:31 +0000)]
From Akira Endoh: handle the NLPID for PPP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8500 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoGive the tag number a value_string table, and have common code, rather
guy [Sat, 20 Sep 2003 03:20:17 +0000 (03:20 +0000)]
Give the tag number a value_string table, and have common code, rather
than tag-specific code, put it, and the tag length, into the protocol
tree.  Make those fields FT_UINT8, as they're one byte long.

Don't pass to "dissect_vendor_specific_ie()" variables whose names and
values are the same as global variables.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8499 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoProvide a mechanism by which a tap can arrange to have its menu enabled
guy [Fri, 19 Sep 2003 07:24:39 +0000 (07:24 +0000)]
Provide a mechanism by which a tap can arrange to have its menu enabled
or disabled based on a currently-selected packet (or lack of same) or a
currently-selected protocol tree item (or lack of same).  Not currently
used, but necessary if we ever make the TCP graph stuff a tap.  API is
tentative and subject to change.

Also, enable and disable taps based on whether we have any packets to
process.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8498 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoPut the presentation context list and transfer syntax list of a dcerpc
tpot [Fri, 19 Sep 2003 05:30:01 +0000 (05:30 +0000)]
Put the presentation context list and transfer syntax list of a dcerpc
bind request into some subtrees to make things look a bit nicer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8497 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Lars Roland: initialize the flags.ref_time field of a frame_data
guy [Fri, 19 Sep 2003 04:52:16 +0000 (04:52 +0000)]
From Lars Roland: initialize the flags.ref_time field of a frame_data
structure.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8496 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoUse bitfields for the end-of-event, reserved, and volume fields.
guy [Fri, 19 Sep 2003 04:27:48 +0000 (04:27 +0000)]
Use bitfields for the end-of-event, reserved, and volume fields.

Don't fetch fields until you need them, so you don't throw an early
exception.

Give the fields names starting with the name of the protocol.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8495 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Kevin A. Noll: RFC 2833 RTP Events support.
guy [Fri, 19 Sep 2003 04:16:23 +0000 (04:16 +0000)]
From Kevin A. Noll: RFC 2833 RTP Events support.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8494 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Jesper Peterson: add support for AAL5 records in ERF files,
guy [Fri, 19 Sep 2003 04:08:11 +0000 (04:08 +0000)]
From Jesper Peterson: add support for AAL5 records in ERF files,
treating them as PDUs with an AAL5 trailer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8493 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoMake the string variables in the *_to_str() functions non-static.
gerald [Thu, 18 Sep 2003 21:42:45 +0000 (21:42 +0000)]
Make the string variables in the *_to_str() functions non-static.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8492 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Michal Melerowicz: Properly terminate the return string in
gerald [Thu, 18 Sep 2003 21:38:44 +0000 (21:38 +0000)]
From Michal Melerowicz: Properly terminate the return string in
msisdn_to_str().

Do the same for imsi_to_str().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8491 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoDon't store the setting of the window scale option unless the "Relative
guy [Thu, 18 Sep 2003 19:19:51 +0000 (19:19 +0000)]
Don't store the setting of the window scale option unless the "Relative
sequence numbers and window scaling" option is set, as that option says
it controls whether we attempt to display the real post-scaling window
size.

Also, don't store it unless the "Analyze TCP sequence numbers" option is
set, as "Relative sequence numbers and window scaling" requires it,
because, unless "Analyze TCP sequence numbers" is set, we don't set up
conversations for TCP connections and don't have a pool of data
structures for per-connection information into which to store the window
scale option value.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8490 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Olivier Biot: put a summary into the top-level SMPP item in the
guy [Wed, 17 Sep 2003 20:24:45 +0000 (20:24 +0000)]
From Olivier Biot: put a summary into the top-level SMPP item in the
protocol tree.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8489 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoHave "register_tap_menu_item()" put the item under Tools, not
guy [Wed, 17 Sep 2003 19:39:34 +0000 (19:39 +0000)]
Have "register_tap_menu_item()" put the item under Tools, not
Tools/Statistics; change the taps to put things under Statistics
themselves.  That allows taps to go elsewhere if appropriate.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8488 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFix recursive heap overflow problem.
jfoster [Wed, 17 Sep 2003 15:58:11 +0000 (15:58 +0000)]
Fix recursive heap overflow problem.
When a socks connection was used to create a second socks connection
the socks dissector would be called recursively until a heap overflow
occurred.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8487 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoHandle PPP with a pseudo-header.
guy [Tue, 16 Sep 2003 20:41:17 +0000 (20:41 +0000)]
Handle PPP with a pseudo-header.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8486 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoThere's no preference setting for the SMTP TCP port (and SMTP has a
guy [Tue, 16 Sep 2003 17:42:01 +0000 (17:42 +0000)]
There's no preference setting for the SMTP TCP port (and SMTP has a
well-known port), so we remove the extra code to handle changing it - if
it ever becomes useful to have the port number settable, we can put it
back.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8485 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoRe-register the dissector if a preference changes - otherwise, changing
guy [Tue, 16 Sep 2003 17:36:09 +0000 (17:36 +0000)]
Re-register the dissector if a preference changes - otherwise, changing
the TCP port number won't have any effect.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8484 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoMake sure we return FALSE in all the failure paths in "do_capture()".
guy [Mon, 15 Sep 2003 23:48:42 +0000 (23:48 +0000)]
Make sure we return FALSE in all the failure paths in "do_capture()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8483 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoWe no longer pop up tap windows until we have a capture file open, so we
guy [Mon, 15 Sep 2003 23:28:07 +0000 (23:28 +0000)]
We no longer pop up tap windows until we have a capture file open, so we
don't have to worry about the file name being null when
"cf_get_display_name()" is called.  (It should never be called before we
have a capture file open; if it is, that's a bug.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8482 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoClean up an error message.
guy [Mon, 15 Sep 2003 23:20:34 +0000 (23:20 +0000)]
Clean up an error message.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8481 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoDon't pop up tap windows specified with "-z" options until we have a
guy [Mon, 15 Sep 2003 23:15:32 +0000 (23:15 +0000)]
Don't pop up tap windows specified with "-z" options until we have a
capture file open.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8480 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoRename various capture file routines to have names starting with "cf_".
guy [Mon, 15 Sep 2003 22:48:42 +0000 (22:48 +0000)]
Rename various capture file routines to have names starting with "cf_".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8479 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoGet rid of a bunch of unnecessary #includes.
guy [Mon, 15 Sep 2003 22:32:21 +0000 (22:32 +0000)]
Get rid of a bunch of unnecessary #includes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8478 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoGet rid of a no-longer-relevant comment.
guy [Mon, 15 Sep 2003 22:17:25 +0000 (22:17 +0000)]
Get rid of a no-longer-relevant comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8477 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAdd a routine to return the display name for a "capture_file" structure,
guy [Mon, 15 Sep 2003 22:16:08 +0000 (22:16 +0000)]
Add a routine to return the display name for a "capture_file" structure,
rather than constructing that name when a capture file is opened and
putting a pointer to it in that structure.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8476 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoDon't allow -k and a capture file to both be specified on the command
guy [Mon, 15 Sep 2003 20:45:19 +0000 (20:45 +0000)]
Don't allow -k and a capture file to both be specified on the command
line - either we're doing a live capture or we're reading a saved
capture file, we can't do both at the same time.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8475 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoKeep a "display name" as part of a capture_file structure; for live
guy [Mon, 15 Sep 2003 20:37:37 +0000 (20:37 +0000)]
Keep a "display name" as part of a capture_file structure; for live
capture temporary files, it's "<capture", and for saved capture files,
it's the last component of the pathname of the file.  Use that in
various places when displaying the file name.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8474 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Yaniv Kaul: add AES-XCBC-MAC to the list of authentication methods,
guy [Mon, 15 Sep 2003 19:08:27 +0000 (19:08 +0000)]
From Yaniv Kaul: add AES-XCBC-MAC to the list of authentication methods,
per RFC 3566.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8473 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Graeme Hewson:
guy [Mon, 15 Sep 2003 19:05:01 +0000 (19:05 +0000)]
From Graeme Hewson:

Don't crash if "-z" is used on the command line when a live
capture is being done (e.g., with "-k -S" - in that case,
"cfile.filename" is null when the window is created), just don't
display the file name in the title.

Don't set the title of a non-existent window - create the window
first.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8472 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Josef Korelus: call the data dissector on the contents of the LLC
guy [Mon, 15 Sep 2003 18:49:06 +0000 (18:49 +0000)]
From Josef Korelus: call the data dissector on the contents of the LLC
PDU information element.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8471 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Ritchie: dissect country information tag.
guy [Mon, 15 Sep 2003 18:40:53 +0000 (18:40 +0000)]
From Ritchie: dissect country information tag.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8470 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoUse "int"s as array indices - it squelches a
guy [Mon, 15 Sep 2003 18:31:17 +0000 (18:31 +0000)]
Use "int"s as array indices - it squelches a
signed-vs-unsigned-comparison complaint in one case, and it's a
generally good habit.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8469 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFix a buffer overflow in msisdn_to_str(). Clean up string pointer handling
gerald [Sun, 14 Sep 2003 21:28:13 +0000 (21:28 +0000)]
Fix a buffer overflow in msisdn_to_str().  Clean up string pointer handling
in it, imsi_to_str(), and id_to_str() a bit.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8468 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFix warning: guint8 is always <= 255
jmayer [Sun, 14 Sep 2003 20:59:31 +0000 (20:59 +0000)]
Fix warning: guint8 is always <= 255

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8467 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAccording to draft-ietf-manet-aodv-13, the only differences between V4
guy [Sat, 13 Sep 2003 00:57:10 +0000 (00:57 +0000)]
According to draft-ietf-manet-aodv-13, the only differences between V4
and V6 AODV messages is the addresses in the message.

According to the now-expired draft-perkins-aodv6-01, some of the
messages differ in the order of the fields as well.

Dissect the draft-ietf-manet-aodv-13 messages correctly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8466 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAccording to draft-ietf-manet-aodv-13, "the only changes to the protocol
guy [Fri, 12 Sep 2003 22:52:22 +0000 (22:52 +0000)]
According to draft-ietf-manet-aodv-13, "the only changes to the protocol
are that the address fields are enlarged", so presumably that supercedes
the now-expired draft-perkins-aodv6-01 which gives different type
numbers for V6.  We support both - the draft-ietf-manet-aodv-13 messages
are dissected based on the address type of the source address, while the
draft-perkins-aodv6-01 messages are dissected as V6.

Handle the Route Reply Acknowledgment message.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8465 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Kari Tiirikainen:
guy [Fri, 12 Sep 2003 19:40:33 +0000 (19:40 +0000)]
From Kari Tiirikainen:

Updated the COPS dissector to print the names of the Prefix
PRIDs correctly.  The last fix to PRID OID printout caused this
minor problem for PPRIDs.

Rename a few variables to make the code more logical to read.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8464 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoUpdate to netlogon
sahlberg [Fri, 12 Sep 2003 11:13:17 +0000 (11:13 +0000)]
Update to netlogon

make it decode DsrGetDCSiteCoverage replies properly

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8463 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoupadtes to NETLOGON
sahlberg [Fri, 12 Sep 2003 10:32:21 +0000 (10:32 +0000)]
upadtes to NETLOGON

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8462 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoEnhancement to the TCP dissector:
sahlberg [Fri, 12 Sep 2003 05:52:38 +0000 (05:52 +0000)]
Enhancement to the TCP dissector:
Track window scaling and display the window field after it has been scaled to its real value

If we have seen a SYN packet with a WindowScalingOption
then if the option to use RelativeSequence numbers has been enabled,
then ethereal will change the presented window field to be the window after it has been scaled to the real value.

This obviously only works if we have seen the SYN packet and if the SYN packet contained a window scaling option

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8461 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAttempt to prettify frame.time_relative
sahlberg [Fri, 12 Sep 2003 04:52:55 +0000 (04:52 +0000)]
Attempt to prettify frame.time_relative
and some other fields

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8460 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAdded TimeReference frames.
sahlberg [Fri, 12 Sep 2003 02:48:23 +0000 (02:48 +0000)]
Added TimeReference frames.

One can now select a packet and mark it as a TimeReference packet using the menu.
A TimeReference packet will be indicated by having all timestamp related column entries replaced by the string *REF*
A TimeReference packet will always be displayed in the packet pane, and overrides any display filters.

When a frame is a TimeReference frame, all later frames will calculate the TimeRelativeToFirstPacket  relative to the timestamp of the TimeReference frame instead of the first frame of the capture.

You can have any number of TimeReference frames you like.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8459 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom hans Viens:
sahlberg [Thu, 11 Sep 2003 13:37:35 +0000 (13:37 +0000)]
From hans Viens:
T38 dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8458 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Hans Viens :
sahlberg [Thu, 11 Sep 2003 13:36:04 +0000 (13:36 +0000)]
From Hans Viens :
T38 dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8457 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Jean-Baptiste Marchand
sahlberg [Thu, 11 Sep 2003 13:24:19 +0000 (13:24 +0000)]
From Jean-Baptiste Marchand

update of the type of pointer used for DsrGetSiteName reply packets

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8456 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoDo not take the pointer to a stack object and pass it to the tap system.
sahlberg [Thu, 11 Sep 2003 10:31:01 +0000 (10:31 +0000)]
Do not take the pointer to a stack object and pass it to the tap system.
The tap listener will try to parse this pointer at a much later stage where the stack frame where this object lived will have dissapeared and possible got overwritten.

best that can happen is that service response times for dcerpc interfaces is screwed up
more probable is that we get a coredump

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8455 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Anders Broman: add support for BICC dissection.
guy [Thu, 11 Sep 2003 00:08:14 +0000 (00:08 +0000)]
From Anders Broman: add support for BICC dissection.

Change his e-mail address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8454 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoDon't export MAX_VAR_LEN - nobody uses it.
guy [Wed, 10 Sep 2003 23:55:52 +0000 (23:55 +0000)]
Don't export MAX_VAR_LEN - nobody uses it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8453 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoDocument the "Print only marked packets" option in the "Print" dialog,
guy [Wed, 10 Sep 2003 22:33:31 +0000 (22:33 +0000)]
Document the "Print only marked packets" option in the "Print" dialog,
and document that you can now search for packets with particular text in
the Info column or protocol tree.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8452 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoWhen saving packets, we have a "Save only marked packets" option; label
guy [Wed, 10 Sep 2003 22:23:58 +0000 (22:23 +0000)]
When saving packets, we have a "Save only marked packets" option; label
the option to print only marked packets similarly, rather than as
"Suppress unmarked packets" (for consistency, and because the latter
isn't unlike a double negative).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8451 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoMake tvb_find_tvb() return -1 if either tvb length is 0. Otherwise, an
gerald [Wed, 10 Sep 2003 21:19:47 +0000 (21:19 +0000)]
Make tvb_find_tvb() return -1 if either tvb length is 0.  Otherwise, an
assertion happens 'xxxx contains ""'.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8450 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoDon't use "alloca()", and don't use "match_strval()", just use
guy [Wed, 10 Sep 2003 20:07:10 +0000 (20:07 +0000)]
Don't use "alloca()", and don't use "match_strval()", just use
"val_to_str()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8449 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoUse the *correct* value_string for the IE Type field.
guy [Wed, 10 Sep 2003 19:27:14 +0000 (19:27 +0000)]
Use the *correct* value_string for the IE Type field.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8448 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Albert Chin: fix yet another C++-comment problem.
guy [Wed, 10 Sep 2003 19:23:29 +0000 (19:23 +0000)]
From Albert Chin: fix yet another C++-comment problem.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8447 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoNETLOGON/DsrDeregisterDNSHostRecords :
sahlberg [Wed, 10 Sep 2003 09:49:31 +0000 (09:49 +0000)]
NETLOGON/DsrDeregisterDNSHostRecords :
The dns_host field is a REF pointer to a unicode string.
NOT a Unique pointer.

Update iethereal so that this packet is dissected properly

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8446 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAlbert Chin:
jmayer [Wed, 10 Sep 2003 07:17:21 +0000 (07:17 +0000)]
Albert Chin:
- AM_PROC_LIBTOOL is just an alias for AC_PROG_LIBTOOL, which is
  called earlier.
- Use AM_CPPFLAGS instead of CFLAGS and CPPFLAGS to add inlude
  directories

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8445 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoIf there's no saved interface name, set the interface name in the
guy [Wed, 10 Sep 2003 07:02:25 +0000 (07:02 +0000)]
If there's no saved interface name, set the interface name in the
Capture Options dialog box to the first string in the combo box, not to
the first interface name in the list, so we get the description.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8444 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoIf we have no interfaces, don't set the popdown list for interface combo
guy [Wed, 10 Sep 2003 06:55:28 +0000 (06:55 +0000)]
If we have no interfaces, don't set the popdown list for interface combo
boxes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8443 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoVoid functions don't return values.
guy [Wed, 10 Sep 2003 06:48:55 +0000 (06:48 +0000)]
Void functions don't return values.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8442 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFix a compile error on Windows.
guy [Wed, 10 Sep 2003 06:47:04 +0000 (06:47 +0000)]
Fix a compile error on Windows.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8441 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoHave "get_interface_list()" return a list of "if_info_t" structures
guy [Wed, 10 Sep 2003 05:35:26 +0000 (05:35 +0000)]
Have "get_interface_list()" return a list of "if_info_t" structures
containing a pointer to an interface name and possibly a pointer to an
interface description (although that pointer might be null if no
description is available), rather than having the Windows version glue
together the name and description into a single string.

Supply for the Linux "any" device the same description that libpcap's
"pcap_findalldevs()" returns.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8440 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFinal(?) changes for the 0.9.15 release.
gerald [Tue, 9 Sep 2003 23:17:08 +0000 (23:17 +0000)]
Final(?) changes for the 0.9.15 release.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8438 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoUse the right value_string table for the filter mode in
guy [Tue, 9 Sep 2003 19:22:05 +0000 (19:22 +0000)]
Use the right value_string table for the filter mode in
CMD_CARD_SET_FILTER_MODE and CMD_CARD_GET_FILTER_MODE.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8437 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFix the URL for the DOCSIS specifications.
guy [Tue, 9 Sep 2003 19:14:29 +0000 (19:14 +0000)]
Fix the URL for the DOCSIS specifications.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8436 f5534014-38df-0310-8fa8-9805f1628bb7