obnox/wireshark/wip.git
21 years agoUpdated LSA. Function 2f is called SetInformationPolicy2
sahlberg [Fri, 9 Aug 2002 09:27:33 +0000 (09:27 +0000)]
Updated LSA. Function 2f is called SetInformationPolicy2

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5974 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Tom Uijldert: WTP TPI dissection, and reindentation.
guy [Fri, 9 Aug 2002 09:12:51 +0000 (09:12 +0000)]
From Tom Uijldert: WTP TPI dissection, and reindentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5973 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Mike Frisch: add the FATTR4_MOUNTED_ON_FILEID attribute.
guy [Thu, 8 Aug 2002 22:15:07 +0000 (22:15 +0000)]
From Mike Frisch: add the FATTR4_MOUNTED_ON_FILEID attribute.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5972 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoRemove some unused includes.
jmayer [Thu, 8 Aug 2002 21:42:05 +0000 (21:42 +0000)]
Remove some unused includes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5971 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoMake "dissect_fw1()" static.
guy [Thu, 8 Aug 2002 09:33:26 +0000 (09:33 +0000)]
Make "dissect_fw1()" static.

Get rid of the redundant "fw1_" in the "summary in tree" preference name
(the full name is "fw1.summary_in_tree", so you don't need another
"fw1_" in there).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5970 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Alfred Koebler: support for interpreting Ethernet captures as
guy [Thu, 8 Aug 2002 09:28:11 +0000 (09:28 +0000)]
From Alfred Koebler: support for interpreting Ethernet captures as
CheckPoint FireWall-1 monitor files (those files look like snoop files
for Ethernet).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5969 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Tom Uijldert: modify MMSE dissector to also accept content that is
guy [Wed, 7 Aug 2002 08:34:55 +0000 (08:34 +0000)]
From Tom Uijldert: modify MMSE dissector to also accept content that is
not multipart.

Replace my fix to create subtrees for POST data with Tom's.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5968 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoProperly set the LANE traffic type.
guy [Wed, 7 Aug 2002 06:59:49 +0000 (06:59 +0000)]
Properly set the LANE traffic type.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5967 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Mike Frisch: fixed LOOKUPP (NFSv4) decoding (previously undefined
guy [Wed, 7 Aug 2002 02:54:22 +0000 (02:54 +0000)]
From Mike Frisch: fixed LOOKUPP (NFSv4) decoding (previously undefined
operation), added two new NFS4ERR_xxx error codes, and minor fix to ACL
decoding.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5966 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFix a return code in samr_dissect_query_information_domain_reply()
tpot [Wed, 7 Aug 2002 01:04:51 +0000 (01:04 +0000)]
Fix a return code in samr_dissect_query_information_domain_reply()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5965 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdded dissectors for OpenEntry, EnumKey and Unknown1A.
tpot [Wed, 7 Aug 2002 01:03:10 +0000 (01:03 +0000)]
Added dissectors for OpenEntry, EnumKey and Unknown1A.

Renamed protocol to WINREG from just REG.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5964 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoIn dissect_doserror and dissect_ntstatus, don't add anything to the
tpot [Wed, 7 Aug 2002 00:54:32 +0000 (00:54 +0000)]
In dissect_doserror and dissect_ntstatus, don't add anything to the
COL_INFO field if the proto_tree parameter is NULL.  This prevents
duplicate error messages when we just want to peek at the value of the
error.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5963 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdded DOS error 259 - no more items.
tpot [Wed, 7 Aug 2002 00:48:53 +0000 (00:48 +0000)]
Added DOS error 259 - no more items.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5962 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoDisplay calling and called names in COL_INFO for session request.
tpot [Wed, 7 Aug 2002 00:43:13 +0000 (00:43 +0000)]
Display calling and called names in COL_INFO for session request.

Display error string in COL_INFO for negative session response.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5961 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoUpdate packet-dcerpc-samr.{c,h} to fix the names for the functions we now
sharpe [Tue, 6 Aug 2002 21:58:09 +0000 (21:58 +0000)]
Update packet-dcerpc-samr.{c,h} to fix the names for the functions we now
know are SamrConnect, SamrConnect2, SamrConnect3 and SamrConnect4.

Thanks to Jim McDonnough and Tod Sabin.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5960 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoTypo fix.
guy [Tue, 6 Aug 2002 19:02:24 +0000 (19:02 +0000)]
Typo fix.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5959 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoPut in a comment noting that forcibly setting "pinfo->fd->lnk_t" means
guy [Tue, 6 Aug 2002 08:13:42 +0000 (08:13 +0000)]
Put in a comment noting that forcibly setting "pinfo->fd->lnk_t" means
you can't turn the "Treat all frames as DOCSIS frames" option off.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5958 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Mike Frisch: fix NFSv4 ACL decoding.
guy [Tue, 6 Aug 2002 05:51:13 +0000 (05:51 +0000)]
From Mike Frisch: fix NFSv4 ACL decoding.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5957 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Mike Frisch: sync the SETCLIENTID args decoder with the latest
guy [Tue, 6 Aug 2002 05:43:30 +0000 (05:43 +0000)]
From Mike Frisch: sync the SETCLIENTID args decoder with the latest
nfs4_prot.x.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5956 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Anand V. Narwani: add an entry for the DOCSIS encapsulation to the
guy [Tue, 6 Aug 2002 05:40:47 +0000 (05:40 +0000)]
From Anand V. Narwani: add an entry for the DOCSIS encapsulation to the
Wiretap table of encapsuations.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5955 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFix the declaration of "empty_line()" to match the definition.
guy [Tue, 6 Aug 2002 01:00:07 +0000 (01:00 +0000)]
Fix the declaration of "empty_line()" to match the definition.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5954 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoMake the argument to "empty_line()" a "const guchar *", so we don't have
guy [Tue, 6 Aug 2002 00:59:15 +0000 (00:59 +0000)]
Make the argument to "empty_line()" a "const guchar *", so we don't have
to worry about characters with the 8th bit set being sign-extended.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5953 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrame numbers are "guint32"s, not signed "int"s.
guy [Tue, 6 Aug 2002 00:58:23 +0000 (00:58 +0000)]
Frame numbers are "guint32"s, not signed "int"s.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5952 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Jan Kratochvil: fix MMSE handling of strings with specified
guy [Mon, 5 Aug 2002 08:37:47 +0000 (08:37 +0000)]
From Jan Kratochvil: fix MMSE handling of strings with specified
character set.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5951 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agonet/inet.h should not be needed by a dissector.
jmayer [Sun, 4 Aug 2002 09:08:03 +0000 (09:08 +0000)]
net/inet.h should not be needed by a dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5950 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Hidetaka Ogawa: fix PPP FCS computation to include address and
guy [Sun, 4 Aug 2002 08:44:31 +0000 (08:44 +0000)]
From Hidetaka Ogawa: fix PPP FCS computation to include address and
control field if present.

Add Sergei Shokhor to the contributor list in the Ethereal man page.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5949 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoSome more function updates
sahlberg [Sun, 4 Aug 2002 01:37:07 +0000 (01:37 +0000)]
Some more function updates

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5948 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoUndo my last change: These files are used by systems only that need sys/types.h
jmayer [Sun, 4 Aug 2002 00:45:59 +0000 (00:45 +0000)]
Undo my last change: These files are used by systems only that need sys/types.h
anyway (see Guys remark on inet_pton.c).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5947 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Sergei Shokhor, bug in EPM dissector
sahlberg [Sun, 4 Aug 2002 00:45:49 +0000 (00:45 +0000)]
From Sergei Shokhor, bug in EPM dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5946 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdd sequence number wrap to tcp window checking.
jmayer [Sat, 3 Aug 2002 23:20:06 +0000 (23:20 +0000)]
Add sequence number wrap to tcp window checking.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5945 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoThe url to the IEEE data changed for non-interactive use.
jmayer [Sat, 3 Aug 2002 23:09:24 +0000 (23:09 +0000)]
The url to the IEEE data changed for non-interactive use.
Bring manuf up to date.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5944 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoCreate the TCP protocol tree, and put the source and destination ports
guy [Sat, 3 Aug 2002 22:28:16 +0000 (22:28 +0000)]
Create the TCP protocol tree, and put the source and destination ports
into it, as soon as we've extracted the source and destination ports
from the packet, so that if we throw an exception fetching something
else from the packet, we still have the protocol tree and ports.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5943 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoWe don't use anything from <sys/socket.h> (we need to know the AF_INET6
guy [Sat, 3 Aug 2002 20:06:46 +0000 (20:06 +0000)]
We don't use anything from <sys/socket.h> (we need to know the AF_INET6
values of the various BSDs that support DLT_NULL, but those aren't
necessarily the AF_ values on the machine on which you're building
Ethereal), so we don't need to include it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5942 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoWe don't use anything from <arpa/inet.h>, so we don't need to include
guy [Sat, 3 Aug 2002 20:01:13 +0000 (20:01 +0000)]
We don't use anything from <arpa/inet.h>, so we don't need to include
it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5941 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoWe don't use anything from <sys/socket.h>, so we don't need to include
guy [Sat, 3 Aug 2002 19:50:44 +0000 (19:50 +0000)]
We don't use anything from <sys/socket.h>, so we don't need to include
it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5940 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoWe don't use anything from <sys/socket.h> (we need to know the AF_
guy [Sat, 3 Aug 2002 19:49:30 +0000 (19:49 +0000)]
We don't use anything from <sys/socket.h> (we need to know the AF_
values of the various BSDs that support DLT_NULL, but those aren't
necessarily the AF_ values on the machine on which you're building
Ethereal), so we don't need to include it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5939 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoWe don't use anything from <arpa/inet.h>, so we don't need to include
guy [Sat, 3 Aug 2002 19:47:50 +0000 (19:47 +0000)]
We don't use anything from <arpa/inet.h>, so we don't need to include
it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5938 f5534014-38df-0310-8fa8-9805f1628bb7

21 years ago<netinet/in.h> is needed for <arpa/inet.h>, at least on some platforms,
guy [Sat, 3 Aug 2002 19:37:48 +0000 (19:37 +0000)]
<netinet/in.h> is needed for <arpa/inet.h>, at least on some platforms,
and <sys/types.h> is needed for <netinet/in.h>.

On systems with "inet_pton()", the API is defined using "u_char", and
we're including <sys/types.h> on platforms that have it (which should be
most if not all UNIX platforms) and including <winsock2.h> on platforms
that have it (Windows), so we might as well use "u_char" and "u_int", as
the BSD version of "inet_pton.c" does.  (Besides, we weren't including
any GLib include files, so "guchar" and "guint" weren't getting defined
in any case.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5937 f5534014-38df-0310-8fa8-9805f1628bb7

21 years ago<netinet/in.h> is needed for <arpa/inet.h>, at least on some platforms,
guy [Sat, 3 Aug 2002 19:35:16 +0000 (19:35 +0000)]
<netinet/in.h> is needed for <arpa/inet.h>, at least on some platforms,
and <sys/types.h> is needed for <netinet/in.h>.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5936 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoUpdated LogonControl2 and ServerAuthenticate2 functions
sahlberg [Sat, 3 Aug 2002 10:48:46 +0000 (10:48 +0000)]
Updated LogonControl2 and ServerAuthenticate2 functions

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5935 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoI still have to see a case when a MAC address starting with 0:0:0
jmayer [Sat, 3 Aug 2002 00:50:22 +0000 (00:50 +0000)]
I still have to see a case when a MAC address starting with 0:0:0
actually means Xerox, but 0:0:0:0:0:0 can be found quite often.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5934 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoReplace the types from sys/types.h and netinet/in.h by their glib.h
jmayer [Fri, 2 Aug 2002 23:46:26 +0000 (23:46 +0000)]
Replace the types from sys/types.h and netinet/in.h by their glib.h
equivalents in the READMEs and examples in the doc/ directory.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5933 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoReplace the types from sys/types.h and netinet/in.h by their glib.h
jmayer [Fri, 2 Aug 2002 23:36:07 +0000 (23:36 +0000)]
Replace the types from sys/types.h and netinet/in.h by their glib.h
equivalents for the toplevel directory. The removal of winsock2.h will
hopefully not cause any problems under MSVC++, as those files using
struct timeval still include wtap.h, which still includes winsock2.h.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5932 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoTwo new options added to TCP.
sahlberg [Fri, 2 Aug 2002 22:41:56 +0000 (22:41 +0000)]
Two new options added to TCP.
1, Analyze TCP sequence numbers.
   This option will keep track of sequence numbers for all tcp sessions
   and flag the following:
   a, If a new segment is seen which is beyong the right edge this is
      an indication that the previous segment was lost and this will be
      flagged as previous segment lost.
   b, If a segment is seen which lies left of the right edge this is flagged
      as retransmission.
   c, if a keep-alive is seen (empty segment, seq==expected seq-1)
      this is flagged as a retransmission.
   d, if an ACK is seen which is beyond the right edge this is an indication
      that a segment has been lost and it will be flagged as segment lost.

   All ACKs which advance the left edge get the RTT displayed between the ACKed
   segment and the ACK itself. The ACK also gets an indication of WHICH segment
   it is an ACK for.

2, Relative sequence numbers. This option needs the first option to be selected
as well. This option will as best as it can try to get ethereal to use
relative sequence numbers instead of absolute ones.

The patch does not handle sequence number wrapping and unexpected results
can probably happen for such.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5931 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoReplace the types from sys/types.h and netinet/in.h by their glib.h
jmayer [Fri, 2 Aug 2002 22:34:54 +0000 (22:34 +0000)]
Replace the types from sys/types.h and netinet/in.h by their glib.h
equivalents for the gtk/ directory.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5930 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoReplace the types from sys/types.h and netinet/in.h by their glib.h
jmayer [Fri, 2 Aug 2002 22:04:22 +0000 (22:04 +0000)]
Replace the types from sys/types.h and netinet/in.h by their glib.h
equivalents for the plugins/ directory.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5929 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoReplace the types from sys/types.h and netinet/in.h by their glib.h
jmayer [Fri, 2 Aug 2002 21:29:45 +0000 (21:29 +0000)]
Replace the types from sys/types.h and netinet/in.h by their glib.h
equivalents for the epan/ directory but leave winsock2.h in inet_pton.c
and inet_ntop.c for now (can't estimate the consequences).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5928 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFix a few more memleaks found by valgrind (all deriving
jmayer [Thu, 1 Aug 2002 03:15:29 +0000 (03:15 +0000)]
Fix a few more memleaks found by valgrind (all deriving
from the get_persconffile_path mess).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5927 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoUse <zlib.h> instead of "zlib.h"
jmayer [Wed, 31 Jul 2002 22:52:38 +0000 (22:52 +0000)]
Use <zlib.h> instead of "zlib.h"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5926 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdd conditional include of winsock2.h again, so compilation with MSVC++
jmayer [Wed, 31 Jul 2002 22:41:34 +0000 (22:41 +0000)]
Add conditional include of winsock2.h again, so compilation with MSVC++
will work again without complaints.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5925 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Jim McDonough: support for LsaQueryInformationPolicy2 in the LSA
guy [Wed, 31 Jul 2002 21:22:39 +0000 (21:22 +0000)]
From Jim McDonough: support for LsaQueryInformationPolicy2 in the LSA
dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5924 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Mike Frisch: fix a problem with decoding the AUTHORIZE call.
guy [Wed, 31 Jul 2002 19:58:28 +0000 (19:58 +0000)]
From Mike Frisch: fix a problem with decoding the AUTHORIZE call.

Update his e-mail address in the AUTHORS file while we're at it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5923 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Motonori Shindo: support for reading CoSine L2 debug output.
guy [Wed, 31 Jul 2002 19:27:57 +0000 (19:27 +0000)]
From Motonori Shindo: support for reading CoSine L2 debug output.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5922 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoCheck whether the first byte of a putative TPKT header is 3 (the TPKT
guy [Wed, 31 Jul 2002 18:45:50 +0000 (18:45 +0000)]
Check whether the first byte of a putative TPKT header is 3 (the TPKT
version number from RFC 1006) and, if not, assume it's *not* a TPKT
header, and don't try getting the packet length and doing TPKT
dissection and reassembly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5921 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFix small typo
sahlberg [Wed, 31 Jul 2002 11:16:19 +0000 (11:16 +0000)]
Fix small typo

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5920 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoDon't loop forever in "find_rsvp_session_tempfilt()" or
guy [Wed, 31 Jul 2002 10:10:44 +0000 (10:10 +0000)]
Don't loop forever in "find_rsvp_session_tempfilt()" or
"dissect_rsvp_msg_tree()" if there's a zero-length object.

In "find_rsvp_session_tempfilt()", check to make sure the data exists
before fetching it, so that it doesn't throw an exception - the
information it returns is only used to put items into the protocol tree,
so there's no reason to quit dissecting the packet just because it can't
find that information because, for example, not enough of the packet
data was captured.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5919 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Chris Waters: check 802.11 FCS if present.
guy [Wed, 31 Jul 2002 09:00:02 +0000 (09:00 +0000)]
From Chris Waters: check 802.11 FCS if present.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5918 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdding a new macro CMP_ADDRESS similar to ADDRESS_EQUAL but this one will return
sahlberg [Wed, 31 Jul 2002 06:15:26 +0000 (06:15 +0000)]
Adding a new macro CMP_ADDRESS similar to ADDRESS_EQUAL but this one will return
-1,0,1 as the xxxcmp() functions will instead of just true/false.
Useful if you not only want to check for equality but also if you want to have a way to order the elements.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5917 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Graeme Hewson:
guy [Tue, 30 Jul 2002 10:13:16 +0000 (10:13 +0000)]
From Graeme Hewson:

Ethereal sometimes creates a progress dialog bar and then, if
the processing is fast, quickly destroys it.  The resulting
"flash" can be disconcerting.  This set of patches ensures a
progress bar is either not created or is displayed for a minimum
time.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5916 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoCall "proto_item_add_subtree()" to create a subtree for POST data, don't
guy [Tue, 30 Jul 2002 07:36:22 +0000 (07:36 +0000)]
Call "proto_item_add_subtree()" to create a subtree for POST data, don't
just use the return value of a "proto_tree_add" routine as if it could
be used as a protocol tree.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5915 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Michael Tuexen: AF_INET6 support for DLT_NULL captures from
guy [Tue, 30 Jul 2002 07:25:29 +0000 (07:25 +0000)]
From Michael Tuexen: AF_INET6 support for DLT_NULL captures from
Darwin/MacOS X.  (As if FreeBSD and {Net,Open}BSD having different
AF_INET6 values wasn't enough, we have The Other BSD having its own
value....)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5914 f5534014-38df-0310-8fa8-9805f1628bb7

21 years ago#ifdef out some variables not used on Windows.
guy [Tue, 30 Jul 2002 07:04:08 +0000 (07:04 +0000)]
#ifdef out some variables not used on Windows.

If printing a single packet to a file, don't use the "print to a
printer" code for Windows.

Only free "print_args.dest" *after* the last usage.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5913 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoCode from Jan Berkel <jan.berkel@gmx.de> to
girlich [Mon, 29 Jul 2002 09:28:28 +0000 (09:28 +0000)]
Code from Jan Berkel <jan.berkel@gmx.de> to
* fully decode client->server packets (mouse movement, button press etc.)
* start of decoding server->client packets (names of first command as text)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5912 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Didier Gautheron: add FPGetUserInfo.
guy [Mon, 29 Jul 2002 06:35:12 +0000 (06:35 +0000)]
From Didier Gautheron: add FPGetUserInfo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5911 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Joerg Mayer:
guy [Mon, 29 Jul 2002 06:30:01 +0000 (06:30 +0000)]
From Joerg Mayer:

gtk/colors.c: Fix a memleak found by valgrind
   (Note that there are similar bugs in other functions that
   use the same construct with path!)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5910 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Joerg Mayer:
guy [Mon, 29 Jul 2002 06:09:59 +0000 (06:09 +0000)]
From Joerg Mayer:

All files:
  - Replace types from sys/types.h by those from glib.h
  - Replace ntoh family of macros from netinet/in.h and winsock2.h
    by g_ntoh family from glib.h
  - Remove now unneeded includes of sys/types.h, netinet/in.h and
    winsock2.h
wtap.h
  Move includes to the top

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5909 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoCommitting Kerberos NetBIOS address type stuff from Jim McDonough.
sharpe [Mon, 29 Jul 2002 02:03:54 +0000 (02:03 +0000)]
Committing Kerberos NetBIOS address type stuff from Jim McDonough.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5908 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoChanged the SMB dissector to put ALL command PDUs in one SMB in the summary
sahlberg [Sat, 27 Jul 2002 05:03:53 +0000 (05:03 +0000)]
Changed the SMB dissector to put ALL command PDUs in one SMB in the summary
line, separated by ;

It only prints "Request"/"Response" for the first command to save space

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5907 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoIf conversations have already been created in lower layers, say TCP before
sahlberg [Sat, 27 Jul 2002 03:18:29 +0000 (03:18 +0000)]
If conversations have already been created in lower layers, say TCP before
SMB sees the PDU, then SMB would forget to create the proper state variables and crash.

SMB is changed to split the operation into
1, only create a conversation if it needs to. (as before)
2, detect if it needs to create the si.ct state variables independant of
whether smb also created a conversation or not.

Without this patch and with changes to say TCP to create conversations ethereal would crash at the first packet the SMB dissector would see.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5906 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Stefan Wenk: remove an unnecessary +1 from some offset
guy [Thu, 25 Jul 2002 21:43:53 +0000 (21:43 +0000)]
From Stefan Wenk: remove an unnecessary +1 from some offset
computations.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5905 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFor connection-oriented DCE RPC, show the stub data if we can't actually
guy [Thu, 25 Jul 2002 21:30:58 +0000 (21:30 +0000)]
For connection-oriented DCE RPC, show the stub data if we can't actually
do anything else with a request or reply (e.g., because we haven't seen
the bind request).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5904 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoRemove trailing space characters between a netbios name and the name type.
tpot [Mon, 22 Jul 2002 20:52:21 +0000 (20:52 +0000)]
Remove trailing space characters between a netbios name and the name type.
This makes the display look much nicer!

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5903 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoUpdate from Anand V. Narwani:
guy [Mon, 22 Jul 2002 20:18:23 +0000 (20:18 +0000)]
Update from Anand V. Narwani:

fix a minor problem in which the Info colum was incorrectly
defaulted to "Fragmentation Frame";

add 4 missing fields for the Extended header in Fragmentation
frames.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5902 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFix up some comments.
guy [Sun, 21 Jul 2002 20:31:21 +0000 (20:31 +0000)]
Fix up some comments.

Fix up a call to use the right byte-ordering routine (both routines have
the same effect, but we want to use the right one to make it clearer
what we're doing).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5901 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoMention the "-h" flag.
guy [Sun, 21 Jul 2002 20:28:35 +0000 (20:28 +0000)]
Mention the "-h" flag.

Fix up the list of arguments to "-S" in the synopsis.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5900 f5534014-38df-0310-8fa8-9805f1628bb7

21 years ago"yyin" is from lex/flex, so it should be "extern", not "static" - we
guy [Sun, 21 Jul 2002 20:27:30 +0000 (20:27 +0000)]
"yyin" is from lex/flex, so it should be "extern", not "static" - we
have to modify lex/flex's input stream, not some private "FILE *".

Fix up the usage message to:

mention the "-h" flag;

not mention the non-existent "-w" flag;

fit within 80 columns.

Add "-h" to the list of options in the "getopt()" call, as there's code
to support it, and remove "-r" and "-w", as there wasn't any code to
support them.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5899 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFix the problems WRT overwriting a capture file. From Joerg Mayer.
sharpe [Sun, 21 Jul 2002 16:54:22 +0000 (16:54 +0000)]
Fix the problems WRT overwriting a capture file. From Joerg Mayer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5898 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoOffsets in packets should be "int", not "guint8", unless there is an
guy [Sun, 21 Jul 2002 00:22:17 +0000 (00:22 +0000)]
Offsets in packets should be "int", not "guint8", unless there is an
*inviolable guarantee* that the offset will *never* be bigger than 255.
(The same applies for "guint16" and 65535.) Otherwise, you run the risk
of an infinite loop (packets are not guaranteed to be valid, nor are the
contents of capture files - and there's no guarantee that you're reading
a DOCSIS file if you've turned on the "force interpretation as DOCSIS"
flag.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5897 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Anand V. Narwani: fix to the Info column for Request frames.
guy [Sat, 20 Jul 2002 23:19:20 +0000 (23:19 +0000)]
From Anand V. Narwani: fix to the Info column for Request frames.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5896 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Prabhakar Krishnan: add item to SMB protocol tree for time between
guy [Sat, 20 Jul 2002 23:14:39 +0000 (23:14 +0000)]
From Prabhakar Krishnan: add item to SMB protocol tree for time between
request and response.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5895 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoInclude sys/types.h to provide the type size_t, which is needed
girlich [Fri, 19 Jul 2002 12:59:21 +0000 (12:59 +0000)]
Include sys/types.h to provide the type size_t, which is needed
further down in this file but must not be defined yet in the C source,
which includes this header file.
Example: without this change, packet-dcerpc-samr.c 1.51 could not be
compiled under SINIX-M.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5894 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Richard Urwin: fixes for README.plugins.
guy [Fri, 19 Jul 2002 09:33:17 +0000 (09:33 +0000)]
From Richard Urwin: fixes for README.plugins.

Combine the two entries for Anand Narwani in the AUTHORS file and the
Ethereal man page list of contributors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5893 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoChange a "proto_tree_add_uint()" call to use "proto_tree_add_item()".
guy [Wed, 17 Jul 2002 10:37:31 +0000 (10:37 +0000)]
Change a "proto_tree_add_uint()" call to use "proto_tree_add_item()".

When dissecting a BYE packet, bump the chunk count when dissecting the
SSRC/CSRC identifiers, so the loop terminates properly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5892 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdd an extra argument to "tvb_find_line_end()", which specifies what it
guy [Wed, 17 Jul 2002 06:55:29 +0000 (06:55 +0000)]
Add an extra argument to "tvb_find_line_end()", which specifies what it
should do if it doesn't find an EOL; if FALSE, it behaves as before,
returning values that treat the line as ending at the end of the tvbuff,
and if TRUE, it returns -1, so its caller can do segment reassembly
until it gets the EOL.

Add an option to the SMTP dissector to do segment reassembly, and do
segment reassembly of the first line.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5891 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Kan Sasaki:
guy [Wed, 17 Jul 2002 01:02:45 +0000 (01:02 +0000)]
From Kan Sasaki:

1. Add some VSAs.

2. Modify the routines match_numval() and
   rd_match_strval_attrib() to use a null string pointer, rather
   than a 0 value, to signify the end of the attribute table,
   because some vendors are using an attribute with a value of 0.

3. Bug fix.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5890 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Joerg Mayer:
guy [Wed, 17 Jul 2002 00:43:03 +0000 (00:43 +0000)]
From Joerg Mayer:

dftest.c:
     Remove #if-0-ed includes

packet-ieee80211.c, packet-wtls.c, packet-afp.c, packet-wsp.c,
        packet-wtp.c, ethereal_gen.py:
     Remove redundant include varargs (already in snprintf.h,
     and required only for snprintf.h)

Remove unused include of snprintf.h from files not using
"snprintf()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5889 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoGet rid of some "unused variable" and "unused static function" warnings,
guy [Wed, 17 Jul 2002 00:22:30 +0000 (00:22 +0000)]
Get rid of some "unused variable" and "unused static function" warnings,
and some compile errors in Tethereal, when compiling without libpcap.

If libpcap is missing (whether that's detected at compile time or, as on
Windows, at run time), don't call any of the "capture_prefs" routines -
the routine to create the capture preferences page wasn't called, so the
other routines can try to refer to non-existent widgets and other items
and crash.

Get rid of the stub routines in "capture_prefs()" used when compiling
without libpcap, as they're no longer called.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5888 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Joerg Mayer: add #includes of "snprintf.h" in modules that used
guy [Tue, 16 Jul 2002 22:50:48 +0000 (22:50 +0000)]
From Joerg Mayer: add #includes of "snprintf.h" in modules that used
"snprintf()" but weren't including "snprintf.h".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5887 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoGet rid of carriage returns.
guy [Tue, 16 Jul 2002 10:11:41 +0000 (10:11 +0000)]
Get rid of carriage returns.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5886 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoDon't allocate structures to remember how to re-access a packet's data,
guy [Tue, 16 Jul 2002 09:41:32 +0000 (09:41 +0000)]
Don't allocate structures to remember how to re-access a packet's data,
or the array to hold pointers to those structures, if we're only reading
the file sequentially.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5885 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Graeme Hewson:
guy [Tue, 16 Jul 2002 07:15:09 +0000 (07:15 +0000)]
From Graeme Hewson:

Allow "-" as the output file name in Wiretap, referring to the
standard error.

Optimize the capture loop.

Fix some of the error-message printing code in Ethereal and Tethereal.

Have Wiretap check whether it can seek on a file descriptor, and pass
the results of that test to the file-type-specific "open for output"
routine.  Have the "open for output" routines for files where we need to
seek when writing the file return an error if seeks don't work.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5884 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Graeme Hewson:
guy [Tue, 16 Jul 2002 05:43:39 +0000 (05:43 +0000)]
From Graeme Hewson:

In sync mode, if the capture file written by the child can't be
opened by the parent, ethereal will write two identical popup
error messages.

This patch fixes the problem.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5883 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoUpdate the "NT sucks for PPP capture" note to include NT 5.1 (XP and
guy [Mon, 15 Jul 2002 23:25:59 +0000 (23:25 +0000)]
Update the "NT sucks for PPP capture" note to include NT 5.1 (XP and
.NET Server).

Fix indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5882 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdded support for dissecting RSVP Bundle Messages
ashokn [Mon, 15 Jul 2002 21:19:56 +0000 (21:19 +0000)]
Added support for dissecting RSVP Bundle Messages

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5881 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Joerg Mayer:
guy [Mon, 15 Jul 2002 20:57:13 +0000 (20:57 +0000)]
From Joerg Mayer:

Replace our own definitions of TRUE/FALSE by their glib.h
equivalents.  Put sys/types.h into ifdefs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5880 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Joerg Mayer:
guy [Mon, 15 Jul 2002 20:55:51 +0000 (20:55 +0000)]
From Joerg Mayer:

Use the GLib macros to convert from network to host byte order.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5879 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Joerg Mayer:
guy [Mon, 15 Jul 2002 20:54:45 +0000 (20:54 +0000)]
From Joerg Mayer:

Change struct addr to guint32 which is the way it is used
anyway.

Use the GLib macros to convert from network to host byte order.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5878 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFix a sample call to add an item to the subtree for a protocol to add it
guy [Mon, 15 Jul 2002 20:31:06 +0000 (20:31 +0000)]
Fix a sample call to add an item to the subtree for a protocol to add it
there rather than to the top-level tree, and use
"proto_tree_add_item()".

Add a description of PROTOSHORTNAME, and give an example of the way
PROTONAME, PROTOSHORTNAME, and PROTOABBREV would be set for a protocol.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5877 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoThe mysterious two bytes were just the FCS. Use the length field from
guy [Mon, 15 Jul 2002 09:56:04 +0000 (09:56 +0000)]
The mysterious two bytes were just the FCS.  Use the length field from
the IP header as the reported length again, but make the actual length
be the minimum of the length of the tvbuff and the reported length, just
to keep from having a weird tvbuff that has more data than the packet
has.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5876 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoClean up the setting of "id_offset" and "sd_offset"; this fixes a bug in
guy [Mon, 15 Jul 2002 09:50:02 +0000 (09:50 +0000)]
Clean up the setting of "id_offset" and "sd_offset"; this fixes a bug in
handling the first few packets in a file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5875 f5534014-38df-0310-8fa8-9805f1628bb7