lego [Thu, 26 Jan 2006 20:20:55 +0000 (20:20 +0000)]
* lua_tree.c
* protect proto_item_add_* calls with a TRY CATCH to avoid the Lua state getting corrupted
* new ProtoItem:add_expert_info() call
* lua_proto.c
* protect call_dissector() and dissector_try_*() calls with TRY CATCH to avoid the Lua state getting corrupted
* ValueString makes no sense, get rid of it we'll use Lua's associative arrays instead
* lua_tvb.c
* while creating a tvb from a ByteArray copy the ByteArray's data and set the tvb's free_cb
* check bounds before calling tvb_*() to avoid a longjmp breaking Lua
* do not leak the string in Tvb_tostring()
* new Tvb:get_ipv4() call
* new Tvb:get_eth() call
* packet-lua.[ch]
* export lua_tvb and lua_malformed to other modules being the current tvb and the protocol_id of malformed
* convert some Lua to C
* do not register ValueString (eliminated)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17106
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 26 Jan 2006 06:54:52 +0000 (06:54 +0000)]
Add the abillity to translate MCC.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17105
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Wed, 25 Jan 2006 22:49:58 +0000 (22:49 +0000)]
two bugs less
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17104
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Wed, 25 Jan 2006 22:39:07 +0000 (22:39 +0000)]
One step at a time
several fixes and additions
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17103
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 25 Jan 2006 21:34:04 +0000 (21:34 +0000)]
from Gisle Vanem:
This file uses SEH which AFAIK is only available for MS Visual-C.
I build using MingW/gcc, so the attached patch is needed.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17102
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 25 Jan 2006 21:32:55 +0000 (21:32 +0000)]
Win32: add SEH to the new features. It might be noteworthy to the users that we probably won't crash for hardware exceptions caused by buggy dissectors
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17101
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Wed, 25 Jan 2006 20:49:42 +0000 (20:49 +0000)]
Bind IuUP to RTP
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17100
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Wed, 25 Jan 2006 20:48:37 +0000 (20:48 +0000)]
Use the right tree
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17099
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 25 Jan 2006 17:56:27 +0000 (17:56 +0000)]
- Add new IE:s
- White space and comment changes.
- IE type fixes.
- Print timezone data.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17098
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Wed, 25 Jan 2006 02:08:10 +0000 (02:08 +0000)]
Avoid crashing when given an object of the wrong usertype
format_time()
format_date()
report_failure()
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17097
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Tue, 24 Jan 2006 23:22:52 +0000 (23:22 +0000)]
an Address class, changed the names of some classes, modified pinfo to be a table
pinfo.src = Address.ip("www.xxx.com")
pinfo.col.info = "A special packet"
if (pinfo.src_port == 2) then pinfo.col.protocol = "STRANGE" end
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17096
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Tue, 24 Jan 2006 23:18:09 +0000 (23:18 +0000)]
it wasn't a goo idea,
sorry
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17095
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 24 Jan 2006 20:20:33 +0000 (20:20 +0000)]
Replace round() with floor(), I don't know if it's the right thing to do but at least it compiles on Windows again.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17094
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Tue, 24 Jan 2006 19:03:09 +0000 (19:03 +0000)]
minor code cleanup
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17093
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Tue, 24 Jan 2006 18:59:49 +0000 (18:59 +0000)]
add missing capture_radiotap
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17092
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Tue, 24 Jan 2006 11:54:27 +0000 (11:54 +0000)]
Derived some more assumptions from NLB traffic
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17091
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Tue, 24 Jan 2006 02:11:38 +0000 (02:11 +0000)]
fix a typo
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17090
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Tue, 24 Jan 2006 00:26:57 +0000 (00:26 +0000)]
Add register_postdissector() to the API.
Dissectors registered with register_postdissector() will be called after all other dissectors have been called.
Use it to register mate.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17089
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Tue, 24 Jan 2006 00:04:53 +0000 (00:04 +0000)]
I forgot the Licence!
set svn:keywords Id on source
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17088
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Mon, 23 Jan 2006 23:55:13 +0000 (23:55 +0000)]
Use .la instead of .so as dependency in Makefiles
Fix svn:ignore
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17087
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Mon, 23 Jan 2006 23:31:05 +0000 (23:31 +0000)]
Add lua-5.0.2
Split packet-lua.c
Changes aren't tested.
It should compile ok.
Makefile.nmake still missing.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17086
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 23 Jan 2006 23:21:02 +0000 (23:21 +0000)]
Add some more sanity checking of the Radiotap header.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17085
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 23 Jan 2006 22:13:08 +0000 (22:13 +0000)]
Bugfix: network address not dissected correctly
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17084
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 23 Jan 2006 16:56:34 +0000 (16:56 +0000)]
Call capture_radiotap() when capturing on a device supplying Radiotap
headers.
Fix capture_radiotap() to check for padding between the 802.11 header
and the 802.11 payload and to call different capture routines depending
on whether it's present or not, and create capture_ieee80211_datapad()
to handle the case where it's present.
Fix capture_radiotap() to convert the Radiotap header length from
little-endian, and to do some sanity checking of that length.
Fix capture_ieee80211_common() to use the offset supplied to it to fetch
the frame control field, as that offset isn't necessarily 0.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17083
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Mon, 23 Jan 2006 11:56:49 +0000 (11:56 +0000)]
From Irene: Add support for showing TSN and time in the graphical analysis.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17082
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 23 Jan 2006 10:17:07 +0000 (10:17 +0000)]
Rename all the COOK_ macros to indicate the field from which they're
extracting data (except for the association ID field, where adding
ASSOC_ID would be redundant).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17081
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 23 Jan 2006 09:20:06 +0000 (09:20 +0000)]
From Sam Leffler:
1. Fix a bug in caclulating the 802.11 header length for QoS
data frames (way bad regression from previous code).
2. Add support for packets w/ data padding between the 802.11
header and the payload (as indicated in the radiotap flags).
3. Add support for handling FCS indication in the radiotap
flags.
4. Fix display of TSF (previous code was not byte swapping).
5. Update ieee80211_mhz2ieee in radiotap.c to handle more
channels.
6. Nuke some #if 0 code I left in radiotap.c a while back.
Also, clean up the various macros that extract stuff from 802.11 header
fields or define bitfields within those header fields:
group them by the fields from which they extract and the values
they extract, or the header fields to which they belong;
get rid of some of the COOK_ in the names - COOK_ really doesn't
indicate anything useful, such as the field from which they're
extracting (we should get rid of the rest);
put in some more comments explaining what they do;
get rid of some unused macros;
get rid of some values that aren't flag values - they're values
to test whether something's a data frame with a particular byte
set in the subtype field, but they're only used on data frames,
so we only need to test the bit in question, so we define macros
to test the bit and name them to indicate that they're for use
on data frames.
Consistently use "CF-Ack" and "CF-Poll" in the strings for various data
frame type/subtype values, and get rid of "802.11" (it should be obvious
to one and all that this is 802.11...).
Comment out some variables used only in commented-out code.
Get rid of some unused variables.
Fix up one "proto_tree_add_text()" call where the format string didn't
match the arguments.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17080
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Mon, 23 Jan 2006 07:12:26 +0000 (07:12 +0000)]
Implemention of T38 TCP defragmentation by Alejandro Vaquero
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17079
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 23 Jan 2006 06:14:31 +0000 (06:14 +0000)]
From Marc Petit-Huguenin:
This patch for the STUN dissector fixes a bug (wrong value for DATA_INDICATION attribute) and adds the decoding of IPv6 address in attributes.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17078
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 22 Jan 2006 23:14:58 +0000 (23:14 +0000)]
Get rid of unused variables, fix indentation, don't assign NULL to
non-pointer variables.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17077
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 22 Jan 2006 23:08:15 +0000 (23:08 +0000)]
"size_t" can be "unsigned int" or "unsigned long", so cast it to
"unsigned long" and print it with %lu.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17076
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 22 Jan 2006 21:16:33 +0000 (21:16 +0000)]
Dissect CellGlobalIdOrServiceAreaIdOrLAI and RAIdentity
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17075
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 22 Jan 2006 19:31:42 +0000 (19:31 +0000)]
simply use DISSECTOR_ASSERT() to detect tvb problems instead of my previous commit
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17074
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 22 Jan 2006 16:47:16 +0000 (16:47 +0000)]
add fragment_get_reassembled_id so the handed id doesn't need to be a packet number (experimental)
add a check to fragment_add_common() if the given tvb parameters are ok, otherwise throw a DissectorError
add some more symbols to libethereal.def
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17073
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 22 Jan 2006 16:32:45 +0000 (16:32 +0000)]
Win32: call an existing debugger if a DissectorError is thrown. This preserves the call stack of the bug making debugging much easier.
This can't be done in every error throwing case, as e.g. throwing a ReportedBoundsError might happen a lot even if no bugs are involved. Anyway, extending this to other errors can be done manually while debugging.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17072
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 22 Jan 2006 16:26:41 +0000 (16:26 +0000)]
show the number of packets captured, if "Update list of packets ..." isn't used
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17071
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 22 Jan 2006 02:22:14 +0000 (02:22 +0000)]
add Win32 Structured Exception Handling (SEH) at the same place we're already doing the Portable Exception Handling.
This way we (hopefully) can continue dissecting with the next packet, even if a more serious exception had occured, e.g. a memory access violation or a divide by zero exception.
Obviously, not all problems solved, as SEH won't protect us from other problems, e.g. endless loops and such
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17070
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sat, 21 Jan 2006 19:12:52 +0000 (19:12 +0000)]
RANAP - Dissect ProtocolExtensionField IE:s
GSM A - Service Request; Mobile identity element is LV type
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17069
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 21 Jan 2006 17:49:00 +0000 (17:49 +0000)]
add matched coloring rule name and string to the frame dissector output (or nothing if no coloring rule matched or none was set)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17068
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Sat, 21 Jan 2006 14:54:57 +0000 (14:54 +0000)]
Another iteration, new things aren't tested yet.
Update README, to have a description of the classes
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17067
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 21 Jan 2006 14:36:04 +0000 (14:36 +0000)]
bugfix #709: don't g_assert returned (mandatory) length of some NDIS driver functions.
simply ignore the length returned in that cases
this way, we may "print" buggy data, but that's what the driver returned ...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17066
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Fri, 20 Jan 2006 21:18:18 +0000 (21:18 +0000)]
packet-bgp.c: Fix incorrect use of g_snprintf return value
mp_addr_to_str was unnecessary 'complex' - simplified it
packet-dns.c: Fix incorrect use of g_snprintf return value
packet-dcm.c: Fix incorrect use of g_snprintf return value
Someone who understands the protocol should look at the
"vr, tr might be used uninitialized..." warning.
packet-x11.c: Fix incorrect use of g_snprintf return value
packet-kerberos.c: Fix incorrect use of g_snprintf return value
Someone should take a look at the
"longjump might clobber ..." messages
packet-diameter.c: Fix incorrect use of g_snprintf return value
Get rid of unsigned < 0 check
packet-pgm.c: Fix incorrect use of g_snprintf return value
packet-nbns.c: Fix incorrect use of g_snprintf return value
packet-winsrepl.c: Collateral damage to packet-nbns.c fix
packet-netbios.c: Collateral damage to packet-nbns.c fix
packet-netbios.h: Collateral damage to packet-nbns.c fix
packet-kerberos.c: Collateral damage to packet-nbns.c fix
packet-nbipx.c: Collateral damage to packet-nbns.c fix
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17065
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Fri, 20 Jan 2006 19:56:02 +0000 (19:56 +0000)]
Cleaning up copy to CSV code
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17064
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 20 Jan 2006 19:41:31 +0000 (19:41 +0000)]
Dissect:
- PDPcontext
- GSN-Address
- QoS
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17063
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 20 Jan 2006 19:39:38 +0000 (19:39 +0000)]
Dissect:
- PDPcontext
- GSN-Address
- QoS
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17062
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 20 Jan 2006 19:34:53 +0000 (19:34 +0000)]
Dissect:
- PDPcontext
- GSN-Address
- QoS
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17061
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 20 Jan 2006 19:32:59 +0000 (19:32 +0000)]
Handle sgmented XUDT:s
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17060
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Fri, 20 Jan 2006 09:09:26 +0000 (09:09 +0000)]
Add the commit message as README
svn propset svn:keywords Id *
svn propset svn:eol-style native *
Todo: svn propset svn:ignore .
Because I don't know what to ignore
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17059
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Fri, 20 Jan 2006 08:48:43 +0000 (08:48 +0000)]
Mike Hall:
This will add the ability to configure a .1q vlan column in ethereal.
Me:
Change 1q -> 1Q
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17058
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Fri, 20 Jan 2006 00:06:20 +0000 (00:06 +0000)]
Starts to work so I check it in.
This is an interface to the Lua programming language.
http://www.lua.org
I've already wrote a simple dissector that calls another dissectors.
soon It will be able to register a tap and do something more.
I did not checkin changes to the Makefiles so in order to use it you must change the makefiles.
Other than that to get it to work you need to download lua-5.0.2.tar.gz into the plugin directory, uncompress it, cd to it and call make.
the interface is buggy and far from finished, time will help on this.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17057
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 19 Jan 2006 23:01:24 +0000 (23:01 +0000)]
Make sure we don't use the ADNS version of inet_aton; it's broken.
This fixes bug 523, but exposes more of bug 658.
The TACACS and SDP dissectors don't call inet_aton(), so don't include it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17056
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 19 Jan 2006 18:20:14 +0000 (18:20 +0000)]
ext_qos_subscribed was not correctly decoded in Camel and GSM MAP
Change to use proto_add_item in packet-gsm_a.c for some octets and export value strings.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17055
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 19 Jan 2006 05:51:59 +0000 (05:51 +0000)]
Dont dissect XDT data in case of Segmentation as that will give [Malformed packet] and the Segmentation IE will n ot be dissecterd.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17054
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 19 Jan 2006 02:00:28 +0000 (02:00 +0000)]
add "RPC_E_TIMEOUT" to the reject status codes
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17053
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Wed, 18 Jan 2006 21:41:34 +0000 (21:41 +0000)]
Add option presentation, solving bug 697
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17052
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 18 Jan 2006 20:02:19 +0000 (20:02 +0000)]
In packet-cops.c use proto_item_append_text() instead of creating a
separate buffer. Fixes the current Buildbot failure.
Don't let the sprint_realloc_* functions reallocate ep_allocated memory.
Add comments warning against this in the future.
In emem.c, make sure we don't use an extra 100k every stinkin' time
someone wants to allocate memory when debugging is enabled.
Fixup whitespace.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17051
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 17 Jan 2006 21:52:30 +0000 (21:52 +0000)]
Change some OPCODE decodes from respons to Invoke (bug fix), let gsm_a decode som IE:s.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17050
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 17 Jan 2006 21:50:43 +0000 (21:50 +0000)]
Add ethertypes and value_str for IEC 61850
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17049
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Tue, 17 Jan 2006 18:50:02 +0000 (18:50 +0000)]
Fix an off-by-one error. Fixes bug 698, possibly others.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17048
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 17 Jan 2006 13:13:29 +0000 (13:13 +0000)]
According to 802.11e D11, 7.3.2.13, station count is a 16 bit value.
Accoding to 802.11, 7.1.1, numbers are little endian.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17047
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 17 Jan 2006 10:56:06 +0000 (10:56 +0000)]
packet-fcswils.c: Fix incorrect use of g_snprintf return
packet-wccp.c: Fix incorrect use of g_snprintf return
packet-cops.c: Fix incorrect use of g_snprintf return value
packet-wtp.c: Fix incorrect use of g_snprintf return value
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17046
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 17 Jan 2006 10:54:23 +0000 (10:54 +0000)]
- Replace snprintf by g_snprintf
- Beginning of incorrect g_snprintf retval ussage fixes
- Make qbss station count a byte again until we know
whether the count is a 2 byte le value instead
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17045
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Tue, 17 Jan 2006 06:39:57 +0000 (06:39 +0000)]
Fix typo, solving bug 693
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17044
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Tue, 17 Jan 2006 01:18:51 +0000 (01:18 +0000)]
remove an obsolete comment
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17043
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Tue, 17 Jan 2006 00:40:32 +0000 (00:40 +0000)]
GTK 2.x only: show a slightly different Ethereal main icon while capturing.
I very often forget to stop a running capture, so Ethereal keeps capturing packets on and on, leaving me with a lot of unrequired packets.
On the other hand (because of the above) I often maximize Ethereal just to see that it's really not capturing any longer.
Looking at the window title isn't of much help, as this title changes with every capture file name loaded, so there's no title which can be easily remembered.
We probably might use this icon mechanism as well, when Ethereal loads a (huge) file, so the user get's a more visual feedback when the capture loading is finished (and probably for other potential "lengthy" tasks as well).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17042
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Tue, 17 Jan 2006 00:01:22 +0000 (00:01 +0000)]
MSVC compiler warnings:
packet-ldap.c(784) : warning C4101: 'seq_len' : unreferenced local variable
packet-ldap.c(782) : warning C4101: 'length' : unreferenced local variable
packet-ldap.c(785) : warning C4101: 'header_bytes' : unreferenced local variable
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17041
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 16 Jan 2006 23:43:06 +0000 (23:43 +0000)]
add bugs #648 and #661: "Win32: Unicode chars in filenames" as they seems to be really relevant for some Win32 users
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17040
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Mon, 16 Jan 2006 16:31:54 +0000 (16:31 +0000)]
Update from samba tree revision 12761 to 12961
============================ Samba log start ============
------------------------------------------------------------------------
r12776 | metze | 2006-01-08 21:20:18 +0100 (Sun, 08 Jan 2006) | 3 lines
Changed paths:
M /branches/SAMBA_4_0/source/pidl/tests/Util.pm
use $ENV{TEST_DATA_PREFIX} for test files if available
metze
------------------------------------------------------------------------
============================ Samba log end ==============
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17039
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Mon, 16 Jan 2006 07:59:44 +0000 (07:59 +0000)]
done:
packet-ntp.c: Rather confused and incorrect use of g_snprintf return value
packet-pim.c: whitespace change
packet-icmpv6.c: g_snprintf takes trailing \0 into account, fix off by 1 error
packet-clnp.c: Fix incorrect use of g_snprintf return value
packet-isakmp.c: g_snprintf takes trailing \0 into account
packet-tr.c: Fix incorrect use of g_snprintf return value
packet-radius.c: Fix incorrect use of g_snprintf return value
packet-radius.h: constify a string variable
packet-ldap.c: The return value isn't needed, so don't use it incorrectly
packet-tcp.c: Fix incorrect use of g_snprintf return value
packet-windows-common.c: Remove unneeded DISSECTOR_ASSERT
packet-smb-sidsnooping.c: g_snprintf takes trailing \0 into account
packet-pvfs2.c: g_snprintf takes trailing \0 into account
packet-ptp.c: Remove #include snprintf
packet-ppp.c: Fix incorrect use of g_snprintf return value
packet-ospf.c: Fix incorrect use of g_snprintf return value
packet-mip6.c: snprintf -> g_snprintf
packet-bootp.c: Remove a commented out bad use of g_snprintf
packet-ber.c: snprintf -> g_snprintf, g_snprintf takes trailing \0 into account
2do:
52 packet-ieee80211.c: 2DO
2 packet-nfs.c: 2DO - too many side effects
33 packet-bgp.c: 2DO
18 packet-dns.c: 2DO
14 packet-dcm.c: 2DO
13 packet-x11.c: 2DO
11 packet-kerberos.c: 2DO
10 packet-diameter.c: 2DO
9 packet-snmp.c: 2DO
9 packet-pgm.c: 2DO
7 packet-nbns.c: 2DO
6 packet-fcswils.c: 2DO
5 packet-wccp.c: 2DO
5 packet-cops.c: 2DO
4 packet-wtp.c: 2DO
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17038
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Mon, 16 Jan 2006 06:31:25 +0000 (06:31 +0000)]
Remove uninitalized variable warning
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17037
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 16 Jan 2006 06:05:25 +0000 (06:05 +0000)]
From Alejandro Vaquero:
patch to add t38 setup info for h245 packets.
- Me add /y to makefiles.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17036
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 15 Jan 2006 22:10:56 +0000 (22:10 +0000)]
Backup changes.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17035
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 15 Jan 2006 22:09:41 +0000 (22:09 +0000)]
Sort AVP:s nummerically to make updates easier, remove double entries add nasreq AVP:s and expand some enums.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17034
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Sun, 15 Jan 2006 15:01:14 +0000 (15:01 +0000)]
Hi All,
Find attached a couple of changes for t38:
- Use the dissector to reassemble t30 frames
- Dissect t30 protocol
- Move the "Fax t38 analysis" to the "VoIP Calls". Now when selecting
"Statistics"->"Fax t38 analysis" option, there is a message that
redirect the user to use the "Voip calls" instead. We may keep this
option for one release, and then remove it ?
- Added in the "Voip calls" the ability to detect a t38 call if there
are not signaling associated with it. For example, when using "Decode
as.." to dissect t38 packets, it is possible to use the "Voip calls" to analyze that call.
- Display "SDP (t38)" in the "Voip calls graph" for SDP t38 sessions.
Regards
Alejandro Vaquero
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17033
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 15 Jan 2006 13:51:58 +0000 (13:51 +0000)]
add COTP to fragment COL_INFO message, so the user knows where the fragment is coming from
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17032
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Sat, 14 Jan 2006 23:09:44 +0000 (23:09 +0000)]
Jaap Keuter:
I'm not too fond of using pointer arithmetic in such cases. How about
this:
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17031
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Sat, 14 Jan 2006 11:29:24 +0000 (11:29 +0000)]
We may not work with the length returned by g_snprintf, as this is
the number of bytes that would have been used if the buffer was long
enough.
Fixes http://bugs.ethereal.com/bugzilla/show_bug.cgi?id=686
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17030
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sat, 14 Jan 2006 09:52:04 +0000 (09:52 +0000)]
MTP3 standard in SCCP MTP3 and M3UA will be determined by Preference setting in MTP3.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17029
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Fri, 13 Jan 2006 18:30:12 +0000 (18:30 +0000)]
- Change Cisco QBSS V2 to be part of the Aironet IE dissection.
- Change proto_tree_add_uint ( ...., tvb_get_guint8(...)) to
proto_tree_add_item ( ....) for all qbss dissection code
- Change all qbss occurrences scount to be 16 bits (I may have
gotten endianess wrong! Testers / sample captures needed)
- Change wlan_mgt.tag.aironet... filter to wlan_mgt.aironet...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17028
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Fri, 13 Jan 2006 15:17:50 +0000 (15:17 +0000)]
From Patrik Olsson
Attached is a patch that fixes several decoding problem is the gsm_a
dissector. The bugs are also submitted to bugzilla id #684 and #687.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17027
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Fri, 13 Jan 2006 04:35:10 +0000 (04:35 +0000)]
Add code to verify the shared secret for documentation purposes.
#if 0 that code.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17026
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 12 Jan 2006 22:38:37 +0000 (22:38 +0000)]
fix #661
Win32: convert filenames coming in from command line parameters from locale (current code page) into utf8 encoding
This must also be done for the other command line tools like tethereal, editcap and alike ...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17025
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 12 Jan 2006 22:32:29 +0000 (22:32 +0000)]
fix #648:
Win32 only: reading a pathname from an environment var requires us to read it in as unicode somehow and convert it to utf8. Using _wgetenv should work under all circumstances on NT, using getenv and g_locale_to_utf8 on Windows OT is the best we can do in this case.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17024
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Thu, 12 Jan 2006 22:16:20 +0000 (22:16 +0000)]
Add warning when UDP length field is too large.
Patch by Graeme Hewson
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17023
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 12 Jan 2006 21:53:02 +0000 (21:53 +0000)]
Reset h245_pi using CLEANUP_PUSH/CLEANUP_CALL_AND_POP so that we don't leave
ep_alloc()ated memory lying around. Fixes bug 667.
Fixup whitespace.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17022
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 12 Jan 2006 19:27:56 +0000 (19:27 +0000)]
Backup the latest edits
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17021
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Thu, 12 Jan 2006 16:17:07 +0000 (16:17 +0000)]
Fixes bug 679.
The offset wasn't passed to the PDU dissector so it always started dissection
from the start of the TVB.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17020
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Thu, 12 Jan 2006 15:02:25 +0000 (15:02 +0000)]
The attached patch to fix bug 663 allows Ethereal to read Windows
Sniffer V2 format capture files with captyp=5, timeunit=0.
The ticks_per_sec for this case apparently is 1e6.
Bill Meier
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17019
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 12 Jan 2006 11:21:07 +0000 (11:21 +0000)]
we have 2006 in the meantime ...
I've also added "and contributors" to the copyright string
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17018
f5534014-38df-0310-8fa8-
9805f1628bb7
kukosa [Thu, 12 Jan 2006 09:29:41 +0000 (09:29 +0000)]
oid_to_str_buf() keep enough speace before appending next part of string (Bug 669)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17017
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 12 Jan 2006 06:09:48 +0000 (06:09 +0000)]
FromHannes Gredler
-rework the GGSN dissector to proper parse meta extensions -more graceful magic-number detection - for better (JUNOS 6.4)
downwards compatability
-correct calculate the offset to ATM cookies when there
are meta-extensions present
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17016
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 12 Jan 2006 02:06:34 +0000 (02:06 +0000)]
Before we begin dissection, NULLify some global variables that might
contain ep_alloc()ed data from a previous dissection. Correctly fixes
bug 651 (the previous fix was incorrect).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17015
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 12 Jan 2006 01:32:06 +0000 (01:32 +0000)]
update usage output
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17014
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 12 Jan 2006 01:31:22 +0000 (01:31 +0000)]
minor changes
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17013
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 12 Jan 2006 01:29:20 +0000 (01:29 +0000)]
minor changes
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17012
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 12 Jan 2006 00:13:40 +0000 (00:13 +0000)]
fix usage output
fix -F command option handling (output list of available formats if missing of invalid)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17011
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 12 Jan 2006 00:10:46 +0000 (00:10 +0000)]
fix sequence of time stamp ordering: from most to least information content
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17010
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 12 Jan 2006 00:09:15 +0000 (00:09 +0000)]
minor changes to the usage output
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17009
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Wed, 11 Jan 2006 22:05:43 +0000 (22:05 +0000)]
From Thomas Sillaber
here is the Patch for:
- AVA (Alcatel Automatic VLAN Assignment)
- QBSS ( QOS Basic Service Set)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17008
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 11 Jan 2006 21:36:00 +0000 (21:36 +0000)]
add <> to the option parameters
add some minor enhancements
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17007
f5534014-38df-0310-8fa8-
9805f1628bb7