Stefan Metzmacher [Wed, 15 Jul 2009 18:58:11 +0000 (20:58 +0200)]
s3:libsmb: we need to include "includes.h" as first header to let code build on all platforms
This should fix the Tru64 build.
metze
Stefan Metzmacher [Wed, 15 Jul 2009 18:54:01 +0000 (20:54 +0200)]
s3:tldap: fix the build - a void function should not return a value
metze
Jeremy Allison [Wed, 15 Jul 2009 18:49:33 +0000 (11:49 -0700)]
Make cli_unlock and cli_unlock64 async. Fix POSIX lock test.
Jeremy.
Stefan Metzmacher [Wed, 15 Jul 2009 18:47:07 +0000 (20:47 +0200)]
s4:winbind: rename uint => uint32_t as uint isn't portable
metze
Stefan Metzmacher [Wed, 15 Jul 2009 18:45:53 +0000 (20:45 +0200)]
s4:libnet: rename uint => uint32_t because uint is not portable
metze
Stefan Metzmacher [Wed, 15 Jul 2009 18:43:23 +0000 (20:43 +0200)]
s4:heimdal_build: try to fix the build on Solaris
We need the definition of 'struct flock'.
metze
Stefan Metzmacher [Wed, 15 Jul 2009 17:23:12 +0000 (19:23 +0200)]
s4:ntvfs/ipc: replace unnesessary talloc_reference() by a simple talloc_strdup()
metze
Stefan Metzmacher [Wed, 15 Jul 2009 17:17:57 +0000 (19:17 +0200)]
s3:ntvfs/posix: avoid unnesessary talloc_reference()
This caused the panics on the RAW-SETFILEINFO.RENAME test,
because we returned an empty strings.
The problem was:
ERROR: talloc_steal with references at ntvfs/posix/pvfs_setfileinfo.c:215
reference at ntvfs/posix/pvfs_resolve.c:799
metze
Björn Jacke [Wed, 15 Jul 2009 16:40:57 +0000 (18:40 +0200)]
s4:heimdal: teach heimdal we have (v)aѕprintf in libreplace
Björn Jacke [Wed, 15 Jul 2009 16:32:58 +0000 (18:32 +0200)]
ѕ4:heimdal: teach heimdal that we have strnlen via libreplcae
Björn Jacke [Wed, 15 Jul 2009 15:24:14 +0000 (17:24 +0200)]
s3: make linking of rpcclient --as-needed safe
Peter Volkov [Wed, 15 Jul 2009 15:36:25 +0000 (17:36 +0200)]
s3: make linking of cifs.upcall --as-needed safe
See http://www.gentoo.org/proj/en/qa/asneeded.xml for details.
Michael Adam [Wed, 15 Jul 2009 14:59:07 +0000 (16:59 +0200)]
s3:dbwrap: fix embarrassing typo :-)
Michael
Michael Adam [Tue, 7 Jul 2009 15:16:21 +0000 (17:16 +0200)]
s3:registry: db backend: add my C
Michael
Michael Adam [Wed, 15 Jul 2009 10:50:55 +0000 (12:50 +0200)]
s3:registry: flush the provided subkey_ctr in regdb_fetch_keys_internal()
This way, we always return what has really been read from the db,
and not more. The callers assume exactly this, but one could hand
in an already pre-filled subkey container...
Michael
Michael Adam [Wed, 15 Jul 2009 10:47:12 +0000 (12:47 +0200)]
s3:registry: add function regsubkey_ctr_reinit()
This reinitializes an already allocated regsubkey_ctr structure,
emptying out the subkey array and hash table.
Michael
Michael Adam [Wed, 15 Jul 2009 10:45:43 +0000 (12:45 +0200)]
s3:registry: turn regdb_fetch_keys_internal() from int to WERROR return type
This way, more error information is propagated to the callers.
Michael
Michael Adam [Mon, 13 Jul 2009 15:15:14 +0000 (17:15 +0200)]
s3:registry: use transaction wrapper in create_sorted_subkeys()
Michael
Michael Adam [Thu, 9 Jul 2009 10:54:16 +0000 (12:54 +0200)]
s3:registry: restructure logic of create_sorted_subkes() slightly
This makes it clearer to me, and it also makes it easier to
use the transaction retry wrapper in the next step.
Michael
Michael Adam [Thu, 9 Jul 2009 09:04:20 +0000 (11:04 +0200)]
s3:registry: use transaction wrapper in regdb_delete_subkey().
Michael
Michael Adam [Thu, 9 Jul 2009 08:54:18 +0000 (10:54 +0200)]
s3:registry: add a comment header for the delete_subkey set of commands.
Michael
Michael Adam [Thu, 9 Jul 2009 08:52:40 +0000 (10:52 +0200)]
s3:registry: add a comment header for the create_subkey set of functions
Michael
Michael Adam [Thu, 9 Jul 2009 08:41:59 +0000 (10:41 +0200)]
s3:registry: use transaction wrapper in regdb_create_subkey()
Michael
Michael Adam [Thu, 9 Jul 2009 08:28:29 +0000 (10:28 +0200)]
s3:registry: use transaction wrapper in regdb_store_keys_internal().
Michael
Michael Adam [Wed, 8 Jul 2009 22:21:46 +0000 (00:21 +0200)]
s3:registry: don't leak to talloc_stack in regdb_store_keys_internal2()
and catch one potential talloc failure.
Michael
Michael Adam [Wed, 8 Jul 2009 22:10:08 +0000 (00:10 +0200)]
s3:registry: unify exit logic and remove leaking to talloc_stack in regdb_store_keys_internal()
Michael
Michael Adam [Wed, 8 Jul 2009 15:26:06 +0000 (17:26 +0200)]
s3:registry: change regdb_store_keys_internal2() to return WERROR
instead of bool for better error propagation.
Michael
Michael Adam [Wed, 8 Jul 2009 11:58:52 +0000 (13:58 +0200)]
s3:registry: refactor adding of builtin reg values out
into regdb_ctr_add_value(). For readability.
Michael
Michael Adam [Wed, 8 Jul 2009 11:10:37 +0000 (13:10 +0200)]
s3:registry: use transaction wrapper in init_registry_data()
Michael
Michael Adam [Wed, 8 Jul 2009 10:38:41 +0000 (12:38 +0200)]
s3:registry: add regdb_store_values_internal() that takes a db_context argument
Michael
Michael Adam [Wed, 8 Jul 2009 10:32:48 +0000 (12:32 +0200)]
s3:registry: add a regdb_fetch_values_internal() that takes a db_context argument
Michael
Michael Adam [Tue, 7 Jul 2009 21:58:03 +0000 (23:58 +0200)]
s3:registry: use transaction wrapper in init_registry_key().
Michael
Michael Adam [Tue, 7 Jul 2009 21:03:46 +0000 (23:03 +0200)]
s3:registry: add db_context argument to init_registry_key_internal()
Michael
Michael Adam [Tue, 7 Jul 2009 10:42:09 +0000 (12:42 +0200)]
s3:registry: panic upon error at transaction_cancel in create_sorted_subkeys
Michael
Michael Adam [Tue, 7 Jul 2009 10:41:09 +0000 (12:41 +0200)]
s3:registry: fix a comment in create_sorted_subkeys()
Michael
Michael Adam [Tue, 7 Jul 2009 10:39:32 +0000 (12:39 +0200)]
s3:registry: don't loop transaction_commit in create_sorted_subkeys() upon error
This would try to commit a higher level transaction upon commit-error.
Michael
Michael Adam [Tue, 7 Jul 2009 10:27:26 +0000 (12:27 +0200)]
s3:registry: in regdb_delete_subkey(), don't use the transaction wrappers.
This way, the db handle gets used explicitly and the core of the
function can be abstracted.
Michael
Michael Adam [Tue, 7 Jul 2009 10:24:25 +0000 (12:24 +0200)]
s3:registry: in regdb_delete_subkey(), panic if transaction_cancel fails
Michael
Michael Adam [Tue, 7 Jul 2009 10:20:23 +0000 (12:20 +0200)]
s3:registry: panic upon failed transaction_cancel in regdb_create_subkey()
Michael
Michael Adam [Tue, 7 Jul 2009 09:41:08 +0000 (11:41 +0200)]
s3:registry: don't use exported transaction wrappers in regdb_create_subkey()
So that the regdb handle is again explicit and the core of the
function can be abstracted.
Michael
Michael Adam [Tue, 7 Jul 2009 09:31:28 +0000 (11:31 +0200)]
s3:registry: create regdb_store_keys_internal() with db_context argument
and let exported regdb_store_keys() just call regdb_store_keys_internal()
with regdb as an argument. Internally, in reg_backend_db.c, always use the
_internal version.
Michael
Michael Adam [Tue, 7 Jul 2009 09:11:10 +0000 (11:11 +0200)]
s3:registry: rename regdb_store_keys_internal() to regdb_store_keys_internal2()
Michael
Michael Adam [Fri, 3 Jul 2009 15:39:17 +0000 (17:39 +0200)]
s3:registry: create regdb_fetch_keys_internal() with db_context argument
and let exported regdb_fetch_keys() just call regdb_fetch_keys_internal()
with regdb as an argument. Internally, in reg_backend_db.c, always use the
_internal version.
Michael
Michael Adam [Fri, 3 Jul 2009 15:18:19 +0000 (17:18 +0200)]
s3:registry: add db_context argument to scan_parent_subkeys()
Michael
Michael Adam [Fri, 3 Jul 2009 15:10:09 +0000 (17:10 +0200)]
s3:registry: add db_context argument to regdb_fetch_key_internal()
Michael
Michael Adam [Fri, 3 Jul 2009 15:00:44 +0000 (17:00 +0200)]
s3:registry: add db_context argument to regdb_store_keys_internal()
Michael
Michael Adam [Fri, 3 Jul 2009 14:51:26 +0000 (16:51 +0200)]
s3:registry: add db_context argument to regdb_delete_key_lists()
Michael
Michael Adam [Fri, 3 Jul 2009 14:48:36 +0000 (16:48 +0200)]
s3:registry: add db_context argument to regdb_delete_subkeylist()
Michael
Michael Adam [Fri, 3 Jul 2009 14:44:20 +0000 (16:44 +0200)]
s3:registry: add db_context argument to regdb_delete_secdesc()
Michael
Michael Adam [Fri, 3 Jul 2009 14:42:20 +0000 (16:42 +0200)]
s3:registry: add db_context argument to regdb_delete_values()
Michael
Michael Adam [Fri, 3 Jul 2009 14:40:43 +0000 (16:40 +0200)]
s3:registry: add db_context argument to regdb_delete_key_with_prefix()
Michael
Michael Adam [Wed, 8 Jul 2009 14:16:18 +0000 (16:16 +0200)]
s3:registry: don't store differently cased entries for the same keys.
This happened for instance during registry initialization, when
entries for HKLM\Software and HKLM\SOFTWARE were created.
Searching these entries was case insensitive though.
But the entries ended up in the subkey-lists anyways.
This is solved by making the subkeys_hash in the regsubkey_container
structs case insensitive (using the new _bystring_upper() wrappers).
Michael
Michael Adam [Wed, 15 Jul 2009 07:58:02 +0000 (09:58 +0200)]
s3:dbwrap_util: add my C
Michael
Michael Adam [Wed, 8 Jul 2009 14:13:07 +0000 (16:13 +0200)]
s3:dbwrap: add dbwrap_fetch_bystring_upper().
To fetch a key whose name is stored but not given in upper case.
Michael
Michael Adam [Wed, 8 Jul 2009 14:08:41 +0000 (16:08 +0200)]
s3:dbwrap: add dbwrap_store_bystring_upper().
This stores a key under the uppercase version of the given keyname.
Michael
Michael Adam [Wed, 8 Jul 2009 14:02:19 +0000 (16:02 +0200)]
s3:dbwrap: add dbwrap_delete_bystring_upper()
To delete a key whose name is not given in but stored in uppercase.
Michael
Michael Adam [Wed, 15 Jul 2009 12:00:42 +0000 (14:00 +0200)]
s3:dbwrap: add a wrapper dbwrap_trans_do()
This function wraps the action() callback into a db
transaction and the transaction is either committed
or cancelled, depending on the return value of
the action function.
Michael
Stefan Metzmacher [Wed, 15 Jul 2009 10:14:32 +0000 (12:14 +0200)]
torture/smb2: add missing new line to the new SMB2-DIR.FILE-INDEX test
Without this the subunit formated output would be invalid and make test
reports: "UNEXPECTED(error): samba4.smb2.dir (dc).FILE-INDEX"
metze
Stefan Metzmacher [Mon, 13 Jul 2009 07:23:57 +0000 (09:23 +0200)]
s3:smbd: add support for SMB2 SetInfo File*Information
metze
Stefan Metzmacher [Mon, 13 Jul 2009 10:08:20 +0000 (12:08 +0200)]
s3:smbd: implement SMB2 GetInfo with Fs*Information
metze
Stefan Metzmacher [Mon, 13 Jul 2009 07:23:36 +0000 (09:23 +0200)]
s3:smbd: return NT_STATUS_INVALID_INFO_CLASS in SMB2 GetInfo
metze
Stefan Metzmacher [Tue, 14 Jul 2009 07:47:46 +0000 (09:47 +0200)]
s3:smbd: check quota access against sec_initial_uid() instead of 0
And return an NTSTATUS mapped from errno. Instead of hardcoded values.
metze
Stefan Metzmacher [Tue, 14 Jul 2009 07:49:25 +0000 (09:49 +0200)]
s3:lib: map ENOSYS to NT_STATUS_NOT_SUPPORTED instead of NT_STATUS_ACCESS_DENIED
Jeremy: please check and decide if we want to backport this.
metze
Stefan Metzmacher [Wed, 15 Jul 2009 09:54:07 +0000 (11:54 +0200)]
s3:make test: smbtorture from s3 needs to take the config file path via the SMB_CONF_PATH envvar
metze
Stefan Metzmacher [Tue, 14 Jul 2009 11:32:23 +0000 (13:32 +0200)]
SMB2-GETINFO: test SMB2_ALL_EAS
metze
Stefan Metzmacher [Mon, 13 Jul 2009 10:25:40 +0000 (12:25 +0200)]
s4:libcli/smb2: add smb2_transport_credits_set_charge() to change the CreditsCharge value for the next request
metze
Stefan Metzmacher [Wed, 8 Jul 2009 08:09:54 +0000 (10:09 +0200)]
SMB2-CONNECT: unlink the test file at startup
This is needed to get reproducable results...
metze
Volker Lendecke [Tue, 14 Jul 2009 16:31:28 +0000 (18:31 +0200)]
Consolidate gencache also every 100 writes in a single process
Volker Lendecke [Tue, 14 Jul 2009 09:33:04 +0000 (11:33 +0200)]
Consolidate string and data_blob routines in gencache
Volker Lendecke [Mon, 13 Jul 2009 15:04:29 +0000 (17:04 +0200)]
Make gencache more stable
This provides a compromise between stability and performance: gencache is a
persistent database these days that for performance reasons can not use tdb
transactions for all writes. This patch splits up gencache into gencache.tdb
and gencache_notrans.tdb. gencache_notrans is used with CLEAR_IF_FIRST, writes
to it don't use transactions. By default every 5 minutes and when a program
exits, all entries from _notrans.tdb are transferred to gencache.tdb in one
transaction.
Volker Lendecke [Mon, 13 Jul 2009 15:03:52 +0000 (17:03 +0200)]
Add tdb_data_cmp
Volker Lendecke [Fri, 10 Jul 2009 10:24:56 +0000 (12:24 +0200)]
Remove gencache_init/shutdown
gencache_get/set/del/iterate call gencache_init() internally anyway. And we've
been very lazy calling gencache_shutdown, so this seems not really required.
Volker Lendecke [Fri, 10 Jul 2009 10:12:30 +0000 (12:12 +0200)]
Fix some nonempty blank lines
Volker Lendecke [Fri, 10 Jul 2009 10:03:35 +0000 (12:03 +0200)]
Remove gencache_[un]lock_key
Volker Lendecke [Fri, 10 Jul 2009 09:00:24 +0000 (11:00 +0200)]
TDB_CONTEXT -> "struct tdb_context"
Volker Lendecke [Fri, 10 Jul 2009 08:54:33 +0000 (10:54 +0200)]
Replace ASSERTs in gencache with "return false"
It's a bit strong to panic here I think.
Stefan Metzmacher [Wed, 15 Jul 2009 08:49:41 +0000 (10:49 +0200)]
torture/smb2: fix crash bugs in the new SMB2-DIR tests
metze
Jeremy Allison [Tue, 14 Jul 2009 23:54:01 +0000 (16:54 -0700)]
Change to talloc_zero_size instead of extra memset.
Jeremy.
Jeremy Allison [Tue, 14 Jul 2009 23:42:21 +0000 (16:42 -0700)]
When tallocing a memory block for the state in a tevent_req struct,
ensure it's zeroed out. Vl & Metze please check.
Jeremy.
Günther Deschner [Tue, 14 Jul 2009 23:22:32 +0000 (01:22 +0200)]
s4-selftest: ok, s4 cant print. add RPC-SPOOLSS-PRINTER to knownfail for now.
Guenther
Aravind [Tue, 7 Jul 2009 14:11:56 +0000 (07:11 -0700)]
torture/smb2: Adding SMB2 Directory enumeration torture tests.
* Most of the tests were ported from SMB torture tests.
* Added one new tests which checks the behavior of the file_index field
present in SMB2_FIND struct.
* Added one new test to check the enumeration of directories containing
lots of files (~2000 files) with name lengths varying from 1 to 200 char.
Günther Deschner [Tue, 14 Jul 2009 21:36:41 +0000 (23:36 +0200)]
s3-passdb: fix wbc build warning.
Guenther
Volker Lendecke [Tue, 14 Jul 2009 21:12:59 +0000 (23:12 +0200)]
Fix bug 5886
Ok, that's a very long-standing one. I finally got around to install a recent
OpenLDAP and test the different variants of setting a NULL password etc.
Thanks all for your patience!
Volker
Günther Deschner [Fri, 3 Jul 2009 07:56:28 +0000 (09:56 +0200)]
s4-smbtorture: add RPC-SPOOLSS-PRINTER test.
Guenther
Günther Deschner [Thu, 2 Jul 2009 17:38:12 +0000 (19:38 +0200)]
s4-smbtorture: add some tests to check spoolss_SetPrinter behavior.
Guenther
Günther Deschner [Tue, 14 Jul 2009 12:33:08 +0000 (14:33 +0200)]
s4-smbtorture: restructure test_OpenPrinter_server in RPC-SPOOLSS a bit.
Guenther
Björn Jacke [Tue, 14 Jul 2009 20:23:39 +0000 (22:23 +0200)]
s3: allow setting the TCP_QUICKACK socket option
Volker Lendecke [Tue, 14 Jul 2009 19:28:13 +0000 (21:28 +0200)]
Attempt to fix the build
Volker Lendecke [Tue, 14 Jul 2009 16:34:36 +0000 (18:34 +0200)]
Create a talloc_stackframe for each file in wildcard unlink
There might be *many* files to delete
Volker Lendecke [Tue, 14 Jul 2009 16:34:07 +0000 (18:34 +0200)]
Create a correct talloc hierarchy in make_sec_acl()
Volker Lendecke [Tue, 14 Jul 2009 16:33:01 +0000 (18:33 +0200)]
TALLOC_FREE(sd) in check_open_rights upon an error
Jeremy Allison [Tue, 14 Jul 2009 18:25:45 +0000 (11:25 -0700)]
Revert this commit :
s3: Make smbd aware of permission change of usershare. Since usershare are relatively volatile and
non-previledge users must disconnect from smbd and reconnect to it to make share permission in effect.
For now. This is a feature request and I think we need
to design it a little differently so as not to touch
core change_to_user() code.
Jeremy.
Bo Yang [Wed, 15 Jul 2009 09:03:04 +0000 (17:03 +0800)]
s3: fix build of pdbedit and net_sam. Guenther, please check. Signed-off-by: Bo Yang <boyang@samba.org>
Bo Yang [Wed, 15 Jul 2009 07:37:04 +0000 (15:37 +0800)]
s3: Fix double free in net usershare.
Signed-off-by: Bo Yang <boyang@samba.org>
Bo Yang [Wed, 15 Jul 2009 07:36:02 +0000 (15:36 +0800)]
S3: Small fix to get rid of annoying log message.
Signed-off-by: Bo Yang <boyang@samba.org>
Bo Yang [Wed, 15 Jul 2009 07:34:10 +0000 (15:34 +0800)]
s3: Make smbd aware of permission change of usershare. Since usershare are relatively volatile and non-previledge users must disconnect from smbd and reconnect to it to make share permission in effect.
Björn Jacke [Tue, 14 Jul 2009 15:55:50 +0000 (17:55 +0200)]
s3: make
d9c0d58236 better readble and reduce indentation
Björn Jacke [Tue, 14 Jul 2009 15:40:21 +0000 (17:40 +0200)]
s3: don't make same innetgr check twice
Sumit Bose [Fri, 10 Jul 2009 20:44:27 +0000 (22:44 +0200)]
remove all '\n' from ldb_debug
Günther Deschner [Mon, 13 Jul 2009 21:53:49 +0000 (23:53 +0200)]
s3-account_policy: add pdb_policy_type enum.
Guenther