obnox/wireshark/wip.git
18 years agoupdated to latest Ethereal GUI
ulfl [Thu, 16 Jun 2005 21:51:17 +0000 (21:51 +0000)]
updated to latest Ethereal GUI

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14671 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoadd ChIOExportCSVDialog section, docbook validation should work again
ulfl [Thu, 16 Jun 2005 21:34:06 +0000 (21:34 +0000)]
add ChIOExportCSVDialog section, docbook validation should work again

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14670 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoadd a "file sets" section and fix a link to it
ulfl [Thu, 16 Jun 2005 21:19:50 +0000 (21:19 +0000)]
add a "file sets" section and fix a link to it

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14669 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd Paul Ollis
etxrab [Thu, 16 Jun 2005 21:19:37 +0000 (21:19 +0000)]
Add Paul Ollis

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14668 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Paul Ollis:
etxrab [Thu, 16 Jun 2005 21:16:23 +0000 (21:16 +0000)]
From  Paul Ollis:
  epan/dissectors/packet-sigcomp.c
  --------------------------------

    Function dissect_sigcomp:

        1. Make sure the temporary buffer that is used to load byte-code from
           state is zeroed, since the function udvm_state_access implicitly
           relies on this.

        2. Pass the SigComp message header length, state length and partial
           state length to decompress_sigcomp_message.

        3. Removed the state_vars_valid parameter from calls to
           udvm_state_access.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14667 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Paul Ollis:
etxrab [Thu, 16 Jun 2005 21:15:12 +0000 (21:15 +0000)]
From  Paul Ollis:
  epan/sigcomp_state_hdlr.c epan/sigcomp_state_hdlr.h
  ---------------------------------------------------

    Function udvm_state_access:

        1. Removed the state_vars_valid parameter. It is no longer used.

        2. The function now correctly updates each of state_length,
           state_address and state_instruction with saved state value.

           [Previously this was only done for state referenced in the SigComp
            message header.]

        3. Removed code that (incorrectly) read byte_copy_left from UDVM memory
           within the loop that writes the state to UDVM memory.

        4. Removed the code that set the useful values in UDVM memory. This
           should only be done for state referenced in the SigComp message
           header. (The decompress_sigcomp_message function, sets the useful
           values.)

  epan/sigcomp-udvm.c epan/sigcomp-udvm.h
  ---------------------------------------

    Function decompress_sigcomp_message:

        1. Added three new parameters; header_len, byte_code_state_len,
           byte_code_id_len.  The byte_code_state_len and byte_code_id_len
           are used to set the useful values in UDVM memory. The
           header_len is required to calculate the cycles available
           for decompression.

        2. Various minor corrections to spellings, etc in generated
           messages.

        3. Reduced the number of lines of output for print_level_1. Now
           the execution trace shows the instruction name and parameter
           values on one line.

           [This was done because, we found that even at the lowest
           level of detail ethereal became unusably slow; running on
           a 500 MHz SPARC. This seems to be related to the number of
           lines produced by the SigComp trace, which can easily be over
           1000 with the modified code.]

        4. Removed the used of some floating point functions. In all
           cases they were unnecessary and could potentially cause the
           code to produce the wrong results on some platforms (although
           this is unlikely).

        5. The useful values are now set correctly, using the new
           byte_code_state_len and byte_code_id_len parameters.

        6. The message header length is now included in the calculation of
           maximum_UDVM_cycles. Previously, the calculation could underestimate
           the value, resulting in the (small) chance that some legitimate
           messages might fail to decompress.

           Note: The calculation might now slightly over-estimate the cycles
           but this is a reasonable thing to do.

        7. Implemented the PUSH, POP, CALL and RETURN instructions.

           Note: The two SORT instructions and the CRC and SHA-1 instructions
           are still not implemented.

        8. The COPY and COPY-LITERAL instructions now apply the
           byte-copying-rules to the source address as well as the destination
           address.

        9. The COPY-LITERAL and COPY-OFFSET now correctly handle the
           destination operand. Previously, it was possible for the destination
           to be left at byte_copy_right when it should be left at
           byte_copy_left.

        10. All three COPY instructions will now behave correctly if the source
            or destination start at byte_copy_right; i.e. they read/write to
            byte_copy_right, byte_copy_right+1, etc. Previously the parameters
            would wrap to byte_copy_left.

        11. The COPY-OFFSET instruction now correctly calculates the source
            address for all values of offset. Previously a very large offset
            (greater than the circular buffer size) could cause the starting
            position to be mis-calculated.

        12. Modulo 65536 arithmetic has been added in some places where it was
            missing.

            [Only when noticed, we have not been able to check all the code.]

        13. Some redundant code was removed for the INPUT-BITS instruction.
            Also, INPUT-BITS (0, x, x) now correctly discards spare bits when
            the P-bit, has changed.

        14. Corrected the cycles used calculation for the INPUT-BITS
            instruction.

        15. Corrected some minor cases where the used_udvm_cycles was not
            incremented.

            [Not really a problem, but it allowed us to verify correctness with
            some of the SigComp torture tests.]

        16. Removed some redundant code in INPUT-HUFFMAN (and reorganised some
            comments to keep them making sense).

    Function decomp_dispatch_get_bits:

        1. This has been rewritten. The original version could not correctly
           handle requests for more than 8 bits. The new version is cleaner and
           correctly handles all cases.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14666 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoupdated to latest Ethereal GUI
ulfl [Thu, 16 Jun 2005 20:27:55 +0000 (20:27 +0000)]
updated to latest Ethereal GUI

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14665 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix Win32 compilation, broken by yesterday's checkin.
gerald [Thu, 16 Jun 2005 19:51:14 +0000 (19:51 +0000)]
Fix Win32 compilation, broken by yesterday's checkin.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14664 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoGet rid of several megabytes worth of warnings about
jmayer [Thu, 16 Jun 2005 17:23:34 +0000 (17:23 +0000)]
Get rid of several megabytes worth of warnings about
"discards qualifier from assignment".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14663 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoRemove unused variable.
guy [Thu, 16 Jun 2005 10:06:22 +0000 (10:06 +0000)]
Remove unused variable.

Clean up indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14662 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoGet rid of unnecessary assignment and unnecessary "volatile" qualifier.
guy [Thu, 16 Jun 2005 10:05:23 +0000 (10:05 +0000)]
Get rid of unnecessary assignment and unnecessary "volatile" qualifier.

Mark unused parameter as such.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14661 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Peter Kovar: fix an incorrect assignment that caused a compilation
guy [Thu, 16 Jun 2005 09:58:01 +0000 (09:58 +0000)]
From Peter Kovar: fix an incorrect assignment that caused a compilation
error with GCC 4.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14660 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoNote that the WAN_CAPTYPE value of 4 can correspond to Cisco HDLC
guy [Thu, 16 Jun 2005 08:10:13 +0000 (08:10 +0000)]
Note that the WAN_CAPTYPE value of 4 can correspond to Cisco HDLC
traffic as well as Frame Relay traffic, and give some information about
the cruft found in the xxc field of the header for one CHDLC and one FR
capture.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14659 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoClean up white space.
guy [Thu, 16 Jun 2005 07:46:03 +0000 (07:46 +0000)]
Clean up white space.

Register "standard" and "lock_info_col" as obsolete preferences, so
they're silently ignored rather than triggering warnings.

Propagate changes to check for "dissect_ber_octet_string()" supplying a
null tvbuff pointer from the checkins to the generated dissector ("Do
not modify this file" means "Do not modify this file"!) to the tcap.cnf
file, so that they're not lost if the dissector is regenerated.  (Don't
propagate the checks for "tvb_new_subset()" returning null - it never
returns null.)

Pass -1 to "tvb_new_subset()" when appropriate.

When looping over packet data, check against the reported length, not
the captured length, so we indicate a short frame if we get stopped by
the snapshot length.

Get rid of unused variables.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14658 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoRegister "version" as an obsolete preference, so it's silently ignored,
guy [Thu, 16 Jun 2005 06:50:20 +0000 (06:50 +0000)]
Register "version" as an obsolete preference, so it's silently ignored,
rather than provoking a warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14657 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoDon't hand a null pointer to a "%s" format.
guy [Thu, 16 Jun 2005 06:41:28 +0000 (06:41 +0000)]
Don't hand a null pointer to a "%s" format.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14656 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix a typo, and squelch a compiler warning.
guy [Thu, 16 Jun 2005 06:34:27 +0000 (06:34 +0000)]
Fix a typo, and squelch a compiler warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14655 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoInclude <ctype.h> to define/declare "isspace()".
guy [Thu, 16 Jun 2005 06:33:49 +0000 (06:33 +0000)]
Include <ctype.h> to define/declare "isspace()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14654 f5534014-38df-0310-8fa8-9805f1628bb7

18 years ago"dissect_isup_thin()" is a new-style dissector; register it as such.
guy [Thu, 16 Jun 2005 06:32:20 +0000 (06:32 +0000)]
"dissect_isup_thin()" is a new-style dissector; register it as such.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14653 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoSquelch some unitialized variable warnings.
guy [Thu, 16 Jun 2005 06:31:25 +0000 (06:31 +0000)]
Squelch some unitialized variable warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14652 f5534014-38df-0310-8fa8-9805f1628bb7

18 years ago"proto_tree_add_text()" doesn't add a named field, so it takes no "hf_"
guy [Thu, 16 Jun 2005 06:30:33 +0000 (06:30 +0000)]
"proto_tree_add_text()" doesn't add a named field, so it takes no "hf_"
argument.

Report a non-integral type used with "dissect_per_integer()" with an
explicit "REPORT_DISSECTOR_BUG()" call, as that's a dissector bug.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14651 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoInclude <ctype.h> to get "isdigit()" defined/declared.
guy [Thu, 16 Jun 2005 06:28:50 +0000 (06:28 +0000)]
Include <ctype.h> to get "isdigit()" defined/declared.

"dissect_msrp()" is a "new-style" dissector; register it as such.

Squelch an uninitialized variable warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14650 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoSquelch some compiler warnings.
guy [Thu, 16 Jun 2005 06:27:18 +0000 (06:27 +0000)]
Squelch some compiler warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14649 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoStatic variables considered harmful. Make the ISAKMP version a
guy [Thu, 16 Jun 2005 06:19:03 +0000 (06:19 +0000)]
Static variables considered harmful.  Make the ISAKMP version a
parameter to many functions inside the ISAKMP dissector, as well as to
the "isakmp_dissect_payloads()" routine it exports.  Get rid of
"isakmp_set_version()", as the version can be passed to
"isakmp_dissect_payloads()" from the KINK dissector.

Put the declaration of "isakmp_dissect_payloads()" into a
"packet-isakmp.h" header, and have "packet-isakmp.c" and "packet-kink.h"
include it rather than declariing "isakmp_dissect_payloads()" itself -
or not doing so at all.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14648 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoRegenerate - this squelches some compiler warnings.
guy [Thu, 16 Jun 2005 06:06:18 +0000 (06:06 +0000)]
Regenerate - this squelches some compiler warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14647 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agothird and last(?) iteration on the import routines for tektronix 32bit rf5 files.
lego [Thu, 16 Jun 2005 02:27:30 +0000 (02:27 +0000)]
third and last(?) iteration on the import routines for tektronix 32bit rf5 files.
Now the import is correct even for large files.
I found out when and where the "junk" was inserted.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14646 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoupdate toolbar items and icons
ulfl [Wed, 15 Jun 2005 23:55:46 +0000 (23:55 +0000)]
update toolbar items and icons

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14645 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agodon't call "Capture/Start" Capture but Start in the toolbar
ulfl [Wed, 15 Jun 2005 23:05:37 +0000 (23:05 +0000)]
don't call "Capture/Start" Capture but Start in the toolbar

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14644 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoHandle FT_UINTs in dissect_per_integer(). Fixes bug 234.
gerald [Wed, 15 Jun 2005 22:56:23 +0000 (22:56 +0000)]
Handle FT_UINTs in dissect_per_integer().  Fixes bug 234.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14643 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoupdate various menu items (screenshots must be updated as well)
ulfl [Wed, 15 Jun 2005 22:47:20 +0000 (22:47 +0000)]
update various menu items (screenshots must be updated as well)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14642 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agominor editing
ulfl [Wed, 15 Jun 2005 22:45:51 +0000 (22:45 +0000)]
minor editing

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14641 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoMake sure dissect_browser_TYPE_12_data() returns the right value. Catch
gerald [Wed, 15 Jun 2005 22:08:43 +0000 (22:08 +0000)]
Make sure dissect_browser_TYPE_12_data() returns the right value.  Catch
integer overflows in that and other functions.  Fixes bug 236.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14640 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoCatch an infinite loop in smpp_handle_dlist(). Fixes bug 246.
gerald [Wed, 15 Jun 2005 21:42:30 +0000 (21:42 +0000)]
Catch an infinite loop in smpp_handle_dlist().  Fixes bug 246.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14639 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd missing hf entries. Fixes bug 240.
gerald [Wed, 15 Jun 2005 21:33:48 +0000 (21:33 +0000)]
Add missing hf entries.  Fixes bug 240.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14638 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoIn sam_dissect_SAM_SECURITY_DESCRIPTOR_data(), throw an exception if we
gerald [Wed, 15 Jun 2005 20:55:11 +0000 (20:55 +0000)]
In sam_dissect_SAM_SECURITY_DESCRIPTOR_data(), throw an exception if we
fetch a too-long length.  Fixes bug 236.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14637 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix a couple of infinite loops found by Buildbot. Were the recent
gerald [Wed, 15 Jun 2005 18:35:13 +0000 (18:35 +0000)]
Fix a couple of infinite loops found by Buildbot.  Were the recent
changes to this dissector fuzz tested at all?

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14636 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix an infinite loop found by randpkt testing. Change the line endings from
gerald [Wed, 15 Jun 2005 17:56:47 +0000 (17:56 +0000)]
Fix an infinite loop found by randpkt testing.  Change the line endings from
DOS to UNIX.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14635 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoWhen we add an FT_STRINGZ item, throw an exception if the length is
gerald [Wed, 15 Jun 2005 15:10:02 +0000 (15:10 +0000)]
When we add an FT_STRINGZ item, throw an exception if the length is
less than -1.  If the length is 0, set the item string to "[Empty]".
This fixes bug 219.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14634 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd Samuel Thibault
etxrab [Tue, 14 Jun 2005 22:01:55 +0000 (22:01 +0000)]
Add Samuel Thibault

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14633 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Samuel Thibault,
etxrab [Tue, 14 Jun 2005 21:58:54 +0000 (21:58 +0000)]
From Samuel Thibault,
Some updates to the yahoo msg dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14632 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoCorrect a typo
etxrab [Tue, 14 Jun 2005 21:57:17 +0000 (21:57 +0000)]
Correct a typo

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14631 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Javier Acuna
etxrab [Tue, 14 Jun 2005 21:48:42 +0000 (21:48 +0000)]
From Javier Acuna
patch to include Cic info in Voip Calls

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14630 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd vendor AVP:s for T-Mobile and T-Systems Nova International GmbH.
etxrab [Tue, 14 Jun 2005 21:46:51 +0000 (21:46 +0000)]
Add vendor AVP:s for T-Mobile and  T-Systems Nova International GmbH.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14629 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd Vendor ID of T-Mobile and T-Systems Nova International GmbH.
etxrab [Tue, 14 Jun 2005 21:45:29 +0000 (21:45 +0000)]
Add Vendor ID of T-Mobile  and  T-Systems Nova International GmbH.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14628 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Steve Grubb:
gerald [Tue, 14 Jun 2005 18:18:05 +0000 (18:18 +0000)]
From Steve Grubb:

Fix bounds checking in lemon.c.  Fix up an if/else block in
packet-dcerpc-samr.c.  Fix hex printing in packet-gtp.c.

Fix other problems discovered by Steve:

Fix a bounds check in packet-isis-lsp.c.  Also, fix netmask printing
on non-little-endian machines.  Add a comment about adding a netmask
routine to to_str.c.  Add bounds checks to packet-ncp2222.inc.

All of these apply to bug 217.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14627 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAlways skip the whole header: The current code would only decode
jmayer [Tue, 14 Jun 2005 14:33:55 +0000 (14:33 +0000)]
Always skip the whole header: The current code would only decode
sizeof strcut wlan_header_v1 bytes, but if our struct was missing
some newer elements, things would go wrong.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14626 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoNo // comments
jmayer [Tue, 14 Jun 2005 13:35:24 +0000 (13:35 +0000)]
No // comments

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14625 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoChange read_prefs() to use GStrings instead of (re)allocating memory
gerald [Mon, 13 Jun 2005 22:40:11 +0000 (22:40 +0000)]
Change read_prefs() to use GStrings instead of (re)allocating memory
ourselves.  This fixes a potential off-by-one error found by Steve Grubb.

Add two new -G options: defaultprefs and currentprefs.  The first dumps
the default preferences to stdout and the second dumps the user's prefs
to stdout.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14624 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agothe note about not sending sensitive information to the lists should really be a...
ulfl [Mon, 13 Jun 2005 20:04:09 +0000 (20:04 +0000)]
the note about not sending sensitive information to the lists should really be a warning, not only a note

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14623 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agominor editing
ulfl [Mon, 13 Jun 2005 20:01:05 +0000 (20:01 +0000)]
minor editing

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14622 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agouse a helper dissector to show k12 files.
lego [Mon, 13 Jun 2005 19:45:21 +0000 (19:45 +0000)]
use a helper dissector to show k12 files.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14621 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoRead .svn/entries directly instead of calling "svn info", as suggested by
gerald [Mon, 13 Jun 2005 16:31:01 +0000 (16:31 +0000)]
Read .svn/entries directly instead of calling "svn info", as suggested by
Thomas Anders.  This should make things more locale-independent and remove
a dependency on "svn" being present.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14620 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd the missing parlay.la to the makefile
lego [Mon, 13 Jun 2005 08:47:24 +0000 (08:47 +0000)]
Add the missing parlay.la to the makefile

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14619 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agofrom Jaap Keuter: add some comments, how paths should look like for a debian distro
ulfl [Mon, 13 Jun 2005 06:55:06 +0000 (06:55 +0000)]
from Jaap Keuter: add some comments, how paths should look like for a debian distro

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14618 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd some yhoo_service_vals
etxrab [Sat, 11 Jun 2005 21:31:13 +0000 (21:31 +0000)]
Add some yhoo_service_vals

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14617 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoUpdate references to the WinPcap Web site.
guy [Sat, 11 Jun 2005 19:03:49 +0000 (19:03 +0000)]
Update references to the WinPcap Web site.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14616 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoUpdate references to the WinPcap Web site.
guy [Sat, 11 Jun 2005 19:02:31 +0000 (19:02 +0000)]
Update references to the WinPcap Web site.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14615 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoadd missing #include "webbrowser.h" from previous commit
ulfl [Sat, 11 Jun 2005 16:50:18 +0000 (16:50 +0000)]
add missing #include "webbrowser.h" from previous commit

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14614 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd Angelo Bannack as an author.
etxrab [Sat, 11 Jun 2005 16:03:24 +0000 (16:03 +0000)]
Add Angelo Bannack as an author.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14613 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Angelo Bannack,
etxrab [Sat, 11 Jun 2005 15:58:01 +0000 (15:58 +0000)]
From Angelo Bannack,
 A CSM_ENCAPS dissector to use with ethereal.
The CSM_ENCAPS is a protocol used by MindSpeed to communicate with your products, and configure VoIP channels.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14612 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoadd help button pointing to the wiki page
ulfl [Sat, 11 Jun 2005 12:12:12 +0000 (12:12 +0000)]
add help button pointing to the wiki page

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14611 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agothis is an attempt, please report problems:
ulfl [Fri, 10 Jun 2005 19:09:49 +0000 (19:09 +0000)]
this is an attempt, please report problems:

after asking the devlist if this would break things and got no negative response, try to scan command line parameters twice, trying to "rewind" the getopt settings

this way, fixing #135

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14610 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agodon't call g_assert_not_reached() for an unknown port type
ulfl [Fri, 10 Jun 2005 18:30:33 +0000 (18:30 +0000)]
don't call g_assert_not_reached() for an unknown port type

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14609 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agojust to get things straight: a dissector should *never* do any g_assert() calls!
ulfl [Fri, 10 Jun 2005 18:28:22 +0000 (18:28 +0000)]
just to get things straight: a dissector should *never* do any g_assert() calls!

in a simple approach, I've replaced all g_assert() and g_assert_not_reached() calls by their exception throwing counterparts DISSECTOR_ASSERT() and DISSECTOR_ASSERT_NOT_REACHED()

this will replace application crash by showing a dissector bug, which is the desired behaviour

there were some g_assert calls in the protocol registering functions, which might not be acting as expected now, but to be able to simply search for g_assert in the future I've replaced that calls too

one g_assert remained, the one when someone throws an unknown exception "into" packet_frame.c, but IMHO this one should remain.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14608 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFixed indentation and removed control characters, in an attempt to understand why...
lego [Fri, 10 Jun 2005 16:23:22 +0000 (16:23 +0000)]
Fixed indentation and removed control characters, in an attempt to understand why windows fail to compile.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14607 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoInitial checkin of the 32 bit tektronix k12 binary format (rf5)
lego [Fri, 10 Jun 2005 16:01:16 +0000 (16:01 +0000)]
Initial checkin of the 32 bit tektronix k12 binary format (rf5)

There is still much to do, but at the very least it can import files allowing the user to choose which protocols handle the diferent sources.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14606 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoadd Julian Onions
ulfl [Thu, 9 Jun 2005 22:49:08 +0000 (22:49 +0000)]
add Julian Onions

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14605 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agofrom Julian Onions: add more about protocol dissection to the developer's guide
ulfl [Thu, 9 Jun 2005 22:46:41 +0000 (22:46 +0000)]
from Julian Onions: add more about protocol dissection to the developer's guide

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14604 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoraise plugin version from 0.1.0 to 0.1.1 as some bugs were found using fuzz-test...
ulfl [Thu, 9 Jun 2005 20:08:39 +0000 (20:08 +0000)]
raise plugin version from 0.1.0 to 0.1.1 as some bugs were found using fuzz-test.sh since the last Ethereal release

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14603 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agofix positions of create_console()/destroy_console() calls for help and version output
ulfl [Thu, 9 Jun 2005 19:58:02 +0000 (19:58 +0000)]
fix positions of create_console()/destroy_console() calls for help and version output

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14602 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agobugfix: don't crash, if cf->filename is NULL (which happens if an invalid capture...
ulfl [Thu, 9 Jun 2005 19:55:55 +0000 (19:55 +0000)]
bugfix: don't crash, if cf->filename is NULL (which happens if an invalid capture filter is entered)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14601 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoadd some more details of the RT protocols frame ID's
ulfl [Thu, 9 Jun 2005 19:52:10 +0000 (19:52 +0000)]
add some more details of the RT protocols frame ID's

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14600 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoadd some more details to the files section
ulfl [Thu, 9 Jun 2005 19:49:56 +0000 (19:49 +0000)]
add some more details to the files section

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14599 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoChange "colorfilter" to "colorfilters". Fix up whitespace.
gerald [Thu, 9 Jun 2005 18:24:55 +0000 (18:24 +0000)]
Change "colorfilter" to "colorfilters".  Fix up whitespace.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14598 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd dissection of parlay
etxrab [Thu, 9 Jun 2005 17:25:40 +0000 (17:25 +0000)]
Add dissection of parlay
www.parlay.org

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14597 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agowe possibly have global cfilters/dfilters files now
ulfl [Thu, 9 Jun 2005 08:03:34 +0000 (08:03 +0000)]
we possibly have global cfilters/dfilters files now

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14596 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoprovide global default files for cfilters/colorfilters/dfilters
ulfl [Thu, 9 Jun 2005 07:43:32 +0000 (07:43 +0000)]
provide global default files for cfilters/colorfilters/dfilters

at least the colorfilters file needs some more "finetuning"

NSIS (Win32): install these files into the Ethereal Program dir, but don't overwrite existing ones

makefile.am: I've added the three files to EXTRA_DIST and pkgdata_DATA, which *seems* to be the right places

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14595 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoTry to read the "cfilters"/"dfilters" config files from the global path (program...
ulfl [Thu, 9 Jun 2005 06:58:03 +0000 (06:58 +0000)]
Try to read the "cfilters"/"dfilters" config files from the global path (program dir), if no personal versions of these files are available.

This is the same behaviour, as we do it for the colorfilters/preferences/... files already.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14594 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Mike Duigou
etxrab [Thu, 9 Jun 2005 05:40:26 +0000 (05:40 +0000)]
From Mike Duigou
Minor corrections to README.developer and README.tapping

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14593 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Tim Endean:
etxrab [Thu, 9 Jun 2005 04:28:13 +0000 (04:28 +0000)]
From Tim Endean:
Check for tvb.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14592 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Olivier Jacques,
etxrab [Wed, 8 Jun 2005 18:53:11 +0000 (18:53 +0000)]
From Olivier Jacques,
- beautify TCAP decoding without upper dissector associated.
With a couple of if (parameter_tvb) trown in to hopfully fix a Buildbot crash output

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14591 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Olivier Jacques,
etxrab [Wed, 8 Jun 2005 18:52:34 +0000 (18:52 +0000)]
From Olivier Jacques,
- beautify TCAP decoding without upper dissector associated.
With a couple of if (parameter_tvb) trown in to hopfully fix a Buildbot crash output

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14590 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoBreak out of an infinite loop. Fixes bug 232.
gerald [Wed, 8 Jun 2005 15:32:00 +0000 (15:32 +0000)]
Break out of an infinite loop.  Fixes bug 232.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14589 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agofix a problem if the tools have a space char in their path
ulfl [Wed, 8 Jun 2005 06:40:17 +0000 (06:40 +0000)]
fix a problem if the tools have a space char in their path

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14588 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoadd some general and some cygwin related comments
ulfl [Wed, 8 Jun 2005 06:33:49 +0000 (06:33 +0000)]
add some general and some cygwin related comments

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14587 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoCahnge ssn range
etxrab [Wed, 8 Jun 2005 05:06:30 +0000 (05:06 +0000)]
Cahnge ssn range

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14586 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Tim Endean:
etxrab [Wed, 8 Jun 2005 05:04:26 +0000 (05:04 +0000)]
From Tim Endean:
Fix ssn range

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14585 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix a typo.
etxrab [Wed, 8 Jun 2005 05:03:36 +0000 (05:03 +0000)]
Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14584 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom: Martin Mathieson
lego [Tue, 7 Jun 2005 23:25:46 +0000 (23:25 +0000)]
From: Martin Mathieson

fix cases where %d has been used instead of %u...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14583 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agomake sure that colifo gets set and put some other useful info there
lego [Tue, 7 Jun 2005 23:22:37 +0000 (23:22 +0000)]
make sure that colifo gets set and put some other useful info there

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14582 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd some ethertypes
etxrab [Tue, 7 Jun 2005 20:57:27 +0000 (20:57 +0000)]
Add some ethertypes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14581 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd some ethertypes
etxrab [Tue, 7 Jun 2005 20:56:54 +0000 (20:56 +0000)]
Add some ethertypes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14580 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoSome fixes from Tim Endean
etxrab [Tue, 7 Jun 2005 20:30:04 +0000 (20:30 +0000)]
Some fixes from Tim Endean

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14579 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoSome fixes from Tim Endean
etxrab [Tue, 7 Jun 2005 20:29:23 +0000 (20:29 +0000)]
Some fixes from Tim Endean

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14578 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Alejandro Vaquero:
etxrab [Tue, 7 Jun 2005 15:21:22 +0000 (15:21 +0000)]
From Alejandro Vaquero:
glib-object.h is is glib2 only.
 graph_analysis.c:47:25: glib-object.h: No such file or directory
 a patch for ths issue and also to correct the "first_item"
issue reported in "RE: [Ethereal-dev] Voip graph analysis "Save as" button"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14577 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoUsage of new #.FN_PARS directive instead of #.FN_BODY
kukosa [Tue, 7 Jun 2005 12:05:03 +0000 (12:05 +0000)]
Usage of new #.FN_PARS directive instead of #.FN_BODY

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14576 f5534014-38df-0310-8fa8-9805f1628bb7

18 years ago- usage of dissect_per_null() and dissect_ber_null()
kukosa [Tue, 7 Jun 2005 11:58:22 +0000 (11:58 +0000)]
- usage of dissect_per_null() and dissect_ber_null()
- new #.FN_PARS directive (implemented only for OCTET STRING and INTEGER now)
- set true value strings for named bits

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14575 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Tim Endean:
etxrab [Tue, 7 Jun 2005 05:50:28 +0000 (05:50 +0000)]
From Tim Endean:

- I have had to make some changes to packet-ber to allow for PRIVATE and APPLICATION tags.
- Both ANSI and ITU variants supported without configuration.
- Asn.1 dissectors can now register using an OID value as well as an SSN, the oid it tried first.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14574 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Tim Endean:
etxrab [Tue, 7 Jun 2005 05:49:57 +0000 (05:49 +0000)]
From Tim Endean:

- I have had to make some changes to packet-ber to allow for PRIVATE and APPLICATION tags.
- Both ANSI and ITU variants supported without configuration.
- Asn.1 dissectors can now register using an OID value as well as an SSN, the oid it tried first.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14573 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Tim Endean:
etxrab [Tue, 7 Jun 2005 05:49:06 +0000 (05:49 +0000)]
From Tim Endean:

- I have had to make some changes to packet-ber to allow for PRIVATE and APPLICATION tags.
- Both ANSI and ITU variants supported without configuration.
- Asn.1 dissectors can now register using an OID value as well as an SSN, the oid it tried first.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14572 f5534014-38df-0310-8fa8-9805f1628bb7