obnox/wireshark/wip.git
14 years agoTrivial reformatting
martinm [Wed, 17 Mar 2010 19:40:34 +0000 (19:40 +0000)]
Trivial reformatting

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32226 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd CMake tests for pcap_datalink_val_to_description() and
guy [Wed, 17 Mar 2010 19:31:33 +0000 (19:31 +0000)]
Add CMake tests for pcap_datalink_val_to_description() and
pcap_free_datalinks().

Sort the CMake tests in cmake/modules/FindPCAP.cmake into the same order
as the tests in the autoconf script, and note that, in the autoconf
script, the checks for pcap_open_dead() and pcap_freecode() do more than
just look for the routines in the library.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32225 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd HAVE_PCAP_FREE_DATALINKS to config.h.win32, as we've added it to
guy [Wed, 17 Mar 2010 19:31:19 +0000 (19:31 +0000)]
Add HAVE_PCAP_FREE_DATALINKS to config.h.win32, as we've added it to
config.nmake and Makefile.nmake.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32224 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Samu Varjonen: Locator presentation change for HIP dissector.
wmeier [Wed, 17 Mar 2010 18:23:56 +0000 (18:23 +0000)]
From Samu Varjonen: Locator presentation change for HIP dissector.
  See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3378

From me: use consistent (tab) indentation; replace use of C++ style comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32222 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMinor changes:
wmeier [Wed, 17 Mar 2010 18:08:45 +0000 (18:08 +0000)]
Minor changes:
- stdio/stdlib/string includes not req'd;
- Use less generic names for a few enum identifiers;
- Use coonsistent indentation in a few palces.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32221 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse the right #define value to check whether WinPcap has
guy [Wed, 17 Mar 2010 18:04:21 +0000 (18:04 +0000)]
Use the right #define value to check whether WinPcap has
pcap_free_datalinks().

*Set* that #define, while we're at it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32220 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoChange som proto_tree_add_text() regarding protocoll errors to
etxrab [Wed, 17 Mar 2010 17:13:55 +0000 (17:13 +0000)]
Change som proto_tree_add_text() regarding protocoll errors to
expert info's.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32219 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd heuristic table for Q.931 User-specific protocol
kukosa [Wed, 17 Mar 2010 15:25:20 +0000 (15:25 +0000)]
Add heuristic table for Q.931 User-specific protocol

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32218 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix crash when opening About box with disabled OID resolution.
rbalint [Wed, 17 Mar 2010 13:26:07 +0000 (13:26 +0000)]
Fix crash when opening About box with disabled OID resolution.
Thanks to Hilko Bengen for the detailed bug report at
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=574086

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32217 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate according to IANA registery.
jake [Wed, 17 Mar 2010 06:27:34 +0000 (06:27 +0000)]
Update according to IANA registery.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32216 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Harald Welte:
etxrab [Tue, 16 Mar 2010 21:38:03 +0000 (21:38 +0000)]
From Harald Welte:
Add new GSMTAP dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4508
(I incorporated the .h file into the .c file).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32214 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom KATAOKA Toshihiro:
etxrab [Tue, 16 Mar 2010 21:29:42 +0000 (21:29 +0000)]
From KATAOKA Toshihiro:
Diameter dictionary for MIPv4 is out of RFC4004.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4587

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32213 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix unused parameter 'num_fci' warning.
etxrab [Tue, 16 Mar 2010 21:09:47 +0000 (21:09 +0000)]
Fix unused parameter 'num_fci' warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32212 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Ed Beroset: Add missing include in tcp_dissect_pdus example.
wmeier [Tue, 16 Mar 2010 21:06:14 +0000 (21:06 +0000)]
From Ed Beroset: Add missing include in tcp_dissect_pdus example.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32211 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Matteo Valdina:
etxrab [Tue, 16 Mar 2010 20:38:34 +0000 (20:38 +0000)]
From Matteo Valdina:
Support for RTCP RFC-5104.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4582

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32210 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove trailing semicolon
krj [Tue, 16 Mar 2010 14:11:24 +0000 (14:11 +0000)]
Remove trailing semicolon

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32209 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd AMR-WB to the rtp_dyn_payload_type table.
etxrab [Tue, 16 Mar 2010 09:12:24 +0000 (09:12 +0000)]
Add AMR-WB to the rtp_dyn_payload_type table.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32208 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSome if (tree) cleanup
krj [Tue, 16 Mar 2010 07:53:48 +0000 (07:53 +0000)]
Some if (tree) cleanup

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32207 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAvoid some dead assignments
krj [Tue, 16 Mar 2010 07:49:13 +0000 (07:49 +0000)]
Avoid some dead assignments

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32206 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoWhitespace cleanup
krj [Tue, 16 Mar 2010 07:45:12 +0000 (07:45 +0000)]
Whitespace cleanup

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32205 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIndicate width of parent bitfield
krj [Tue, 16 Mar 2010 07:43:17 +0000 (07:43 +0000)]
Indicate width of parent bitfield

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32204 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoInline truth/false table
krj [Tue, 16 Mar 2010 07:36:00 +0000 (07:36 +0000)]
Inline truth/false table

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32203 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoThis adds a new dissector plugin: INTERLINK. This protocol is used in
girlich [Tue, 16 Mar 2010 06:58:25 +0000 (06:58 +0000)]
This adds a new dissector plugin: INTERLINK. This protocol is used in
(real and simulated) BMW cars for all kinds of gadget communication.
My plugin only dissects the high level infrastructure and not any particular
messages. It uses a heuristic dissector to detect INTERLINK packets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32202 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix some compiler warnings, clean up indentation a bit.
guy [Tue, 16 Mar 2010 03:31:44 +0000 (03:31 +0000)]
Fix some compiler warnings, clean up indentation a bit.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32201 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDeclare sip_uri_offset_init() as returning void and remove a couple unused variables
morriss [Mon, 15 Mar 2010 17:51:19 +0000 (17:51 +0000)]
Declare sip_uri_offset_init() as returning void and remove a couple unused variables

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32195 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSquelch some compiler warnings.
guy [Thu, 11 Mar 2010 00:36:45 +0000 (00:36 +0000)]
Squelch some compiler warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32165 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoPut context info in own subtree.
martinm [Tue, 9 Mar 2010 01:41:36 +0000 (01:41 +0000)]
Put context info in own subtree.
Use common function to append text to info column and tree items

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32151 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoWrite context fields inside own subtree.
martinm [Tue, 9 Mar 2010 01:39:08 +0000 (01:39 +0000)]
Write context fields inside own subtree.
Use common functions to append text to info column and tree items.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32150 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMark unused arguments.
guy [Tue, 9 Mar 2010 01:34:55 +0000 (01:34 +0000)]
Mark unused arguments.

Clean up white space.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32149 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse strtok_s on windows and strtok_r otherwise.
etxrab [Sun, 7 Mar 2010 18:56:35 +0000 (18:56 +0000)]
Use strtok_s on windows and strtok_r otherwise.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32138 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Alex Lindberg:
etxrab [Fri, 5 Mar 2010 18:35:44 +0000 (18:35 +0000)]
From  Alex Lindberg:
Permit registration of sub-dissectors for RTPC type APP messages.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4559

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32123 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoCheck if URI is SIP.
etxrab [Fri, 5 Mar 2010 15:16:30 +0000 (15:16 +0000)]
Check if URI is SIP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32122 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd comments and move some things inside if(tree).
etxrab [Fri, 5 Mar 2010 09:33:37 +0000 (09:33 +0000)]
Add comments and move some things inside if(tree).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32121 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd three more ICMPv6 type that only have a code of 0
jmayer [Thu, 4 Mar 2010 23:51:30 +0000 (23:51 +0000)]
Add three more ICMPv6 type that only have a code of 0

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32120 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoCopy over the introduction of Makefile.common change
jmayer [Thu, 4 Mar 2010 23:35:43 +0000 (23:35 +0000)]
Copy over the introduction of Makefile.common change
Replace FindGTK2 by version included in cmake 2.8.x

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32119 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoTry to fix build errors.
gerald [Thu, 4 Mar 2010 21:48:44 +0000 (21:48 +0000)]
Try to fix build errors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32118 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoReport accurate NACK count in stats (although not all values stored in array in tap).
martinm [Thu, 4 Mar 2010 20:58:54 +0000 (20:58 +0000)]
Report accurate NACK count in stats (although not all values stored in array in tap).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32117 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse a hash table to lookup the SIP header.
etxrab [Thu, 4 Mar 2010 20:35:45 +0000 (20:35 +0000)]
Use a hash table to lookup the SIP header.
It reduces the loading time of a file with 220 000 packets by 3s.
(SIP parsing should be optimized, if SIP is dissabled loading time is ~15s with SIP ~30s ).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32116 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoCheck that we haven't gone over MAX_NACKs!
martinm [Thu, 4 Mar 2010 17:49:51 +0000 (17:49 +0000)]
Check that we haven't gone over MAX_NACKs!

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32115 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Ivan Sy via bug 4555:
stig [Thu, 4 Mar 2010 15:07:56 +0000 (15:07 +0000)]
From Ivan Sy via bug 4555:
Added RFC5702 algo for packet-dns.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32114 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofrom Luis Ontanon:
etxrab [Thu, 4 Mar 2010 13:54:21 +0000 (13:54 +0000)]
from Luis Ontanon:
calculate the value of a ber integer by hand instead of just using
proto_tree_add_item().
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3230

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32113 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom LEGO via bug 3459:
stig [Thu, 4 Mar 2010 12:50:18 +0000 (12:50 +0000)]
From LEGO via bug 3459:
Add a callback to UAT to be called after the table has being updated,
use it to renew the snmp_ue_cache.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32112 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSquelch some compiler warnings.
guy [Thu, 4 Mar 2010 09:37:05 +0000 (09:37 +0000)]
Squelch some compiler warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32111 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago"capture-pcap-util.h" include <pcap.h>, and <pcap.h>, for better or
guy [Thu, 4 Mar 2010 07:19:43 +0000 (07:19 +0000)]
"capture-pcap-util.h" include <pcap.h>, and <pcap.h>, for better or
worse, has no include-once guards; include it only once.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32110 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Mark Wallis:
etxrab [Thu, 4 Mar 2010 06:09:03 +0000 (06:09 +0000)]
From Mark Wallis:
Improvements to newHNBAP Iuh dissector
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4553
Removed check_col() from the patch as it's no longer needed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32109 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Mark Wallis:
etxrab [Thu, 4 Mar 2010 05:56:59 +0000 (05:56 +0000)]
From Mark Wallis:
Improvements to new RUA Iuh dissector
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4552
Removed check_col() from the patch as it's no longer needed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32108 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoInclude inet_pton.obj when building TShark, as we now need it.
guy [Thu, 4 Mar 2010 02:42:07 +0000 (02:42 +0000)]
Include inet_pton.obj when building TShark, as we now need it.

(But it built on the Win64 buildbot; did Microsoft add it in later
releases?  If so, should we include it only if it's needed?)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32107 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoInclude "capture_ifinfo.h" to get declarations we require.
guy [Thu, 4 Mar 2010 01:33:56 +0000 (01:33 +0000)]
Include "capture_ifinfo.h" to get declarations we require.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32106 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIt uses isdigit(), so it requires <ctype.h>.
guy [Thu, 4 Mar 2010 01:33:19 +0000 (01:33 +0000)]
It uses isdigit(), so it requires <ctype.h>.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32105 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIn Wireshark and TShark, run dumpcap to get interface lists and lists of
guy [Thu, 4 Mar 2010 01:12:04 +0000 (01:12 +0000)]
In Wireshark and TShark, run dumpcap to get interface lists and lists of
link-layer header types for interfaces; if special privileges are
necessary to open capture devices, Wireshark and TShark shouldn't have
those privileges, but dumpcap should.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32104 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoImplementation of % bytes column.
jake [Wed, 3 Mar 2010 23:04:06 +0000 (23:04 +0000)]
Implementation of % bytes column.
Cleanup of souce code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32103 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoCast the result of the subtraction.
guy [Wed, 3 Mar 2010 21:44:41 +0000 (21:44 +0000)]
Cast the result of the subtraction.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32102 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSquelch MSVC compiler warnings - this should really be done better, e.g.
guy [Wed, 3 Mar 2010 21:03:59 +0000 (21:03 +0000)]
Squelch MSVC compiler warnings - this should really be done better, e.g.
with routines that can display times with a specified precision.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32101 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove one too many columns, causing havoc on display and sorting.
jake [Wed, 3 Mar 2010 21:01:41 +0000 (21:01 +0000)]
Remove one too many columns, causing havoc on display and sorting.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32100 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAllow for other time presentations.
jake [Wed, 3 Mar 2010 20:35:50 +0000 (20:35 +0000)]
Allow for other time presentations.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32099 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake the clean target work.
etxrab [Wed, 3 Mar 2010 20:01:53 +0000 (20:01 +0000)]
Make the clean target work.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32098 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd oids_cleanup and oids_init to libwireshark.def to make it compile.
etxrab [Wed, 3 Mar 2010 19:23:12 +0000 (19:23 +0000)]
Add oids_cleanup and oids_init to libwireshark.def to make it compile.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32097 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDisable OID resolution and loading SMI modules by default.
rbalint [Wed, 3 Mar 2010 17:19:30 +0000 (17:19 +0000)]
Disable OID resolution and loading SMI modules by default.
Add an option to enable OID resolution.
Add an option to suppress errors reported by libsmi.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32096 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix crash where was overwriting buffer for large PDUs when tracking retxs.
martinm [Wed, 3 Mar 2010 16:04:12 +0000 (16:04 +0000)]
Fix crash where was overwriting buffer for large PDUs when tracking retxs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32095 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSet the link dir for DCCH_Messages.
etxrab [Wed, 3 Mar 2010 15:54:57 +0000 (15:54 +0000)]
Set the link dir for DCCH_Messages.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32094 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix a gcc -Wshadow warning.
wmeier [Wed, 3 Mar 2010 15:47:28 +0000 (15:47 +0000)]
Fix a gcc -Wshadow warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32093 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix a test.
martinm [Wed, 3 Mar 2010 15:38:37 +0000 (15:38 +0000)]
Fix a test.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32092 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix re-NACk detection by updating channel *after* have compared with tap_info!
martinm [Wed, 3 Mar 2010 15:34:44 +0000 (15:34 +0000)]
Fix re-NACk detection by updating channel *after* have compared with tap_info!

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32091 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoChanged to use g_str_hash ()
etxrab [Wed, 3 Mar 2010 15:29:38 +0000 (15:29 +0000)]
Changed to use g_str_hash ()
sip_hash_func() function seem to not generate unique enough keys
if load generation tools are used with many thousands users.
Loading time ~5 min -> 30s

There is a memory leak in the sip_is_packet_resend area as well.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32090 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoremove check_col
etxrab [Wed, 3 Mar 2010 13:52:17 +0000 (13:52 +0000)]
remove check_col

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32089 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIts convenient to be able to filter on mac-lte.ulsch or mac-lte.dlsch.
martinm [Wed, 3 Mar 2010 11:57:21 +0000 (11:57 +0000)]
Its convenient to be able to filter on mac-lte.ulsch or mac-lte.dlsch.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32088 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Hitoshi Irino:
etxrab [Tue, 2 Mar 2010 06:12:21 +0000 (06:12 +0000)]
From Hitoshi Irino:
Displaying value and type of IPFIX reverse PEN elements in data records
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4399

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32082 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSquelch some compiler warnings, clean up indentation, clean up a
guy [Tue, 2 Mar 2010 00:06:20 +0000 (00:06 +0000)]
Squelch some compiler warnings, clean up indentation, clean up a
comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32076 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake it look a little like some other Makefile.common files, and get rid
guy [Mon, 1 Mar 2010 22:23:31 +0000 (22:23 +0000)]
Make it look a little like some other Makefile.common files, and get rid
of duplicate EXTRA_CNF.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32070 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom LEGO via bug 4395:
stig [Mon, 1 Mar 2010 22:12:38 +0000 (22:12 +0000)]
From LEGO via bug 4395:
Have the current_frame's last_item actually point to the last item.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32069 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom LEGO via bug 4405:
stig [Mon, 1 Mar 2010 22:11:20 +0000 (22:11 +0000)]
From LEGO via bug 4405:
Add the dot ('.') to the characters that can compose a name.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32068 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSort the geoip_db_ routines, add geoip_db_type(), remove extra
guy [Sun, 28 Feb 2010 21:13:40 +0000 (21:13 +0000)]
Sort the geoip_db_ routines, add geoip_db_type(), remove extra
geoip_db_get_paths().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32056 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdded svn:ignore targets.
stig [Sun, 28 Feb 2010 21:09:28 +0000 (21:09 +0000)]
Added svn:ignore targets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32055 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoConstify and clean up indentation.
guy [Sat, 27 Feb 2010 00:55:55 +0000 (00:55 +0000)]
Constify and clean up indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32021 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoConstify.
guy [Sat, 27 Feb 2010 00:51:14 +0000 (00:51 +0000)]
Constify.

Don't have variables that point to string constants, just make the
string constants be static const arrays.

strlen(array of unspecified size initialized with a string) ==
sizeof array - 1; the latter can be computed at compile time.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32020 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAlmost working out-of-tree builds for the documentation,
jmayer [Thu, 25 Feb 2010 12:30:44 +0000 (12:30 +0000)]
Almost working out-of-tree builds for the documentation,
with a few hacks right now:
- The tip.png, warning.png and note.png images are missing from the
  pdfs and I have no idea how to tell fop how to find them.
- Disabling/enabling building the guides via option currently doesn't
  work (probably too many macros :-), so comment out the subdir instead.
- Right now, in order to build the devleopers guide we need to do the
  following in the source docbook directory:
  touch wsdg_graphics/toolbar/dummy.dummy

Apart from these: The build works with a pristine docbook dir
(svn status --no-ignore).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32004 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoGenerate asn1/hnbap/Makefile.
guy [Thu, 25 Feb 2010 04:55:16 +0000 (04:55 +0000)]
Generate asn1/hnbap/Makefile.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31997 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMove HNBAP to dirty dissectors for now.
etxrab [Wed, 24 Feb 2010 22:19:54 +0000 (22:19 +0000)]
Move HNBAP to dirty dissectors for now.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31994 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix for bug 3926:
dimeg [Wed, 24 Feb 2010 22:17:52 +0000 (22:17 +0000)]
Fix for bug 3926:
Enhance decoding of TS2 channel list

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31993 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix for bug 4323 & 4511:
stig [Wed, 24 Feb 2010 20:24:05 +0000 (20:24 +0000)]
Fix for bug 4323 & 4511:
Call col_custom_prime_edt() when having custom columns on print and
export to csv and psml.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31990 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Neil Piercy:
etxrab [Wed, 24 Feb 2010 20:16:33 +0000 (20:16 +0000)]
From Neil Piercy:
Add 3GPP Home Node B Iuh protocol support (HNBAP & RUA)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4531
 - Added IE extension for HNBAP
 - Removed unused .h files

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31989 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Neil Piercy:
etxrab [Wed, 24 Feb 2010 20:15:31 +0000 (20:15 +0000)]
From Neil Piercy:
Add 3GPP Home Node B Iuh protocol support (HNBAP & RUA)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4531
 - Added IE extension for HNBAP
 - Removed unused .h files

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31988 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix for bug 4522:
jake [Wed, 24 Feb 2010 19:05:55 +0000 (19:05 +0000)]
Fix for bug 4522:
Don't offer "Wiki Protocol Page" and "Filter Field Reference" in the
context menu when a Text item is selected.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31987 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Jakub Zawadzki:
etxrab [Wed, 24 Feb 2010 12:59:09 +0000 (12:59 +0000)]
From Jakub Zawadzki:
Don't sigsegv on negative bd_len in bytes_to_str*

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31986 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoGSM SMS PDU TPVPF wrong interpretation.
etxrab [Wed, 24 Feb 2010 12:41:01 +0000 (12:41 +0000)]
GSM SMS PDU TPVPF wrong interpretation.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4524

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31985 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoPoint to the correct perl script in the autogenerated file + correct tabs
krj [Wed, 24 Feb 2010 12:28:04 +0000 (12:28 +0000)]
Point to the correct perl script in the autogenerated file + correct tabs

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31984 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMark variables as static
krj [Wed, 24 Feb 2010 08:46:29 +0000 (08:46 +0000)]
Mark variables as static

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31983 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoWe already pull in glib.h so use gboolean instead of int to declare boolean types.
krj [Wed, 24 Feb 2010 08:39:51 +0000 (08:39 +0000)]
We already pull in glib.h so use gboolean instead of int to declare boolean types.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31982 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMove the definition of the private data structure from wtap-int.h to the
guy [Wed, 24 Feb 2010 08:39:19 +0000 (08:39 +0000)]
Move the definition of the private data structure from wtap-int.h to the
iSeries capture processor.  Parse the start date into year/month/day at
the time we see it, rather than for every packet; that means we don't
need to allocate a buffer to hold the date as a string (a buffer which
we weren't ever freeing).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31981 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake do_test() static
krj [Wed, 24 Feb 2010 08:36:20 +0000 (08:36 +0000)]
Make do_test() static

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31980 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoConstify format string
krj [Wed, 24 Feb 2010 08:34:35 +0000 (08:34 +0000)]
Constify format string

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31979 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Hannes Diethelm via bug 4525:
stig [Wed, 24 Feb 2010 08:22:33 +0000 (08:22 +0000)]
From Hannes Diethelm via bug 4525:
Corrected values for IdentInfo (which was obviously wrong)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31978 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMoved charging_ase, s1ap and x2ap to ASN.1 dissectors list.
stig [Wed, 24 Feb 2010 08:18:15 +0000 (08:18 +0000)]
Moved charging_ase, s1ap and x2ap to ASN.1 dissectors list.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31977 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd new to_str.o/obj dependency to reassemble_test target
krj [Wed, 24 Feb 2010 08:13:58 +0000 (08:13 +0000)]
Add new to_str.o/obj dependency to reassemble_test target

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31976 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSome more ASN1 dissectors are now clean
krj [Wed, 24 Feb 2010 07:57:34 +0000 (07:57 +0000)]
Some more ASN1 dissectors are now clean

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31975 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDefine the private data structures for some particular capture file
guy [Wed, 24 Feb 2010 07:21:17 +0000 (07:21 +0000)]
Define the private data structures for some particular capture file
types in the modules for those capture file types, not in wtap-int.h, so
wtap-int.h doesn't have to change when the code to handle that
particular capture type changes, or a new capture file type is added.
(Ultimately, we should do this for all the private data structures.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31974 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd descriptions of a few more environment variables that affect *shark's operation
morriss [Wed, 24 Feb 2010 05:13:27 +0000 (05:13 +0000)]
Add descriptions of a few more environment variables that affect *shark's operation

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31973 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoGtkOptionMenu --> GtkComboBox
wmeier [Wed, 24 Feb 2010 01:22:07 +0000 (01:22 +0000)]
GtkOptionMenu --> GtkComboBox

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31972 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate (slightly) the description of ws_combo_box_clear_text_and_pointer().
wmeier [Wed, 24 Feb 2010 01:21:09 +0000 (01:21 +0000)]
Update (slightly) the description of ws_combo_box_clear_text_and_pointer().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31971 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoCalculate/show time between Msg3 and Msg4
martinm [Tue, 23 Feb 2010 22:28:42 +0000 (22:28 +0000)]
Calculate/show time between Msg3 and Msg4

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31970 f5534014-38df-0310-8fa8-9805f1628bb7