wmeier [Mon, 3 Aug 2009 23:18:59 +0000 (23:18 +0000)]
More minor cleanups:
- Move proto_register to near the end of the file as per convention;
- Remove unneeded #include <epan/reassemble.h>;
- Comment out unused ett[] array and associated;
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29284
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 3 Aug 2009 22:38:43 +0000 (22:38 +0000)]
Minor cleanups:
- Comment out code which creates two dissector tables and then
stores a preference value in each of them;
AFAICT the tables are not accessed elsewhere;
- Comment out the no longer required prefs callback specification
in proto_register;
- "if (... == -1)" not req'd in proto_register;
- Remove unused proto_reg_wimax function.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29283
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 3 Aug 2009 22:09:08 +0000 (22:09 +0000)]
Various minor cleanups:
- Do all find_dissector() calls only once during proto_reg_handoff
(not each time a sub-dissector is called when dissecting frames).
- Move proto_register & proto_reg_handoff to the end of the file as per convention;
- Move a global variables to be local;
- Change a global variable to be static;
- Remove unneeded multiple #include <string.h>
- Remove an unneeded variable and a few unneeded lines of code.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29282
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 3 Aug 2009 21:17:30 +0000 (21:17 +0000)]
Clean up indentation somewhat.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29281
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Mon, 3 Aug 2009 21:12:41 +0000 (21:12 +0000)]
From Gerasimos Dimitriadis:
Added decoding support for the High Layer Compatibility IE in DTAP and updated
the relevant part in Q.931. Also some minor enhancements in Q.931.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29280
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 3 Aug 2009 21:07:08 +0000 (21:07 +0000)]
Thou shalt terminate thy value_string arrays with {0, NULL}.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29279
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 3 Aug 2009 19:50:35 +0000 (19:50 +0000)]
Add a null pointer check. Remove some unused variables.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29278
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Mon, 3 Aug 2009 18:23:04 +0000 (18:23 +0000)]
From Ivan Sy:
Support for Host Identity Protocol (HIP) Domain Name System (DNS) Extension.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29277
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 3 Aug 2009 18:06:36 +0000 (18:06 +0000)]
Remove 1 commented-out #include inadvertantly committed.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29276
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 3 Aug 2009 17:25:17 +0000 (17:25 +0000)]
Add some debug code (commented out) to check for duplicate dissector port registrations,
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29275
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 3 Aug 2009 16:21:55 +0000 (16:21 +0000)]
Reword some help text slightly.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29274
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 3 Aug 2009 16:18:06 +0000 (16:18 +0000)]
Use find_dissector() instead of create_dissector_handle();
Fix some indentation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29273
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 3 Aug 2009 15:18:44 +0000 (15:18 +0000)]
Do find_dissector_table() in proto_reg_handoff().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29272
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 3 Aug 2009 14:17:31 +0000 (14:17 +0000)]
(Trivial) Fix two typos.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29271
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 3 Aug 2009 09:58:14 +0000 (09:58 +0000)]
Added missing packet-usb-hid.h
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29270
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 3 Aug 2009 08:05:44 +0000 (08:05 +0000)]
Handle usb_hid_item_usage_vals as range_string.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29269
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Sun, 2 Aug 2009 19:54:33 +0000 (19:54 +0000)]
Do dissector_add() only if port non-zero; register dissector for "decode-as".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29268
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Sun, 2 Aug 2009 19:20:20 +0000 (19:20 +0000)]
packet-stun2 registers for TCP & UDP port 3478 so packet-stun need not register for same.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29267
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Sun, 2 Aug 2009 19:17:09 +0000 (19:17 +0000)]
Change default range from 1401,1401 to 1401 so that the port isn't double-registered.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29266
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Sun, 2 Aug 2009 19:09:36 +0000 (19:09 +0000)]
Don't do dissector_add twice on TCP port 3689;
packet-daap requests registration on that port via http_dissector_add
and thus packet-http does not need to do a default registration on that port.
Also: fix a typo in a comment.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29265
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 2 Aug 2009 15:03:29 +0000 (15:03 +0000)]
[Automatic manuf and enterprise-numbers update for 2009-08-02]
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29262
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Sun, 2 Aug 2009 12:58:57 +0000 (12:58 +0000)]
Remove unneeded #include <epan/emem.h>; fix some indentation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29261
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Sun, 2 Aug 2009 12:53:14 +0000 (12:53 +0000)]
Add additional cypher types.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29260
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Sun, 2 Aug 2009 12:11:38 +0000 (12:11 +0000)]
Fix for bug 3800:
Correctly track the size of Feedback Control Information in Payload specific RTCP feedback packet.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29259
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Sat, 1 Aug 2009 09:52:12 +0000 (09:52 +0000)]
Remember Msg3 bytes and compare with Msg4 Contention Resolution bodies.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29258
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 31 Jul 2009 23:38:02 +0000 (23:38 +0000)]
Fix indentation, get rid of a comment that might no longer apply (dump
*what* as hex? The stuff we now display as generic fields?).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29257
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 31 Jul 2009 22:16:29 +0000 (22:16 +0000)]
From Adam Nielsen via bug 3659:
Here is a patch against SVN that implements preliminary support for USB HID
devices. At the moment it only dissects the initial set up packets (which you
will see if you hotplug a keyboard or mouse.)
The patch also fixes a minor bug in the USB dissector code which reported
certain packets as malformed due to miscounting bytes, and it reports control
packet data and padding data in a more user-friendly manner.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29256
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 31 Jul 2009 20:13:53 +0000 (20:13 +0000)]
Completely remove an unused variable, don't just comment it out
(especially with a C++/C99-style comment that not all compilers used to
compile Wireshark accept).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29255
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 31 Jul 2009 19:19:25 +0000 (19:19 +0000)]
From Holger Freyther via bug 3776:
Part 1:
Rename packet-gsm_abis_ip.c to packet-gsm_ipa.c.
Part 2:
Rename to the content to match the filename.
Part 3:
Add GSM A/SCCP support to the packet-gsm_ipa.c dissector
Adjusted patch to take laforge's comment into account. Use guint16 for the
length and use the ntohs routine to convert the length.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29254
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 31 Jul 2009 16:37:53 +0000 (16:37 +0000)]
From Ivan Sy via bug 3797:
Support for SPF RR (RFC 4408)
- this has the same format as TXT RR (see section 3.1.1) below.
Currently wireshark 1.2.1 shows this as Unknown type 99
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29253
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Fri, 31 Jul 2009 07:05:43 +0000 (07:05 +0000)]
From Ivan Sy:
Add support for SSHFP RR (RFC 4255).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29252
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Fri, 31 Jul 2009 07:02:02 +0000 (07:02 +0000)]
Include packet_info.h before ui_utils.h since we just started passing a
packet_info structure to one of the functions.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29251
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Fri, 31 Jul 2009 06:51:27 +0000 (06:51 +0000)]
From Ivan Sy:
NAPTR RR (RFC 3403) replacement MUST be a fully qualified domain-name.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29250
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 30 Jul 2009 23:47:36 +0000 (23:47 +0000)]
Remove more unused variables.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29249
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 30 Jul 2009 21:40:22 +0000 (21:40 +0000)]
Fix warnings:
the behavior of x = x++ is undefined by the ANSI C standard -
they obviously just meant x++;
get rid of unused variables.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29248
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 30 Jul 2009 21:11:26 +0000 (21:11 +0000)]
From swapnil:
Packet-gtpv2.c dissector extended to support more IE's.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29247
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 30 Jul 2009 17:54:58 +0000 (17:54 +0000)]
From Kovarththanan Rajaratnam via bug 3506:
The exception throwing code in except.c/h should be annotated with
"noreturn" to indicate that they never return. Running static analysis
on Wireshark without this annotation causes a lot of false positives
since these analyzers assume that the exception handling code are
ordinary functions that will eventually return.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29246
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 30 Jul 2009 17:22:00 +0000 (17:22 +0000)]
Remove a couple of unused variables.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29245
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Thu, 30 Jul 2009 16:53:33 +0000 (16:53 +0000)]
Show backoff indicator value in subheader tree root.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29244
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 30 Jul 2009 16:17:46 +0000 (16:17 +0000)]
Remove some unused variable assignments.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29243
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 30 Jul 2009 00:40:32 +0000 (00:40 +0000)]
Remove some unused variables.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29242
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Wed, 29 Jul 2009 23:18:34 +0000 (23:18 +0000)]
Fix a typo
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29241
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Wed, 29 Jul 2009 22:54:28 +0000 (22:54 +0000)]
Function dissect_zcl_attr_data_type() unused: comment it out
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29240
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Wed, 29 Jul 2009 22:33:08 +0000 (22:33 +0000)]
Fix a potential crash and do various other minor changes:
- Fix an hf[] entry which had an invalid "strings" field which could cause a crash;
- Remove unneeded #includes;
- Make most functions & etc static;
- Remove declarations for functions never defined;
- Fix certain comments to refer to the correct function names;
- Change global variable to be local to proto_reg_handoff...
- ...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29239
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 29 Jul 2009 21:32:49 +0000 (21:32 +0000)]
From Kovarththanan Rajaratnam:
This patch fixes the "Decode as" crash. We now freeze the packetlist before
attempting to clear it. This way we don't have to issue a row deleted signal
either.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29238
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 29 Jul 2009 20:58:47 +0000 (20:58 +0000)]
Add pinfo to new_packet_list_append() this should give us the abillity
to store (most) of the underlying data rather than the strings in the store and render it when we need it, thuss saving storage space and loading time.
Idealy we should not store the complete fdata or pinfo structures
but rather just the data relevant to the currently selected/used columns. I'm not entierly sure how to accomplish that however.
Dynamically allocated array to hold pointers to the actual data?
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29237
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Wed, 29 Jul 2009 20:24:10 +0000 (20:24 +0000)]
From Chris Costa: Fix Bug 3786: "NDMP fragmentation fails when final fragment is very small".
(See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3786)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29236
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 29 Jul 2009 19:39:17 +0000 (19:39 +0000)]
Add packet-zbee-zcl.h to the source tarball.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29235
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Wed, 29 Jul 2009 18:26:55 +0000 (18:26 +0000)]
From Neil Piercy:
The Cert Authority hashes in the IKEv2 Cert Request are not dissected properly:
the display offset is not correctly moved on, so the same info is displayed for
all Cert Authority fields.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29234
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Wed, 29 Jul 2009 15:31:25 +0000 (15:31 +0000)]
Mark an unused argument.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29233
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 29 Jul 2009 11:29:53 +0000 (11:29 +0000)]
zigbee cluster dissector,
modified from entry in bug 3765 so it compiles cleanly
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29232
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 29 Jul 2009 10:59:31 +0000 (10:59 +0000)]
start describing ReportEventW in the IDL and make use of the "bitmap"
for EventTypes.
This addresses also bug 3552 with the until now unusued code.
The eventlog dissector is very incomplete.
While the protocol specification is available now, what is lacking is
example capture files to test with when implementing more of the IDL
definitions.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29231
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 29 Jul 2009 10:41:24 +0000 (10:41 +0000)]
Fixup the correct names of the parameters for OpenEventLogW
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29230
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 29 Jul 2009 10:28:10 +0000 (10:28 +0000)]
update the idl to correctly dissect the read eventlog w flags as a
bitmap and not as a uint32
this addresses bug 3691 (that was already manually addressed by hand
in the generated dissector)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29229
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 29 Jul 2009 10:01:14 +0000 (10:01 +0000)]
Break the aes set ket/decrypt/encrypt out from airpdcap_raindoll into
its own crypt-aes.
change the integer types to glib style integers
this may/will be helpful if/when we implement our own version of
kerberos
aes decryption of dcerpc since the existing libraries can not (yet)
handle when header signing is used.
we should implement our own decryption of this for cfx+aes just as we
did for classic+arcfour
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29228
f5534014-38df-0310-8fa8-
9805f1628bb7
kukosa [Wed, 29 Jul 2009 09:13:03 +0000 (09:13 +0000)]
Support for IPv6 addresses in URI
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29227
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Wed, 29 Jul 2009 07:10:02 +0000 (07:10 +0000)]
From Ivan Sy:
Support for DLV RR (RFC 4431) and SHA-256 Digest for DS RR (RFC 4509).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29226
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 28 Jul 2009 22:18:19 +0000 (22:18 +0000)]
Make mark frame work.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29225
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 28 Jul 2009 20:56:36 +0000 (20:56 +0000)]
Clarify (slightly) some comments;
Add a comment as to what looks like incorrect code.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29224
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 28 Jul 2009 20:46:23 +0000 (20:46 +0000)]
From Kovarththanan Rajaratnam:
Enable popup menu in packet list view.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29223
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 28 Jul 2009 18:29:15 +0000 (18:29 +0000)]
Pacify the build bot.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29222
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Tue, 28 Jul 2009 17:27:59 +0000 (17:27 +0000)]
Update the adapter name check to match the buildbot.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29221
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 28 Jul 2009 16:20:05 +0000 (16:20 +0000)]
Set reftime without recreating the packet list.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29220
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 28 Jul 2009 14:11:08 +0000 (14:11 +0000)]
update samr.idl and remove a keyword we no longer support in pidl
regenerate samr and frstrans with the new version of pidl
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29219
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 28 Jul 2009 14:07:15 +0000 (14:07 +0000)]
Fix setting of timestamp_precision.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29218
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 28 Jul 2009 13:53:10 +0000 (13:53 +0000)]
From Stefan Metzmacher
add generated FRSTRANS dissectors and add them to the build
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29217
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 28 Jul 2009 13:50:22 +0000 (13:50 +0000)]
From Stefan Metzmacher :
Add IDL file for FRSTRANS
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29216
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 28 Jul 2009 13:39:42 +0000 (13:39 +0000)]
regenerate SAMR using the new version of pidl
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29215
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 28 Jul 2009 13:38:46 +0000 (13:38 +0000)]
update pidl to the newest version from samba
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29214
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 28 Jul 2009 13:01:41 +0000 (13:01 +0000)]
When we passed the crytobuffer to krb5_c_decrypt() we never actually
verified that we did have enough data in the buffer/tvb, which could
lead to a SEGV.
(for example if we enable KRB5 decryption but we do NOT use TCP
reassembly, and the encrypted data goes beyong the end of the current
segment)
Change the signature to decrypt_krb5_data() to take a TVB instead of a
buffer+length.
Actually check that we do have the entire encrypted PDU before calling
out to the kerberos libraries.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29213
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 28 Jul 2009 10:53:57 +0000 (10:53 +0000)]
Fix setting of new time format.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29212
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 28 Jul 2009 09:26:18 +0000 (09:26 +0000)]
Whitespace change.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29211
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 28 Jul 2009 07:18:05 +0000 (07:18 +0000)]
From: Matthieu Patou <mat+Informatique.Samba@matws.net>
Date: Mon, 27 Jul 2009 08:55:55 +0000 (+0200)
Subject: patch_ldap_260709
Add a few additional LDAP OIDs
and increase the maximum SASL blob size to be 1M instead of 256kb
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29210
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 27 Jul 2009 23:16:29 +0000 (23:16 +0000)]
Add Chris Costa to AUTHORS
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29209
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 27 Jul 2009 21:59:01 +0000 (21:59 +0000)]
Improve defragmentation:
1. Prevent tcpencap (ipsec-tcp) from incorrectly dissecting NDMP PDU fragments;
(Essentially: register NDMP as the dissector for the conversation);
Allows correct NDMP fragment reassembly whether or not the
TCP "Try heuristic sub-dissectors first" preference is enabled.
Fixes Bug #3755 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3755)
2. Use a registered init routine to init the fragment and reassembled tables
each time a complete capture dissection is (re)started.
Fixes a crash.
3. Don't register on TCP port 10000 since the tcpencap dissector needs to own this
port. (The NDMP dissector is a heuristic dissector).
4. Strengthen the heuristic checking slightly.
5. Other minor changes.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29208
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 27 Jul 2009 14:47:12 +0000 (14:47 +0000)]
From Vladimir Smrekar:
Change, that fix infinite loop for dissections of elements:
- Pulse notification
- Line Information
- PSTN FSM state
- Autonomous signalling sequence
- Sequence response
- Performance grading
- Rejection cp cause
Me prefix hf vars with hf_v52_
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29207
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 27 Jul 2009 14:45:25 +0000 (14:45 +0000)]
Move proto_reg_handoff to the end ...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29206
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 27 Jul 2009 13:59:53 +0000 (13:59 +0000)]
reassemble.h: update two comments; reassemble.c: correct a typo.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29205
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 27 Jul 2009 13:08:17 +0000 (13:08 +0000)]
From Gerasimos Dimitriadis:
Decoding support for 4 DTAP IEs.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3777
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29204
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 27 Jul 2009 08:33:26 +0000 (08:33 +0000)]
From Kovarththanan Rajaratnam:
Only fill in frame_data vals when needed.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29203
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 27 Jul 2009 03:34:57 +0000 (03:34 +0000)]
From Kovarththanan Rajaratnam:
Use frame_data values .
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29202
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 26 Jul 2009 22:18:11 +0000 (22:18 +0000)]
Revert change by mistake.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29201
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 26 Jul 2009 22:16:36 +0000 (22:16 +0000)]
"Create" the time cols when we render them making change of time format fast.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29200
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 26 Jul 2009 22:11:46 +0000 (22:11 +0000)]
From Kovarththanan Rajaratnam:
- Don't issue a row_inserted signal. Rely on our caller to have
disconnected the model from the view.
- Removing col_fmt from row_data. It wasn't being used. If we need to store
the column format in the future that should probably be placed in the
PacketList instead of the PacketListRecord
2) Remove double allocation of col_text. Now we allocate it in
new_packet_list_append() and pass it on to packet_list_append_record()
3) Use se_alloc instead of se_alloc0 because we explictly set all the
parameters we use.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29199
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 26 Jul 2009 15:03:27 +0000 (15:03 +0000)]
[Automatic manuf and enterprise-numbers update for 2009-07-26]
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29196
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 26 Jul 2009 10:34:07 +0000 (10:34 +0000)]
From Kovarththanan Rajaratnam:
Only clear packet list store if we need to redissect.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29195
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 26 Jul 2009 00:32:22 +0000 (00:32 +0000)]
Note that libpcap fails if it tries to read a file with a snapshot
length > 65535, so we shouldn't use a larger value.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29194
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Sat, 25 Jul 2009 20:13:46 +0000 (20:13 +0000)]
Remove two unused variables and mark a function paramter as unused
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29193
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sat, 25 Jul 2009 10:40:10 +0000 (10:40 +0000)]
From Kovarththanan Rajaratnam:
Include needed header (unbreak OSX buildbot)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29192
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sat, 25 Jul 2009 09:45:35 +0000 (09:45 +0000)]
From Kovarththanan Rajaratnam:
packet_goto_next_previous_frame
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29191
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sat, 25 Jul 2009 07:50:53 +0000 (07:50 +0000)]
From Kovarththanan Rajaratnam:
New packet list: enable goto first/last packet (Optimized)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29190
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Sat, 25 Jul 2009 03:23:37 +0000 (03:23 +0000)]
Update my e-mail address with a reference to the AUTHORS file
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29189
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 24 Jul 2009 21:25:21 +0000 (21:25 +0000)]
From Kovarththanan Rajaratnam:
New packet list: enable packet history
Me: Add a comment.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29188
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 24 Jul 2009 13:50:57 +0000 (13:50 +0000)]
Use g_slice if glib >=2.10
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29187
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 24 Jul 2009 08:10:33 +0000 (08:10 +0000)]
When using the new packet list select the first packet when the file read is complete. This should take care of the crash when closing WS.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29186
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 23 Jul 2009 21:25:02 +0000 (21:25 +0000)]
Use consistent indentation ...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29185
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 23 Jul 2009 20:53:44 +0000 (20:53 +0000)]
Fix some whitespace ....
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29184
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 23 Jul 2009 20:52:54 +0000 (20:52 +0000)]
Fix emacs editor modeline to be a 'safe" value.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29183
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 23 Jul 2009 20:36:16 +0000 (20:36 +0000)]
From Gerasimos Dimitriadis:
Minor enhancement to LAI decoding.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3770
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29182
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 23 Jul 2009 18:36:25 +0000 (18:36 +0000)]
Saved by removing the bell.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29181
f5534014-38df-0310-8fa8-
9805f1628bb7