guy [Mon, 2 Jul 2001 02:09:26 +0000 (02:09 +0000)]
Get rid of a now-unused variable; it's the only variable of type
"isis_hdr_t", so we can get rid of the definition of that as well.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3630
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 2 Jul 2001 01:46:22 +0000 (01:46 +0000)]
Fetch fields from the ISIS header one at a time, rather than snarfing
the entire ISIS header into a structure - that way, if we run out of
packet data in the middle of the header, we at least dissect the stuff
for which we have packet data.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3629
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 2 Jul 2001 01:41:25 +0000 (01:41 +0000)]
Fetch values only once from the tvbuff, and save them in a variable,
rather than calling the tvbuff accessor multiple times.
Use "proto_tree_add_item()" for fields whose values we don't care about
in the code.
BTW, apologies to Hannes Gredler - the changes with
More IS-IS updates.
HELLO message support in RSVP.
were from him, but I forgot to put that in the checkin message.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3628
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 2 Jul 2001 00:46:21 +0000 (00:46 +0000)]
Fix the file name in the comment, and update Gerald's e-mail address.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3627
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 2 Jul 2001 00:19:34 +0000 (00:19 +0000)]
Tvbuffified ISIS dissector, from Ronnie Sahlberg.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3626
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 1 Jul 2001 20:37:02 +0000 (20:37 +0000)]
Fix a typo, discovered whilst testing the tvbuffified ISIS dissector
(the tvbuffified version is correct here; I'll check this in for
reference purposes, even though I plan to check in the tvbuffified
version later).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3625
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 30 Jun 2001 09:32:44 +0000 (09:32 +0000)]
From Ronnie Sahlberg: fix the AFS macros to parse the element count in
AFSCBFids and AFSCBs as a 32-bit integer rather than an 8-bit integer.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3624
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 29 Jun 2001 20:49:29 +0000 (20:49 +0000)]
From Frank Singleton: when GIOP sub-dissectors register themselves, have
them supply a protocol ID, and have the code that calls the
subdissectors check if the protocol is enabled and, if it isn't, not
call the sub-dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3623
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 29 Jun 2001 18:55:50 +0000 (18:55 +0000)]
MSNIP support, from Ronnie Sahlberg.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3622
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 29 Jun 2001 09:46:54 +0000 (09:46 +0000)]
Create a routine to do the tvbuff-length-adjusting and
"pinfo->{len,captured_len}"-adjusting currently done by the IP
dissector, make the IP dissector call that rather than doing the work
itself, make the IPv6 dissector call that rather than just adjusting the
tvbuff length itself, and make the IPX dissector call that rather than
just adjusting "pi.{len,captured_len}" itself.
This cleans things up a bit, and causes trailers to be properly reported
in IPX-over-Ethernet frames.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3621
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 29 Jun 2001 09:42:45 +0000 (09:42 +0000)]
Update Gerald's e-mail address.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3620
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 28 Jun 2001 19:15:11 +0000 (19:15 +0000)]
Include <string.h> to get "memcmp()" and "memcpy()" declared.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3619
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 28 Jun 2001 08:05:26 +0000 (08:05 +0000)]
Updates from Mark Burton.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3618
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Thu, 28 Jun 2001 02:42:48 +0000 (02:42 +0000)]
Handle a few of the NCP types from the traces sent in by Pete,
<psailor@uswest.net>
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3617
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 27 Jun 2001 20:41:16 +0000 (20:41 +0000)]
Improved support for CORBA IDL "fixed" types, and other updates, from
Frank Singleton.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3616
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 27 Jun 2001 20:38:56 +0000 (20:38 +0000)]
Improved support for CORBA IDL "fixed" types, and fix to handling of
explicit and heuristic GIOP dissectors, from Frank Singleton.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3615
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 27 Jun 2001 20:19:19 +0000 (20:19 +0000)]
MRDISC support, from Ronnie Sahlberg.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3614
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 27 Jun 2001 10:00:14 +0000 (10:00 +0000)]
Don't offer the ability to edit capture filters if Ethereal wasn't
linked with libpcap.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3613
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 27 Jun 2001 08:36:08 +0000 (08:36 +0000)]
Fix a problem that shows up if you build without libpcap.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3612
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 27 Jun 2001 07:47:50 +0000 (07:47 +0000)]
Replace "--enable-pcap" with "--with-pcap", and if an argument is
specified to "--with-pcap", add that directory to the include file and
library search paths, so that you can use "--with-pcap=DIR" to search
for libpcap in a directory other than the standard ones (either because
it was installed somewhere other than under "/usr" or "/usr/local", or
because you want to use a special version you've installed rather than
the standard one).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3611
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 26 Jun 2001 20:52:19 +0000 (20:52 +0000)]
If length arguments to "%*s" aren't of type "int", cast them to "int",
as that's what C requires them to be.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3610
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 26 Jun 2001 20:50:30 +0000 (20:50 +0000)]
Add HFILL to explicitly fill in some additional structure members.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3609
f5534014-38df-0310-8fa8-
9805f1628bb7
itojun [Tue, 26 Jun 2001 17:31:36 +0000 (17:31 +0000)]
indentation consistencies.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3608
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 25 Jun 2001 08:36:48 +0000 (08:36 +0000)]
Remove second entry for Michael Rozhavsky - "Additional OSPF LSA types
and opaque-options flag" falls under the broader heading of "OSPF
enhancements".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3607
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 25 Jun 2001 08:10:38 +0000 (08:10 +0000)]
A better fix - we don't use "assigned" if the action was E_DECODE_NO, so
don't bother fetching it if the action is E_DECODE_NO; that means we can
also avoid fetching the currently selected row if the action is
E_DECODE_NO, so the fact that we've cleared the selection if the action
is E_DECODE_NO doesn't matter.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3606
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 25 Jun 2001 07:57:50 +0000 (07:57 +0000)]
In "decode_network()", get the information about the currently selected
row *before* calling "decode_simple()", as, if the "Do not decode" radio
button is selected, "decode_simple()" will clear the current selection.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3605
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 23 Jun 2001 19:45:12 +0000 (19:45 +0000)]
More IS-IS updates.
HELLO message support in RSVP.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3604
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 23 Jun 2001 19:14:42 +0000 (19:14 +0000)]
Include "strerror.h" only on platforms that don't declare it in a
standard header file, so we get the platform's declaration (which may
include, for example, "dllexport"-type declarations) rather than the
"workaround for platforms that lack it" declaration.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3603
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 23 Jun 2001 19:10:27 +0000 (19:10 +0000)]
"index()" is non-standard, and MSVC++ 6.0 complained about it; the ANSI
C standard has "strchr()" instead, so use it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3602
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Fri, 22 Jun 2001 16:29:15 +0000 (16:29 +0000)]
Support CIDR notation in IPv4 address filtering.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3601
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 22 Jun 2001 08:12:11 +0000 (08:12 +0000)]
Allow the 802.11 management-frame protocol to be disabled.
Don't bother doing the WEP processing and child-tvbuff construction for
frames other than management and data frames, as they have no payload to
be WEP-encrypted or dissected.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3600
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 22 Jun 2001 07:46:25 +0000 (07:46 +0000)]
Dissect the payload of a management frame as a separate protocol, so
that you can open up that protocol without opening up the 802.11 MAC
header; this can save some screen real estate.
Make the tree item for all the WEP parameters a text item, rather than a
"string" field with a null string pointer, as "strings" with null string
pointers give the filtering code gastric distress.
Dissect the WEP initialization vector as an FT_UINT24 (as it's a 3-byte
field), and dissect the key ID as part of an FT_UINT8 (as it's in an
8-bit byte).
After dissecting the frame control field, dissect the rest of the header
in one switch statement, and then:
handle WEP-encrypted frames with common code for all frame
types;
handle the payload of other frames.
(If we can supply the relevant keys to Ethereal, we could perhaps add
code to decrypt the WEP payload and then dissect the decrypted payload
the same way we dissect un-encrypted payloads.)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3599
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 22 Jun 2001 06:03:50 +0000 (06:03 +0000)]
Fix up some incorrect handling of the TO_DS and FROM_DS flags by
#defining all the bits in the flags field, and using those #defines in
the macros to test the flag fields, the macros fot the data address
types, the value_string table for the data frame to/from DS
combinations, and the bitfields for the flag bits.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3598
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 21 Jun 2001 22:35:33 +0000 (22:35 +0000)]
Fix a typo.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3597
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 21 Jun 2001 22:25:53 +0000 (22:25 +0000)]
M2PA support, from Jeff Morriss.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3596
f5534014-38df-0310-8fa8-
9805f1628bb7
girlich [Thu, 21 Jun 2001 15:18:11 +0000 (15:18 +0000)]
some more dissectors of Uwe Girlich added
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3595
f5534014-38df-0310-8fa8-
9805f1628bb7
girlich [Thu, 21 Jun 2001 15:16:43 +0000 (15:16 +0000)]
new source files packet-quakeworld.c and packet-quake2.c added
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3594
f5534014-38df-0310-8fa8-
9805f1628bb7
girlich [Thu, 21 Jun 2001 15:15:57 +0000 (15:15 +0000)]
initial checkin of the Quake II network protocol dissector
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3593
f5534014-38df-0310-8fa8-
9805f1628bb7
girlich [Thu, 21 Jun 2001 15:15:02 +0000 (15:15 +0000)]
initial checkin of the QuakeWorld network protocol dissector
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3592
f5534014-38df-0310-8fa8-
9805f1628bb7
girlich [Thu, 21 Jun 2001 15:13:42 +0000 (15:13 +0000)]
signed/unsigned warning corrected
the server port is now configurable via preferences
code reformatting
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3591
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 21 Jun 2001 06:59:47 +0000 (06:59 +0000)]
Get rid of an unused #define.
Make routines not used outside this module static.
Make "find_header_length()" return the correct value for management and
control frames.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3590
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 21 Jun 2001 06:36:44 +0000 (06:36 +0000)]
Don't use "tvb_get_ptr()" and "pletohs()" just to fetch a 16-bit
integral value from a packet - "tvb_get_letohs()" can do that just fine.
Don't use "tvb_get_ptr()", casting the result to a "guint16 *", and
dereferencing that pointer, either: that doesn't handle byte order
correctly, and it may fail if the pointer isn't aligned on a 2-byte
boundary.
For that matter, don't just use "tvb_get_ptr()" and dereference the
result to get an 8-bit quantity.
Use "proto_tree_add_item()" in many places where it's possible.
Reuse the results of "tvb_get_ptr()" calls when possible.
Show the fragment number and sequence number in decimal - they're just
ordinals.
Fix the blurb for the sequence number field.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3589
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 20 Jun 2001 23:58:57 +0000 (23:58 +0000)]
Make sure the top-level 802.11 item covers the entire frame.
Give the type field values names, rather than just showing them as 0, 1,
and 2.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3588
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 20 Jun 2001 23:29:16 +0000 (23:29 +0000)]
Make the type/subtype field the very first entry in the protocol tree,
and put it under the top-level 802.11 protocol item, so you don't have
to open the frame control field to see it.
Rename the variable for it, and the value_string array for it, to
indicate that it's made out of the type and subtype fields.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3587
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 20 Jun 2001 23:12:05 +0000 (23:12 +0000)]
All four data frame types are now handled with identical code, so,
instead of having four identical copies of that code in switch
statements, just handle all four of them with the same case.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3586
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 20 Jun 2001 23:04:36 +0000 (23:04 +0000)]
Put the combined type/subtype into the protocol tree, so you can look
for all Association Request frames, or all frames except for
Clear-to-send frames, or....
Compute the composed frame type early in the dissection process, and set
the Info column as soon as you've done that, rather than doing it in the
later switch statement.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3585
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 20 Jun 2001 22:26:07 +0000 (22:26 +0000)]
If it's not a protocol, it doesn't belong at the top level of the
protocol tree; not only is putting it at the top level a little weird,
it upsets the heck out of the protocol-statistics code, causing it to
abort. Put the fixed and tagged parameters under the top-level entry
for 802.11 (where one of the fixed-parameters entries already was).
Call the top-level item just "IEEE 802.11", not "IEEE 802.11 Header", as
it includes management-frame information.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3584
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 20 Jun 2001 06:22:33 +0000 (06:22 +0000)]
Clean up a string.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3583
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 20 Jun 2001 06:15:07 +0000 (06:15 +0000)]
Fix "COOK_ADDR_SELECTOR()" to extract the 2 bits that determine the
interpretation of the address fields, in DATA_ADDR_T{1,2,3,4} format.
Clean up a bunch of other macros to enclose their argument in
parentheses.
Clean up "find_header_length()" - it only needs to take the frame
control field of the frame as an argument, and should just check whether
"COOK_ADDR_SELECTOR()" returns DATA_ADDR_T4.
"tofrom_ds" is a value_string table, not a true_false_string table, so
wrap it in "VALS()", not "TFS()".
Don't fetch the header length in N different places in the main
dissector - just fetch it once and use it throughout.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3582
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 20 Jun 2001 05:18:36 +0000 (05:18 +0000)]
Catch TLVs with bogus lengths (i.e., less than the fixed-length header
size); otherwise, we run the risk of looping forever.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3581
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 20 Jun 2001 04:45:52 +0000 (04:45 +0000)]
RTSP fixes, from nuf si.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3580
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 20 Jun 2001 01:58:48 +0000 (01:58 +0000)]
Handle Negotiate Protocol replies with the "extended security"
capability flag set.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3579
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 19 Jun 2001 23:08:57 +0000 (23:08 +0000)]
More signed vs. unsigned cleanups, and initialization cleanups, from
Joerg Mayer.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3578
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 19 Jun 2001 20:10:51 +0000 (20:10 +0000)]
Updates from Frank Singleton.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3577
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 19 Jun 2001 18:50:33 +0000 (18:50 +0000)]
From Frank Singleton: fix compiler warnings.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3576
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 19 Jun 2001 08:47:48 +0000 (08:47 +0000)]
In a capture child process, *completely ignore* the preference setting
for promiscuous mode; just do what the parent process told you, i.e. do
a non-promiscuous capture iff a "-p" flag was specified.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3575
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 19 Jun 2001 08:33:00 +0000 (08:33 +0000)]
Labels must be followed by statements; GCC may let you get away without
the statement, but MSVC++ doesn't.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3574
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 19 Jun 2001 08:29:32 +0000 (08:29 +0000)]
Not all Python scripts generate dissectors; "make-reg-dotc.py" generates
"register.c", and, as such, shouldn't stuff ", HFILL" into its output.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3573
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 19 Jun 2001 04:46:10 +0000 (04:46 +0000)]
Get rid of global references to "pi" - use "pinfo" instead.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3572
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 18 Jun 2001 22:27:30 +0000 (22:27 +0000)]
Many corrections and updates for connection-oriented WSP, from Alexandre
P. Ferreira.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3571
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 18 Jun 2001 19:31:50 +0000 (19:31 +0000)]
From Frank Singleton: add code generation support for IDL array types.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3570
f5534014-38df-0310-8fa8-
9805f1628bb7
girlich [Mon, 18 Jun 2001 16:38:22 +0000 (16:38 +0000)]
NFS file handle analysing works now for kernel based NFS v3 servers of
Linux 2.4.0 too.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3569
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 18 Jun 2001 09:31:15 +0000 (09:31 +0000)]
Don't list the attribute-value pairs if the length field of the packet
says there aren't any (i.e., if the length field minus the size of the
stuff before the AVP's is less than or equal to 0).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3568
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 18 Jun 2001 07:21:30 +0000 (07:21 +0000)]
From Craig Rodrigues: changes to handle current versions of RPM, which
compress man pages.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3567
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 18 Jun 2001 06:31:05 +0000 (06:31 +0000)]
Fix up the buffer size calculation - the starting offset isn't a
multiple of 4, so making the size of the buffer a multiple of 4 isn't
the right thing to do.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3566
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 18 Jun 2001 06:18:03 +0000 (06:18 +0000)]
Get rid of an unnecessary declaration of "packet_list".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3565
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 18 Jun 2001 05:54:26 +0000 (05:54 +0000)]
The ICQ decryption code works on 4 bytes at a time, so the amount of
data it decrypts must be a multiple of 4; round the size of the ICQ data
to a multiple of 4, and use that as the size of the buffer into which to
put the decrypted data and as the byte count passed to the decryption
routine.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3564
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 18 Jun 2001 05:27:18 +0000 (05:27 +0000)]
Support for protocols running atop GIOP, from Frank Singleton.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3563
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 18 Jun 2001 02:26:00 +0000 (02:26 +0000)]
Crank up the warning level in GCC, from Joerg Mayer.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3562
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 18 Jun 2001 02:18:27 +0000 (02:18 +0000)]
From Joerg Mayer: explicitly fill in all members of a
"header_field_info" structure, including the ones that are later set by
the routines to register fields.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3561
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 18 Jun 2001 01:49:17 +0000 (01:49 +0000)]
Various signed vs. unsigned fixes, from Joerg Mayer.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3560
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 18 Jun 2001 01:42:24 +0000 (01:42 +0000)]
Define __USE_XOPEN in files that use "strptime()", from Joerg Mayer.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3559
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 18 Jun 2001 01:24:58 +0000 (01:24 +0000)]
Support for External Reachability TLVs, and assorted output
improvements, from Hannes Gredler.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3558
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 16 Jun 2001 00:54:33 +0000 (00:54 +0000)]
Add the PPP Compression Control Protocol to the list of PPP protocols
for which the ethertype dissector knows the name.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3557
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 16 Jun 2001 00:51:45 +0000 (00:51 +0000)]
Set the Protocol column in dissectors for PPP-specific subprotocols.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3556
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 15 Jun 2001 20:35:08 +0000 (20:35 +0000)]
PAP support, from Laurent Rabret.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3555
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 15 Jun 2001 20:23:41 +0000 (20:23 +0000)]
Explain why we have to be ready to handle Ethernet frames with
protocol type values that are PPP protocol types.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3554
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 15 Jun 2001 08:01:31 +0000 (08:01 +0000)]
There can be more than one next hop network address in the
BGPTYPE_MP_REACH_NLRI stuff; dissect all of them.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3553
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 15 Jun 2001 07:36:31 +0000 (07:36 +0000)]
If "buf" is a "char *", "sizeof(buf)" evaluates to the size of a
"char *" variable, not to the size of the buffer to which it points.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3552
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 15 Jun 2001 01:36:46 +0000 (01:36 +0000)]
If the capture child process sends the parent an error message with a
byte count of zero, don't bother allocating a buffer for that message,
as we wouldn't do anything with that buffer.
Null-terminate the error message once we read it, before using it as a
string.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3551
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 15 Jun 2001 00:42:39 +0000 (00:42 +0000)]
Clean up the handling of RTP padding.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3550
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 14 Jun 2001 22:34:39 +0000 (22:34 +0000)]
Bug fix from Francisco Javier Cabello.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3549
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 14 Jun 2001 20:37:07 +0000 (20:37 +0000)]
As long as we're supporting PPP protocol types over Ethernet, we might
as well just include "ppptypes.h" in "packet-ethertype.c", rather than
defining ETHERTYPE_ values equal to the corresponding PPP_ values, and
add entries for the PPP protocols we now dissect when running atop
Ethernet.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3548
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 14 Jun 2001 20:05:13 +0000 (20:05 +0000)]
LCP-over Ethernet and IPCP-over-Ethernet support, from Laurent Rabret.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3547
f5534014-38df-0310-8fa8-
9805f1628bb7
ashokn [Thu, 14 Jun 2001 18:26:04 +0000 (18:26 +0000)]
Cosmetic: Corrected "Maximum policed unit" to "Maximum packet size"
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3546
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 14 Jun 2001 09:34:14 +0000 (09:34 +0000)]
Set the reported length of the tvbuff we hand to the MPEG1 dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3545
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 14 Jun 2001 09:25:25 +0000 (09:25 +0000)]
RFC 2250 MPEG1 support, from Francisco Javier Cabello.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3544
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 14 Jun 2001 08:23:50 +0000 (08:23 +0000)]
An Acct-Status-Type value of 3 is Interim-Update; thanks and a tip of
the hat to Diana Eichert for pointing out that 3 was missing.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3543
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 14 Jun 2001 08:09:59 +0000 (08:09 +0000)]
Check for a bogus TCP header length, and don't try to do dissection if
it's bogus.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3542
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 14 Jun 2001 07:05:51 +0000 (07:05 +0000)]
If we see an RTP packet for a version of the protocol other than version
2, don't try to dissect any of it other than the version field.
Don't try to dissect the RTP data and padding if there's more padding
than data....
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3541
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 12 Jun 2001 06:32:39 +0000 (06:32 +0000)]
Give a number of files RCS IDs.
Give "proto_hier_stats.h" a standard header.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3540
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 12 Jun 2001 06:21:55 +0000 (06:21 +0000)]
DVMRP support, from Ronnie Sahlberg.
Give "packet-igmp.c" an RCS ID.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3539
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 12 Jun 2001 05:40:05 +0000 (05:40 +0000)]
Display hex numbers with a leading 0x.
Supply "true" and "false" strings for the Order flag bit.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3538
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 10 Jun 2001 09:50:20 +0000 (09:50 +0000)]
Rename the arguments and flags for the conversation routines, so as not
to imply that
1) conversations have source and destination addresses and ports
- they don't (if they did, they'd be monologues, not
conversations), they just have two address/port pairs for the
two endpoints, with one or more of the address or port in the
second pair possibly being wildcarded;
2) the first and second address or port argument to
"find_conversation()" or "try_conversation_dissector()" have
anything to do with the first or second address/port pair in
a conversation - they don't, the two arguments to those
routines are matched against *both* address/port pairs for a
conversation;
as otherwise people might think that they need to add flags to wildcard
the first arguments "conversation_new()" or "find_conversation()" (they
don't, they just have to pass the non-wildcarded address/port first and
then pass the wildcarded one, even if that means passing the destination
first and source second).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3537
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 10 Jun 2001 07:40:39 +0000 (07:40 +0000)]
Clean up the handling of MAC addresses - set the addresses in the
standard fashion, for data and managment packets, and set the columns
correctly for other packets (as we currently put address types in the
address columns; if we don't do so, we could just set the addresses in
the standard fashion for those packets as well).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3536
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 10 Jun 2001 04:42:34 +0000 (04:42 +0000)]
Clean up the handling of AVPs.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3535
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 10 Jun 2001 02:08:11 +0000 (02:08 +0000)]
MP-BGP message support, from Thierry Stagiaire.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3534
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 9 Jun 2001 01:02:29 +0000 (01:02 +0000)]
"long" does not necessarily mean "32-bit integral data type"; the union
used to treat a 32-bit quantity either as 2 16-bit quantities or a
32-bit quantity should use "guint32", not "long", for the latter.
We should also use "guint8" for the two 8-bit quantities in "s_util",
although that shouldn't make a difference in practice (we store into
them, but fetch only the 16-bit overlapping quantity, which is already
unsigned).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3533
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 8 Jun 2001 10:07:55 +0000 (10:07 +0000)]
We only need to print the data corresponding to the field, so fetch only
that data with a "tvb_get_ptr()".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3532
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 8 Jun 2001 08:50:51 +0000 (08:50 +0000)]
When printing the contents of a raw-data field, don't use the raw data
of the current frame as the source, use the raw data of the tvbuff
that's the data source of that field.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3531
f5534014-38df-0310-8fa8-
9805f1628bb7