obnox/wireshark/wip.git
15 years agoCalculate jitter and delta in ms.
etxrab [Sun, 31 May 2009 17:06:04 +0000 (17:06 +0000)]
Calculate jitter and delta in ms.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28546 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdded some svn:ignore targets for epan/wspython
stig [Sun, 31 May 2009 16:37:47 +0000 (16:37 +0000)]
Added some svn:ignore targets for epan/wspython

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28545 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdjusted the python binding message from configure.
stig [Sun, 31 May 2009 16:06:32 +0000 (16:06 +0000)]
Adjusted the python binding message from configure.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28544 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Kovarththanan Rajaratnam's patch in bug 3500:
stig [Sun, 31 May 2009 16:05:13 +0000 (16:05 +0000)]
From Kovarththanan Rajaratnam's patch in bug 3500:
Added info about python version.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28543 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoBring cipher suites in sync.
tuexen [Sun, 31 May 2009 15:25:38 +0000 (15:25 +0000)]
Bring cipher suites in sync.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28542 f5534014-38df-0310-8fa8-9805f1628bb7

15 years ago[Automatic manuf and enterprise-numbers update for 2009-05-31]
gerald [Sun, 31 May 2009 15:03:48 +0000 (15:03 +0000)]
[Automatic manuf and enterprise-numbers update for 2009-05-31]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28540 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoDon't dissect IP-ID and UDP checksum for IR, IR-DYN frames.
martinm [Sun, 31 May 2009 12:11:44 +0000 (12:11 +0000)]
Don't dissect IP-ID and UDP checksum for IR, IR-DYN frames.
Name hf items and filter strings to consistently include "rohc"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28539 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix bug 3489:
jake [Sun, 31 May 2009 11:31:40 +0000 (11:31 +0000)]
Fix bug 3489:
Array overrun at copy of filter expression on GTK1 build.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28538 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoChange my e-mail address
sfisher [Sun, 31 May 2009 05:55:15 +0000 (05:55 +0000)]
Change my e-mail address

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28537 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agogtk_file_chooser_set_do_overwrite_confirmation() is only available in
guy [Sat, 30 May 2009 20:02:38 +0000 (20:02 +0000)]
gtk_file_chooser_set_do_overwrite_confirmation() is only available in
2.8 and later.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28536 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd cipher suites defined in RFC 4279.
tuexen [Sat, 30 May 2009 19:52:41 +0000 (19:52 +0000)]
Add cipher suites defined in RFC 4279.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28535 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix the save_as functions so they work (including work-around
wmeier [Sat, 30 May 2009 18:07:35 +0000 (18:07 +0000)]
Fix the save_as functions so they work (including work-around
when save-as raises an alert box).
Also:
- save_as_csv: don't skip over first line of output;
- save_as_csv: Fix some (probably significant) memory leaks
  associated with the use of gtk_tree_view;
- Prevent tendency for IAX2 stream window and graph window
  to get lost behind other windows;
- Minor save_as dialog window reformatting;
- Misc source code cleanup & reformatting.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28534 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoadding README.python to EXTRA_DIST
standel [Sat, 30 May 2009 13:38:45 +0000 (13:38 +0000)]
adding README.python to EXTRA_DIST

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28533 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agopython binding update :
standel [Sat, 30 May 2009 13:37:02 +0000 (13:37 +0000)]
python binding update :

    * adding pydoc documentation to doc/README.python
    * possible to access directly libwireshark via libhandle and raw_<tvb|pinfo|tree>
    * transform some methods into properties
    * update sample to reflect changes/features
    * adding comments!!!

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28532 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoTidy up comments.
martinm [Sat, 30 May 2009 12:54:08 +0000 (12:54 +0000)]
Tidy up comments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28531 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoDual-license this header file.
martinm [Sat, 30 May 2009 11:57:39 +0000 (11:57 +0000)]
Dual-license this header file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28530 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agopython binding for wireshark (first commit)
standel [Fri, 29 May 2009 21:10:40 +0000 (21:10 +0000)]
python binding for wireshark (first commit)

      * ability to write dissectors with python for wireshark.
        documentation (http://wiki.wireshark.org/Python)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28529 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoPrevent "echo ? ... " from expanding ? as a file name pattern;
wmeier [Fri, 29 May 2009 20:11:17 +0000 (20:11 +0000)]
Prevent "echo ? ... " from expanding ? as a file name pattern;
(Trivial) Remove duplicate xcopy of libwireshark.dll;
(Trivial) xcopy $(MSVCR_DLL) ...  only if newer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28528 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUpdate the Windows library tags and documentation filename.
gerald [Fri, 29 May 2009 18:45:24 +0000 (18:45 +0000)]
Update the Windows library tags and documentation filename.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28527 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUpdate the logo in the documentation.
gerald [Fri, 29 May 2009 17:57:55 +0000 (17:57 +0000)]
Update the logo in the documentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28526 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUpdate version numbers.
gerald [Fri, 29 May 2009 17:12:20 +0000 (17:12 +0000)]
Update version numbers.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28525 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd WinPcap_4_1_beta5.exe to the distribution.
gerald [Fri, 29 May 2009 17:06:25 +0000 (17:06 +0000)]
Add WinPcap_4_1_beta5.exe to the distribution.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28523 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoInstall WinPcap 4.1 beta5. It's stable, and is required for Win64.
gerald [Fri, 29 May 2009 16:28:20 +0000 (16:28 +0000)]
Install WinPcap 4.1 beta5. It's stable, and is required for Win64.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28521 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUse consistent indentation.
wmeier [Fri, 29 May 2009 13:42:51 +0000 (13:42 +0000)]
Use consistent indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28520 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoSmall comment fixes
jmayer [Fri, 29 May 2009 10:59:27 +0000 (10:59 +0000)]
Small comment fixes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28519 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoResume work on CMake for Wireshark. Finally found and fixed a
jmayer [Fri, 29 May 2009 10:57:47 +0000 (10:57 +0000)]
Resume work on CMake for Wireshark. Finally found and fixed a
few mistakes that I made earlier.

Current status: dumpcap still doesn't build
Next step: Add a ylwrap like workaround for flex misbehaviour.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28518 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agotvb_new_real_data -> tvb_new_child_real_data
etxrab [Fri, 29 May 2009 06:16:43 +0000 (06:16 +0000)]
tvb_new_real_data -> tvb_new_child_real_data

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28517 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoVersion 2: Fix bug: Makefile doesn't detect some out-of-date libraries.
wmeier [Thu, 28 May 2009 23:20:20 +0000 (23:20 +0000)]
Version 2: Fix bug: Makefile doesn't detect some out-of-date libraries.
 The previous fix (SVN 28504) didn't quite work since
 nmake always errored out if the libraries were not up-to-date; this
 prevented doing an nmake ... setup.

 This version of the fix:
 1. Gets the library status (checktag) at the beginning of the make.
 2. Effectively does the actual testing of the status whenever
    a target with $(LIBS_CHECK) as a dependency is invoked.

 Result: nmake ... [all] will error-out while nmake .... setup will
  work properly.

 Note that nmake ... setup will now show an initial error message
  (from checktag) if the libraries are out of date; setup will still
  proceed normally.
  This is a slight change from the current behavior wherein no
  error message occurs when nmake ... setup is invoked when the
  libraries are out of date.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28516 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom yami (bug 3497):
stig [Thu, 28 May 2009 20:25:26 +0000 (20:25 +0000)]
From yami (bug 3497):
Improved the "Invalid filter" message in the status bar.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28515 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoInclude profinet plugin in PLUGINS symbol.
jake [Thu, 28 May 2009 18:42:40 +0000 (18:42 +0000)]
Include profinet plugin in PLUGINS symbol.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28514 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Tobias Witek (bug 3496):
stig [Thu, 28 May 2009 08:38:49 +0000 (08:38 +0000)]
From Tobias Witek (bug 3496):
The patch puts the function declarations for zbee_sec_ccm_decrypt() and
zbee_sec_key_hash() into a #ifdef HAVE_LIBGCRYPT guardian to avoid gcc from
complaining about functions that are declared as 'static' but never defined.

It additionally puts the function zbee_sec_make_nonce() (and its declaration)
into a #ifdef HAVE_LIBGCRYPT guardian to avoid gcc from complaining about a
defined but unused function, if libgcrypt is not used.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28513 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd casts from size_t to fix win64 buildbot problems.
martinm [Thu, 28 May 2009 03:26:40 +0000 (03:26 +0000)]
Add casts from size_t to fix win64 buildbot problems.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28512 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd definitions for a UDP framing protocol and heuristic dissector (example client...
martinm [Thu, 28 May 2009 02:24:27 +0000 (02:24 +0000)]
Add definitions for a UDP framing protocol and heuristic dissector (example client code will be posted on wiki soon)
Add a missed initialisation to stats window struct.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28511 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoImplement a simpler way to check for a change in the svn version.
wmeier [Wed, 27 May 2009 20:08:39 +0000 (20:08 +0000)]
Implement a simpler way to check for a change in the svn version.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28510 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoDetect if the setup channel is video or not.
etxrab [Wed, 27 May 2009 18:22:39 +0000 (18:22 +0000)]
Detect if the setup channel is video or not.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28509 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoCopy over r28507 from /trunk-1.2.
gerald [Wed, 27 May 2009 18:20:52 +0000 (18:20 +0000)]
Copy over r28507 from /trunk-1.2.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28508 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd missing quote
wmeier [Wed, 27 May 2009 17:13:07 +0000 (17:13 +0000)]
Add missing quote

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28505 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix bug: Makefile doesn't detect some out-of-date libraries.
wmeier [Wed, 27 May 2009 17:07:51 +0000 (17:07 +0000)]
Fix bug: Makefile doesn't detect some out-of-date libraries.

Reason:
 The makefile was coded to do the checktag and libverify checks
 only if makefile.nmake changed. It's now the case that some
 library updates are reflected in config.nmake rather than in
 Makefile.nmake and thus were missed.

Solution:
 Do a checktag once at the beginning of the make.
 Do not do a libverify any more. I think that checking
  that the library 'tag' is correct is sufficient.
 (The libverify code has been effectively commented out for now.
  It can be removed at a later date once we're comfortable
  with just using checktag).
 --This line, and those below, will be ignored--

M    Makefile.nmake

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28504 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Siddhes (bug 3483):
stig [Wed, 27 May 2009 14:13:55 +0000 (14:13 +0000)]
From Siddhes (bug 3483):
Throttle splash screen updates when running remote.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28503 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoChange button label to "Quit without Saving" from "Continue without Saving"
rbalint [Wed, 27 May 2009 02:42:43 +0000 (02:42 +0000)]
Change button label to "Quit without Saving" from "Continue without Saving"
when exiting Wireshark and having an open, not yet saved capture file.
This fixes bug 1427.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28502 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMake it possible to toggle the displayed IP address in the capture interfacs
stig [Tue, 26 May 2009 21:13:16 +0000 (21:13 +0000)]
Make it possible to toggle the displayed IP address in the capture interfacs
dialog if more than one IP address exists for the selected device.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28498 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agodocbook: Windows: rebuild docs only when source or svn_version actually changes.
wmeier [Tue, 26 May 2009 20:57:39 +0000 (20:57 +0000)]
docbook: Windows: rebuild docs only when source or svn_version actually changes.
 Also: rebuild docs if docbook/Makefile.nmake or docbook/Makefile.common changes;
       rebuilding individual target (wdug, wsdg,...) will check for svn_version change.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28497 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMove the trunk to 1.3.
gerald [Tue, 26 May 2009 20:53:28 +0000 (20:53 +0000)]
Move the trunk to 1.3.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28495 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMake the TZSP dissector register itself for find_dissector.
sfisher [Tue, 26 May 2009 17:10:49 +0000 (17:10 +0000)]
Make the TZSP dissector register itself for find_dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28491 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUpdate 3GPP AVP:s
etxrab [Tue, 26 May 2009 16:48:31 +0000 (16:48 +0000)]
Update 3GPP AVP:s

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28490 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMove xml validation to the individual wsug, wsdg & release_notes targets.
wmeier [Tue, 26 May 2009 16:06:12 +0000 (16:06 +0000)]
Move xml validation to the individual wsug, wsdg & release_notes targets.
Enables proper making of just one of the targets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28489 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMisc dissector cleanup:
wmeier [Tue, 26 May 2009 16:01:12 +0000 (16:01 +0000)]
Misc dissector cleanup:
- Make some fcns & vars static
- hf[] blurbs: "" and repeated text --> NULL
- Move proto_register & proto_reg_handoff to end of source
- packet-catapult-dct2000: simplify proto_reg_handoff
- Use consistent indentation

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28488 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agozbee: Misc cleanup:
wmeier [Tue, 26 May 2009 15:50:10 +0000 (15:50 +0000)]
zbee: Misc cleanup:
- Ethereal --> Wireshark
- Make fome fcns & vars static
- Spelling
- hf[] blurbs: "" --> NULL
- Remove some unneeded forward declarations
- packet-zep: rework reg_handoff to init handles only once
- Rename global 'get_bit_field' to 'zbee_get_bit_field'
  ...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28487 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Kovarththanan Rajaratnam: dfilter: Fix for bug #3490:
wmeier [Tue, 26 May 2009 15:13:19 +0000 (15:13 +0000)]
From Kovarththanan Rajaratnam: dfilter: Fix for bug #3490:
"Purify reports an uninitialized memory read in dfw_append_const() when
accessing the 'next_const_id' member. This seems to be caused by dfwork_new()
which doesn't properly initialize the member."

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28486 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd a note about README.developer to the beginning of the "Packet Dissection" chapter.
wmeier [Tue, 26 May 2009 15:03:17 +0000 (15:03 +0000)]
Add a note about README.developer to the beginning of the "Packet Dissection" chapter.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28485 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUpdate the "Adding a basic dissector" section a bit to reflect current practice.
wmeier [Tue, 26 May 2009 14:32:45 +0000 (14:32 +0000)]
Update the "Adding a basic dissector" section a bit to reflect current practice.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28484 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoDocument the changes in the Capture Interfaces description.
stig [Tue, 26 May 2009 13:52:43 +0000 (13:52 +0000)]
Document the changes in the Capture Interfaces description.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28483 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Carlos G Mendioroz:
stig [Tue, 26 May 2009 13:52:03 +0000 (13:52 +0000)]
From Carlos G Mendioroz:
Use the user defined comment in the Capture Interfaces dialog box.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28482 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd a comment from IANA assignments, whitspace changes.
etxrab [Tue, 26 May 2009 06:26:34 +0000 (06:26 +0000)]
Add a comment from IANA assignments, whitspace changes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28481 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd a cast for Win64.
gerald [Tue, 26 May 2009 04:32:51 +0000 (04:32 +0000)]
Add a cast for Win64.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28480 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd the FIX build files to the distribution.
gerald [Tue, 26 May 2009 00:51:33 +0000 (00:51 +0000)]
Add the FIX build files to the distribution.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28479 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Didier Gautheron via bug 3052:
gerald [Tue, 26 May 2009 00:49:38 +0000 (00:49 +0000)]
From Didier Gautheron via bug 3052:

Add:
- FIX 4.0 to 4.4 fields, auto generated with XSLT stylesheets applied on
http://www.quickfixengine.org/ xml files (not included quickfixengine code is
BSD but xml files have no copyright).

- value_string functions for string keys, added to value_string.c.

- FIX desegmentation, it doesn't work well with malformed FIX PDU.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28478 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Roberto Mariani via bug 3324:
gerald [Tue, 26 May 2009 00:32:16 +0000 (00:32 +0000)]
From Roberto Mariani via bug 3324:

- Removed heuristic for find if is_request and used event_type

- URB_INTERRUPT don't goes in reverse direction... fixed

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28477 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix the build.
gerald [Tue, 26 May 2009 00:30:08 +0000 (00:30 +0000)]
Fix the build.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28476 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Didier Gautheron via bug 3391:
gerald [Mon, 25 May 2009 23:48:29 +0000 (23:48 +0000)]
From Didier Gautheron via bug 3391:

when loading files > 50 MB wireshark redraws the first pane on each
update_progress_dlg(). If auto_scroll_live is not set that's mean it redraws
the same rows again and again.

The patch attached only redraws it once or if cf->displayed_count < 1000, in
case you have a very big screen.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28475 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUpdate the .svg files as well.
gerald [Mon, 25 May 2009 23:07:12 +0000 (23:07 +0000)]
Update the .svg files as well.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28474 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoIncrease the size of the Finder windows slightly.
gerald [Mon, 25 May 2009 23:02:34 +0000 (23:02 +0000)]
Increase the size of the Finder windows slightly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28473 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdded an expert info for "IP port reused".
stig [Mon, 25 May 2009 21:10:22 +0000 (21:10 +0000)]
Added an expert info for "IP port reused".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28472 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix for bug 3469:
sake [Mon, 25 May 2009 19:59:17 +0000 (19:59 +0000)]
Fix for bug 3469:

In Juniper NetScreen snoop output files, the encapsulation type of
traffic on ADSL interfaces can be ethernet or PPP. Check whether the
first 6 bytes of the data are the same as the destination mac-address
in the packet header. If they are, assume ethernet. If not, assume PPP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28471 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoSquelch an uninitialized variable complaint from older versions of GCC
guy [Mon, 25 May 2009 18:40:07 +0000 (18:40 +0000)]
Squelch an uninitialized variable complaint from older versions of GCC
(which presumably don't know that g_assert_not_reached() never returns).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28470 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdded missing daintree-sna.h to Makefile.
stig [Mon, 25 May 2009 06:57:12 +0000 (06:57 +0000)]
Added missing daintree-sna.h to Makefile.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28469 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Dan Gora:
jake [Mon, 25 May 2009 06:50:34 +0000 (06:50 +0000)]
From Dan Gora:
This patch adds support for the I-TDM control protocol specified in PICMG SFP.1 chapter 3.12.
This control protocol is used to "automatically" initialize new I-TDM data flows.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28468 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Thomas M. Knoll:
jake [Mon, 25 May 2009 06:48:40 +0000 (06:48 +0000)]
From Thomas M. Knoll:
The CoS Capability extended community has been changed to a transitive ext. community
and was reassigned an IANA type number. It has changed from 0x40 to 0x05.
see: http://www.iana.org/assignments/bgp-extended-communities

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28467 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Michael Lum:
jake [Mon, 25 May 2009 06:46:33 +0000 (06:46 +0000)]
From Michael Lum:
Some of the hard-coded 96 and 127 values representing dynamic payloads
were changed to use #defines from rtp_pt.h but not all.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28466 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUse proto_tree_add_uint64 for 64 bits values.
stig [Sun, 24 May 2009 23:23:06 +0000 (23:23 +0000)]
Use proto_tree_add_uint64 for 64 bits values.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28465 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFixed some email addresses.
stig [Sun, 24 May 2009 22:57:11 +0000 (22:57 +0000)]
Fixed some email addresses.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28464 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Fred Fierling (bug 3486):
stig [Sun, 24 May 2009 22:49:36 +0000 (22:49 +0000)]
From Fred Fierling (bug 3486):
Added support for Daintree's Sensor Network Analyzer capture files.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28463 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Rama Chitta (bug 3467):
stig [Sun, 24 May 2009 22:39:07 +0000 (22:39 +0000)]
From Rama Chitta (bug 3467):
Added routines for Memcache Textual Protocol.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28462 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoRewrite some non-ascii characters.
stig [Sun, 24 May 2009 20:59:33 +0000 (20:59 +0000)]
Rewrite some non-ascii characters.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28461 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFound some problems when testing with live captures:.
martinm [Sun, 24 May 2009 07:25:57 +0000 (07:25 +0000)]
Found some problems when testing with live captures:.
- Fixed problem with iter_valid values (causing multiple rows for one UE).
- Set UE counters to 0 when current UE is deselected.
- Get rid of some unused counters

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28459 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoHave fileset_extract_prefix_suffix() print an error message if it fails,
guy [Sat, 23 May 2009 20:29:12 +0000 (20:29 +0000)]
Have fileset_extract_prefix_suffix() print an error message if it fails,
so we don't just exit silently.  Don't bother checking the validity of
arguments - it shouldn't be passed NULL fprefix or fsuffix arguments in
the first place, and isn't passed them.

Exit with an exit status of 1 for command-line syntax errors and 2 for
file open/close/IO errors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28458 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix indentation.
guy [Sat, 23 May 2009 20:22:42 +0000 (20:22 +0000)]
Fix indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28457 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoOut goes a C++ comment inside #if 0 #endif to make the API checker happy.
tuexen [Sat, 23 May 2009 12:09:15 +0000 (12:09 +0000)]
Out goes a C++ comment inside #if 0 #endif to make the API checker happy.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28456 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoInitialize pdh...
sake [Sat, 23 May 2009 08:57:20 +0000 (08:57 +0000)]
Initialize pdh...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28455 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Kovarththanan Rajaratnam <krj@rajaratnam.dk> in bug 2683
sake [Sat, 23 May 2009 07:59:23 +0000 (07:59 +0000)]
From Kovarththanan Rajaratnam <krj@rajaratnam.dk> in bug 2683
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2683):

Editcap should split file according to fileset pattern

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28454 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom David Aggeler via bug 3468:
gerald [Fri, 22 May 2009 23:09:31 +0000 (23:09 +0000)]
From David Aggeler via bug 3468:

Escape filenames in the welcome screen with g_markup_escape_text().

From me:

Add a binary prefix for gigabytes. Add a comment explaining why we're
using binary prefixes instead of IEC.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28453 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Benjamin Tse via bug 2200:
gerald [Fri, 22 May 2009 19:52:30 +0000 (19:52 +0000)]
From Benjamin Tse via bug 2200:

I've created a new bug rather than reopening 1181 as the scope is constrained
somewhat more.

Basically, when capturing from a named pipe the wireshark display lags by one
packet. This is especially frustrating when the packets arrive at low rates.

tshark is fine. But the packet count in dumpcap also lags by one.

Looking at the code, the problem appears to be in cap_pipe_select(). It
attempts to use WaitForSingleObject() on the named pipe but AFAICT this never
blocks.

I've attached a diff for some code that fixes the issue for me. The semantics
of overlapped IO in Win32 is quite different from the select/read model - hence
the other changes!

I've tested this fix on WinXP, 2k server and 2003 server. I've also checked
that my changes compile on a Freespire box that I have lying around.

From me:

Adapt the changes for dumpcap, which is where the affected code now lives.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28452 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Nick Lewis via bug 3319:
gerald [Fri, 22 May 2009 18:39:26 +0000 (18:39 +0000)]
From Nick Lewis via bug 3319:

When audio samples have to be dropped or silence samples inserted to reflect
the timestamp there is no indication of these problems on the display.

I propose that such problems be indicated on the waveform display by the use of
amber coloration and that the number of incorrect timestamps be listed

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28451 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd Greg Schwendimann.
gerald [Fri, 22 May 2009 17:42:26 +0000 (17:42 +0000)]
Add Greg Schwendimann.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28450 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Greg Schwendimann via bug 3156:
gerald [Fri, 22 May 2009 17:38:21 +0000 (17:38 +0000)]
From Greg Schwendimann via bug 3156:

Airpdcap does not allow for more than one key to be stored for a pair of nodes.
 This means that when a device associates more than once the previous keys are
lost.  This is ok for the first pass as the newest key is all that is needed
but when the user tries to click on a packet, to get the tree, which used a
previous key all that is seen is the encrypted data.  The attached patch stores
previous associations in a linked list and will try all known keys before
decided the packet can't be decrypted.  The list of keys is garbage collected
when a new capture is started.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28449 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Terry Hardie via bug 3080:
gerald [Fri, 22 May 2009 16:05:30 +0000 (16:05 +0000)]
From Terry Hardie via bug 3080:

In ISUP, if the redirecting or original called number parameters are present,
but have a zero length number in them, the dissector (incorrectly) marks them
as malformed packets.

Also, the precedence decoder is very terse (Doesn't even display the precedence
level correctly)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28448 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agog_string_append_printf() is the correct name of the function (oops).
wmeier [Fri, 22 May 2009 13:08:54 +0000 (13:08 +0000)]
g_string_append_printf() is the correct name of the function (oops).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28447 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix usage of several GTK/Glib deprecated functions.
wmeier [Fri, 22 May 2009 12:58:48 +0000 (12:58 +0000)]
Fix usage of several GTK/Glib deprecated functions.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28446 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agogtk_exit(): deprecated and no longer used in Wireshark: 'W' ==> 'E'
wmeier [Fri, 22 May 2009 12:39:00 +0000 (12:39 +0000)]
gtk_exit():  deprecated and no longer used in Wireshark: 'W' ==> 'E'

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28445 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agogtk_exit() is deprecated; "use the standard exit() function instead"
wmeier [Fri, 22 May 2009 12:36:20 +0000 (12:36 +0000)]
gtk_exit() is deprecated; "use the standard exit() function instead"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28444 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Aaron Turner: Use wtap_wtap_encap_to_pcap_encap() instead of
tuexen [Fri, 22 May 2009 07:33:58 +0000 (07:33 +0000)]
From Aaron Turner: Use wtap_wtap_encap_to_pcap_encap() instead of
                   fixed mapping for ethernet only.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28443 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Kovarththanan Rajaratnam via bug 2680:
gerald [Fri, 22 May 2009 00:05:19 +0000 (00:05 +0000)]
From  Kovarththanan Rajaratnam via bug 2680:

Currently Wireshark doesn't support saving
WTAP_ENCAP_BLUETOOTH_H4_WITH_PHDR files as btsnoop files.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28442 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Kovarththanan Rajaratnam via bug 2676:
gerald [Thu, 21 May 2009 23:16:49 +0000 (23:16 +0000)]
From Kovarththanan Rajaratnam via bug 2676:

If a PCAP file containing WTAP_ENCAP_BLUETOOTH_H4_WITH_PHDR packets is saved,
it gets corrupted because the direction pseudo header isn't included.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28441 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoSmall improvements for the compare capture files dialog:
stig [Thu, 21 May 2009 22:10:17 +0000 (22:10 +0000)]
Small improvements for the compare capture files dialog:
- Added autocompletion in the filter entry
- Added a help button (documentation TBD)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28440 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agozbee: minor cleanup
wmeier [Thu, 21 May 2009 20:03:03 +0000 (20:03 +0000)]
zbee: minor cleanup
- replace C++ comments by C-style comments (or #if 0...#endif);
- Chnage all hf[] "" blurbs to NULL;
- Fix some spelling;
- Remove two unused handles.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28439 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoStrip single quotes around our output paths. This should fix the current
gerald [Thu, 21 May 2009 19:53:35 +0000 (19:53 +0000)]
Strip single quotes around our output paths. This should fix the current
U3 buildbot failure.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28438 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agopaltalk: minor cleanup:
wmeier [Thu, 21 May 2009 18:36:32 +0000 (18:36 +0000)]
paltalk: minor cleanup:
 - prefs registration not req'd (no prefs);
 - move hf[] & ett[] to be local to proto_register;
 - use std dissector format: move proto_register & proto_reg_handoff to end;
 - if (proto == -1) in proto_register not req'd;
 - if (! initialized) not req'd in proto_reg_handoff since no prefs callback.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28437 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd filterable generated item arp.isgratuitous. Inspired
jmayer [Thu, 21 May 2009 05:15:03 +0000 (05:15 +0000)]
Add filterable generated item arp.isgratuitous. Inspired
by question on wireshark-users ML by
wireshark.20090520@tozer.org.uk

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28436 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agofoo() and foo(void) might be the same in C++, but they're not the same
guy [Thu, 21 May 2009 01:01:22 +0000 (01:01 +0000)]
foo() and foo(void) might be the same in C++, but they're not the same
in C.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28435 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Mohammad Ebrahim Mohammadi Panah via bug 2954:
gerald [Thu, 21 May 2009 00:34:03 +0000 (00:34 +0000)]
From Mohammad Ebrahim Mohammadi Panah via bug 2954:

I've developed a Wireshark dissector for Paltalk messenger protocol.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28434 f5534014-38df-0310-8fa8-9805f1628bb7