guy [Sun, 30 Apr 2006 09:25:34 +0000 (09:25 +0000)]
Get rid of extra semicolon - GCC warns that ISO C doesn't allow it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18045
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 30 Apr 2006 09:14:42 +0000 (09:14 +0000)]
Constify some stuff, to eliminate compiler warnings and to make a table
that isn't written const.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18044
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 30 Apr 2006 08:59:26 +0000 (08:59 +0000)]
No C++/C99 comments, please (GCC warns about them in the Solaris
buildbot build, even though the code is #if 0'ed out).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18043
f5534014-38df-0310-8fa8-
9805f1628bb7
gal [Sun, 30 Apr 2006 07:23:42 +0000 (07:23 +0000)]
Request/result matching, port preference and display tweaks
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18042
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 30 Apr 2006 06:57:01 +0000 (06:57 +0000)]
Add "file_dlg.h" to declare "set_last_open_dir()".
Try leaving "dlg_utils.h" out.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18041
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 30 Apr 2006 06:54:25 +0000 (06:54 +0000)]
Include <errno.h> to get errnos.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18040
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 30 Apr 2006 03:22:39 +0000 (03:22 +0000)]
See whether <stdio.h> will get EISDIR defined.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18039
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 30 Apr 2006 03:19:59 +0000 (03:19 +0000)]
We use stuff from dlg_utils.h.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18038
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 30 Apr 2006 03:19:11 +0000 (03:19 +0000)]
We need <gdk/gdkkeysyms.h> to define GDK_VoidSymbol.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18037
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 30 Apr 2006 01:47:58 +0000 (01:47 +0000)]
Move the file selection dialog routines to file_dlg.c, and give it a
header file.
#if 0 out some includes; if none of the builds have a problem with
that, I'll remove them.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18036
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 29 Apr 2006 23:18:47 +0000 (23:18 +0000)]
Fix the idempotent-include #define.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18035
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 29 Apr 2006 23:03:57 +0000 (23:03 +0000)]
Most of the stuff in file_dlg.c is specific to capture files, so rename
it to capture_file_dlg.c, and rename its header file. We might want to
move the generic file dialog stuff to a file_dlg.c file (it's currently
in dlg_utils.c), and move the non-capture-file dialog stuff in
capture_file_dlg.c to another file.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18034
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 29 Apr 2006 18:54:54 +0000 (18:54 +0000)]
Add some simple sanity checking of BVLC packets, so if you're unlucky
enough to have a non-BVLC packet from or to port 47808, we're likely to
reject it and let another dissector try it. Fixes bug 855 (in which an
MS Messenger packet was unlucky enough to have come from that port).
Add value_string tables to some fields, and just use
proto_tree_add_uint() to add them to the protocol tree, rather than
generating our own text for them.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18033
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 29 Apr 2006 17:54:46 +0000 (17:54 +0000)]
Have the ring buffer routines take a pointer to a "bytes written" count
as an argument, rather than keeping the count to themselves, so the
count kept by the capturing program can be updated correctly - including
getting reset when files are switched. Fixes bug 895.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18032
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 29 Apr 2006 17:31:20 +0000 (17:31 +0000)]
Clean up indentation; use 2-space indentation throughout.
Save the media encoding name in the transport_info_t structure rather
than in a global variable. Allocate it with tvb_get_ephemeral_string()
so it's released after the packet is completely processed. Do *NOT*
assume it's necessarily non-null in decode_sdp_fmtp(), as the code flow
doesn't guarantee that to be true.
proto_tree_add_string() now suffices for adding a particular SDP item -
strings are now displayed "safely", with escaping of non-printable
characters done.
Update a comment (we no longer have the Big Transfer Vector to allow
plugins to call dissector functions in Windows, we have those functions
in a DLL).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18031
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Sat, 29 Apr 2006 15:25:44 +0000 (15:25 +0000)]
chrisaudley@yahoo.com:
Patch to fix:
[Bug 904] FIX protocol dissector missing some message types
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18030
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 29 Apr 2006 09:30:09 +0000 (09:30 +0000)]
A dissector called from tcp_dissect_pdus() has to return void. (If you
want to have a dissector capable of rejecting packets, you need to
reject the packet before you call tcp_dissect_pdus() - once you're doing
reassembly, etc., it's too late to reject the packet.)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18029
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 28 Apr 2006 21:42:18 +0000 (21:42 +0000)]
Check Payload type before dissecting fmtp parameters.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18028
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 28 Apr 2006 21:41:13 +0000 (21:41 +0000)]
Fix bug 896 by using tcp_dissect_pdus() .
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18027
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 28 Apr 2006 18:43:33 +0000 (18:43 +0000)]
Fetch a combobox control handle before we try to use it. Add some needed
_T macros. Remove some extraneous comments.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18026
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 28 Apr 2006 16:40:39 +0000 (16:40 +0000)]
Fix logic used to test protection under Windows OT. Only initialize
our page size and OS version information once.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18025
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 28 Apr 2006 09:44:02 +0000 (09:44 +0000)]
tcp analysis updates to prepare for later tcp reassembly updates
now that we have se_tree_lookup32_le we can do the tracking of pdu boundaries much more efficiently.
track pdu boundaries by a new tcp_multisegment_pdu structure that is indexed by sequence numbers and let this structure replace the older tcp_next_pdu structure.
with se_tree_lookup32_le we no longer need to track segment by segment and can get rid of the two hash tables
tcp_pdu_tracking_table
tcp_pdu_skipping_table
Neither do we need the tree tcp_pdu_time_table anymore so that one is gone as well.
remove various other functions that are no longer needed due to removing the structure and the tables/tree
this part of the code shoul;d be much more readable now and also a bit faster
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18024
f5534014-38df-0310-8fa8-
9805f1628bb7
kukosa [Fri, 28 Apr 2006 06:47:51 +0000 (06:47 +0000)]
- fix Bug 890
- remove c2asn() which did not work exactly
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18023
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 28 Apr 2006 06:29:19 +0000 (06:29 +0000)]
Don't change rflags for any properties other than
IEEE80211_RADIOTAP_FLAGS.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18022
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 27 Apr 2006 22:13:29 +0000 (22:13 +0000)]
add some higher packet length values
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18021
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 27 Apr 2006 19:58:32 +0000 (19:58 +0000)]
This was completely broken, as the "length" variable actually reflected
the amount of data left in the radiotap header after the fields we've
processed so far, not the total length of the header, so it couldn't be
used to skip past the radiotap header and get a tvbuff of the packet
data. Fix that.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18020
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 27 Apr 2006 19:12:50 +0000 (19:12 +0000)]
From Diego Petteno and Daniel Black: add more libraries to the list of
libraries with which we link libethereal, fixing the reopened bug 878.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18019
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 27 Apr 2006 18:46:05 +0000 (18:46 +0000)]
Add an extra null pointer check. Fixes Coverity CID 154.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18018
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 27 Apr 2006 14:58:46 +0000 (14:58 +0000)]
Properly grow our buffers for utf_8to16().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18017
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 27 Apr 2006 05:02:57 +0000 (05:02 +0000)]
From Martin Mathieson:
Fix typo in menu item name
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18016
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Wed, 26 Apr 2006 22:53:00 +0000 (22:53 +0000)]
From Mark C. Brown:
The code was incorrectly bounds checking AndXOffset. AndXOffset is only
relevant when AndXCommand is not 0xFF. This patch corrects erroneous
"Malformed packet" exceptions.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18015
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 26 Apr 2006 21:15:51 +0000 (21:15 +0000)]
Properly set our export file name before we try to use it. Fixes bug 894.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18012
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 26 Apr 2006 21:06:52 +0000 (21:06 +0000)]
If we're running under Windows 95/98/Me, don't abort if we can't protect
our guard pages.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18011
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 26 Apr 2006 20:16:57 +0000 (20:16 +0000)]
Add dissection of MPEG4 fmtp parameter.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18010
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 26 Apr 2006 20:13:33 +0000 (20:13 +0000)]
minor enhancements
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18009
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Wed, 26 Apr 2006 17:31:56 +0000 (17:31 +0000)]
Check for NULL return value from wtap_dump_open().
Fixes coverity bug 159.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18005
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Wed, 26 Apr 2006 15:10:23 +0000 (15:10 +0000)]
authesserre samuel <sauthess@gmail.com>:
The current ssl decryption code does not work for 3des session.
The attached patch fixes the problem.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18004
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 26 Apr 2006 09:40:49 +0000 (09:40 +0000)]
add tracking of ndmp conversations and use this to track the version used if we have seen the CONNECT_OPEN request.
rename the preference to DEFAULT protocol version to indicate it is only used for those conversation where we have not automatically detected the version used.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18003
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 26 Apr 2006 07:58:45 +0000 (07:58 +0000)]
NOTIFY_[DATA|MOVER]_HALTED requests no longer take an XDR string containing the reason for version 4 of ndmp and forward.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18002
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Wed, 26 Apr 2006 06:37:46 +0000 (06:37 +0000)]
Workaround for bug 852. Force a line break so that the text view doesn't blow up on excessive long lines.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18001
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 25 Apr 2006 19:12:08 +0000 (19:12 +0000)]
Add some more ANSI Message types and Parameters dissect ANSI cause.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18000
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 25 Apr 2006 18:45:08 +0000 (18:45 +0000)]
Add distclean and maintainerclean rules.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17999
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 25 Apr 2006 18:35:15 +0000 (18:35 +0000)]
Add distclean and maintainerclean rules.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17998
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 25 Apr 2006 18:34:09 +0000 (18:34 +0000)]
Add the usual Makefile.nmake comment.
Change "cd.." to "cd .." - I don't know whether they're equivalent, but,
if they're not, the former probably won't work.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17997
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 25 Apr 2006 18:01:43 +0000 (18:01 +0000)]
Check several sets of additional libraries that libpcap might need
(-lcfg -lodm on AIX with the current tcpdump.org libpcap, -lpfring with
the ring buffer stuff on Linux).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17996
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 25 Apr 2006 13:41:05 +0000 (13:41 +0000)]
Add a URL
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17995
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 25 Apr 2006 13:40:04 +0000 (13:40 +0000)]
Update from samba tree revision 14805 to 15243
============================ Samba log start ============
svn: When specifying working copy paths, only one target may be given
============================ Samba log end ==============
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17994
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 25 Apr 2006 08:25:25 +0000 (08:25 +0000)]
Ignore the generated plugin.c.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17993
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 25 Apr 2006 08:22:55 +0000 (08:22 +0000)]
Include non-dissector support files in the source.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17992
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 25 Apr 2006 01:42:35 +0000 (01:42 +0000)]
rename some value_Strings from ..._val to ..._vals
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17991
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Tue, 25 Apr 2006 01:22:05 +0000 (01:22 +0000)]
WinPcap 3.2 beta 1 (3, 2, 0, 29) seems to be working with the packet.dll, so don't warn the user about it
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17990
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Tue, 25 Apr 2006 01:00:16 +0000 (01:00 +0000)]
fix win32 build:
scsi_mmc_val DATA
scsi_sbc2_val DATA
scsi_ssc2_val DATA
BTW: these values should be renamed to ..._vals as in every other dissector I know!
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17989
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Tue, 25 Apr 2006 00:25:41 +0000 (00:25 +0000)]
various changes:
mention informational URLs at the beginning and not at each element
replace some // by /**/
start to decode the informational elements in the BSSID list
add a privacy tab to the BSSID list (None, WEP, WPA, WPA2)
various minor label changes
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17988
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Tue, 25 Apr 2006 00:18:06 +0000 (00:18 +0000)]
bugifx (should be copied to the 1.0 trunk): don't crash, if the interface hardware in question was removed since the list of interfaces was generated (NULL pointer returned from wpcap_packet_open() caused a crash)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17987
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Tue, 25 Apr 2006 00:12:43 +0000 (00:12 +0000)]
copy input data into the buffer given to PacketRequest(), so functions with input parameters will also work
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17986
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Mon, 24 Apr 2006 23:24:27 +0000 (23:24 +0000)]
remove a debugging printf
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17985
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Mon, 24 Apr 2006 23:09:34 +0000 (23:09 +0000)]
SCSI Service Response Time Staistics
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17984
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Mon, 24 Apr 2006 21:27:12 +0000 (21:27 +0000)]
Column list pointer became invalid when element was removed from list. Fixes bug 886.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17983
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 24 Apr 2006 19:11:33 +0000 (19:11 +0000)]
Preparations to include ANSI ISUP dissection.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17981
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 24 Apr 2006 19:10:36 +0000 (19:10 +0000)]
From Miha Jemec:
With the new feature we can:
1. Measure how big the bursts are for a video streams (it uses sliding window algorithm) 2. Measure how big the output buffer should be that no packet drop will occur (it uses Leaky bucket algorithm)
3. Detect if we have loses inside the MPEG2 video stream (if there are already MPEG2 packets missing) - this part of code is not added yet, see Limitations
The addition is called Multicast streams and works as follows:
- it uses the TAP system
- the main "stream" logic is taken from rtp_strems.* files
- the TAP system checks for UDP packets where the destination MAC address starts with "01:00:5E" (ethernet multicast address)
- it creates an entry for every new multicast stream
- based on sliding window and leaky bucket algorithm it calculates for every stream average BW, max BW, burst size, max buffer needed, some alarms if the limits are exceeded,...
- the same calculation is done for all streams together
- inside the window dialog you can specify the burst interval, the alarm limits and output speeds
To do & limitations:
- Currently the analysis can be done only for multicast streams, it means that VoD (Video on demand) or PayTV streams, which are normally unicast can not be analysed.
- since the MPEG2 is patended I don't know if decoding of MPEG2 packets is allowed? Can we look inside this packets and calculate packets drops based on some counter information inside the payload? Can someone please answer this question? If we can do this, I will post this part of code too.
- some more flexibility will be added
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17980
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 24 Apr 2006 19:08:52 +0000 (19:08 +0000)]
From Martin Mathieson:
This patch should hopefully remove any possible buffer overflows in
parse_line() as reported by the current Coverity scan. I'm not sure
that the error it currently reports is valid (I think its confused by
supposing that a condition that is being tested can be true, whereas it
can't...), but this patch fixes a number of potential problems remaining
in the function.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17979
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Mon, 24 Apr 2006 16:43:22 +0000 (16:43 +0000)]
Make some /******...*/ lines less wide: They make svn-diffs on the web page
unreadable unless you have a 2000xsomething display.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17978
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Mon, 24 Apr 2006 08:16:18 +0000 (08:16 +0000)]
change the signature for dissect_scsi_snsinfo() to take itlq and itl structures
update the comment in packet-scsi.c to reflect that it is the transport now that is responsible to track itl and itlq data
make scsi tapable
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17974
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 24 Apr 2006 05:04:30 +0000 (05:04 +0000)]
Use 2-space indentation.
Clean up the checks for STP vs. RSTP vs. MSTP.
Show the version 3 length field as a separate field, rather than as the
top-level item for the MSTP stuff.
"Trust" the version 3 length field, so that if it doesn't agree with the
packet length, we report a malformed frame (as we should).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17973
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 23 Apr 2006 20:14:33 +0000 (20:14 +0000)]
Use proto_tree_add_item() whenever possible; this simplifies the code,
and, in particular, means we don't, for example, use tvb_get_ntohs() to
fetch a 4-byte quantity - that fixes bug 883.
The MST config name is either null-terminated or null-padded; mark it as
such.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17972
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 23 Apr 2006 19:13:48 +0000 (19:13 +0000)]
Export tvb_uncompress to plugins; fixes bug 893.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17971
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 23 Apr 2006 18:54:32 +0000 (18:54 +0000)]
Try using the new generic plugin Makefile.nmake.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17970
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 23 Apr 2006 18:50:58 +0000 (18:50 +0000)]
From Diego Petteno: link the shared libethereal against the ADNS
library. If that's not done, it leaves to ethereal or other binaries
using it the job of linking adns within them. This behaviour is
unreliable and breaks when using the --as-needed flag for GNU ld
(version 2.16 or better 2.17).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17969
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 23 Apr 2006 18:05:23 +0000 (18:05 +0000)]
Fix CID: 150
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17968
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 23 Apr 2006 17:45:22 +0000 (17:45 +0000)]
Use the PLUGIN_NAME macro, to see if we can minimize the number of
changes needed to Makefile.nmake for a new plugin.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17967
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 23 Apr 2006 09:13:18 +0000 (09:13 +0000)]
"irda", not "ira".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17966
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 23 Apr 2006 08:23:49 +0000 (08:23 +0000)]
Resolve conflicts.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17965
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 23 Apr 2006 03:15:51 +0000 (03:15 +0000)]
Registration routines can't be static - they're called from plugin.c
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17964
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 23 Apr 2006 02:14:11 +0000 (02:14 +0000)]
Add the objects built from DISSECTOR_SUPPORT_SRC.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17963
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 22 Apr 2006 20:34:14 +0000 (20:34 +0000)]
add various OID's and a value_string for all of them
add output of some MAC_OPTIONS fields
enhance some 802.11 output labels
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17962
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 22 Apr 2006 20:26:16 +0000 (20:26 +0000)]
Convert most other plugin dissectors to use the make-dissector-reg
scripts.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17961
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 22 Apr 2006 20:16:47 +0000 (20:16 +0000)]
as I've experienced a scrollbar again while having 7 interfaces, I've tried to add the number of interfaces to the height formula to fix this
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17960
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 22 Apr 2006 13:44:11 +0000 (13:44 +0000)]
the "Generic dialup adapter" interface doesn't support any OID's at all, extend the tab insensitive mechanism to all tabs
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17959
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 22 Apr 2006 13:21:39 +0000 (13:21 +0000)]
add a new tab with TCP/IP offloading capabilities
add some debug functions to show available OID's
clarify some 802.11 item labels
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17958
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 22 Apr 2006 10:31:30 +0000 (10:31 +0000)]
put some exchange tracking info in scsi CDBs and DATA pdus
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17957
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 22 Apr 2006 10:15:00 +0000 (10:15 +0000)]
add the spc commands to the mmc tables
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17956
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 22 Apr 2006 10:00:05 +0000 (10:00 +0000)]
add the spc commands to the smc and ssc tables
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17955
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 22 Apr 2006 09:23:52 +0000 (09:23 +0000)]
add all supported SPC commands used by SBC to the SBC tables
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17954
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 22 Apr 2006 04:42:07 +0000 (04:42 +0000)]
start prettifying the dissection
make scsi responses also display the opcode in the info column
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17953
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 22 Apr 2006 02:16:52 +0000 (02:16 +0000)]
the scsi transports (fc/fcp and iscsi) now track both itl and itlq
structures for scsi.
we no longer need the scsi_task_id structure passed by pinfo->private_data so get rid of it.
we no longer need the (broken by design) scsi_task_data hash table since this has been replaced byt hte itl and itlq structures and tracking
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17952
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 21 Apr 2006 22:47:19 +0000 (22:47 +0000)]
change the HHC setting to HHC_DIR, so we can use it also to call the HtmlHelp function
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17951
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 21 Apr 2006 22:40:33 +0000 (22:40 +0000)]
prepare to list the IP addresses in the command line interfaces list output
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17950
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 21 Apr 2006 22:00:38 +0000 (22:00 +0000)]
remover the lun parameter from dissect_scsi_cdb/payload since this is now part of the exchange data in itlq
remove the two fields opcode and devtype from the scsi_task_data structure since these are also part of the itlq and itl structures
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17949
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 21 Apr 2006 21:09:09 +0000 (21:09 +0000)]
slightly rephrase the time zone chapter
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17948
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 21 Apr 2006 18:11:20 +0000 (18:11 +0000)]
From Jeff Morris:
I tried out the 0.99.0pre1 release and I noticed that all my SCCP management messages (on SSN==1) were getting decoded as TCAP. Turns out that the INAP dissector (due to a bug) registers to SSN==1 by default (instead of 106 and 241). Rather than just fix that bug, the attached patch modifies the INAP dissector to use a range preference (like GSM MAP, TCAP, etc.).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17945
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Fri, 21 Apr 2006 15:48:43 +0000 (15:48 +0000)]
From Irene: Fix a bug when searching for an assoc.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17944
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Fri, 21 Apr 2006 15:10:27 +0000 (15:10 +0000)]
From Chris Maynard:
Using the attached patch, this file was generated via "File -> Export -> as XML
- "PDML" (packet details) file ...". As can be seen in the file, the 1st
packet now contains the value for the "media", whereas previously it did not.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17943
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 21 Apr 2006 11:08:24 +0000 (11:08 +0000)]
updates to get the fc and scsi dissectors
and get rid of some breakage in the design
let the scsi transport keep track of itl (initiator, target, lun) matching
and let it pass a itl structure to scsi that is persistent across packets.
let scsi use this itl structure to track device type for a specific itl instead of the (must have been) broken hashtable.
update both iscsi and fc to track the itl structure for scsi and schange the scsi signature to accept itl as a parameter.
more to come.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17942
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 21 Apr 2006 02:18:24 +0000 (02:18 +0000)]
use a CSS stylesheet for HTML output. This seems to be the official way to format a sidebar to look different than normal floating text
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17941
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 21 Apr 2006 00:44:40 +0000 (00:44 +0000)]
enhance the "File Sets" page (e.g. add a screenshot)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17940
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Thu, 20 Apr 2006 21:17:18 +0000 (21:17 +0000)]
From: Shashidhar Bhandare
I have added ISUP dissector support for decoding four ANSI ISUP messages for decoding: CRM, CRA, CVT and CVR
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17939
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 20 Apr 2006 20:40:29 +0000 (20:40 +0000)]
fix help button settings
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17938
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 20 Apr 2006 20:35:58 +0000 (20:35 +0000)]
if HHC_DIR is defined in config.nmake, link Ethereal with the required htmlhelp.lib
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17937
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 20 Apr 2006 20:33:04 +0000 (20:33 +0000)]
if HHC_DIR is defined in config.nmake, include the user-guide.chm file into the Win32 installer
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17936
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 20 Apr 2006 20:31:05 +0000 (20:31 +0000)]
add a Help button to the Preferences dialog
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17935
f5534014-38df-0310-8fa8-
9805f1628bb7