obnox/wireshark/wip.git
15 years agoWe always use start_offset, so don't wrap it in "#ifdef HAVE_KERBEROS".
gerald [Tue, 30 Sep 2008 02:55:42 +0000 (02:55 +0000)]
We always use start_offset, so don't wrap it in "#ifdef HAVE_KERBEROS".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26301 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd a cast to try to fix compilation on Windows.
gerald [Tue, 30 Sep 2008 02:55:13 +0000 (02:55 +0000)]
Add a cast to try to fix compilation on Windows.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26300 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agodissect lookupnames3
sahlberg [Mon, 29 Sep 2008 22:10:40 +0000 (22:10 +0000)]
dissect lookupnames3

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26299 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Derek Morr:
jake [Mon, 29 Sep 2008 21:40:53 +0000 (21:40 +0000)]
From Derek Morr:
The DNS dissector conflates KEY (used for TSIG) and DNSKEY records. Also, the
DNSKEY dissector doesn't parse the REVOKED flag, defined in RFC 5011.

The attached patch splits KEY and DNSKEY parsing, and adds support for REVOKED.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26298 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Jelmer Vernooij:
jake [Mon, 29 Sep 2008 21:39:13 +0000 (21:39 +0000)]
From Jelmer Vernooij:
The attached patch adds support for dissecting GSSAPI authentication
data to the SOCKS dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26297 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agothere exists clients (linux) that sends a SETCLIENTID specifying the
sahlberg [Mon, 29 Sep 2008 21:06:12 +0000 (21:06 +0000)]
there exists clients (linux) that sends a SETCLIENTID specifying the
callback address/port with only 2 octets (high/low port)  i.e. witout
specifying the ip address.

this caused wireshark to corrupt memory when trying to 0-terminate the
original string after the fourth '.'   which happened to be beyond the
end of the string.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26296 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agofrom metze
sahlberg [Mon, 29 Sep 2008 18:52:17 +0000 (18:52 +0000)]
from metze

fallback to spnego_krb5_wrap for RFC4121 krb5 blobs

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26295 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agofrom Metze
sahlberg [Mon, 29 Sep 2008 18:44:10 +0000 (18:44 +0000)]
from Metze

add dissection of RFC4121 krb5 blobs

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26294 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agofrom metze
sahlberg [Mon, 29 Sep 2008 18:38:45 +0000 (18:38 +0000)]
from metze

add support for decryption of gssapi auth type 16

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26293 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoWindows Vista: Fix so 'touch --reference ...' file mod time is always gt Makefile...
wmeier [Mon, 29 Sep 2008 17:05:46 +0000 (17:05 +0000)]
Windows Vista: Fix so 'touch --reference ...' file mod time is always gt Makefile.nmake time

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26292 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoGSM MAP: inconsistent spacing in Info column
etxrab [Mon, 29 Sep 2008 16:57:09 +0000 (16:57 +0000)]
GSM MAP: inconsistent spacing in Info column
Bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2912

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26291 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd Sequence Number for DTAP messages.
etxrab [Mon, 29 Sep 2008 16:53:28 +0000 (16:53 +0000)]
Add Sequence Number for DTAP messages.
Fixes bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2490

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26290 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Joan Ramio:
etxrab [Mon, 29 Sep 2008 16:49:14 +0000 (16:49 +0000)]
From  Joan Ramio:
New dissector IEC 60870-5-104.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26289 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Jelmer Vernooij:
etxrab [Mon, 29 Sep 2008 16:28:34 +0000 (16:28 +0000)]
From Jelmer Vernooij:
Support for AYIYA protocol.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26288 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Francesco Fusco:
etxrab [Mon, 29 Sep 2008 16:20:24 +0000 (16:20 +0000)]
From  Francesco Fusco:
Endace ERFII (extension header) support.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26287 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Reinhard(rspmn):
etxrab [Sat, 27 Sep 2008 14:16:55 +0000 (14:16 +0000)]
From Reinhard(rspmn):
Wrong display of USSD strings in the GSM 7-bit alphabet for non-ASCII data

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26286 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMinor cleanup for proto_reg-handoff & etc
wmeier [Sat, 27 Sep 2008 14:02:23 +0000 (14:02 +0000)]
Minor cleanup for proto_reg-handoff & etc

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26285 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoSmall cleanup of proto_reg_handoff & etc
wmeier [Sat, 27 Sep 2008 13:38:59 +0000 (13:38 +0000)]
Small cleanup of proto_reg_handoff & etc
- 'once-only' not req'd in some cases
- use find_dissector as appropriate
- remove unneeded code

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26284 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoHandle pref change via pref callback instead of registering an init fcn
wmeier [Sat, 27 Sep 2008 01:08:19 +0000 (01:08 +0000)]
Handle pref change via pref callback instead of registering an init fcn

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26283 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAddt'l minor change relating to proto_reg_handoff
wmeier [Fri, 26 Sep 2008 22:34:41 +0000 (22:34 +0000)]
Addt'l minor change relating to proto_reg_handoff

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26282 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMinor cleanup related to proto_register and proto_reg_handoff
wmeier [Fri, 26 Sep 2008 22:07:45 +0000 (22:07 +0000)]
Minor cleanup related to proto_register and proto_reg_handoff

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26281 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMinor cleanup related to proto_register & proto_reg_handoff
wmeier [Fri, 26 Sep 2008 20:06:40 +0000 (20:06 +0000)]
Minor cleanup related to proto_register & proto_reg_handoff

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26280 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAddt'l minor cleanup
wmeier [Fri, 26 Sep 2008 17:12:15 +0000 (17:12 +0000)]
Addt'l minor cleanup

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26279 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoprefs callback not req'd
wmeier [Fri, 26 Sep 2008 17:06:44 +0000 (17:06 +0000)]
prefs callback not req'd

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26278 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMinor cleanups related to proto_reg_handoff
wmeier [Fri, 26 Sep 2008 17:04:01 +0000 (17:04 +0000)]
Minor cleanups related to proto_reg_handoff

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26277 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoReformat somewhat for readability
wmeier [Fri, 26 Sep 2008 16:45:28 +0000 (16:45 +0000)]
Reformat somewhat for readability

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26276 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoChange emv -> evm, as noted in bug 2903.
stig [Fri, 26 Sep 2008 10:15:58 +0000 (10:15 +0000)]
Change emv -> evm, as noted in bug 2903.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26275 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Sagar Pai:
jake [Thu, 25 Sep 2008 22:06:58 +0000 (22:06 +0000)]
From Sagar Pai:
This is a dissector for ZRTP, the Zfone projects secure media protocol, developed by Phil Zimmermann.
It is updated to the latest IETF draft draft-zimmermann-avt-zrtp-08.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26274 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoYet another GTK+ update...
etxrab [Thu, 25 Sep 2008 20:32:00 +0000 (20:32 +0000)]
Yet another GTK+ update...
Overview of Changes from GTK+ 2.14.2 to 2.14.3
==============================================

* Revert problematic GtkAdjustment changes

* Bugs fixed:
 552837 mem leak in gtkimmulticontext
 553000 incorrect i18n header in gtkfilesystem.c
 553135 eog crash: assertion failed
 552545 leaks GpImage

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26273 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd the missing part of the fix for "Failure to dissect long SASL wrapped LDAP response".
etxrab [Thu, 25 Sep 2008 19:21:44 +0000 (19:21 +0000)]
Add the missing part of the fix for "Failure to dissect long SASL wrapped LDAP response".
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2687

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26272 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUpdate to the latest asn1 files and try to get rid of unused code warnings.
etxrab [Thu, 25 Sep 2008 19:20:14 +0000 (19:20 +0000)]
Update to the latest asn1 files and try to get rid of unused code warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26271 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUpdate to the latest asn1 files and try to get rid of unused code warnings.
etxrab [Thu, 25 Sep 2008 19:19:39 +0000 (19:19 +0000)]
Update to the latest asn1 files and try to get rid of unused code warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26270 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agodo not call proto_tree_add_...() inside PROTO_ITEM_SET_HIDDEN() macro
kukosa [Thu, 25 Sep 2008 18:32:14 +0000 (18:32 +0000)]
do not call proto_tree_add_...() inside PROTO_ITEM_SET_HIDDEN() macro
it creates item three times

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26269 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix for Bug 2891:
sake [Thu, 25 Sep 2008 06:21:02 +0000 (06:21 +0000)]
Fix for Bug 2891:

Read the capture setting from the preferences *before* parsing the
capture command line arguments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26268 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd value_string to dissect_q931_cause_ie().
etxrab [Thu, 25 Sep 2008 05:21:33 +0000 (05:21 +0000)]
Add value_string to dissect_q931_cause_ie().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26267 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoGet rid of no-longer-used variables.
guy [Thu, 25 Sep 2008 02:57:58 +0000 (02:57 +0000)]
Get rid of no-longer-used variables.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26266 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMinor proto_reg_handoff cleanup
wmeier [Thu, 25 Sep 2008 02:21:04 +0000 (02:21 +0000)]
Minor proto_reg_handoff cleanup

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26265 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoPacket-isup.c &packet-q931.[ch]:
etxrab [Wed, 24 Sep 2008 21:59:50 +0000 (21:59 +0000)]
Packet-isup.c &packet-q931.[ch]:
In case of cause pointing out ie "faults" use the correct "ie value_string".
in packet-isup.c use packet-e164.c for country code translation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26264 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agotrack smb dialects between negprot request to the responses so we can
sahlberg [Wed, 24 Sep 2008 16:16:01 +0000 (16:16 +0000)]
track smb dialects between negprot request to the responses so we can
show the name of the selected dialect in the response and not just the
index

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26263 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2848 :
morriss [Wed, 24 Sep 2008 13:41:47 +0000 (13:41 +0000)]
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2848 :
Decode SUA GT digits.  This removes the (undecoded, raw BCD) FT_BYTES field
sua.global_title_signals and adds an FT_STRING field sua.global_title_digits
(like in SCCP).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26262 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoput original tag name (not lowercase) into dissected xml structure too
kukosa [Wed, 24 Sep 2008 10:42:24 +0000 (10:42 +0000)]
put original tag name (not lowercase) into dissected xml structure too
dissect xml even if tree is null

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26261 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUpdate release number.
jake [Wed, 24 Sep 2008 06:25:39 +0000 (06:25 +0000)]
Update release number.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26260 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoSwitch back to normal versioning. Bump the development version to 1.1.2.
gerald [Wed, 24 Sep 2008 03:29:21 +0000 (03:29 +0000)]
Switch back to normal versioning. Bump the development version to 1.1.2.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26259 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix indentation to be reasonably consistent
wmeier [Wed, 24 Sep 2008 00:50:18 +0000 (00:50 +0000)]
Fix indentation to be reasonably consistent

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26258 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAs reported by Chidambaram Arunachalam in bug 2893:
stig [Tue, 23 Sep 2008 23:58:23 +0000 (23:58 +0000)]
As reported by Chidambaram Arunachalam in bug 2893:
Handle RVALS correctly in proto_tree_set_(u)int and label_fill_(u)int

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26257 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoBuild 1.1.1.
gerald [Tue, 23 Sep 2008 21:05:00 +0000 (21:05 +0000)]
Build 1.1.1.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26256 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUse the latest GTK packages, changes:
etxrab [Tue, 23 Sep 2008 20:32:40 +0000 (20:32 +0000)]
Use the latest GTK packages, changes:
Overview of Changes from GLib 2.18.0 to GLib 2.18.1
===================================================

* Bugs fixed:
 550433 g_test_init doesn't recognize --help
 523463 Core dump in gmain.c:2482:IA__g_main_context_check
 551228 G_STRFUNC on recent Sun compiler should be expanded...
 551410 gtestutils.c: using printf without prototype
 551731 g_date_set_time[_t] docs should mention what timezone
 548321 <string.h> is not included in gi18n-lib.h
 551149 xdgmime mem leak
 550647 synchronous pipe I/O when reading mount reply
 551887 Docs for g_desktop_app_info_new_from_filename aren't...
 551681 g_content_type_guess() too naive with filenames
 552352 g_app_info_launch doesn't work if "Path" key...
 551408 gmodule.def generated to builddir...
 552359 g_file_info_get_icon should return GThemedIcon, and...

Overview of Changes from GTK+ 2.14.1 to 2.14.2
==============================================

* Don't use XRRGetScreenResources, since it doesn't work well

* Bugs fixed:
 551063 deprecated marking without a link to what new code should use
 319849 gtkcalendar look in RTL locales
 550989 gdk_display_put_event should call g_main_context_wakeup
 550062 Small update in gdk/gdkkeysyms.h
 551325 Reference to wrong parameter in gtk_editable_insert_text
 551386 gtk_printer_set_is_default() always sets TRUE
 550676 Memory leak, update keyboard layout data structure
 551699 gtk_scrolled_window_destroy() is broken
 551567 DND mark broken
 551378 Print dialog: should try UDS when fetching PPD for localhost
 536542 gtk_list_store_set() documentation doesn't say whether...
 552153 GtkModules loading with XSettings doesn't work...
 552001 gtkimcontextsimple.c: variable is declared at middle...
 551987 GtkPaned redrawing problem
 551722 gtk_widget_set_scroll_adjustments() should check...
 552107 Small libtool fixes
 552500 GtkPrintSettings API doc not precise enough
 408154 Change GtkEntryCompletion max-items to style property
 329593 Entering characters on a line very cpu intensive and slow
 552667 gtkimage containing gicon leaks memory
 552668 format not a string literal and no format arguments...
 346903 gtk_enumerate_printers needs events to complete
 550969 fix a typo which breaks the static build
 517233 Calling gdk_pixbuf_loader_close causes "GError set over...
 551063 deprecated marking without a link to what new code should use
 540967 docs build slowly because of entities

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26255 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMinor changes related to proto_reg_handoff & pref ranges
wmeier [Tue, 23 Sep 2008 15:03:39 +0000 (15:03 +0000)]
Minor changes related to proto_reg_handoff & pref ranges

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26254 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMinor change: use guint for prefs port variables.
wmeier [Tue, 23 Sep 2008 01:10:45 +0000 (01:10 +0000)]
Minor change: use  guint for prefs port variables.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26253 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMinor revision related to proto_reg_handoff ...
wmeier [Tue, 23 Sep 2008 00:55:28 +0000 (00:55 +0000)]
Minor revision related to proto_reg_handoff ...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26252 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoTrivial changes: comment and spacing
wmeier [Tue, 23 Sep 2008 00:45:05 +0000 (00:45 +0000)]
Trivial changes: comment and spacing

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26251 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix minor bug: dissector_delete(...) should be "tcp" and not "udp".
wmeier [Tue, 23 Sep 2008 00:33:33 +0000 (00:33 +0000)]
Fix minor bug:  dissector_delete(...)  should be "tcp" and not "udp".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26250 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoPolish up the proto_tree_add_bitmask() description example.
jake [Mon, 22 Sep 2008 22:15:26 +0000 (22:15 +0000)]
Polish up the proto_tree_add_bitmask() description example.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26249 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix for bug 2889:
jake [Mon, 22 Sep 2008 21:53:44 +0000 (21:53 +0000)]
Fix for bug 2889:
Add description of FT_UINT_BYTES.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26248 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix:About dialog: all text selected when switching tabs
etxrab [Mon, 22 Sep 2008 21:28:55 +0000 (21:28 +0000)]
Fix:About dialog: all text selected when switching tabs
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1349
Hopfully the right thing to do :)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26247 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMinor cleanup related to proto_reg_handoff
wmeier [Mon, 22 Sep 2008 16:26:41 +0000 (16:26 +0000)]
Minor cleanup related to proto_reg_handoff

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26246 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoTurn on -Werror for the top level targets, excluding text2pcap (which includes some...
morriss [Sun, 21 Sep 2008 14:59:05 +0000 (14:59 +0000)]
Turn on -Werror for the top level targets, excluding text2pcap (which includes some generated code).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26245 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoDon't define a static variable (the_tapinfo_struct) in a header file; instead declare...
morriss [Sun, 21 Sep 2008 14:50:05 +0000 (14:50 +0000)]
Don't define a static variable (the_tapinfo_struct) in a header file; instead declare it in each C file that needs it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26244 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoTry to fix some "defined but not used" warnings.
etxrab [Sun, 21 Sep 2008 14:23:34 +0000 (14:23 +0000)]
Try to fix some  "defined but not used" warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26243 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoDeclare ts_sec as a time_t because that's how it's used; this avoids a warning
morriss [Sun, 21 Sep 2008 14:04:41 +0000 (14:04 +0000)]
Declare ts_sec as a time_t because that's how it's used; this avoids a warning
about how dereferencing a type-punned pointer will break strict-aliasing rules
when calling localtime().
Make ts_sec in text2pcap's definition of a PCAP record header unsigned to match
that in libpcap.h .
Cast the time_t into guint32 as necessary.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26242 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Derek Morr:
jake [Sun, 21 Sep 2008 13:55:32 +0000 (13:55 +0000)]
From Derek Morr:
The Kerberos dissector does not parse IPv6 addresses in AS-REQ messages.
Attached is a patch that adds IPv6 dissection support, and adds a new filter,
kerberos.addr_ipv6, which is analagous to the existing kerberos.addr_ip.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26241 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoDo not leak the port range in parse_service_line().
stig [Sat, 20 Sep 2008 14:24:29 +0000 (14:24 +0000)]
Do not leak the port range in parse_service_line().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26240 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoThe Official Home of the AVS header spec appears to bhe the
guy [Sat, 20 Sep 2008 01:57:18 +0000 (01:57 +0000)]
The Official Home of the AVS header spec appears to bhe the
linux-wlan-ng source tree; just insert it verbatim into a big honking
comment, rather than trying to play Find The URL with it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26239 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUpdate Dustin's email address.
gerald [Fri, 19 Sep 2008 23:57:15 +0000 (23:57 +0000)]
Update Dustin's email address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26238 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMinor cleanup primarily related to proto_reg_handoff; spacing changes
wmeier [Fri, 19 Sep 2008 20:42:01 +0000 (20:42 +0000)]
Minor cleanup primarily related to proto_reg_handoff; spacing changes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26237 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMinor cleanup mostly related to proto_reg_handoff
wmeier [Fri, 19 Sep 2008 17:39:44 +0000 (17:39 +0000)]
Minor cleanup mostly related to proto_reg_handoff

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26236 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd a newline at the end of the file
morriss [Fri, 19 Sep 2008 16:40:37 +0000 (16:40 +0000)]
Add a newline at the end of the file

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26235 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoSet SVN properties.
gerald [Fri, 19 Sep 2008 16:28:57 +0000 (16:28 +0000)]
Set SVN properties.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26234 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMove wtap_pcap_encap_to_wtap_encap and wtap_wtap_encap_to_pcap_encap to
gerald [Fri, 19 Sep 2008 16:26:37 +0000 (16:26 +0000)]
Move wtap_pcap_encap_to_wtap_encap and wtap_wtap_encap_to_pcap_encap to
libwsutil.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26233 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoDump the unsupported opcode for invoke result and invoke error,
stig [Fri, 19 Sep 2008 15:28:43 +0000 (15:28 +0000)]
Dump the unsupported opcode for invoke result and invoke error,
as is done for invoke argument.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26232 f5534014-38df-0310-8fa8-9805f1628bb7

15 years ago(Temporarily?) Put libwireshark_la_DEPENDENCIES back: it seems to allow inet_aton...
morriss [Fri, 19 Sep 2008 12:23:21 +0000 (12:23 +0000)]
(Temporarily?) Put libwireshark_la_DEPENDENCIES back: it seems to allow inet_aton.c to get built if it is needed (not sure why). There should be a better way to deal with this.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26231 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoIf we get an LSSU of length 2, interpret the first octet of the SF field the
morriss [Fri, 19 Sep 2008 12:19:17 +0000 (12:19 +0000)]
If we get an LSSU of length 2, interpret the first octet of the SF field the
same as it would be for a LSSU of length 1 (see Q.703/11.1.2).  Since the
second octet is undefined just display it was a hex FT_UINT8.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26230 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoCorrect the field lengths for the segmentation parameter (fixes the highlighting...
morriss [Fri, 19 Sep 2008 12:17:32 +0000 (12:17 +0000)]
Correct the field lengths for the segmentation parameter (fixes the highlighting in the byte pane).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26229 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix a spelling error pointed out by Noam Rathaus.
gerald [Thu, 18 Sep 2008 17:19:15 +0000 (17:19 +0000)]
Fix a spelling error pointed out by Noam Rathaus.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26228 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agohttp://www.gnu.org/software/libtool/manual/libtool.html#Inter_002dlibrary-dependencies
morriss [Thu, 18 Sep 2008 13:31:14 +0000 (13:31 +0000)]
gnu.org/software/libtool/manual/libtool.html#Inter_002dlibrary-dependencies
says:

"However, most shared library systems are restricted in that they only allow a
single level of dependencies. In these systems, programs may depend on shared
libraries, but shared libraries may not depend on other shared libraries."

So reverse the top-level Makefile.am change of rev 26218.  That is: link the
executables against libwsutil again.

This hopefully will fix:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1677#c23

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26227 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoIf we're dissecting for a read filter in the GUI [tshark assigns
morriss [Wed, 17 Sep 2008 21:59:15 +0000 (21:59 +0000)]
If we're dissecting for a read filter in the GUI [tshark assigns
frame numbers before running the read filter], don't do the TSN
analysis.  (We can't anyway because we don't have a valid frame
number...)

Without this change if you load a capture file in the
GUI while using a read filter, every SCTP TSN is marked as a
retransmission of that in frame 0.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26226 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoA couple of trivial indentation fixes
morriss [Wed, 17 Sep 2008 15:54:55 +0000 (15:54 +0000)]
A couple of trivial indentation fixes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26225 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoPut back the "Checking whether to use the GNU ADNS library if available"
guy [Wed, 17 Sep 2008 08:09:45 +0000 (08:09 +0000)]
Put back the "Checking whether to use the GNU ADNS library if available"
message, so that the "yes" or "no" printed when the check finishes is
associated with a "Checking..." message.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26224 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix some imdentation
wmeier [Wed, 17 Sep 2008 03:27:40 +0000 (03:27 +0000)]
Fix some imdentation

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26223 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMinor cleanup related to proto_reg_handoff
wmeier [Wed, 17 Sep 2008 03:21:55 +0000 (03:21 +0000)]
Minor cleanup related to proto_reg_handoff

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26222 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoinet_aton(), like inet_pton(), is in -lsocket in Solaris and possibly
guy [Wed, 17 Sep 2008 02:31:05 +0000 (02:31 +0000)]
inet_aton(), like inet_pton(), is in -lsocket in Solaris and possibly
other SVR4-flavored UN*Xes; search for it the same way we search for
inet_pton().

Note that, while that fixes the Solaris build, this probably still
wouldn't build on a platform without inet_aton() (if any such exist),
and might have problems with platforms lacking other functions (as they
handle this similarly).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26221 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUpdate the Win32 libs download tag to 2008-09-16.
gerald [Tue, 16 Sep 2008 22:49:00 +0000 (22:49 +0000)]
Update the Win32 libs download tag to 2008-09-16.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26220 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd /D_BIND_TO_CURRENT_CRT_VERSION=1 to LOCAL_CFLAGS in modern versions
gerald [Tue, 16 Sep 2008 21:08:18 +0000 (21:08 +0000)]
Add /D_BIND_TO_CURRENT_CRT_VERSION=1 to LOCAL_CFLAGS in modern versions
of Visual C++. (How did this "feature" ever see the light of day?) Make
sure we use LOCAL_CFLAGS *everywhere*. This should fix problems with
building a usable installer under Visual Studio 2008 SP1.

Add comments with links to Visual C++'s idiotic handling of assemblies
and deployment using xcopy. Move to c-ares 1.5.3. Make sure we remove
all of our manifests in epan and packaging/u3/tools.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26219 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoLink libwireshark and wiretap against libwsutil. That was the original intent
morriss [Tue, 16 Sep 2008 19:24:25 +0000 (19:24 +0000)]
Link libwireshark and wiretap against libwsutil.  That was the original intent
of adding libwsutil but somehow I missed it/got it wrong.  This should solve
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1677#c18

Also remove the _DEPENDENCIES lines in epan and wiretap (as was done in the
top-level Makefile in rev 25930) so that automake will automatically figure out
the dependencies for us.

Since the those 2 libraries now link against libwsutil, don't make every
executable link against the library.  (If this works I think we can
significantly trim the list of libraries the executables link against and just
let the libraries pull in what they need--which is, apparently, the point of
the --as-needed flag: http://www.gentoo.org/proj/en/qa/asneeded.xml ).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26218 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix compilation under Windows (uint -> guint).
gerald [Tue, 16 Sep 2008 18:26:43 +0000 (18:26 +0000)]
Fix compilation under Windows (uint -> guint).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26217 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdds 64 bit integer handling to Lua interface.
rbalint [Tue, 16 Sep 2008 14:37:00 +0000 (14:37 +0000)]
Adds 64 bit integer handling to Lua interface.
Fixes bug 2750.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26216 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix for bug 1965:
rbalint [Tue, 16 Sep 2008 14:00:48 +0000 (14:00 +0000)]
Fix for bug 1965:
Fix ByteArray append() and set_size()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26215 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Vladimir Koutny:
jake [Tue, 16 Sep 2008 05:43:36 +0000 (05:43 +0000)]
From Vladimir Koutny:
The size of selected_registrar fiels in WPS IE should be 1b, not 2b
(it is defined as BOOL in WPS specs).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26214 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd libgail.dll to the list of files to be removed.
gerald [Tue, 16 Sep 2008 00:57:46 +0000 (00:57 +0000)]
Add libgail.dll to the list of files to be removed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26213 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix for bug 2875:
jake [Mon, 15 Sep 2008 21:50:50 +0000 (21:50 +0000)]
Fix for bug 2875:
Fix a final eth_fopen -> ws_fopen
When configuring with --without-zlib these functions need to have some parameters tagged _U_

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26212 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoPut Data dissection (if no subdissector is found) on the toplevel tree instead of...
morriss [Mon, 15 Sep 2008 20:35:02 +0000 (20:35 +0000)]
Put Data dissection (if no subdissector is found) on the toplevel tree instead of within the SUA tree.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26211 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoIf ANSI and national==0, decode the PC as ITU (not China). This fixes bug 2861.
morriss [Mon, 15 Sep 2008 20:17:47 +0000 (20:17 +0000)]
If ANSI and national==0, decode the PC as ITU (not China).  This fixes bug 2861.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26210 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoSince we require autoconf 2.60 or later, update the error message to indicate that...
morriss [Mon, 15 Sep 2008 19:57:56 +0000 (19:57 +0000)]
Since we require autoconf 2.60 or later, update the error message to indicate that (rather than still indicating that we need only 2.52).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26209 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoproto_reg_handoff: fix so port pref change works; gen'l cleanuop
wmeier [Mon, 15 Sep 2008 19:54:40 +0000 (19:54 +0000)]
proto_reg_handoff: fix so port pref change works; gen'l cleanuop

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26208 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Michael Bernhard:
jake [Mon, 15 Sep 2008 19:49:43 +0000 (19:49 +0000)]
From Michael Bernhard:
The dissector asserted displaying cookies in DTLS frames because it was registered as FT_NONE.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26207 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix compile error
wmeier [Mon, 15 Sep 2008 19:38:16 +0000 (19:38 +0000)]
Fix compile error

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26206 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix so pkt_ccc port pref works; proto_reg_handoff's: gen'l cleanup.
wmeier [Mon, 15 Sep 2008 19:33:38 +0000 (19:33 +0000)]
Fix so pkt_ccc port pref works; proto_reg_handoff's: gen'l cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26205 f5534014-38df-0310-8fa8-9805f1628bb7

15 years ago'static initialized' --> 'static gboolean initialized'
wmeier [Mon, 15 Sep 2008 19:03:03 +0000 (19:03 +0000)]
'static initialized' --> 'static gboolean initialized'

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26204 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoproto_reg_handoff: rework/cleanup; fix so ports properly deleted/added.
wmeier [Mon, 15 Sep 2008 18:58:03 +0000 (18:58 +0000)]
proto_reg_handoff: rework/cleanup; fix so ports properly deleted/added.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26203 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoproto_reg-handoff: Fix to properly delete/add port when pref changed; cleanup.
wmeier [Mon, 15 Sep 2008 18:48:28 +0000 (18:48 +0000)]
proto_reg-handoff: Fix to properly delete/add port when pref changed; cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26202 f5534014-38df-0310-8fa8-9805f1628bb7