obnox/wireshark/wip.git
21 years agoMarking packets with the middle mouse button works now with GTK2.
oabad [Thu, 28 Aug 2003 20:33:14 +0000 (20:33 +0000)]
Marking packets with the middle mouse button works now with GTK2.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8301 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFix signed/unsigned comparison warning.
gram [Thu, 28 Aug 2003 17:26:15 +0000 (17:26 +0000)]
Fix signed/unsigned comparison warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8300 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFix small display bug. we returned the wrong value from dissect_per_choice and...
sahlberg [Thu, 28 Aug 2003 14:41:20 +0000 (14:41 +0000)]
Fix small display bug.    we returned the wrong value from dissect_per_choice and it made us display the wrong string sometimes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8299 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoUpdate to H.225 when H.245 is tunneled in some octet strings,
sahlberg [Thu, 28 Aug 2003 14:29:41 +0000 (14:29 +0000)]
Update to H.225    when H.245 is tunneled in some octet strings,
call the h245 dissector instead of just showing the octet string content as some random hex bytes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8298 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoupdate to h245 to decode the county codes
sahlberg [Thu, 28 Aug 2003 12:57:24 +0000 (12:57 +0000)]
update to h245 to decode the county codes

from anders broman

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8297 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoUpdate a comment.
guy [Thu, 28 Aug 2003 04:46:13 +0000 (04:46 +0000)]
Update a comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8296 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoMake "process_reassembled_data()" do the check for fragmentation not
guy [Thu, 28 Aug 2003 04:19:29 +0000 (04:19 +0000)]
Make "process_reassembled_data()" do the check for fragmentation not
being complete and for fragmentation being trivial (i.e., the packet in
question is both the first and last fragment).  Have its callers *not*
do that check - this lets "process_reassembled_data()" put in the
"Reassembled in" item for fragments other than the last fragment.

Add a "Reassembled in" field to TDS.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8295 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdd a "reassembled in" field.
guy [Thu, 28 Aug 2003 03:35:23 +0000 (03:35 +0000)]
Add a "reassembled in" field.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8294 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoIt appears that TDS packets do have a sequence number; use that when
guy [Thu, 28 Aug 2003 02:19:00 +0000 (02:19 +0000)]
It appears that TDS packets do have a sequence number; use that when
reassembling.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8293 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoUse "process_reassembled_data()"; this means we get to use common code,
guy [Thu, 28 Aug 2003 02:12:26 +0000 (02:12 +0000)]
Use "process_reassembled_data()"; this means we get to use common code,
and it means we only dissect the reassembled data for the last frame (so
code running through the packet list, and humans clicking on frames, see
only one instance of the reassembled data, not multiple instances that
might look like retransmissions).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8292 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdd an API to let a dissector register a dissector table and field for a
guy [Thu, 28 Aug 2003 01:29:16 +0000 (01:29 +0000)]
Add an API to let a dissector register a dissector table and field for a
given OUI; the field is used when the PID for that OUI is put into the
protocol tree, and the dissector table is used to find a dissector for
that PID.

Not yet used, thus not yet tested; API is subject to change.
(Eventually, several of the cases in the big switch statement in
"dissect_llc()" should be handled by registering information for those
OUIs.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8291 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Giles Scott: Nortel/SynOptics Network Management Protocol support.
guy [Thu, 28 Aug 2003 00:11:32 +0000 (00:11 +0000)]
From Giles Scott: Nortel/SynOptics Network Management Protocol support.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8290 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoMake various lengths unsigned in "dissect_fhandle_data_unknown()", so
guy [Wed, 27 Aug 2003 23:53:07 +0000 (23:53 +0000)]
Make various lengths unsigned in "dissect_fhandle_data_unknown()", so
lengths > 2^31-1 get handled correctly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8289 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Yaniv Kaul: fix the dissection of TDS7 login packets, and add
guy [Wed, 27 Aug 2003 23:28:37 +0000 (23:28 +0000)]
From Yaniv Kaul: fix the dissection of TDS7 login packets, and add
dissection for several fields in that packet.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8288 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoThe Fibre Channel dissector doesn't have any tables in which it
guy [Wed, 27 Aug 2003 23:05:59 +0000 (23:05 +0000)]
The Fibre Channel dissector doesn't have any tables in which it
registers itself - it's just imported by name.  Get rid of the
"create_dissector_handle()" call, as the resulting dissector handle
isn't ever used.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8287 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoUse "GPOINTER_TO_INT()" to convert the return value of
guy [Wed, 27 Aug 2003 23:01:10 +0000 (23:01 +0000)]
Use "GPOINTER_TO_INT()" to convert the return value of
"gtk_clist_get_row_data()" to an "int", to squelch compiler warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8286 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Richard Urwin:
guy [Wed, 27 Aug 2003 22:55:51 +0000 (22:55 +0000)]
From Richard Urwin:

use Export and Import for the buttons in GTK+ 2.x as well;

get rid of a duplicate fclose;

other fixes.

Update the description of color filters in the Ethereal man page to
reflect the change, clean up the formatting (use =item), and add the
global and personal color filters files to the FILES section; refer to
them as "color filters" files rather than "colorfilters" files, as the
FILES section gives the "colorfilters" file name so you don't have to
use that as the name.

Clean up white space.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8285 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFix a typo.
guy [Wed, 27 Aug 2003 21:59:12 +0000 (21:59 +0000)]
Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8284 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoupdate to the talkers popup list.
sahlberg [Wed, 27 Aug 2003 21:54:36 +0000 (21:54 +0000)]
update to the talkers popup list.

hopefully it will now create the filter for the actual conversation
we selected.

add EP1 <-> ANY and EP2 <-> ANY fitlers

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8283 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Jesper Peterson: fix a typo.
guy [Wed, 27 Aug 2003 21:12:27 +0000 (21:12 +0000)]
From Jesper Peterson: fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8282 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoInclude <string.h> to get "strlen()" declared.
guy [Wed, 27 Aug 2003 21:11:39 +0000 (21:11 +0000)]
Include <string.h> to get "strlen()" declared.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8281 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdd a "contains" operator for byte-strings, strings, and tvbuffs (protocols).
gram [Wed, 27 Aug 2003 15:23:11 +0000 (15:23 +0000)]
Add a "contains" operator for byte-strings, strings, and tvbuffs (protocols).
The search uses a naive approach; more work is required to add a
Boyer-Moore Search algorithm.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8280 f5534014-38df-0310-8fa8-9805f1628bb7

21 years ago Updates for the endpoint talkers thing
sahlberg [Wed, 27 Aug 2003 12:10:21 +0000 (12:10 +0000)]
 Updates for the endpoint talkers thing

The table now has a popup menu with
   Match display filter
         Selected
               EP1 <-> EP2
               EP1 --> EP2
               EP1 <-- EP2
               EP1 --> ANY
               EP1 <-- ANY
               EP2 --> ANY
               EP2 <-- ANY
          Not Selected
               ...
          ...
    Prepare Display Filter
          ...

Self explanatory.

Now the bad news.
I set the display filter box in the main window and i call redissect_packet
which redissects the packet list   but the displayfilter does not take
or affect the main window until i click  the apply button.

Some signal needs to be raised to some object me thinks.

Please feel free to fix it if you know what is missing.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8279 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Jesper Peterson:
guy [Tue, 26 Aug 2003 23:07:43 +0000 (23:07 +0000)]
From Jesper Peterson:

use WTAP_ENCAP_ATM_PDUS as the default encapsulation for ATM;

don't use ULL constants, as not all C compilers that support
gint64 support them, and as there's no need to make them ULL
constants.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8278 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoThe definition of NonStandardParameter is different between H.225 and H.245
sahlberg [Tue, 26 Aug 2003 21:44:35 +0000 (21:44 +0000)]
The definition of NonStandardParameter is different between H.225 and H.245
Create an alternative NonStandardParameter dissector that matches the
definition that H.225 needs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8277 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Anders Broman, updates and fixes to MEGACO
sahlberg [Tue, 26 Aug 2003 21:36:17 +0000 (21:36 +0000)]
From Anders Broman, updates and fixes to MEGACO

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8276 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoMake the option to display the internal PER fields default to FALSE
sahlberg [Tue, 26 Aug 2003 21:30:08 +0000 (21:30 +0000)]
Make the option to display the internal PER fields default to FALSE

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8275 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFix macro logic to allow classical resolution even if we have HAVE_GNU_ADNS
gerald [Tue, 26 Aug 2003 20:21:08 +0000 (20:21 +0000)]
Fix macro logic to allow classical resolution even if we have HAVE_GNU_ADNS
defined.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8274 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoPass the pointer in the "data" field of the destination address, not a
guy [Tue, 26 Aug 2003 19:41:09 +0000 (19:41 +0000)]
Pass the pointer in the "data" field of the destination address, not a
pointer to that pointer, to "ip_to_str()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8273 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Jesper Peterson: support for Endace ERF file format.
guy [Tue, 26 Aug 2003 07:10:39 +0000 (07:10 +0000)]
From Jesper Peterson: support for Endace ERF file format.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8272 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Jesper Peterson:
guy [Tue, 26 Aug 2003 07:07:41 +0000 (07:07 +0000)]
From Jesper Peterson:

Extract the FCS decoding section of the PPP_HDLC dissector to
allow the CHDLC dissector to use the same routine.

The ppp_options used for preferences has been renamed to
fcs_options and exported via packet-ppp.h so CHDLC gets a
separate (but identical) FCS preference.

This means prefs.h has to be included before packet-ppp.h so a
couple of ppp related files (packet-{gtp,null,raw,vj}.c) had
their includes slightly re-arranged.

From me: make the PPP/CHDLC FCS code use "crc32()" to check the 32-bit
FCS.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8271 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoNote that the SCTP CRC-32c is not the same as the AUTODIN/HDLC/802.x
guy [Tue, 26 Aug 2003 07:03:14 +0000 (07:03 +0000)]
Note that the SCTP CRC-32c is not the same as the AUTODIN/HDLC/802.x
CRC, as it uses a different polynomial.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8270 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoIn "col_set_addr()", don't do anything other than clearing the column
guy [Tue, 26 Aug 2003 06:40:25 +0000 (06:40 +0000)]
In "col_set_addr()", don't do anything other than clearing the column
expression information if the address type is AT_NONE -
"address_to_str_buf()" panics if passed an AT_NONE address, as there's
nothing sensible one can do with them.  (A null string wouldn't be
appropriate here, as a dissector might have set the address columns to a
string.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8269 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoMake the CRC-32 routines take a tvbuff and a length as arguments.
guy [Tue, 26 Aug 2003 06:18:18 +0000 (06:18 +0000)]
Make the CRC-32 routines take a tvbuff and a length as arguments.

Rename "crc32()" so as not to collide with the one in zlib; rename
"crc32_802()" to match.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8268 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFix a typo.
guy [Tue, 26 Aug 2003 05:56:43 +0000 (05:56 +0000)]
Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8267 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Jesper Peterson:
guy [Tue, 26 Aug 2003 05:52:53 +0000 (05:52 +0000)]
From Jesper Peterson:

Extract the FCS decoding section of the PPP_HDLC dissector to
allow the CHDLC dissector to use the same routine.

The ppp_options used for preferences has been renamed to
fcs_options and exported via packet-ppp.h so CHDLC gets a
separate (but identical) FCS preference.

This means prefs.h has to be included before packet-ppp.h so a
couple of ppp related files (packet-{gtp,null,raw,vj}.c) had
their includes slightly re-arranged.

From me: make the PPP/CHDLC FCS code use "crc32()" to check the 32-bit
FCS.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8266 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoExtract the CRC-32 code from the 802.11 dissector into a separate file,
guy [Tue, 26 Aug 2003 05:09:56 +0000 (05:09 +0000)]
Extract the CRC-32 code from the 802.11 dissector into a separate file,
and use it in the Ethernet dissector as well, to check the FCS in
Ethernet frames, if present.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8265 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoHandle snapshot lengths that cut off *part* of the FCS.
guy [Tue, 26 Aug 2003 04:34:26 +0000 (04:34 +0000)]
Handle snapshot lengths that cut off *part* of the FCS.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8264 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAll endpoint talkers table taps use "address_to_str()" as the routine to
guy [Tue, 26 Aug 2003 01:46:23 +0000 (01:46 +0000)]
All endpoint talkers table taps use "address_to_str()" as the routine to
use to translate addresses to strings - wire that into
"endpoint_talkers_table.c", don't pass the function as an argument to
"init_ett_table()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8263 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoUse "address_to_str_buf()" to generate column data for non-resolved
guy [Tue, 26 Aug 2003 01:30:48 +0000 (01:30 +0000)]
Use "address_to_str_buf()" to generate column data for non-resolved
addresses.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8262 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoInclude "osi-utils.h" to define "print_nsap_net_buf()".
guy [Tue, 26 Aug 2003 01:28:28 +0000 (01:28 +0000)]
Include "osi-utils.h" to define "print_nsap_net_buf()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8261 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoCreate an "address_to_str_buf()" routine, called by "address_to_str()",
guy [Tue, 26 Aug 2003 01:00:30 +0000 (01:00 +0000)]
Create an "address_to_str_buf()" routine, called by "address_to_str()",
which fills in a caller-supplied buffer.

Create "_buf()" versions of various "to_str" routines for various
address types, and create a routine to map SNA FIDs to strings, and use
them to finish up "address_to_str_buf()".

Get rid of the declaration of "sna_fid_type_4_addr_to_str()" in
"packet-sna.h", as that routine has been swallowed up in
"sna_fid_to_str()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8260 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Greg Morris: added support for defragmentation of NDS packets.
guy [Mon, 25 Aug 2003 22:16:57 +0000 (22:16 +0000)]
From Greg Morris: added support for defragmentation of NDS packets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8259 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Greg Morris:
guy [Mon, 25 Aug 2003 22:14:07 +0000 (22:14 +0000)]
From Greg Morris:

1. Added support for defragmentation of NDS packets

2. The packet signature fixes seemed to never been applied.  I
   have been using this code to dissect reply packets with packet
   signatures for quite some time and have never experienced any
   problems with it.  Without these changes then reply packets
   containing signatures will not be decoded properly.  It was
   recommended by Guy to not use public variables to track the
   signatures but it has been my experience that if signatures are
   enabled then it is enabled in the whole environment and would be
   valid for all NCP packets within the trace.  I could change this
   but it would add additional code to build a memory table to
   track this.  If for some reason it is determined to not add this
   part of the code then I will have to go back and add this table.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8258 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Greg Morris:
guy [Mon, 25 Aug 2003 22:12:04 +0000 (22:12 +0000)]
From Greg Morris:

1. Added support for defragmentation of NDS packets

2. Moved the run_info_string logic outside of the
   pinfo->fd->flags->visited because of the dissection of info
   strings is not processed on subsequent decodes then the
   find/string/info will not locate info string values.  By moving
   this outside then when the find logic runs a tvb_dissect_new
   then the info string gets processed again and all data is
   visible.  Otherwise only info column data that is processed by
   the NCP dissector is visible not any data from ncp2222.py
   processed by the info string function.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8257 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Greg Morris:
guy [Mon, 25 Aug 2003 22:06:38 +0000 (22:06 +0000)]
From Greg Morris:

1. Added Secret Store Services group
2. Added a number of NCP return values
3. Added support for NDS defragmentation
4. Fixed type from file to bindery on ncp's 23/20, 23/21, 23/22, 23/24,
   23/27, 23/28, 23/29, 23/30, and 23/31
5. Fixed type from comm to nmas on ncp 91
6. Fixed ncp 92 to include 92/01, 92/02, 92/03, 92/04, 92/05, 92/06,
   92/07, 92/08, 92/09, and 92/10
7. Added return value for 104/02
8. Fixed reply structures for NCP 123/60 and NCP 123/79

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8256 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Greg Morris: fix reassembly not to use global variables, and to use
guy [Mon, 25 Aug 2003 21:59:18 +0000 (21:59 +0000)]
From Greg Morris: fix reassembly not to use global variables, and to use
the SPX EOM flag as a "last fragment" indication.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8255 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoH.263 updates from Niklas Ogren.
guy [Mon, 25 Aug 2003 21:48:44 +0000 (21:48 +0000)]
H.263 updates from Niklas Ogren.

Put him in the authors list in the Ethereal man page.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8254 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Matthijs Melchior:
guy [Mon, 25 Aug 2003 21:42:33 +0000 (21:42 +0000)]
From Matthijs Melchior:

make the "Help" menu the rightmost menu item, as is done in

recent versions of Windows;

Mac OS X;

recent versions of KDE;

recent versions of GNOME;

rather than making it an item on the far right side.

Make the "Protocol" display in the help mention the number of
entries, and give it has 3 columns, starting with the one that
was used to sort this list.

Make the "Display Filters" display mention the number of fields
for each protocol and at the end the total number of fields.
Give it 4 columns, including the 'blurb'.

List all fields with the correct protocol.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8253 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoInclude the header files required by new APIs in the plugin API table.
guy [Mon, 25 Aug 2003 21:35:36 +0000 (21:35 +0000)]
Include the header files required by new APIs in the plugin API table.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8252 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoUpdate to IO-Stat to put the capture filename on the titlebar
sahlberg [Mon, 25 Aug 2003 11:06:32 +0000 (11:06 +0000)]
Update to IO-Stat to put the capture filename on the titlebar
to make it easier to navigate when having multiple instances of ethereal
and io-stat open
at the same time.

Updates to all endpoint talkers and service response time windows to do this as well.

Bonus, when the user opens a new capture file when having these windows open,
the title bar will be updated to reflect the name of the new capture file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8251 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoDue to popular demand:
sahlberg [Mon, 25 Aug 2003 10:17:38 +0000 (10:17 +0000)]
Due to popular demand:

The heuristic for RPC detection sometimes mistakenly decodes something as RPC when in reality it is payload.

Since the heuristics is based on the PDU suze as specified in the record marker
make this limit settable from the preferences.

Arbitrary limit of 256kb is choosen as default instead of the original limit of 2mb.
(face it, the largest common oncrpc pdus are those for nfs read/write anyway and these seldom go above 32kb.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8250 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoUse "XXX Talkers", rather than "IO-USERS Statistics" and "Type:xxx", as
guy [Mon, 25 Aug 2003 00:44:20 +0000 (00:44 +0000)]
Use "XXX Talkers", rather than "IO-USERS Statistics" and "Type:xxx", as
the title on the Tethereal -z talkers,xxx output, along the lines of
what the Ethereal version uses as the title.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8249 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Matthijs Melchior:
guy [Mon, 25 Aug 2003 00:15:02 +0000 (00:15 +0000)]
From Matthijs Melchior:

support for registering fields after all the protocol
    registration routines are called (i.e., adding fields to the
    named field tree as they're registered);

fix the GTK 2.x version of the field list dialog to show the
    correct name.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8248 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Matthijs Melchior: "P" in "PER" stands for "Packed", not "Packet".
guy [Mon, 25 Aug 2003 00:00:20 +0000 (00:00 +0000)]
From Matthijs Melchior: "P" in "PER" stands for "Packed", not "Packet".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8247 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdd default development package locations to README.win32. Use zlib 1.1.4
gerald [Sun, 24 Aug 2003 23:25:40 +0000 (23:25 +0000)]
Add default development package locations to README.win32.  Use zlib 1.1.4
by default in config.nmake.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8246 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoGet rid of the wrappers around "address_to_str()".
guy [Sun, 24 Aug 2003 22:34:32 +0000 (22:34 +0000)]
Get rid of the wrappers around "address_to_str()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8245 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoClean up the text, and boldface "-z talkers" in "These statistics
guy [Sun, 24 Aug 2003 20:32:40 +0000 (20:32 +0000)]
Clean up the text, and boldface "-z talkers" in "These statistics
windows can also be invoked from the Ethereal command line using the -z
talkers argument" (as pod2man suggests be done).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8244 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoPut in some comments about possible future work on "address_to_str()".
guy [Sun, 24 Aug 2003 20:30:46 +0000 (20:30 +0000)]
Put in some comments about possible future work on "address_to_str()".

Put in some additional "case AT_" statements to

1) squelch compiler warnings;

2) add AT_ARCNET (cheap and easy);

3) add placeholders for some other address types.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8243 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoUpdate for the tethereal talkers to amke it support IPX.
sahlberg [Sun, 24 Aug 2003 05:44:48 +0000 (05:44 +0000)]
Update for the tethereal talkers to amke it support IPX.

Useage is   -z talkers,ipx[,<filter>]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8242 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoThe IPX endpoint talkers implementation
sahlberg [Sun, 24 Aug 2003 05:39:05 +0000 (05:39 +0000)]
The IPX endpoint talkers implementation

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8241 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdd endpoint talker support for IPX
sahlberg [Sun, 24 Aug 2003 05:38:23 +0000 (05:38 +0000)]
Add endpoint talker support for IPX

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8240 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoMinor update to IPX. Move a lot of proto_tree_add_items outside of the if(tree...
sahlberg [Sun, 24 Aug 2003 05:21:01 +0000 (05:21 +0000)]
Minor update to IPX.   Move a lot of proto_tree_add_items outside of the if(tree) where the subtree is (optionally) created.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8239 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdd a tap to the IPX protocol
sahlberg [Sun, 24 Aug 2003 05:17:51 +0000 (05:17 +0000)]
Add a tap to the IPX protocol

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8238 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdd support for Fibre Channel talker statistics for tethereal.
sahlberg [Sun, 24 Aug 2003 04:58:32 +0000 (04:58 +0000)]
Add support for Fibre Channel talker statistics for tethereal.

-z talkers,fc[,<filter>]  to invoke it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8237 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoUpdate manpage for ethereal.
sahlberg [Sun, 24 Aug 2003 03:31:54 +0000 (03:31 +0000)]
Update manpage for ethereal.
Update the talkers tap for tethereal (iousers) and change the command line to invoke the tethereal version from  -z io,users,   to -z talkers, to be the same
as for ethereal.

Sorry if it breaks some scripts but io,users was a very nonintuitive name for this option.
talkers is not much better  but at least a little bit more descriptive/intuitive.   Anyone with a better name for this are welcome to provide a patch.

The tethereal version is now agnostic to wether v4 or v6 are transporting UDP/TCP

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8236 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoUpdate address_to_str to handle FC and ETH addresses as well.
sahlberg [Sun, 24 Aug 2003 03:00:11 +0000 (03:00 +0000)]
Update address_to_str to handle FC and ETH addresses as well.
Update the fc and eth and tr  endpoint talker list to use the new api

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8235 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdd a new function address_to_str to to_str.c
sahlberg [Sun, 24 Aug 2003 02:50:32 +0000 (02:50 +0000)]
Add a new function  address_to_str  to to_str.c
Implement conersion from address to string for IPv4 and IPv6
and update the conversation tables to use the new interface.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8234 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Erwin Rol, updates to teh ArtNet plugin dissector
sahlberg [Sun, 24 Aug 2003 01:44:00 +0000 (01:44 +0000)]
From Erwin Rol,   updates to teh ArtNet plugin dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8233 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoCast the argument to "ip6_to_str()" to avoid compiler warnings.
guy [Sun, 24 Aug 2003 01:39:55 +0000 (01:39 +0000)]
Cast the argument to "ip6_to_str()" to avoid compiler warnings.

Use "%u", not "%d", for unsigned values.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8232 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoCast arguments to "g_free()" to avoid compiler warnings (those are known
guy [Sun, 24 Aug 2003 01:39:04 +0000 (01:39 +0000)]
Cast arguments to "g_free()" to avoid compiler warnings (those are known
to be mallocated, so it's safe to cast them).

Use "%u", not "%d", for unsigned values.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8231 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoUse "ip_to_str_buf()" to turn a pointer to an IP address to a string.
guy [Sun, 24 Aug 2003 01:37:34 +0000 (01:37 +0000)]
Use "ip_to_str_buf()" to turn a pointer to an IP address to a string.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8230 f5534014-38df-0310-8fa8-9805f1628bb7

21 years ago"tvb_get_ptr()" returns a "const guint8 *"; make the pointers to which
guy [Sun, 24 Aug 2003 01:36:44 +0000 (01:36 +0000)]
"tvb_get_ptr()" returns a "const guint8 *"; make the pointers to which
you assign its return value pointers to "const" as well.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8229 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Devin H, update to NTLMSSP to better handle address lists
sahlberg [Sun, 24 Aug 2003 01:29:50 +0000 (01:29 +0000)]
From Devin H,  update to NTLMSSP to better handle address lists

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8228 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Niklas O
sahlberg [Sun, 24 Aug 2003 01:25:19 +0000 (01:25 +0000)]
From Niklas O

Add the blurb description to the hF fields in the H.263 dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8227 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFC addresses are no longer extracted into guint32s, so "fc32_to_str()"
guy [Sun, 24 Aug 2003 01:06:21 +0000 (01:06 +0000)]
FC addresses are no longer extracted into guint32s, so "fc32_to_str()"
is no longer needed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8226 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoWrite Token Ring as Token Ring and not TokenRing
sahlberg [Sat, 23 Aug 2003 13:58:54 +0000 (13:58 +0000)]
Write Token Ring as Token Ring and not TokenRing

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8225 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoUpdate the UDP and the TCP conversation list tool so that it can handle IPv6 as well.
sahlberg [Sat, 23 Aug 2003 13:56:40 +0000 (13:56 +0000)]
Update the UDP and the TCP conversation list tool so that it can handle IPv6 as well.
Make no distinction between UDP/TCP over IPv4 and UDP/TCP over IPv6
and present them in the same list.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8224 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdd FibreChannel to the types of protocols we can show a conversation list for
sahlberg [Sat, 23 Aug 2003 13:35:06 +0000 (13:35 +0000)]
Add FibreChannel to the types of protocols we can show a conversation list for

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8223 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoNew feature. Statistics/EndpointTalkjers can now present a sortable table with a...
sahlberg [Sat, 23 Aug 2003 09:09:35 +0000 (09:09 +0000)]
New feature.  Statistics/EndpointTalkjers can now present a sortable table with a list of all seen conversations of a certain type.

Supported types are Ethernet/TokenRing/IP/UDP and TCP.
Will add FibreChannel soon.

The framework for this feature needs to be enhanced in the future so that by selecting one entry and click the right mousebutton, this will bring up a menu with  Prepare/Match options  with suboptions for AnyDirection, ForwardOnly or ReverseOnly   which updates the display filter accordingly.

Had to update some of the taps as well to change them to use a proper address structure for the address fields.
We should now be able to to these stats correctly even for ip tunneled over ip tunnelled over ip ...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8222 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoUse "file_access.c", not "file_io.c", as the latter is already in use in
guy [Sat, 23 Aug 2003 08:34:12 +0000 (08:34 +0000)]
Use "file_access.c", not "file_io.c", as the latter is already in use in
a not-yet-ready-for-prime-time project of mine (fast random access to
gzipped files, plus an mechanism to allow support for other forms of
compression).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8221 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Tomas Kukosa: export the PER dissection routines, and some
guy [Sat, 23 Aug 2003 08:23:24 +0000 (08:23 +0000)]
From Tomas Kukosa: export the PER dissection routines, and some
H.225/H.245 routines, to plugins on platforms where they have to go
through the function call table.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8220 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Tomas Kukosa: export the PER dissection routines, and some
guy [Sat, 23 Aug 2003 07:35:50 +0000 (07:35 +0000)]
From Tomas Kukosa: export the PER dissection routines, and some
H.225/H.245 routines, to plugins on platforms where they have to go
through the function call table.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8219 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoThe Python 1.5.2 I have installed didn't seem to like "+=", so use "x =
guy [Sat, 23 Aug 2003 07:34:31 +0000 (07:34 +0000)]
The Python 1.5.2 I have installed didn't seem to like "+=", so use "x =
x + y" instead.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8218 f5534014-38df-0310-8fa8-9805f1628bb7

21 years ago_U_ is for definitions, not declarations; putting it there caused a
guy [Sat, 23 Aug 2003 07:31:02 +0000 (07:31 +0000)]
_U_ is for definitions, not declarations; putting it there caused a
compiler problem when rebuilding the X* files for the plugin API.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8217 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Tomas Kukosa: export the PER dissection routines, and some
guy [Sat, 23 Aug 2003 07:23:21 +0000 (07:23 +0000)]
From Tomas Kukosa: export the PER dissection routines, and some
H.225/H.245 routines, to plugins on platforms where they have to go
through the function call table.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8216 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdd a dissector table for RTP payload types, and have dissectors
guy [Sat, 23 Aug 2003 06:36:46 +0000 (06:36 +0000)]
Add a dissector table for RTP payload types, and have dissectors
register themselves in that table rather than exporting their dissectors
by name and having the RTP dissector know about particular dissectors
for particular payload types.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8215 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoThe FreeTDS TDS document says that the first string in an RPC packet is
guy [Sat, 23 Aug 2003 05:59:54 +0000 (05:59 +0000)]
The FreeTDS TDS document says that the first string in an RPC packet is
a procedure name.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8214 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoIf a Netlib message has "Not last buffer" set, flag it as such in the
guy [Sat, 23 Aug 2003 05:19:01 +0000 (05:19 +0000)]
If a Netlib message has "Not last buffer" set, flag it as such in the
Info column, to distinguish it from the message with the last buffer in
it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8213 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Niklas Ogren
sahlberg [Sat, 23 Aug 2003 04:19:22 +0000 (04:19 +0000)]
From Niklas Ogren

the H263 dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8212 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Niklas Ogren
sahlberg [Sat, 23 Aug 2003 04:18:18 +0000 (04:18 +0000)]
From Niklas Ogren

New Protocol: H.263   called and used by the RTP dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8211 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdd the packet type name for the "Remote Procedure Call Packet" (which I
guy [Sat, 23 Aug 2003 02:34:09 +0000 (02:34 +0000)]
Add the packet type name for the "Remote Procedure Call Packet" (which I
suspect refers to stored SQL procedures on the server, not to RPCs in
the traditional sense), and the beginnings of a routine to dissect those
packets (at least as seen in one capture).

Don't use "get_unicode_or_ascii_string()", as it really expects to be
used inside an SMB dissector, and wants arguments like the "bc"
argument.  Just use "tvb_fake_unicode()" and "tvb_get_string()",
instead.

If we're doing reassembly, and the PDU is split across segment
boundaries, return after setting the desegmentation offset and length,
don't just drive on and dissect the partial PDU.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8210 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Biot Oliver
sahlberg [Sat, 23 Aug 2003 02:15:53 +0000 (02:15 +0000)]
From Biot Oliver

Support in SMPP for GSM SMS and GSM CBS.
Reassembly of SMPP has also been fixed so that it now works.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8209 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoRename "wiretap/file.c" to "wiretap/file_io.c", as some tools, such as
guy [Fri, 22 Aug 2003 19:07:45 +0000 (19:07 +0000)]
Rename "wiretap/file.c" to "wiretap/file_io.c", as some tools, such as
the MS Visual Studio debugger, get confused by two files with the same
name being in a program's source, even though they're in different
directories.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8208 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoSometimes Ethernet captures include an FCS at the end of the packet.
guy [Thu, 21 Aug 2003 21:05:30 +0000 (21:05 +0000)]
Sometimes Ethernet captures include an FCS at the end of the packet.

An Ethernet trailer is only needed to pad the packet to 60 bytes of
Ethernet header plus payload; if the packet has what appears to be a
trailer, and it's 4 or more bytes (i.e., long enough to include an FCS),
and the Ethernet frame was claimed to have 64 or more bytes (i.e., it
has at least an FCS worth of data more than the minimum 60 bytes),
assume that the last 4 bytes of the frame were an FCS.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8207 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Tomas Kukosa: allow subdissectors to be registered for
guy [Thu, 21 Aug 2003 18:00:22 +0000 (18:00 +0000)]
From Tomas Kukosa: allow subdissectors to be registered for
NonStandardParameter data in the H.245 dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8206 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Lars Roland:
guy [Thu, 21 Aug 2003 17:48:04 +0000 (17:48 +0000)]
From Lars Roland:

A scrollable GtkCList is used now for both GTK1 and GTK2.

Removed "overall" line from statistics table. It is not useful.

"Response Time Delay" was renamed into "Service Response Time".

Menu Item moved to "Service Response Time" folder.

As Ronnie suggested, the active display filter is now used as
default statistics filter.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8205 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoLabel the Count field in a Write AndX response as such, rather than as
guy [Thu, 21 Aug 2003 08:18:09 +0000 (08:18 +0000)]
Label the Count field in a Write AndX response as such, rather than as
"Data Length".

Fix some low-16-bits-of fields to have "_low", rather than "_high", at
the ends of their names.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8204 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAlign the --with-pcap help message with other help messages.
guy [Thu, 21 Aug 2003 07:25:22 +0000 (07:25 +0000)]
Align the --with-pcap help message with other help messages.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8203 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFix up --with messages that include square brackets.
guy [Thu, 21 Aug 2003 07:20:56 +0000 (07:20 +0000)]
Fix up --with messages that include square brackets.

Put --with-plugins on the left margin, as the rest of the messages are.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8202 f5534014-38df-0310-8fa8-9805f1628bb7