obnox/wireshark/wip.git
16 years agomake the sbus dissector nwe-style and make it check that the packet does
sahlberg [Tue, 2 Oct 2007 22:04:07 +0000 (22:04 +0000)]
make the sbus dissector nwe-style and make it check that the packet does
indeed look like sbus before taking it.

this fixes bug 1871

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23057 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agobug 1872
sahlberg [Tue, 2 Oct 2007 21:26:22 +0000 (21:26 +0000)]
bug 1872

from chris maynard  fix some filter names for ansi_a

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23056 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoifdef out a function that is not yet used
sahlberg [Tue, 2 Oct 2007 21:21:55 +0000 (21:21 +0000)]
ifdef out a function that is not yet used

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23055 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix comments
etxrab [Tue, 2 Oct 2007 20:28:11 +0000 (20:28 +0000)]
Fix comments

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23054 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDissect more IE's
etxrab [Tue, 2 Oct 2007 20:09:15 +0000 (20:09 +0000)]
Dissect more IE's

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23053 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoCheck return value from ptvcursor_add in an attempt to fix bug 1886.
stig [Tue, 2 Oct 2007 19:02:58 +0000 (19:02 +0000)]
Check return value from ptvcursor_add in an attempt to fix bug 1886.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23052 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUse given length when decoding fhandles as unknown.
stig [Tue, 2 Oct 2007 16:46:49 +0000 (16:46 +0000)]
Use given length when decoding fhandles as unknown.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23051 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdded a missing break - fixing bug 1890.
stig [Tue, 2 Oct 2007 16:27:52 +0000 (16:27 +0000)]
Added a missing break - fixing bug 1890.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23050 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDo not indicate bogus length if inside an icmp.
stig [Tue, 2 Oct 2007 15:46:17 +0000 (15:46 +0000)]
Do not indicate bogus length if inside an icmp.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23049 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMake the CPFI dissector new style: return 0 in several cases (including if we don...
morriss [Tue, 2 Oct 2007 14:45:20 +0000 (14:45 +0000)]
Make the CPFI dissector new style: return 0 in several cases (including if we don't have MAC addresses for the packet) to give other dissectors a chance to dissect the packet.  I rearranged the code quite a bit here and don't have a sample capture to test against: hopefully I didn't break anything.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23048 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoreview and update list of TLS cipher suites
kukosa [Tue, 2 Oct 2007 09:26:28 +0000 (09:26 +0000)]
review and update list of TLS cipher suites

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23047 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agocoverity 263 check if variable is null before dereferencing it
sahlberg [Tue, 2 Oct 2007 08:33:38 +0000 (08:33 +0000)]
coverity 263      check if variable is null before dereferencing it

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23046 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoremove a test for null that we dont need since the variable can not be
sahlberg [Tue, 2 Oct 2007 08:27:39 +0000 (08:27 +0000)]
remove a test for null that we dont need since the variable can not be
null at this point

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23045 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoget rid of a check for null we dont need
sahlberg [Tue, 2 Oct 2007 08:21:25 +0000 (08:21 +0000)]
get rid of a check for null we dont need

coverity 257

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23044 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agosupport of 'ANY DEFINED BY' from X.208 which is obsolete but still used in some RFCs
kukosa [Tue, 2 Oct 2007 06:52:11 +0000 (06:52 +0000)]
support of 'ANY DEFINED BY' from X.208 which is obsolete but still used in some RFCs

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23043 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agobe a bit more verbose, if the name given to register_dissector_table() is not unique...
ulfl [Tue, 2 Oct 2007 05:07:13 +0000 (05:07 +0000)]
be a bit more verbose, if the name given to register_dissector_table() is not unique (e.g. because of a buggy/duplicated plugin)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23042 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoupdate to latest IEC draft
ulfl [Tue, 2 Oct 2007 05:04:35 +0000 (05:04 +0000)]
update to latest IEC draft

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23041 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd 'C' as a valid -N option in error message.
wmeier [Mon, 1 Oct 2007 00:22:39 +0000 (00:22 +0000)]
Add 'C' as a valid -N option in error message.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23040 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agochange dissect_radius() to become a new-style dissector that can reject
sahlberg [Sun, 30 Sep 2007 23:14:18 +0000 (23:14 +0000)]
change dissect_radius() to become a new-style dissector that can reject
packets that doesnt look like valid radius.

verify that a packet is radius by checking that the command code is
known and also that the length is between 20 and 4096 bytes

move the tap data to be ep_allocated instead of a static global variable

dont use tvb_memcpy() to read a structure off the wiredata
use tvb_get_...    to unmarshall the fields explicitely

this fixes bug 1634

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23039 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoupdate filter fields for bug 1803
sahlberg [Sun, 30 Sep 2007 22:34:19 +0000 (22:34 +0000)]
update filter fields for bug 1803

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23038 f5534014-38df-0310-8fa8-9805f1628bb7

16 years ago"get_compiled_version_info()" appends to the string text starting with
guy [Sun, 30 Sep 2007 22:34:15 +0000 (22:34 +0000)]
"get_compiled_version_info()" appends to the string text starting with
"with", so we shouldn't put our own "with" in there.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23037 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoClean up indentation.
guy [Sun, 30 Sep 2007 22:13:38 +0000 (22:13 +0000)]
Clean up indentation.

"time_t" is not guaranteed to be an "unsigned long"; when printing it
with %lu, cast it to "unsigned long".

The "secs" field of a wtap_nstime, however, *is* defined to be a time_t;
there's no need to cast it to time_t.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23036 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoTry xdg-open before htmlview.
stig [Sun, 30 Sep 2007 10:07:56 +0000 (10:07 +0000)]
Try xdg-open before htmlview.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23035 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Stéphane Loeuillet: patches to fix problems with the .desktop files
guy [Sun, 30 Sep 2007 00:18:44 +0000 (00:18 +0000)]
From Stéphane Loeuillet: patches to fix problems with the .desktop files
found by desktop-file-validate:

  wireshark.desktop: warning: value "" for key "Path" in group "Desktop Entry"
  does not look like an absolute path
  wireshark.desktop: warning: value "GNOME;Application;Network;" for key
  "Categories" in group "Desktop Entry" contains a deprecated value
  "Application"

  wireshark-root.desktop: warning: key "Encoding" in group "Desktop Entry" is
  deprecated
  wireshark-root.desktop: warning: value "" for key "Path" in group "Desktop
  Entry" does not look like an absolute path
  wireshark-root.desktop: warning: value "GNOME;Application;Network;" for key
  "Categories" in group "Desktop Entry" contains a deprecated value
  "Application"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23034 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoWireshark builds with 10.4's X11 as well.
guy [Sun, 30 Sep 2007 00:03:38 +0000 (00:03 +0000)]
Wireshark builds with 10.4's X11 as well.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23033 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoInclude DragonFly BSD in the list of BSDs to which this applies.
guy [Sat, 29 Sep 2007 23:42:45 +0000 (23:42 +0000)]
Include DragonFly BSD in the list of BSDs to which this applies.

Add information on how to set the mode, owner, and/or group of the BPF
devices in FreeBSD with devfs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23032 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoWhen reading NetScreen snoop output, only use WTAP_ENCAP_PER_PACKET
sake [Sat, 29 Sep 2007 07:55:25 +0000 (07:55 +0000)]
When reading NetScreen snoop output, only use WTAP_ENCAP_PER_PACKET
if there are packets with different encapsulationtype in the file.
Otherwise use the encapsulationtype of the packets in the file.

This makes it possible to save the imported data as libpcap file
(or any other format that does not support per-packet encapsulation).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23031 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoGet rid of a forward declaration of a routine that no longer exists.
guy [Sat, 29 Sep 2007 02:27:04 +0000 (02:27 +0000)]
Get rid of a forward declaration of a routine that no longer exists.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23030 f5534014-38df-0310-8fa8-9805f1628bb7

16 years ago"pinfo->match_string" is a "const char *"; save it into a variable of
guy [Sat, 29 Sep 2007 02:20:17 +0000 (02:20 +0000)]
"pinfo->match_string" is a "const char *"; save it into a variable of
the same type - that makes compilers much happier.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23029 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate to reflect that we're using libsmi, not Net-SNMP.
guy [Sat, 29 Sep 2007 02:10:25 +0000 (02:10 +0000)]
Update to reflect that we're using libsmi, not Net-SNMP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23028 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix typo.
guy [Sat, 29 Sep 2007 02:05:31 +0000 (02:05 +0000)]
Fix typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23027 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoClean up indentation a bit.
guy [Sat, 29 Sep 2007 02:05:09 +0000 (02:05 +0000)]
Clean up indentation a bit.

Count packets even if we're not dissecting them.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23026 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMake the "-Z" argument to dumpcap take an argument that's the file
guy [Sat, 29 Sep 2007 01:36:03 +0000 (01:36 +0000)]
Make the "-Z" argument to dumpcap take an argument that's the file
descriptor to use as the sync pipe.  For now, always pass 1, so the sync
pipe is the standard output of dumpcap.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23025 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDon't hardcode the notion that the sync pipe is the standard output into
guy [Sat, 29 Sep 2007 01:15:11 +0000 (01:15 +0000)]
Don't hardcode the notion that the sync pipe is the standard output into
sync_pipe_errmsg_to_parent(); have it take the FD for the sync pipe as
an argument.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23024 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoThe fork_child argument to sync_interface_stats_close is unused on UN*X.
guy [Sat, 29 Sep 2007 01:14:16 +0000 (01:14 +0000)]
The fork_child argument to sync_interface_stats_close is unused on UN*X.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23023 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoWe don't use NetSNMP any more.
guy [Sat, 29 Sep 2007 01:01:02 +0000 (01:01 +0000)]
We don't use NetSNMP any more.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23022 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoWe don't use NetSNMP any more.
guy [Sat, 29 Sep 2007 00:58:20 +0000 (00:58 +0000)]
We don't use NetSNMP any more.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23021 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoSupport Solaris along with Windows.
gerald [Fri, 28 Sep 2007 23:40:51 +0000 (23:40 +0000)]
Support Solaris along with Windows.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23020 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoImproves dissection of JXTA traffic from http connections.
bondolo [Fri, 28 Sep 2007 20:53:56 +0000 (20:53 +0000)]
Improves dissection of JXTA traffic from http connections.

Improved address display in packet summary panes.

more options for jxta pdu filtering by addresses.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23019 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoWhy do I have to enable the Bytes View to see the (start of) data of the Data dissector?
jake [Fri, 28 Sep 2007 19:16:05 +0000 (19:16 +0000)]
Why do I have to enable the Bytes View to see the (start of) data of the Data dissector?
Adding the data as a subtree to the Data dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23018 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoSpecial casing is no longer necessary for formatting of AT_STRINGZ in col_set_addr...
bondolo [Fri, 28 Sep 2007 19:00:45 +0000 (19:00 +0000)]
Special casing is no longer necessary for formatting of AT_STRINGZ in col_set_addr() as
address_to_str_buf() does now take COL_MAX_LEN as a parameter.

Add support for AT_URI to col_expr for addresses in col_set_addr(). The field names are "uri.src" and "uri.dst".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23017 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoChanges get_addr_name_buf() to use the more common convention where the provided...
bondolo [Fri, 28 Sep 2007 18:23:59 +0000 (18:23 +0000)]
Changes get_addr_name_buf() to use the more common convention where the provided buffer size is the entire size of the buffer including the space for the terminating \0

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23016 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd error checking for fwrites; replacement for the 2nd of the patches provided in...
wmeier [Fri, 28 Sep 2007 17:22:03 +0000 (17:22 +0000)]
Add error checking for fwrites; replacement for the 2nd of the patches provided in bug #1864

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23015 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoSpecify that -l causes tshark to flush the *standard* output (from bug 1875). The...
morriss [Fri, 28 Sep 2007 16:34:59 +0000 (16:34 +0000)]
Specify that -l causes tshark to flush the *standard* output (from bug 1875).  The man page already states this

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23014 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoHandle IPv6 addresses in ipprim headers.
martinm [Fri, 28 Sep 2007 16:17:22 +0000 (16:17 +0000)]
Handle IPv6 addresses in ipprim headers.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23013 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoWhen reading NetScreen snoop output, allow the '.' in interface names
sake [Fri, 28 Sep 2007 14:37:15 +0000 (14:37 +0000)]
When reading NetScreen snoop output, allow the '.' in interface names
so that packets on subinterfaces are accepted too.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23012 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd a small note saying not to use proto_tree_add_text() in new code unless you have...
morriss [Fri, 28 Sep 2007 13:39:20 +0000 (13:39 +0000)]
Add a small note saying not to use proto_tree_add_text() in new code unless you have a specific reason (like those given in the next paragraphs).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23011 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd notes suggesting not to use hidden fields but if you're going to, use PROTO_ITEM_...
morriss [Fri, 28 Sep 2007 13:33:54 +0000 (13:33 +0000)]
Add notes suggesting not to use hidden fields but if you're going to, use PROTO_ITEM_SET_HIDDEN() instead of proto_tree_add_*_hidden().  (I thought that was in here already...)  Suggest putting fields-you-want-hidden in subtrees where they can be found by ordinary users.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23010 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agothis silly protocol uses the same port as ndmp and worse, there is
sahlberg [Fri, 28 Sep 2007 07:34:42 +0000 (07:34 +0000)]
this silly protocol uses the same port as ndmp   and worse,   there is
nothing really in the header to identify it reliably as silly
vendor specific encapsulation

10000 is actually registered by iana for ndmp   so it makes no sense for
a lazy vendor to use it by default.

make it check if the packet is ndmp first before assuming that anything
that goes to port 10000 must be some lazy vendor specific protocol

grrr

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23009 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoadd ndmp.h to the makefile
sahlberg [Fri, 28 Sep 2007 07:26:40 +0000 (07:26 +0000)]
add ndmp.h to the makefile

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23008 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoadd a function to test if a packet is ndmp or not
sahlberg [Fri, 28 Sep 2007 07:25:50 +0000 (07:25 +0000)]
add a function to test if a packet is ndmp or not

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23007 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agondmp and tcp encapsulation of esp both use port 10000
sahlberg [Fri, 28 Sep 2007 07:08:52 +0000 (07:08 +0000)]
ndmp   and tcp encapsulation of esp   both use port 10000

make ndmp a heuristic dissector so it will "win" over tcp esp  if the
packets look like ndmp  and if "preferences/tcp/heuristic dissectors
first has been
chosen"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23006 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUse the tag for downloading.
etxrab [Fri, 28 Sep 2007 06:06:36 +0000 (06:06 +0000)]
Use the tag for downloading.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23005 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoqueue the ip/eth headers for tapping before calling any subdissectors
sahlberg [Fri, 28 Sep 2007 05:50:19 +0000 (05:50 +0000)]
queue the ip/eth headers for tapping before calling any subdissectors
so that they can be tapped even if the subdissectors cause an exception

this fixes bug 1527

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23004 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoLoad wpcap.dll, since we still use it for some things. This should hopefully
gerald [Thu, 27 Sep 2007 23:49:05 +0000 (23:49 +0000)]
Load wpcap.dll, since we still use it for some things.  This should hopefully
fix Buildbot.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23003 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdated to include the ranap header file.
stig [Thu, 27 Sep 2007 21:48:25 +0000 (21:48 +0000)]
Updated to include the ranap header file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23002 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdded default svn:ignore for asn1 rrlp, rrc, ulp and t38.
stig [Thu, 27 Sep 2007 21:27:34 +0000 (21:27 +0000)]
Added default svn:ignore for asn1 rrlp, rrc, ulp and t38.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23001 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Martin Warnes:
sake [Thu, 27 Sep 2007 18:36:17 +0000 (18:36 +0000)]
From Martin Warnes:

Attached is a small patch that correct an issue with reading certain IBM
iSeries Comms traces.

Traces where data has been dropped for whatever reason now have the
packet number suffixed with an asterix "*", this causes the current
iSeries wiretap routine to report a "bad" header. The attached patch
simply scans the packet number field and removes any "* characters prior
to scanning, the fact that data may be missing is more than adequately
reported later by current wireshark packet processing.

Regards .. Martin

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23000 f5534014-38df-0310-8fa8-9805f1628bb7

16 years ago(Try to) get tshark capturing working on *NIX (it works for me anyway):
morriss [Thu, 27 Sep 2007 15:58:54 +0000 (15:58 +0000)]
(Try to) get tshark capturing working on *NIX (it works for me anyway):
We can simply block waiting for input from the child process because we are
in a CLI that does not need to worry about updating a GUI while we're waiting
for packets and so forth.

Before I realized that I wrote a working (for me) method using select() that
I've left in for now (#ifdef'd out).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22999 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAs requested by Juan Wortley on -users: instead of allowing only 2 UDP ports to be...
morriss [Thu, 27 Sep 2007 14:11:57 +0000 (14:11 +0000)]
As requested by Juan Wortley on -users: instead of allowing only 2 UDP ports to be dissected as NSIP, allow a range.  Obsolete the old preferences.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22998 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoConvert asn1/dap/
jmayer [Thu, 27 Sep 2007 09:24:38 +0000 (09:24 +0000)]
Convert asn1/dap/

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22997 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agorevert changes in config.nmake committed by mistake and commit configure.in
kukosa [Thu, 27 Sep 2007 08:33:53 +0000 (08:33 +0000)]
revert changes in config.nmake committed by mistake and commit configure.in

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22996 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoadd forgotten makefiles
kukosa [Thu, 27 Sep 2007 07:08:47 +0000 (07:08 +0000)]
add forgotten makefiles

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22995 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoput next few simple ASN.1 dissectors into the new makefile structure
kukosa [Thu, 27 Sep 2007 06:03:45 +0000 (06:03 +0000)]
put next few simple ASN.1 dissectors into the new makefile structure

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22994 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdded 1 min and 10 min tick intervals to the user guide.
stig [Wed, 26 Sep 2007 22:55:36 +0000 (22:55 +0000)]
Added 1 min and 10 min tick intervals to the user guide.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22993 f5534014-38df-0310-8fa8-9805f1628bb7

16 years ago- Added Tick interval 1 min and 10 min.
stig [Wed, 26 Sep 2007 22:50:53 +0000 (22:50 +0000)]
- Added Tick interval 1 min and 10 min.
- Draw an empty graph if no items in given tick interval.
- Initialize interval_delta so we don't get overlaping x-scale labels.
- Some whitespace cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22992 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix unused functions.
etxrab [Wed, 26 Sep 2007 21:37:57 +0000 (21:37 +0000)]
Fix unused functions.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22991 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoThe unused pinfo strikes back (again).
etxrab [Wed, 26 Sep 2007 19:50:53 +0000 (19:50 +0000)]
The unused pinfo strikes back (again).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22990 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFurther IE dissection.
etxrab [Wed, 26 Sep 2007 19:01:29 +0000 (19:01 +0000)]
Further IE dissection.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22989 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoTry to fix the U3 build.
etxrab [Wed, 26 Sep 2007 19:00:48 +0000 (19:00 +0000)]
Try to fix the U3 build.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22988 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd the -E (encapsulation) flag.
gerald [Wed, 26 Sep 2007 15:48:45 +0000 (15:48 +0000)]
Add the -E (encapsulation) flag.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22987 f5534014-38df-0310-8fa8-9805f1628bb7

16 years ago- show type (number) of unrecognised tlvs in the tlv root item
martinm [Wed, 26 Sep 2007 14:47:22 +0000 (14:47 +0000)]
- show type (number) of unrecognised tlvs in the tlv root item
- also add this as an expert item
- tlv root item is now an FT_BYTES item (allowing filtering on whole tlv contents)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22986 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDecode role on shared link
jmayer [Wed, 26 Sep 2007 08:38:43 +0000 (08:38 +0000)]
Decode role on shared link

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22985 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoBeginnings of EAPS shared link packet dissection (EAPSv2)
jmayer [Wed, 26 Sep 2007 07:10:40 +0000 (07:10 +0000)]
Beginnings of EAPS shared link packet dissection (EAPSv2)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22984 f5534014-38df-0310-8fa8-9805f1628bb7

16 years ago"fix" some warnings about "might be used uninitialized" variables
jmayer [Wed, 26 Sep 2007 07:09:51 +0000 (07:09 +0000)]
"fix" some warnings about "might be used uninitialized" variables

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22983 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMake the number of bytes just a guint, in the hopes that it'll squelch
guy [Wed, 26 Sep 2007 06:53:38 +0000 (06:53 +0000)]
Make the number of bytes just a guint, in the hopes that it'll squelch
some of the warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22982 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMove sync_pipe_write.c to WIRESHARK_COMMON_SRC since it is now also needed
sfisher [Wed, 26 Sep 2007 03:31:41 +0000 (03:31 +0000)]
Move sync_pipe_write.c to WIRESHARK_COMMON_SRC since it is now also needed
by tshark as well as Wireshark to fix compilation on Unix platforms.
This is due to the introduction of capture_sync.c (which calls
sync_pipe_errmsg_to_parent) to tshark_SOURCES in SVN revision 22969.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22981 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoThe dissector packet-dcp.c now fails to compile on MacOS X (gcc 4.0.1/Apple). Change...
sfisher [Wed, 26 Sep 2007 03:05:42 +0000 (03:05 +0000)]
The dissector packet-dcp.c now fails to compile on MacOS X (gcc 4.0.1/Apple).  Change G_INLINE_FUNC back to inline per GLib documentation (also remove recommendation in developer's guide to not use inline):

http://library.gnome.org/devel/glib/unstable/glib-Miscellaneous-Macros.html#id2571572

G_INLINE_FUNC

#define             G_INLINE_FUNC
This macro is used to export function prototypes so they can be linked with an external version when no inlining is performed. The file which implements the functions should define G_IMPLEMENTS_INLINES before including the headers which contain G_INLINE_FUNC declarations. Since inlining is very compiler-dependent using these macros correctly is very difficult. Their use is strongly discouraged.

This macro is often mistaken for a replacement for the inline keyword; inline is already declared in a portable manner in the glib headers and can be used normally.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22980 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoSquelch *another* "case M ... N:".
guy [Wed, 26 Sep 2007 02:36:22 +0000 (02:36 +0000)]
Squelch *another* "case M ... N:".

To quote doc/README.developer:

  Don't use "inline"; not all compilers support it.  If you want to have a
  function be an inline function if the compiler supports it, use
  G_INLINE_FUNC, which is declared by <glib.h>.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22979 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoA guint8 can never be > 255.
guy [Wed, 26 Sep 2007 02:21:31 +0000 (02:21 +0000)]
A guint8 can never be > 255.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22978 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agothe Ubuntu / OS X buildbots don't seem to like G_STATIC_MUTEX_INIT (for whatever...
ulfl [Wed, 26 Sep 2007 00:44:47 +0000 (00:44 +0000)]
the Ubuntu / OS X buildbots don't seem to like G_STATIC_MUTEX_INIT (for whatever reason), try to use g_static_mutex_init() instead

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22977 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDon't use
guy [Wed, 26 Sep 2007 00:41:00 +0000 (00:41 +0000)]
Don't use

case N ... M:

as that's not supported by all compilers.

Say so in the Portability section of README.developer, in the hopes of
discouraging others from using that GCCism.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22976 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agosolve some more of the unix specific buildbot problems
ulfl [Wed, 26 Sep 2007 00:03:30 +0000 (00:03 +0000)]
solve some more of the unix specific buildbot problems

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22975 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoadd a dummy function, so unix/linux version should at least compile
ulfl [Tue, 25 Sep 2007 23:23:56 +0000 (23:23 +0000)]
add a dummy function, so unix/linux version should at least compile

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22974 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoremove trailing backslash
ulfl [Tue, 25 Sep 2007 22:38:39 +0000 (22:38 +0000)]
remove trailing backslash

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22973 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoadd a "build.0" configuration, MSVC 2005 wants to have it (for whatever reasons)
ulfl [Tue, 25 Sep 2007 21:59:19 +0000 (21:59 +0000)]
add a "build.0" configuration, MSVC 2005 wants to have it (for whatever reasons)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22972 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoadd some more files
ulfl [Tue, 25 Sep 2007 21:57:25 +0000 (21:57 +0000)]
add some more files

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22971 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoslightly better summary of IODWriteRes and don't repeat AR info for each IODWriteRes_...
ulfl [Tue, 25 Sep 2007 21:56:43 +0000 (21:56 +0000)]
slightly better summary of IODWriteRes and don't repeat AR info for each IODWriteRes_header

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22970 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoas "advertised" some days ago:
ulfl [Tue, 25 Sep 2007 21:55:06 +0000 (21:55 +0000)]
as "advertised" some days ago:
rewrite the tshark capture code almost completely, to use dumpcap instead of it's own pcap functionality.

This works on Win32 and should work on unix/linux (but I'm not sure here). Some stuff needs to be cleaned up, some more may need to be rewritten to specifically work with unix/win32. Futher work needs to be done at:

1. read filters (simply document current behaviour?)
2. event loop polling
3. privileges
4. code cleanup (e.g. in capture_loop.c)

Be prepared that tshark might not work as before / expected at least in the next days!

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22969 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoclarify tshark -B (file format) option
ulfl [Tue, 25 Sep 2007 21:38:54 +0000 (21:38 +0000)]
clarify tshark -B (file format) option

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22968 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd an item about the coloring rules crash fix.
gerald [Tue, 25 Sep 2007 21:35:20 +0000 (21:35 +0000)]
Add an item about the coloring rules crash fix.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22967 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoThis patch adds two new fields to the tcp-dissector:
sake [Tue, 25 Sep 2007 20:37:13 +0000 (20:37 +0000)]
This patch adds two new fields to the tcp-dissector:

tcp.time_relative ==> the time that has elapsed since the
   first packet that was seen in the current TCP stream

tcp.time_delta ==> the time that has elapsed since the
   last packet that was seen in the current TCP stream

Calculating these timestamps is turned off by default to not
use the extra memory that is needed for the per-packet-data.
It can be turned on through the TCP protocol preferences

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22966 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix whitespace of newly added lines to match rest of file
wmeier [Tue, 25 Sep 2007 20:34:06 +0000 (20:34 +0000)]
Fix whitespace of newly added lines to match rest of file

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22965 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd error checking for fwrites; replacement for one of patches provided in bug #1864
wmeier [Tue, 25 Sep 2007 19:59:50 +0000 (19:59 +0000)]
Add error checking for fwrites; replacement for one of patches provided in bug #1864

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22964 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agofix a typo in the source files target, took me more than an hour to find it :-(((
ulfl [Tue, 25 Sep 2007 19:52:51 +0000 (19:52 +0000)]
fix a typo in the source files target, took me more than an hour to find it :-(((

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22963 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd the file encapsulation.
gerald [Tue, 25 Sep 2007 19:52:19 +0000 (19:52 +0000)]
Add the file encapsulation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22962 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Gerrit Renker:
jake [Tue, 25 Sep 2007 19:42:46 +0000 (19:42 +0000)]
From Gerrit Renker:
This is an update for the DCCP dissector and has previously been sent to
the DCCP dissector maintainer, Francesco Fondelli, who supplied
the Acked-by. I have been using it with profit for several weeks.

This patch provides the following extensions:
 * type-dependent decoding of feature-negotiation options (NN and SP types of
options, NN is a 1..6 byte value in network-byte-order, SP is always a list of
unsigned char)
 * decoding for CCID3 Send Loss Event Rate feature
 * some pretty-printing of options
 * decoding of CCID3-specific options
       - Loss Event Rate (receiver report)
       - Receive Rate (also reported by receiver)
 * there was a change in the spec - the NDP count at sometime `grew' from 3 to
6 bytes (it was the same in the kernel). I have updated the data type from uint32 to
uint64
 * utility function to decode from network-byte-order into host byte order with
variable length

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22961 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoHighlight whole ethernet trailer in Packet Details View.
stig [Tue, 25 Sep 2007 19:30:26 +0000 (19:30 +0000)]
Highlight whole ethernet trailer in Packet Details View.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22960 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoalso do a distclean when doing a clean for the all target
ulfl [Tue, 25 Sep 2007 19:22:31 +0000 (19:22 +0000)]
also do a distclean when doing a clean for the all target

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22959 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoChange some additional protocols to the new build system
jmayer [Tue, 25 Sep 2007 18:02:49 +0000 (18:02 +0000)]
Change some additional protocols to the new build system

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22958 f5534014-38df-0310-8fa8-9805f1628bb7