guy [Mon, 20 May 2002 01:29:07 +0000 (01:29 +0000)]
From Yaniv Kaul: update to draft-ietf-ipsec-udp-encaps-02, which removed
UDP-encapsulated AH packet support.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5512
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 20 May 2002 01:01:11 +0000 (01:01 +0000)]
From Hannes Gredler: fix to label stack handling for withdrawn routes.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5511
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 20 May 2002 00:56:30 +0000 (00:56 +0000)]
Don't include the FCS in the tvbuff handed to "dissect_ppp_common()", so
that it's not included in the tvbuff handed to subdissectors. Use that
tvbuff to compute the FCS.
Properly handle the FCS in frames that don't include all the captured
data.
In VJ-compressed packets, put the VJ compression information into the
protocol tree, and set the Protocol and Info columns, and don't worry
about the CRC - as per the above, it's no longer in the tvbuff (and
never *was* in the tvbuff in some cases).
Also, clean up some other stuff in the VJ dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5510
f5534014-38df-0310-8fa8-
9805f1628bb7
tpot [Mon, 20 May 2002 00:36:04 +0000 (00:36 +0000)]
Some miscellaneous updates:
- implemented WritePrinter, DeletePrinterData
- fixed dissection of various printerdata routines to use a more
consistent field naming scheme and convert to ndr functions
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5509
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 19 May 2002 17:12:25 +0000 (17:12 +0000)]
Add Ronnie's notes about compiling under Cygwin.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5508
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 19 May 2002 14:01:07 +0000 (14:01 +0000)]
Get NEWS ready for the 0.9.4 release.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5506
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 18 May 2002 22:25:40 +0000 (22:25 +0000)]
From Michael Tuexen: show the filler only if present.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5505
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 18 May 2002 21:19:48 +0000 (21:19 +0000)]
Set the Info column for compressed and uncompressed TCP.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5504
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 18 May 2002 20:33:53 +0000 (20:33 +0000)]
From Michael Tuexen: updates to later IETF drafts:
draft-ietf-tsvwg-addip-sctp-05.txt for the add-IP extension
draft-stewart-prsctp-00.txt for the 'Partial Reliability' extension
draft-ietf-tsvwg-sctpcsum-07.txt
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5503
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sat, 18 May 2002 17:17:12 +0000 (17:17 +0000)]
Make the default SNMP build behavior "ifpresent" instead of "yes", so things
work as they should by default on systems without SNMP libraries.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5502
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sat, 18 May 2002 14:58:00 +0000 (14:58 +0000)]
Add initial support for GIOP.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5501
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sat, 18 May 2002 04:00:35 +0000 (04:00 +0000)]
Increment versions to 0.9.4, get NEWS current to April 25 (more NEWS to
come).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5500
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sat, 18 May 2002 02:41:46 +0000 (02:41 +0000)]
In the Windows capture dialog, place the interface description before the
interface name.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5499
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sat, 18 May 2002 02:05:47 +0000 (02:05 +0000)]
Add a "break;" after a "default:" to fix an MSVC++ compilation error.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5498
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Fri, 17 May 2002 23:17:22 +0000 (23:17 +0000)]
Update from Greg Morris.
Increase the max number of allowable req_cond_index's.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5497
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 17 May 2002 09:53:20 +0000 (09:53 +0000)]
Added support for HPUX11 NETTL captures for the NS_LS_DRIVER type.
It works for such captures containing 100baseT captures. It may explode on
other link types.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5496
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Fri, 17 May 2002 05:00:50 +0000 (05:00 +0000)]
DirectoryBase should be a uint32.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5495
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 16 May 2002 23:36:43 +0000 (23:36 +0000)]
From Andrew Esh: support for additional interest levels in
TRANS2_QUERY_FS_INFORMATION, and fix handling of level 1022 to treat the
file name as always being in Unicode.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5494
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 16 May 2002 21:47:22 +0000 (21:47 +0000)]
Set the default for "--want_ucdsnmp" back to "yes", since overflow problems
have been fixed in recent versions.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5493
f5534014-38df-0310-8fa8-
9805f1628bb7
ashokn [Thu, 16 May 2002 20:11:32 +0000 (20:11 +0000)]
- Major cleanup of the RSVP dissector
- Added support for OIF O-UNI 1.0 (as per 125.7 standard)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5492
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 16 May 2002 19:29:03 +0000 (19:29 +0000)]
From Andrew Esh: fix a compiler warning.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5491
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 16 May 2002 10:03:31 +0000 (10:03 +0000)]
Fix from Mark Burton.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5490
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 16 May 2002 09:59:52 +0000 (09:59 +0000)]
Move the #defines for NCP packet types to "packet-ncp-int.h", and use
them in "packet-ncp2222.inc".
The page at
http://www.odyssea.com/whats_new/tcpipnet/tcpipnet.html
indicates that a positive ACK (0x9999) NCP packet has the same
completion code and connection status fields as a reply (0x3333) packet
(but nothing after them); hand "dissect_ncp_reply()" the packet type as
one of its arguments, and have it handle positive ACK packets as well as
reply packets.
It also indicates that bit 4 of the connection status indicates that the
server is unavailable, and the page at
http://www.unm.edu/~network/presentations/course/appendix/appendix_f/tsld088.htm
speaks of that and of the significance of other bits; put a comment in
"ncp2222.py", before the "hf_ncp_connection_status" field, about that.
From looking at a capture, it appears that a "destroy service
connection" (0x5555) packet should be treated like a "create service
connection" (0x1111) packet and be handed to "dissect_ncp_request()".
Note that perhaps watchdog packets should be handled by
"dissect_ncp_reply()" as well.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5489
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 16 May 2002 08:57:12 +0000 (08:57 +0000)]
Added function names for all v2 and v3 functions for the SUN NFS ACL protocol stub dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5488
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 16 May 2002 08:51:17 +0000 (08:51 +0000)]
New dissector for SUN NFS AUTH nfs authentication protocol, stubs only.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5487
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 16 May 2002 08:50:00 +0000 (08:50 +0000)]
Stubs for new dissector for SUN NFS AUTHentication protocol.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5486
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Thu, 16 May 2002 03:31:34 +0000 (03:31 +0000)]
For response packets, add a field showing the number of the frame
containing the request packet.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5485
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 16 May 2002 02:43:53 +0000 (02:43 +0000)]
Fix a return type mismatch for get_CDR_wchar and a parameter type mismatch
for get_CDR_octet_seq. The one for get_CDR_octet_seq was preventing
compilation under MSVC++.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5484
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 15 May 2002 23:01:51 +0000 (23:01 +0000)]
Don't dissect the stuff after the RPC information in an RPC reply as a
protocol reply if:
we got anything other than SUCCESS for MSG_ACCEPTED;
we got MSG_DENIED;
we got anything other than MSG_ACCEPTED or MSG_DENIED;
as there isn't a protocol reply in there.
Just use "-1, -1" as arguments to "tvb_new_subset()" if you want the new
tvbuff to run to the end of the packet - there's no need to call
"tvb_reported_length_remaining()".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5483
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Wed, 15 May 2002 21:50:27 +0000 (21:50 +0000)]
Add Greg Morris as author of NCP dissector.
Remove paragraph begging for help on NCP dissector from README.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5482
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 15 May 2002 21:40:25 +0000 (21:40 +0000)]
From Hannes Gredler: labeled unicast support for BGP.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5481
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 15 May 2002 21:37:19 +0000 (21:37 +0000)]
Get rid of the "Connection Number High" entry - the "Connection Number"
entry covers both bytes of the connection number (as well as the number
in the middle - alas, there's no way to create a protocol tree item that
covers a discontiguous range of bytes).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5480
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 15 May 2002 21:18:19 +0000 (21:18 +0000)]
Get rid of an assigned-to-but-not-used variable, and eliminate another
variable that's used only once.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5479
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 15 May 2002 21:17:21 +0000 (21:17 +0000)]
NCP-over-UDP doesn't have a special header, as NCP-over-TCP does.
Dissect NCP watchdog packets.
Clean up the handling of NCP packet-specific headers and payload a bit.
Put in a protocol tree item for the upper 8 bits of the connection
number.
Make the "sorry, we don't dissect this yet" protocol tree item cover the
part we *don't* dissect, rather than covering the packet type.
Use the data dissector to dissect the data in a burst mode packet.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5478
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 15 May 2002 19:37:26 +0000 (19:37 +0000)]
From Andrew Esh: support for interest level 1003 and 1007 in
TRANS2_QUERY_FS_INFORMATION.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5477
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 15 May 2002 19:32:22 +0000 (19:32 +0000)]
iSCSI draft 12 support, from Mark Burton.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5476
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 15 May 2002 07:24:20 +0000 (07:24 +0000)]
Use registered fields for the subfields of the Flags field in DNS and
NBNS.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5475
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 15 May 2002 07:21:41 +0000 (07:21 +0000)]
Check in stub dissectors for Sun's NFS ACL, remote statistics, and
Solstice administration daemon RPC services.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5474
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 15 May 2002 06:51:07 +0000 (06:51 +0000)]
Make the message text an item in the protocol tree.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5473
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 15 May 2002 06:50:33 +0000 (06:50 +0000)]
Set the Info column as soon as we have enough information to do so.
Add support for burst packets.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5472
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 15 May 2002 03:33:40 +0000 (03:33 +0000)]
Add a comment about the Name Space field and its possible use to
indicate the character set for strings.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5471
f5534014-38df-0310-8fa8-
9805f1628bb7
tpot [Wed, 15 May 2002 03:28:43 +0000 (03:28 +0000)]
Set the length field correctly for proto_tree_add_text() when marking the
undissected part of a long frame.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5470
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 14 May 2002 21:35:17 +0000 (21:35 +0000)]
From Mark Burton: make the iSCSI protocol level a settable preference
rather than something chosen at compile time, and get rid of an
unused-but-#ifdeffed-out variable.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5469
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 14 May 2002 21:22:39 +0000 (21:22 +0000)]
From Mike Frisch: implement MAPID (procedure 12) in PCNFSD v2.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5468
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Tue, 14 May 2002 20:06:37 +0000 (20:06 +0000)]
Fix JobFileHandle and JobFileHandleLong.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5467
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 14 May 2002 18:27:28 +0000 (18:27 +0000)]
Use "-G fields" rather than "-G" in Makefiles.
Print an error and exit if an invalid option is given for the "-G" flag.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5466
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 14 May 2002 10:40:25 +0000 (10:40 +0000)]
Update from Kan Sasaki.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5465
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 14 May 2002 10:39:29 +0000 (10:39 +0000)]
Fix a compiler warning.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5464
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 14 May 2002 10:32:12 +0000 (10:32 +0000)]
From Ruud Linders: report errors from "g_module_open()".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5463
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 14 May 2002 10:15:12 +0000 (10:15 +0000)]
Make the "-G" flag take an argument. If no arugment is specified, or if
the argument is "fields", dump out a table of the fields, as we
currently do; if the argument is "protocols", dump out a table of the
protocols.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5462
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 14 May 2002 09:46:38 +0000 (09:46 +0000)]
Show the opaque type as a field and, if the opaque type is Traffic
Engineering LSA, show the rest of the LSA ID as a reserved field and an
instance, as per draft-katz-yeung-ospf-traffic-06.txt.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5461
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 14 May 2002 09:24:27 +0000 (09:24 +0000)]
From Kan Sasaki: added some VSAs from the FreeRadius dictionary files
and other changes to RADIUS.
Export the Q.931 cause location and code values, and use them in the
RADIUS dissector for ACC cause codes and values.
Make "CHAP" all caps, as it should be, and use InterCaps in AppleTalk
(Apple does).
The CHAP Challenge is an octet string, not a text string - the
FreeRadius dictionary has an error there.
In "rdconvertinttostr()", if there's no value_string table, just print
the value numerically, don't call "rd_match_strval()".
Don't pass a null value_string pointer to "rd_match_strval_attrib()" -
just report the value, without attempting to find a string for it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5460
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 14 May 2002 07:29:13 +0000 (07:29 +0000)]
Add some comments.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5459
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Mon, 13 May 2002 22:52:15 +0000 (22:52 +0000)]
Change the name under which variables are hashed during processing.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5458
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 13 May 2002 21:18:26 +0000 (21:18 +0000)]
Have "is_tpkt()" take a minimum-payload-length argument and check
whether the length value in the TPKT header is large enough to include
that much payload - if not, report the packet as not being a TPKT
packet.
Have the heuristic Q.931 dissector supply the appropriate value.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5457
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 13 May 2002 20:46:37 +0000 (20:46 +0000)]
From Motonori Shindo:
1) OSPF Link State Request packet in V2 has 4-octets LS type field
whereas 2-octets MBZ and 2-octets LS type field in V3.
2) 6th argument to proto_tree_add_item() has to be boolean value.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5456
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 13 May 2002 08:57:43 +0000 (08:57 +0000)]
From Kan Sasaki:
1. merge '#define XXX', XXX_printinfo and XXX_attrib_type_vals
into XXX_attrib to make it easy to add new attributes.
2. put decoded VSAs as sub item.
Update comments to reflect those changes.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5455
f5534014-38df-0310-8fa8-
9805f1628bb7
tpot [Mon, 13 May 2002 01:27:07 +0000 (01:27 +0000)]
Added subdissectors for StartDocPrinter and EndDocPrinter RPCs.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5454
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 13 May 2002 01:24:47 +0000 (01:24 +0000)]
Add a "tvb_ensure_bytes_exist()", which is like "tvb_bytes_exist()" only
it throws the appropriate exception if the bytes don't exist. Use it in
the GIOP and ASN.1 code to check whether the bytes to be copied to a
buffer exist before allocating the buffer.
Make "check_offset_length_no_exception()" check for an overflow, so that
it can be used in "tvb_ensure_bytes_exist()" and do all the checking
that the code "tvb_ensure_bytes_exist()" replaces did.
Make "get_CDR_wchar()" return a "gint", so that if the length octet it
fetched has a value between 128 and 255, the length can be returned
correctly.
Fix some comments not to specify the exception thrown by various
routines that can throw various exceptions.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5453
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 12 May 2002 20:43:29 +0000 (20:43 +0000)]
Fix a bounds checking error in get_CDR_octet_seq.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5452
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 11 May 2002 23:04:53 +0000 (23:04 +0000)]
Put in a note about date and time formats.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5451
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 11 May 2002 22:53:58 +0000 (22:53 +0000)]
Mark unused arguments as such.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5450
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 11 May 2002 22:40:40 +0000 (22:40 +0000)]
From Didier Gautheron: do case-insensitive comparison against the
authentication mode, and add support for the "exchange file" operation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5449
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 11 May 2002 22:29:43 +0000 (22:29 +0000)]
In "dissect_nt_policy_hnd()":
add arguments to specify whether the policy handle is being
opened or closed, and don't set the "open frame" for the handle
unless it's being opened and don't set the "close frame" for the
handle unless it's being closed;
store the policy handle before fetching it, so that an open or
close is marked appropriately in the protocol tree on the first
pass;
if the policy handle has a name associated with it, put that
name into the top-level item for the policy handle.
In "packet-dcerpc-spoolss.c":
get rid of aun unused variable;
make "setjob_commands[]" static, as it's not used outside
"packet-dcerpc-spoolss.c";
put a "VALS()" call around the reference to "setjob_commands",
to squelch compiler warnings;
give the SPOOLSS return code field the appropriate
"value_string" array.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5448
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 11 May 2002 22:22:11 +0000 (22:22 +0000)]
Handle an LSA length <= the length of an LSA header.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5447
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 11 May 2002 18:58:02 +0000 (18:58 +0000)]
Add a mechanism for registering "obsolete" preference modules, so that
if a dissector had preferences at one point but no longer does, it can
register that fact, so that the old preferences in the preference file
are silently ignored.
Use that mechanism in the NCP dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5446
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 11 May 2002 18:55:22 +0000 (18:55 +0000)]
Instead of creating two handles for the RPC-over-TCP and
RPC-over-everything-else dissectors, one registered by name and one
anonymous, just fetch the handles for the registered dissectors.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5445
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 11 May 2002 18:52:55 +0000 (18:52 +0000)]
Use a name, not a number, to refer to the IP protocol number for UDP.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5444
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 11 May 2002 18:46:38 +0000 (18:46 +0000)]
From Graeme Hewson: add some sanity checks to DNS dissector to avoid
loops.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5443
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 11 May 2002 18:43:09 +0000 (18:43 +0000)]
Get rid of an unused variable.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5442
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 10 May 2002 23:20:38 +0000 (23:20 +0000)]
From Joerg Mayer: make a pile of stuff not used outside one source file
static, and add a new "packet-data.h" to declare "proto_data".
Display escape sequences in octal in the IAPP dissector, as is now done
in the RADIUS dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5441
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 10 May 2002 22:09:24 +0000 (22:09 +0000)]
Update the URL and comment for the SNIA CIFS spec, now that it's final.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5440
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 10 May 2002 20:02:40 +0000 (20:02 +0000)]
Mark an unused argument as such.
Fix a couple of typos in comments.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5439
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 10 May 2002 19:34:15 +0000 (19:34 +0000)]
The two entries for Martin Thomas are for the same person; combine them
under the e-mail address he says should be used.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5438
f5534014-38df-0310-8fa8-
9805f1628bb7
ashokn [Fri, 10 May 2002 18:37:38 +0000 (18:37 +0000)]
- Added support for LMP draft versions -02 and -03 (selectable in
protocol preferences)
- Added OSPF display filtering support, including OSPF/TE extensions
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5437
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Fri, 10 May 2002 02:44:08 +0000 (02:44 +0000)]
Register FT_UINT_BYTES with correct structure.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5436
f5534014-38df-0310-8fa8-
9805f1628bb7
tpot [Fri, 10 May 2002 02:41:48 +0000 (02:41 +0000)]
Add printer name to COL_INFO for ClosePrinter request.
Converted enumjobs command to Ronnie's NDR dissection routines.
Implemented getjob, setjob, startpageprinter, endpageprinter commands using
NDR routines.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5435
f5534014-38df-0310-8fa8-
9805f1628bb7
tpot [Fri, 10 May 2002 02:30:22 +0000 (02:30 +0000)]
Added a private data member to the dcerpc_info structure. This second
level of private data turns out to be needed to pass something other than
an int to dcerpc_dissect_fnct_t functions passed to dissect_ndr_pointer.
A nicer way of doing this would be to convert the levels parameter to a
void *state type of variable but this turns out to be a lot more work as
opposed to a one line change here. (-:
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5434
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Thu, 9 May 2002 23:50:34 +0000 (23:50 +0000)]
Merge the work in Novell_NCP_branch into the mainline code.
A little work still needs to be done on the new NCP dissector -- make
some of the COL_INFO texts more useful, handle a Unicode issue, and
modify some of the cases that use "request conditions".
But the NCP dissector as it stands is very usable now.
Note: I didn't merge in the PROTO_LENGTH_UNTIL_END macro... I wanted
to think about the various possible macros and review an email conversation
I had with Guy on the subject.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5432
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 9 May 2002 12:10:06 +0000 (12:10 +0000)]
Added parsing of PORTMAP GETPORT functions.
When we see PRTOMAP GETPORT calls for UDP, make sure all further UDP packets to or from
this port goes to the ONC-RPC dissector regardless of the port on the other side.
We need this because if there is ONC-RPC traffic going between the ONC-RPC Program port to a port which has a normal ethereal dissector, ethereal would dissect the traffic as the protocol associated with the other port instead.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5430
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 9 May 2002 11:18:47 +0000 (11:18 +0000)]
Process address lengths according to the X.25 spec.
Put in a comment noting that the address data should, if the A bit is
set, be processed according to the spec.
Label addresses for registration requests and confirmations
appropriately.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5429
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 9 May 2002 09:54:13 +0000 (09:54 +0000)]
Put in a comment noting that the previous change came from a real
capture, so if an IDL disagrees, the IDL is wrong.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5428
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 9 May 2002 09:49:34 +0000 (09:49 +0000)]
As Ronnie Sahlberg notes, the problem is that the QueryDomainInfo
response starts with a UNIQUE pointer to a DOMAIN_INFO, not with a REF
pointer to a DOMAIN_INFO - and also not with a UNIQUE pointer to a
DOMAIN_INFO REF pointer; fix the code to match that.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5427
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 9 May 2002 08:36:45 +0000 (08:36 +0000)]
In at least one capture, a QueryDomainInfo response starts with what is,
I guess, a UNIQUE pointer to a DOMAIN_INFO REF pointer; dissect it as
such.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5426
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 9 May 2002 08:27:51 +0000 (08:27 +0000)]
Fix another place where the heuristic dissector was checking data before
it new it was available.
Fix some comments.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5425
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 9 May 2002 07:42:07 +0000 (07:42 +0000)]
In the heuristic dissector, check to make sure the data being looked at
is available before looking at it, so we don't throw an exception before
we conclude whether the packet is, or isn't, one of ours.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5424
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 9 May 2002 05:49:28 +0000 (05:49 +0000)]
From Martin Thomas: handle address lengths based on TOA bit in X.25.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5423
f5534014-38df-0310-8fa8-
9805f1628bb7
tpot [Thu, 9 May 2002 02:44:22 +0000 (02:44 +0000)]
Added a routine to dissect a DOS error code. These are used in the spoolss
(also registry and srvsvc?) pipe dissectors.
Also added some helper routines for decoding a range of uint8s. These map
nicely to the dissect_{dcerpc,ndr}_foo() format with the addition of a
length parameter, but aren't really part of the NDR specification and are
probably only going to be used in the NT dcerpc dissectors.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5421
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 8 May 2002 23:46:34 +0000 (23:46 +0000)]
From Didier Gautheron:
DSI and ASP updates to better handle addresses in replies.
Dissect DSI "open session" and "attention" messages.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5420
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 8 May 2002 22:24:03 +0000 (22:24 +0000)]
From Joerg Mayer:
autoconf 2.53 creates directories named autom4te.cache
Add them to .cvsignore
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5419
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 8 May 2002 20:29:47 +0000 (20:29 +0000)]
From Stefan Wenk: SIP heuristic dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5418
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 8 May 2002 12:51:45 +0000 (12:51 +0000)]
Added option to match async NLM MSG with RES packets, to print which MSG packet matches which RES packet and v.v as well as (in RES packets) how long the call took to execute.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5417
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 8 May 2002 08:13:08 +0000 (08:13 +0000)]
From Kan Sasaki: VSA decoding and other changes to RADIUS.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5416
f5534014-38df-0310-8fa8-
9805f1628bb7
tpot [Wed, 8 May 2002 05:15:11 +0000 (05:15 +0000)]
Added constant and value_string for invalid security descriptor owner
error.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5415
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 7 May 2002 18:52:27 +0000 (18:52 +0000)]
From Chenjiang Hu: use the correct offset when fetching unreserved
bandwidth values.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5414
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 7 May 2002 11:26:46 +0000 (11:26 +0000)]
Several bugfixes for SAMR
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5413
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 7 May 2002 10:07:55 +0000 (10:07 +0000)]
Added extra check in the function that parses NDR pointers.
When the representation for a pointer type gets dissected, the dissector
is actually called twice. Once with conformant_run==1 and once ==0.
The idea is that when conformant_run is ==1, the ONLY bytes that will be
dissected and would be the array structure preceeding the actual data.
And the normal data and content will be dissected when conformant_run ==0.
This is to handle the case properly when conformant arrays are embedded inside
aggregated types, in which case there will be other data inserted between
these array control data, and the array content.
The check that is added will assert that no other data is actually eaten
for conformant_run==1 than just this data.
This will help debugging dcerpc dissectors.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5412
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 7 May 2002 06:25:30 +0000 (06:25 +0000)]
Traffic with a traffic type of 0x06 is Signalling AAL traffic, including
non-Q.2931 SSCOP traffic; change comments to reflect that.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5411
f5534014-38df-0310-8fa8-
9805f1628bb7
tpot [Tue, 7 May 2002 00:35:14 +0000 (00:35 +0000)]
Fix up item lengths for policy handle subtree and subitems under it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5410
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 6 May 2002 21:53:33 +0000 (21:53 +0000)]
Remove the unused "offset_saved" variable, as per the changes to
"ethereal_gen.py" not to generate the line setting it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5409
f5534014-38df-0310-8fa8-
9805f1628bb7