Fix markup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36302 f5534014-38df-0310-8fa8-9805f1628bb7

remove a conditional that can never be true

coverity 247

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36301 f5534014-38df-0310-8fa8-9805f1628bb7

Clean up information about older Windows versions.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36300 f5534014-38df-0310-8fa8-9805f1628bb7

Added an entry about the new tshark "-z <proto>,srt" syntax.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36299 f5534014-38df-0310-8fa8-9805f1628bb7

Add ICMP echo request/reply conversation tracking.  Closes bug 5770.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36298 f5534014-38df-0310-8fa8-9805f1628bb7

From: wireshark.org/lists/wireshark-dev/201103/msg00157.html
Change RTT references to SRT.
(tshark.pod could use a description for -z afp,srt and -z camel,srt)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36297 f5534014-38df-0310-8fa8-9805f1628bb7

From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5768 :

Patch 1 :
Enhance MySQL : Reorder hf and Proto_reg

Patch 2 :
Enhance MySQL : white space changes, use ENC_NA when appropriate, use
proto_tree_add_item()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36296 f5534014-38df-0310-8fa8-9805f1628bb7

Remove unneeded NULL Test...

Addresses Coverity 598

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36295 f5534014-38df-0310-8fa8-9805f1628bb7

Recode a loop slightly ....

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36294 f5534014-38df-0310-8fa8-9805f1628bb7

Fix bug: 'if ((octet & 0x80) == 80)' ==> 'if ((octet & 0x80) == 0x80)'

Coverity 345

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36293 f5534014-38df-0310-8fa8-9805f1628bb7

Fix bugs: 'if ((flags & 0x2) == 1)' ==> 'if ((flags & 0x2) != 0)'
Coverity 346 & 347

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36292 f5534014-38df-0310-8fa8-9805f1628bb7

Fixed second parameter to create_persconffile_profile.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36291 f5534014-38df-0310-8fa8-9805f1628bb7

Ensure we create the "Default" personal configuration files directory before
creating a new profile.  This fixes a bug when trying to create a new profile
from a newly installed wireshark with no saved preferences.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36290 f5534014-38df-0310-8fa8-9805f1628bb7

Fix bug: 'guint8 |=0x8000'.
Coverity 350

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36289 f5534014-38df-0310-8fa8-9805f1628bb7

Don't use C++/C99-style comments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36288 f5534014-38df-0310-8fa8-9805f1628bb7

Remove some unncessary assignments to proto_item pointers.

Coverity 904 & 905.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36287 f5534014-38df-0310-8fa8-9805f1628bb7

Don't assign proto_item pointers that are not used.

Coverity CIDs 1021 & 1022.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36286 f5534014-38df-0310-8fa8-9805f1628bb7

Remove static that was added to appease Coverity 753. 2016 bytes isn't too much to put on the stack.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36285 f5534014-38df-0310-8fa8-9805f1628bb7

From Vincent Helfre:
- added documentation in packet-csn1.h
- fixed a bug in packet-csn1.c
- fixed a BSIC description in packet-gsm_a_rr.c
- removed the "_v" suffix in packet-gsm_rlcmac element description

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36284 f5534014-38df-0310-8fa8-9805f1628bb7

Removed unused parameter to parseServiceNodeId.

Coverity 596.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36283 f5534014-38df-0310-8fa8-9805f1628bb7

Rewrote check for szStr in dissect_ICBAPhysicalDevice_get_LogicalDevice_rqst.

Coverity 535.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36282 f5534014-38df-0310-8fa8-9805f1628bb7

Removed "comparing an array to null", with no effect.

Coverity 534.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36281 f5534014-38df-0310-8fa8-9805f1628bb7

Removed "comparing an array to null", with no effect.

Coverity 533.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36280 f5534014-38df-0310-8fa8-9805f1628bb7

Removed "comparing an array to null", with no effect.

Coverity 532.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36279 f5534014-38df-0310-8fa8-9805f1628bb7

value&0x03 does not need to be shifted to the right by two.

cut-n-paste bug from a few lines above where value&0x0c do need to be shifted by two
before printing as a value

coverity 342

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36278 f5534014-38df-0310-8fa8-9805f1628bb7

CID 453,454
Missing break

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36277 f5534014-38df-0310-8fa8-9805f1628bb7

dont assign to a proto_item* unless we are going to use the value

coverity 1157

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36276 f5534014-38df-0310-8fa8-9805f1628bb7

Print the time units in the CSV output for io_stat using correct extension, i.e. always in seconds.

coverity 419

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36275 f5534014-38df-0310-8fa8-9805f1628bb7

Shift the correct number of steps when masking the UAAERP bit to 0/1

coverity 348

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36274 f5534014-38df-0310-8fa8-9805f1628bb7

The NSG bits in the login pdu are 0x0c   not 0xc0

coverity 344

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36273 f5534014-38df-0310-8fa8-9805f1628bb7

Don't compute each checksum twice when adding dummy headers (-u, -T, -s, -S options)

g_ntohs() & friends may be (are ?) macros and may (will ?) eval args more than once ...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36272 f5534014-38df-0310-8fa8-9805f1628bb7

Don't compile expert_dlg.c (that dialog is being removed)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36271 f5534014-38df-0310-8fa8-9805f1628bb7

Clarify a comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36270 f5534014-38df-0310-8fa8-9805f1628bb7

Coverity 989

Remove some item=  assignments we dont need since we never use the value
of the created item.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36269 f5534014-38df-0310-8fa8-9805f1628bb7

Added a sanity check for finfo->hfinfo.

Coverity 425.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36268 f5534014-38df-0310-8fa8-9805f1628bb7

Remove two tests for fail return from g_malloc();  Fixes Coverity #424 "FORWARD_NULL"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36267 f5534014-38df-0310-8fa8-9805f1628bb7

Allocate correct size of fdata col_text and col_text_len.

Coverity 711 & 716.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36266 f5534014-38df-0310-8fa8-9805f1628bb7

Allocate correct size of nwk_keyring.

Coverity 715.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36265 f5534014-38df-0310-8fa8-9805f1628bb7

Allocate correct size of hash_key.

Coverity 713.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36264 f5534014-38df-0310-8fa8-9805f1628bb7

Allocate correct size of reload_frame.

Coverity 714.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36263 f5534014-38df-0310-8fa8-9805f1628bb7

Allocate correct size of range.

Coverity 718.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36262 f5534014-38df-0310-8fa8-9805f1628bb7

Allocate correct size of int, not size of a pointer to int.

Coverity 717.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36261 f5534014-38df-0310-8fa8-9805f1628bb7

Initialize al_cto before usage.

Coverity 808.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36260 f5534014-38df-0310-8fa8-9805f1628bb7

Initialize geom in window_get_geometry.

Coverity 804.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36259 f5534014-38df-0310-8fa8-9805f1628bb7

Fix potential array overrun: Coverity CID #565.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36258 f5534014-38df-0310-8fa8-9805f1628bb7

Fix mask when extracting FACH Indicator.
Coverity CID 349.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36257 f5534014-38df-0310-8fa8-9805f1628bb7

Remove redundant comparison.
Coverity CID 361.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36256 f5534014-38df-0310-8fa8-9805f1628bb7

Make a struct static to avoid growing the stack too much.
Coverity CID 753.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36255 f5534014-38df-0310-8fa8-9805f1628bb7

Don't assign top_ti - delete it for now.
Coverity CID 862

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36254 f5534014-38df-0310-8fa8-9805f1628bb7

From Dirk via bug #5771: Add heuristic dissector for images and HTTP

Also add to AUTHORS file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36253 f5534014-38df-0310-8fa8-9805f1628bb7

We have to initialize the elements of the fdata->col_text array to null
pointers, as there's code that assumes that if they're not set to null
pointers, they're set correctly, and doesn't bother setting them to the
right value.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36252 f5534014-38df-0310-8fa8-9805f1628bb7

Copy expert_tapdata_t here so that expert_dlg.h is no longer needed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36251 f5534014-38df-0310-8fa8-9805f1628bb7

There can be up to 15 DL HARQ processes (depending upon TDD config index).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36250 f5534014-38df-0310-8fa8-9805f1628bb7

Fix a typo

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36249 f5534014-38df-0310-8fa8-9805f1628bb7

Pass pointers to structs instead of struct values to create_ntlmssp_v2_key.

Coverity 567.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36248 f5534014-38df-0310-8fa8-9805f1628bb7

Allocate space for null termination in make_basename.

Coverity 710.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36247 f5534014-38df-0310-8fa8-9805f1628bb7

Close fp in error case in ssl_parse_key_list to avoid leakage.

Coverity 597.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36246 f5534014-38df-0310-8fa8-9805f1628bb7

Rewrote error reporting to avoid using a 2048 bytes stack buffer.

Coverity 726.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36245 f5534014-38df-0310-8fa8-9805f1628bb7

Corrected hack for TAPA by checking for "not IPv4".

Coverity 343.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36244 f5534014-38df-0310-8fa8-9805f1628bb7

Coverity 1167

Dont assign tlv_item unless we need to dereference it.
Also push the variable deeper into the scope where it is used isntead of function wide scope.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36243 f5534014-38df-0310-8fa8-9805f1628bb7

Coverity 1168

Create the items for 33_ARS under the subtree we create for this type and not under the parent node in the tree.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36242 f5534014-38df-0310-8fa8-9805f1628bb7

Coverity 512

Check if we ran out of bytes in the tvb and return NULL
instead of trying to pass it to the decryption routines.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36241 f5534014-38df-0310-8fa8-9805f1628bb7

Coverity 323

Use strdup to copy a string literal we will free() later on.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36240 f5534014-38df-0310-8fa8-9805f1628bb7

- Add 9.4.5 IMEISV IE dissection
- UE Time Zone is TLV
- Cell Global Identity  PDU type is SGSAP_PDU_TYPE

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36239 f5534014-38df-0310-8fa8-9805f1628bb7

Coverity 420

Remove dead code and add a g_assert_not_reached() at a spot we can definitely never reach.

change a if(x)g_free(x) to a g_free(x)
since g_free(NULL) is just a nop.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36238 f5534014-38df-0310-8fa8-9805f1628bb7

Use the same style in netscreen_seek_read() that we use in
netscreen_read(), checking the return value of
parse_netscreen_hex_dump() against -1 and explicitly returning FALSE if
it's -1, otherwise driving on.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36237 f5534014-38df-0310-8fa8-9805f1628bb7

Make expert_tapdata_t opaque to its clients; define the structure only
in gtk/expert_comp_dlg.c.

Don't declare now-static functions in gtk/expert_dlg.h.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36236 f5534014-38df-0310-8fa8-9805f1628bb7

Remove the Exper info dialogue.
(Leave the fies for a while).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36235 f5534014-38df-0310-8fa8-9805f1628bb7

When we allocate the col_text array, initialize it to a bunch of
pointers to null strings, rather than a bunch of null pointers, so that
if an exception is thrown before we set any of the columns, or some
other problem occurs, we don't end up with null pointers that could
later cause a crash.

Fix indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36234 f5534014-38df-0310-8fa8-9805f1628bb7

Re-arrange code so Coverity Prevent doesn't falsely report several INFINITE_LOOPs: Coverity 427-429 (run 617)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36233 f5534014-38df-0310-8fa8-9805f1628bb7

Fix for bug 5762, wireshark asserts on reading juniper snoop output when no hex data is present (snoop detail off).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36232 f5534014-38df-0310-8fa8-9805f1628bb7

Fix an "infinite loop" defect reported by Coverity Prevent (Coverity 430 (run 616)).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36231 f5534014-38df-0310-8fa8-9805f1628bb7

Corrected decoding of oid values with length 5.
This fixes coverity 340.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36230 f5534014-38df-0310-8fa8-9805f1628bb7

Re-arrange code slightly to remove a false positive Coverity Prevent "Forward Null" defect report.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36229 f5534014-38df-0310-8fa8-9805f1628bb7

Added some casts to fix coverity 325.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36228 f5534014-38df-0310-8fa8-9805f1628bb7

Add a comment re a "suspicious" sizeof() reported by Coverity Prevent.
(The report seems correct but I'm not altogether sure).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36227 f5534014-38df-0310-8fa8-9805f1628bb7

Don't close file handle if a file write error; (caller does the close)

Fixes "USE_AFTER_FREE" defect reported by Coverity Prevent.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36226 f5534014-38df-0310-8fa8-9805f1628bb7

Fix a comment; Use consistent indentatation & formatting.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36225 f5534014-38df-0310-8fa8-9805f1628bb7

#if out another unused routine.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36224 f5534014-38df-0310-8fa8-9805f1628bb7

From Jakub Zawadzki via wireshark-dev: Fix comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36223 f5534014-38df-0310-8fa8-9805f1628bb7

#if 0-out an unused routine.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36222 f5534014-38df-0310-8fa8-9805f1628bb7

Add Python 3 support via 2to3.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36221 f5534014-38df-0310-8fa8-9805f1628bb7

expert_dlg.c:603: warning: 'expert_dlg_cb' defined but not used

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36220 f5534014-38df-0310-8fa8-9805f1628bb7

Don't register the Exper info dialogue as a first step of removal.

Should the common routines be moved into expet_comp_dlg.[ch]?

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36219 f5534014-38df-0310-8fa8-9805f1628bb7

[Automatic manuf, services and enterprise-numbers update for 2011-03-20]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36216 f5534014-38df-0310-8fa8-9805f1628bb7

Added a configure message when having c-ares instead of adns.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36215 f5534014-38df-0310-8fa8-9805f1628bb7

From Roland Knall <rknall [AT] gmail.com>: allow heuristic subdissectors
for SERCOS III packets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36214 f5534014-38df-0310-8fa8-9805f1628bb7

Clean up indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36213 f5534014-38df-0310-8fa8-9805f1628bb7

From James Deucker via bug 5766:
Mark some unused arguments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36212 f5534014-38df-0310-8fa8-9805f1628bb7

From Alexis La Goutte submitted in bug 5759: Use  ENC_NA where appropriate.
From me:  Remove unused header fields found by checkhf.pl.  One more ENC_NA.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36211 f5534014-38df-0310-8fa8-9805f1628bb7

All fields are little-endian.  Fixes bug 5759 reported by Tang Fulin.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36210 f5534014-38df-0310-8fa8-9805f1628bb7

Don't clobber the capinfos data if we have a valid capture file. This
should let the original file information show up in bug reports.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36209 f5534014-38df-0310-8fa8-9805f1628bb7

Respond to most of the clang warnings for this dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36208 f5534014-38df-0310-8fa8-9805f1628bb7

From Jakub Zawadzki: Simpler patch to resolve bug 5755 to properly display all
strings in dissect_octet_string() without having to allocate extra memory.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36207 f5534014-38df-0310-8fa8-9805f1628bb7

As per bug 5751, these header files are no longer needed/used.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36206 f5534014-38df-0310-8fa8-9805f1628bb7

Add README.heuristic to the source distribution

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36205 f5534014-38df-0310-8fa8-9805f1628bb7

Avoid some unnecessary assignments (as reported by clang).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36204 f5534014-38df-0310-8fa8-9805f1628bb7

Don't increment after reading last outheader value (as reported by clang).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36203 f5534014-38df-0310-8fa8-9805f1628bb7

Avoid having large buffers on the stack (as noted in VS Code Analyzer warnings).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36202 f5534014-38df-0310-8fa8-9805f1628bb7

2 VS Code Analyzer warnings were bogus. Avoid one and add a comment about the second one.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36201 f5534014-38df-0310-8fa8-9805f1628bb7