obnox/wireshark/wip.git
16 years agodo the fifo test on platforms where mkfifo is available
richardv [Fri, 24 Aug 2007 15:45:16 +0000 (15:45 +0000)]
do the fifo test on platforms where mkfifo is available

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22640 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix bug 1181 by always using select() on a capture fd on linux
richardv [Fri, 24 Aug 2007 15:34:08 +0000 (15:34 +0000)]
Fix bug 1181 by always using select() on a capture fd on linux

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22639 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd some comments to the effect that capture_loop_dispatch must timeout to make
richardv [Fri, 24 Aug 2007 15:33:37 +0000 (15:33 +0000)]
Add some comments to the effect that capture_loop_dispatch must timeout to make
the packet batching stuff work properly.

Hence, do not block forever when doing a select() on a capture fd.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22638 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agofix log msg typo
richardv [Fri, 24 Aug 2007 15:29:13 +0000 (15:29 +0000)]
fix log msg typo

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22637 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoRevert back to old version with manually fixed get_ber_length parameters
jmayer [Fri, 24 Aug 2007 13:52:37 +0000 (13:52 +0000)]
Revert back to old version with manually fixed get_ber_length parameters

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22636 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agocomplete the death of the h223 plugin
richardv [Fri, 24 Aug 2007 13:44:59 +0000 (13:44 +0000)]
complete the death of the h223 plugin

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22635 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agomove packet-srp into the core (from the h223 plugin)
richardv [Fri, 24 Aug 2007 13:08:21 +0000 (13:08 +0000)]
move packet-srp into the core (from the h223 plugin)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22634 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoadd oids.{c,h} for LEGO
richardv [Fri, 24 Aug 2007 12:45:08 +0000 (12:45 +0000)]
add oids.{c,h} for LEGO

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22633 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoCut and paste old oid_to_subid_buf (it used to be in packet-snmp.c) to get things...
richardv [Fri, 24 Aug 2007 12:44:29 +0000 (12:44 +0000)]
Cut and paste old oid_to_subid_buf (it used to be in packet-snmp.c) to get things building again.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22632 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agofix 'unused variable' warning
richardv [Fri, 24 Aug 2007 12:43:38 +0000 (12:43 +0000)]
fix 'unused variable' warning

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22631 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoadd newline to end of file
richardv [Fri, 24 Aug 2007 12:15:49 +0000 (12:15 +0000)]
add newline to end of file

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22630 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoWarning fixes
jmayer [Fri, 24 Aug 2007 10:20:22 +0000 (10:20 +0000)]
Warning fixes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22629 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoThe ber header was missing from the object, resulting in
jmayer [Fri, 24 Aug 2007 08:12:39 +0000 (08:12 +0000)]
The ber header was missing from the object, resulting in
invalid saved certificates.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22628 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoget_ber_length doesn't need the tree argument, get rid of it.
jmayer [Fri, 24 Aug 2007 07:12:04 +0000 (07:12 +0000)]
get_ber_length doesn't need the tree argument, get rid of it.
Rebuild asn1 dissectors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22627 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDecode certificates
jmayer [Fri, 24 Aug 2007 07:10:33 +0000 (07:10 +0000)]
Decode certificates

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22626 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDon't acidentally print the hexdump of a certificate
jmayer [Fri, 24 Aug 2007 06:52:19 +0000 (06:52 +0000)]
Don't acidentally print the hexdump of a certificate
in the summary-tree

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22625 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMake Windows path separator look like Unix path separator.
jmayer [Fri, 24 Aug 2007 06:51:10 +0000 (06:51 +0000)]
Make Windows path separator look like Unix path separator.
That way, we will not have irrelevant diffs depending on
the platform the last submitter built the dissector on.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22624 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd a value for message_authenticator
jmayer [Fri, 24 Aug 2007 06:49:47 +0000 (06:49 +0000)]
Add a value for message_authenticator

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22623 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Chris Maynard:
etxrab [Fri, 24 Aug 2007 05:59:08 +0000 (05:59 +0000)]
From Chris Maynard:
Fix display filter field problems
Correct the template files in the case of generated dissectors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22622 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Chris Maynard:
etxrab [Fri, 24 Aug 2007 05:58:08 +0000 (05:58 +0000)]
From Chris Maynard:
Fix display filter field problems
Correct the template files in the case of generated dissectors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22621 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agothis one was missing
lego [Fri, 24 Aug 2007 00:41:43 +0000 (00:41 +0000)]
this one was missing

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22620 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoNever, never, never modify a generated file... or out of idiocy you might loose chang...
lego [Fri, 24 Aug 2007 00:33:35 +0000 (00:33 +0000)]
Never, never, never modify a generated file... or out of idiocy you might loose changes (or not check them in).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22619 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAnother iteration, the new code is almost there, We're missing just the implied octet...
lego [Fri, 24 Aug 2007 00:26:30 +0000 (00:26 +0000)]
Another iteration, the new code is almost there, We're missing just the implied octetstrings indexes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22618 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoIn keeping with all the other path variables (eg, libdir), don't resolve
richardv [Fri, 24 Aug 2007 00:06:30 +0000 (00:06 +0000)]
In keeping with all the other path variables (eg, libdir), don't resolve
plugindir at configure time. Instead leave it to be defined at make
time, which means it can then be changed by, eg, changing $prefix. This
also means moving the definition of PLUGIN_DIR from config.h to a -D in
CPPFLAGS.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22617 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDon't build in init_plugin_dir if HAVE_PLUGINS is not defined, which
richardv [Fri, 24 Aug 2007 00:03:02 +0000 (00:03 +0000)]
Don't build in init_plugin_dir if HAVE_PLUGINS is not defined, which
means that we aren't reliant on PLUGIN_DIR having a sensible value.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22616 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Chris Maynard <christopher.maynard@gtech.com> / bug 1789:
richardv [Thu, 23 Aug 2007 23:58:59 +0000 (23:58 +0000)]
From Chris Maynard <christopher.maynard@gtech.com> / bug 1789:

Incorrect display filter field naming conventions for packet-c*.c dissector
files.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22615 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoadd remaining golay_* functions
richardv [Thu, 23 Aug 2007 23:33:23 +0000 (23:33 +0000)]
add remaining golay_* functions

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22614 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMove follow_infos into folow_stream.c and initialize it.
gerald [Thu, 23 Aug 2007 23:01:20 +0000 (23:01 +0000)]
Move follow_infos into folow_stream.c and initialize it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22613 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Scott Robinson:
sfisher [Thu, 23 Aug 2007 22:11:39 +0000 (22:11 +0000)]
From Scott Robinson:

Enhancement patch:
  http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1758

This change gives Wireshark the ability to read ATM captures saved by UpTime
Select traffic capture.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22612 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix comment on top of file
sfisher [Thu, 23 Aug 2007 21:51:44 +0000 (21:51 +0000)]
Fix comment on top of file

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22611 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFixed drawing of X Axis decimal values: "0. 50" -> "0.050"
stig [Thu, 23 Aug 2007 21:51:36 +0000 (21:51 +0000)]
Fixed drawing of X Axis decimal values:  "0. 50" -> "0.050"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22610 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoWhen detecting fast retransmissions or out of order packets, use a 64-bit variable...
morriss [Thu, 23 Aug 2007 21:38:15 +0000 (21:38 +0000)]
When detecting fast retransmissions or out of order packets, use a 64-bit variable to store the time delta (instead of a 32-bit one).  We're counting nanoseconds here, so this allows us to accurately detect differences greater than 4.294 seconds.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22609 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoExport golay_errors() to get the Windows builds going again
morriss [Thu, 23 Aug 2007 21:11:47 +0000 (21:11 +0000)]
Export golay_errors() to get the Windows builds going again

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22608 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoClean up the code.
jake [Thu, 23 Aug 2007 20:42:27 +0000 (20:42 +0000)]
Clean up the code.
- Move add. info from header
- Remove excess comma's
- Use plurality macro
- NULL pointer for field descriptions

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22607 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoImplement Resolution of conceptual table indexing
lego [Thu, 23 Aug 2007 19:45:31 +0000 (19:45 +0000)]
Implement Resolution of conceptual table indexing
So far this has being tested only for integer indexes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22606 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoList additional request for command presentation
jake [Thu, 23 Aug 2007 19:12:52 +0000 (19:12 +0000)]
List additional request for command presentation

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22605 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoInclude libpcap.h so that we can use wtap_pcap_encap_to_wtap_encap()
gerald [Thu, 23 Aug 2007 17:49:47 +0000 (17:49 +0000)]
Include libpcap.h so that we can use wtap_pcap_encap_to_wtap_encap()
in its new location.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22604 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoin preparation for de-pluginising h223, move golay code support into libwireshark
richardv [Thu, 23 Aug 2007 17:25:22 +0000 (17:25 +0000)]
in preparation for de-pluginising h223, move golay code support into libwireshark

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22603 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoTranslate Q.850 Cause values.
etxrab [Thu, 23 Aug 2007 17:00:44 +0000 (17:00 +0000)]
Translate Q.850 Cause values.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22602 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDon't rename to self when fuzz err; enable ^C file cleanup trap
wmeier [Thu, 23 Aug 2007 14:56:18 +0000 (14:56 +0000)]
Don't rename to self when fuzz err; enable ^C file cleanup trap

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22601 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoLarge update with improvements in objects dissected, fragment reassembly, info column...
grahamb [Thu, 23 Aug 2007 09:28:03 +0000 (09:28 +0000)]
Large update with improvements in objects dissected, fragment reassembly, info column details and filter field names

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22600 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoPermit decoding of individual service errors + removal of a few lines consisting...
grahamb [Thu, 23 Aug 2007 09:26:01 +0000 (09:26 +0000)]
Permit decoding of individual service errors + removal of a few lines consisting of just whitespace

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22599 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom David Helder:
jake [Thu, 23 Aug 2007 09:16:31 +0000 (09:16 +0000)]
From David Helder:
The MP_REACH_NLRI (and MP_UNREACH_NLRI) parser incorrectly increments a buffer
offset.  Any attributes following will be skipped and/or parsed incorrectly.
No security problem I see - the bounds are checked before parsing each attribute.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22598 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Steve Karg
jake [Thu, 23 Aug 2007 06:56:04 +0000 (06:56 +0000)]
From Steve Karg
1. Moved all the network layer message type decodings under the network layer control bit check to prevent malformed packets.
2. Added the decoding of the optional network number for the Who-Is-Router-To-Network message type.
3. Added the decoding for the Establish-Connection-To-Network and Disconnect-Connection-To-Network network layer messages.
4. Corrected Initialize-Routing-Table and Initialize-Routing-Table-Ack decoding.
5. Added Network layer info under Column Info.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22597 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoPrepare the oids dataset for managing conceptual table indexing
lego [Wed, 22 Aug 2007 22:56:36 +0000 (22:56 +0000)]
Prepare the oids dataset for managing conceptual table indexing

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22596 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdded DPNSS_NONE as par3_num and par4_num to "PCON-P"
stig [Wed, 22 Aug 2007 22:32:13 +0000 (22:32 +0000)]
Added DPNSS_NONE as par3_num and par4_num to "PCON-P"
Fixed a signed/unsigned compiler warning

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22595 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Todd J Martin:
stig [Wed, 22 Aug 2007 21:58:21 +0000 (21:58 +0000)]
From Todd J Martin:
When LACP packets have the actor state or partner state fields set to 0x00,
wireshark prints the state like this (note the closing parenthesis):

  Actor State: 0x00)

Since there are no flags set, this fields should be printed like this:
  Actor State: 0x00

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22594 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoPut suplementarry service strings and parameters into the tree.
etxrab [Wed, 22 Aug 2007 21:47:31 +0000 (21:47 +0000)]
Put suplementarry service strings and parameters into the tree.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22593 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoPostpone checking if dumpcap is enabled until after we have checked if we have libpca...
morriss [Wed, 22 Aug 2007 21:05:25 +0000 (21:05 +0000)]
Postpone checking if dumpcap is enabled until after we have checked if we have libpcap or not: if not, don't bother trying to build dumpcap.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22592 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMove wtap_pcap_encap_to_wtap_encap()'s definition to libpcap.h so packet-ppi.c can...
morriss [Wed, 22 Aug 2007 19:38:49 +0000 (19:38 +0000)]
Move wtap_pcap_encap_to_wtap_encap()'s definition to libpcap.h so packet-ppi.c can get access to it even when we don't HAVE_LIBPCAP (besides, it doesn't seem to be specific to capturing...)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22591 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoHandle case of source-dir != build-dir; 2 other minor bug fixes
wmeier [Wed, 22 Aug 2007 19:36:49 +0000 (19:36 +0000)]
Handle case of source-dir != build-dir; 2 other minor bug fixes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22590 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoautoscroll_button is not used if we don't HAVE_LIBPCAP so put it inside the #ifdef
morriss [Wed, 22 Aug 2007 18:58:26 +0000 (18:58 +0000)]
autoscroll_button is not used if we don't HAVE_LIBPCAP so put it inside the #ifdef

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22589 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agogcc 4 doesn't like my macro for getting the interface description: it says there...
morriss [Wed, 22 Aug 2007 18:56:20 +0000 (18:56 +0000)]
gcc 4 doesn't like my macro for getting the interface description: it says there's an invalid lvalue in it.  I don't see what's wrong with it, but replace the macro with a function.  Also: don't include the .xpm files in gtk/main.c if we're building without PCAP (as they're not used in that configuration).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22588 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1757 :
morriss [Wed, 22 Aug 2007 16:30:16 +0000 (16:30 +0000)]
Fix bug bugs.wireshark.org/bugzilla/show_bug.cgi?id=1757 :

Try to call get_interface_descriptive_name() as little as possible (storing
the result in capture_opts) to avoid a performance hit during live capture
(especially if you have lots of interfaces) and to avoid leaking memory.

One issue with this is that capture_opts.c cannot (without adding significant
dependencies) set the iface_descr so readers of that field (only gtk/main.c
and tshark.c) use a macro to (set if not already set and) get the value of
that field.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22587 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoShow which bits 'fragment offset' comes from (I had to look it up :( )
martinm [Wed, 22 Aug 2007 14:43:26 +0000 (14:43 +0000)]
Show which bits 'fragment offset' comes from (I had to look it up :( )

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22586 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoThe reserved field is now 16 bits. Treat it as such.
jake [Wed, 22 Aug 2007 13:58:39 +0000 (13:58 +0000)]
The reserved field is now 16 bits. Treat it as such.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22585 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMore timestamp calculation fixes similar to the previous ones.
guy [Wed, 22 Aug 2007 07:14:08 +0000 (07:14 +0000)]
More timestamp calculation fixes similar to the previous ones.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22584 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Victor Fajardo:
jake [Wed, 22 Aug 2007 06:59:28 +0000 (06:59 +0000)]
From Victor Fajardo:
Updated patches to support draft-ietf-pana-pana-18.txt.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22583 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoOops, have to regenerate this after changing its template.
guy [Wed, 22 Aug 2007 04:31:32 +0000 (04:31 +0000)]
Oops, have to regenerate this after changing its template.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22582 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoCast away shortening conversions that are presumed not to lose any data.
guy [Wed, 22 Aug 2007 04:25:00 +0000 (04:25 +0000)]
Cast away shortening conversions that are presumed not to lose any data.

Use G_GINT64_CONSTANT() to make a 64-bit integral constant; not all
compilers we use support LL as a suffix for that (MSVC++ 6, for one).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22581 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoCast away shortening conversions that are presumed not to lose any data.
guy [Wed, 22 Aug 2007 02:45:42 +0000 (02:45 +0000)]
Cast away shortening conversions that are presumed not to lose any data.

Use G_GINT64_CONSTANT() to make a 64-bit integral constant; not all
compilers we use support LL as a suffix for that (MSVC++ 6, for one).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22580 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix a known- and marked-by-a-comment memory leak: replace g_strdup() with se_strdup...
morriss [Tue, 21 Aug 2007 22:18:27 +0000 (22:18 +0000)]
Fix a known- and marked-by-a-comment memory leak: replace g_strdup() with se_strdup().  (The address in question is stored in a conversation structure so it's "seasonal".)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22579 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom yin sun <sunyin51@gmail.com> / bug 1722:
richardv [Tue, 21 Aug 2007 22:15:17 +0000 (22:15 +0000)]
From     yin sun <sunyin51@gmail.com> / bug 1722:

When a subdissector on top of TCP set ... DESEGMENT_UNTIL_FIN ... then
the subdissector should receive the whole reassembled TCP stream in tvb.
But the bug is it is missing the last payload from the FIN packet.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22578 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Shaun Jackman <sjackman@gmail.com> / bug 1753:
richardv [Tue, 21 Aug 2007 22:00:06 +0000 (22:00 +0000)]
From Shaun Jackman  <sjackman@gmail.com> / bug 1753:

        * asn1/mpeg/packet-mpeg-pes-template.c: Improved decoding of PES
        extension header and Pack header. Decode SCR, PTS, and DTS.
        * asn1/mpeg/mpeg-pes.asn (Pack): Remove.
        * epan/dissectors/packet-mpeg-pes.c: Regenerate.
        * wiretap/mpeg.c (mpeg_read): Decode the SCR using integer
        arithmetic instead of double float arithmetic to prevent rounding
        error.
        * wiretap/wtap-int.h (mpeg_t) <t0>: Use time_t instead of double.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22577 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Francois-Xavier Le Bail <fx.lebail@yahoo.com> / bug 1724:
richardv [Tue, 21 Aug 2007 21:40:18 +0000 (21:40 +0000)]
From Francois-Xavier Le Bail <fx.lebail@yahoo.com> / bug 1724:

The following patch decode DHCP option 249 (Classless Static Route) used by
some Microsoft systems. Same decoding as option 121 (RFC 3442).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22576 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoA further iteration in the code, things start to look good!
lego [Tue, 21 Aug 2007 21:32:00 +0000 (21:32 +0000)]
A further iteration in the code, things start to look good!

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22575 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agofix usage message for -o option
richardv [Tue, 21 Aug 2007 21:25:53 +0000 (21:25 +0000)]
fix usage message for -o option

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22574 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoChange COPY_ADDRESS to SE_COPY_ADDRESS: all of these appear to have "seasonal" scope...
morriss [Tue, 21 Aug 2007 21:23:37 +0000 (21:23 +0000)]
Change COPY_ADDRESS to SE_COPY_ADDRESS: all of these appear to have "seasonal" scope (e.g., they are used in conversations or similar).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22573 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Florent DROUIN <florent.drouin@alcatel.fr>, bug 1518:
richardv [Tue, 21 Aug 2007 21:15:57 +0000 (21:15 +0000)]
From Florent DROUIN <florent.drouin@alcatel.fr>, bug 1518:

Fix for g_assert when clicking 'OK' on colour filters dialogue whilst
individual filter edit window is open.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22572 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUse SET_ADDRESS (instead of COPY_ADDRESS) for an address that has "ephemeral" scope...
morriss [Tue, 21 Aug 2007 21:03:59 +0000 (21:03 +0000)]
Use SET_ADDRESS (instead of COPY_ADDRESS) for an address that has "ephemeral" scope.  Use SE_COPY_ADDRESS when the address is copied to the template cache (with "seasonal" scope.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22571 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Mike Duigou <wireshark@duigou.org> (bug 1698):
richardv [Tue, 21 Aug 2007 20:57:52 +0000 (20:57 +0000)]
From Mike Duigou <wireshark@duigou.org> (bug 1698):

Enclosed is a patch with fixes problems with the desegmentation of chunked HTTP
message bodies.

...

Changing the value of pinfo->desegment_len to DESEGMENT_ONE_MORE_SEGMENT rather
than the current 1 or 2 seems to make everything work. (I'm kind of confused as
to why the headers resassembly code already used DESEGMENT_ONE_MORE_SEGMENT and
the body reassembly code did not).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22570 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agofix a signedness-in-comparison warning
richardv [Tue, 21 Aug 2007 20:32:22 +0000 (20:32 +0000)]
fix a signedness-in-comparison warning

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22569 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoWhen saving off a temporary copy of an address, use SET_ADDRESS instead of COPY_ADDRE...
morriss [Tue, 21 Aug 2007 20:24:17 +0000 (20:24 +0000)]
When saving off a temporary copy of an address, use SET_ADDRESS instead of COPY_ADDRESS so as to avoid a memory leak (or adding g_free() calls to fix said memory leak).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22568 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd default svn:ignore files to unistim plugin.
stig [Tue, 21 Aug 2007 18:50:37 +0000 (18:50 +0000)]
Add default svn:ignore files to unistim plugin.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22567 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoGive the full pathname of the wireshark.nsi file, and add information on
guy [Tue, 21 Aug 2007 18:09:33 +0000 (18:09 +0000)]
Give the full pathname of the wireshark.nsi file, and add information on
what to do for the U3 win32/makefile.nmake file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22566 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd the UNISTIM plugin, and put the plugins in alphabetical order (to
guy [Tue, 21 Aug 2007 18:04:09 +0000 (18:04 +0000)]
Add the UNISTIM plugin, and put the plugins in alphabetical order (to
simplify checking whether we have the full list).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22565 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd more information on adding a plugin to the NSIS installer.
guy [Tue, 21 Aug 2007 17:59:08 +0000 (17:59 +0000)]
Add more information on adding a plugin to the NSIS installer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22564 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate the NSIS files to add the UNISTIM plugin.
guy [Tue, 21 Aug 2007 17:49:54 +0000 (17:49 +0000)]
Update the NSIS files to add the UNISTIM plugin.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22563 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Neil Piercy:
jake [Tue, 21 Aug 2007 07:23:34 +0000 (07:23 +0000)]
From Neil Piercy:
This patch set provides a an API for out of band signalling protocols to
register flows as SRTP/SRTCP using extended versions of the existing
rt(c)p_add_address functions. At present the encrypted portions of the payloads
are simply skipped, and the auth tags etc added as fields.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22562 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix the build.
jake [Mon, 20 Aug 2007 21:48:25 +0000 (21:48 +0000)]
Fix the build.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22561 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDissect End-to-End and Link-by-Link messages.
etxrab [Mon, 20 Aug 2007 20:58:02 +0000 (20:58 +0000)]
Dissect End-to-End and Link-by-Link messages.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22560 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Cyrille Colin:
etxrab [Mon, 20 Aug 2007 20:55:06 +0000 (20:55 +0000)]
From Cyrille Colin:
gsm_a :
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1754
SMS CP (gsm_a_dtap), RP (gsm_a_rp) and T-PDU (gsm_sms) protocol stacks are
decoded in Wireshark when called by BSSAP or RANAP.
Same protocol stack can be called by GPRS-LLC (sapi 7). Simple modification
needed in packet-gsm_a.c to add dtap dissector to llcgprs.sapi 7.

Me a comment in gprs-llc.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22559 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd the UNISTIM plugin to Wireshark.
jake [Mon, 20 Aug 2007 20:50:29 +0000 (20:50 +0000)]
Add the UNISTIM plugin to Wireshark.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22558 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agowe need to track the fid in the rwdata structure so that reassembly of
sahlberg [Mon, 20 Aug 2007 08:09:52 +0000 (08:09 +0000)]
we need to track the fid in the rwdata structure so that reassembly of
connectionoriented dcerpc over smb pipes will be able to find the fid
used for reassembly

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22557 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFiltering on snmp variables starts to work so I put it there in case anyone wants...
lego [Sun, 19 Aug 2007 23:00:47 +0000 (23:00 +0000)]
Filtering on snmp variables starts to work so I put it there in case anyone wants to start playing with it. I'll leave the generated dissector in place and the rest off the Makefiles so that others are not bothered by this.

TODO:
- Global
   - add libsmi to autoconf (I modified CFLAGS and LDADDs in the makefile.ams appending my own values, that's good only for me)
   - have other users of oid_resolv.h get to use the new functions in oids.h
   - add a menu item or preference setting for the smi_modules UAT ( the smi_modules file has one dquoted string per line with the name of each module to be loaded)
- SNMP
  - put complete information in the labels of the VarBind Items
  - add oids to COL_INFO
  - negative testing (Well, testing in general)
- OIDS
  - implement "ALL" modules
  - some functions are not yet tested or implemented

I'll put a TO-DO list on the wiki for people (incl. me) to add more items

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22556 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMark pinfo as unused to make buildbot happy again.
stig [Sun, 19 Aug 2007 21:56:11 +0000 (21:56 +0000)]
Mark pinfo as unused to make buildbot happy again.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22555 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix copy-paste errors.
etxrab [Sun, 19 Aug 2007 20:41:16 +0000 (20:41 +0000)]
Fix copy-paste errors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22554 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDisscet CC messages.
etxrab [Sun, 19 Aug 2007 20:26:08 +0000 (20:26 +0000)]
Disscet CC messages.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22553 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoCheck for COTP if Call Request has not been captured.
stig [Sat, 18 Aug 2007 22:56:44 +0000 (22:56 +0000)]
Check for COTP if Call Request has not been captured.
Fixed an offset for diagnostic in COL_INFO.

This file should really be rewritten to use more proto_tree_add_item's
instead of proto_tree_add_text's.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22552 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoHandle unknown Universal and BMP strings.
gal [Sat, 18 Aug 2007 17:39:44 +0000 (17:39 +0000)]
Handle unknown Universal and BMP strings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22551 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoBug #1446 work-around from Toralf Förster
wmeier [Sat, 18 Aug 2007 15:48:10 +0000 (15:48 +0000)]
Bug #1446 work-around from  Toralf Förster

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22550 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd #include needed to get defs for PT_PCMU & etc
wmeier [Sat, 18 Aug 2007 04:28:40 +0000 (04:28 +0000)]
Add #include needed to get defs for PT_PCMU & etc

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22549 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix some gcc warnings so buildbots can proceed.
wmeier [Sat, 18 Aug 2007 03:19:44 +0000 (03:19 +0000)]
Fix some gcc warnings so buildbots can proceed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22548 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUse #defines, rather than raw numbers, for RTP payload types.
guy [Sat, 18 Aug 2007 01:46:14 +0000 (01:46 +0000)]
Use #defines, rather than raw numbers, for RTP payload types.

Note that we should return an error for payload types we don't support,
so the user knows we can't handle the audio.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22547 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoaccept 64bit integers where 8 <= len <= 1
lego [Sat, 18 Aug 2007 00:14:52 +0000 (00:14 +0000)]
accept 64bit integers where 8 <= len <= 1

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22546 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix a couple of signedness mismatches.
gerald [Fri, 17 Aug 2007 23:53:41 +0000 (23:53 +0000)]
Fix a couple of signedness mismatches.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22545 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd code for finding sub dissectors.
etxrab [Fri, 17 Aug 2007 23:23:36 +0000 (23:23 +0000)]
Add code for finding sub dissectors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22544 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd a rudimentarry DPNSS dissector - work in progress.
etxrab [Fri, 17 Aug 2007 21:31:22 +0000 (21:31 +0000)]
Add a rudimentarry DPNSS dissector - work in progress.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22543 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoReplace a couple more calls to tvb_get_string() with tvb_get_ephemeral_string()....
morriss [Fri, 17 Aug 2007 21:21:50 +0000 (21:21 +0000)]
Replace a couple more calls to tvb_get_string() with tvb_get_ephemeral_string().  2 of the 3 replacements fix memory leaks.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22542 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdded support for 802.1ad and 802.1ah ethernet frames
ashokn [Fri, 17 Aug 2007 21:21:18 +0000 (21:21 +0000)]
Added support for 802.1ad and 802.1ah ethernet frames

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22541 f5534014-38df-0310-8fa8-9805f1628bb7