Jelmer Vernooij [Wed, 26 Nov 2008 18:06:10 +0000 (19:06 +0100)]
Fix indentation for some configure options.
Jelmer Vernooij [Thu, 15 Jan 2009 20:16:31 +0000 (21:16 +0100)]
python/param: Cope with lp configfile being NULL.
Jeremy Allison [Thu, 15 Jan 2009 18:29:34 +0000 (10:29 -0800)]
Fix bug #6040 - Calling Samba print server with an aliased DNS-name fails.
Jeremy.
Kai Blin [Thu, 15 Jan 2009 09:14:55 +0000 (10:14 +0100)]
s4-winbind: Add support for the WINBINDD_LIST_GROUPS command.
Kai Blin [Wed, 14 Jan 2009 12:49:14 +0000 (13:49 +0100)]
s4 torture: Add another wbinfo test and fix a typo in another one
Jeremy Allison [Thu, 15 Jan 2009 00:08:19 +0000 (16:08 -0800)]
Remove smbclient globals that bled into clidfs.c. Now we only have
the connections list and authentication structures to worry about.
Jeremy
Jeremy Allison [Wed, 14 Jan 2009 22:33:46 +0000 (14:33 -0800)]
Fix build of netapi.
Jeremy.
Jeremy Allison [Wed, 14 Jan 2009 22:26:56 +0000 (14:26 -0800)]
Remove another global from clidfs that is only used in client.c.
Jeremy.
Jeremy Allison [Wed, 14 Jan 2009 21:17:38 +0000 (13:17 -0800)]
Fix bug #6035 - Possible race between fcntl F_SETLKW and alarm delivery.
Jeremy.
Bo Yang [Wed, 14 Jan 2009 19:47:45 +0000 (11:47 -0800)]
Fix bug in get_dc_name_via_netlogon(), null pointer refrence.
Jeremy Allison [Wed, 14 Jan 2009 19:12:52 +0000 (11:12 -0800)]
Clean up comments a little.
Jeremy.
Bo Yang [Wed, 14 Jan 2009 06:26:40 +0000 (14:26 +0800)]
Don't send message to any other child in child process.
Signed-off-by: Bo Yang <boyang@novell.com>
Volker Lendecke [Wed, 14 Jan 2009 15:51:43 +0000 (16:51 +0100)]
Make rpc_read look like a real read call
It doesn't really need to know about prs_structs
Volker Lendecke [Wed, 14 Jan 2009 15:43:37 +0000 (16:43 +0100)]
Make rpc_read() match the control flow normally used in Samba
Replace do { .. } while () with a while () { .. }
Volker Lendecke [Wed, 14 Jan 2009 15:06:10 +0000 (16:06 +0100)]
Simplify rpc_read a bit
rpc_read always reads the whole bytes it was asked to read. So it is not really
necessary for it to update the current_pdu_offset, for clarity this can better
be done in the caller.
Volker Lendecke [Wed, 14 Jan 2009 11:58:38 +0000 (12:58 +0100)]
Remove an unnecessary size check
rpc_read is only ever called with at most fraglen-RPC_HEADER_SIZE length
Volker Lendecke [Wed, 14 Jan 2009 11:58:13 +0000 (12:58 +0100)]
Check the fragment size the server has sent us
Volker Lendecke [Tue, 13 Jan 2009 21:50:43 +0000 (22:50 +0100)]
Slightly simplify rpc_read: It should not do the resize
Volker Lendecke [Tue, 13 Jan 2009 21:24:57 +0000 (22:24 +0100)]
Always read with offset 0 from a named pipe
Günther Deschner [Wed, 14 Jan 2009 09:53:04 +0000 (10:53 +0100)]
s3-eventlog: fix ps struct removal leftover.
Guenther
Günther Deschner [Tue, 13 Jan 2009 13:45:18 +0000 (14:45 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Tue, 13 Jan 2009 12:14:36 +0000 (13:14 +0100)]
eventlog: more eventlog record idl fixes.
- treat eventlogEventTypes as an enum.
- do not align the full eventlog entry.
- set range on number of strings according to docs.
- make a little more obvious what the reserved field stands for.
Guenther
Günther Deschner [Tue, 13 Jan 2009 13:43:46 +0000 (14:43 +0100)]
s3-rpcclient: always parse the full eventlog entry.
Guenther
Günther Deschner [Tue, 13 Jan 2009 10:04:45 +0000 (11:04 +0100)]
s3-eventlog: use main talloc context in eventlog read call.
Guenther
Günther Deschner [Tue, 13 Jan 2009 13:44:29 +0000 (14:44 +0100)]
s4-smbtorture: also test for invalid flags in eventlog test_ReadEventLog.
Guenther
Günther Deschner [Mon, 12 Jan 2009 17:21:20 +0000 (18:21 +0100)]
s4-smbtorture: pure cosmetic cleanup of eventlog test.
Guenther
Kai Blin [Wed, 14 Jan 2009 07:25:52 +0000 (08:25 +0100)]
s4 torture: Fix the wbinfo blackbox tests
Andrew Bartlett [Wed, 14 Jan 2009 04:05:08 +0000 (15:05 +1100)]
Fix error message in mkrelease to refer to source4, not source
Torgeir Lerkerod [Tue, 13 Jan 2009 21:15:37 +0000 (22:15 +0100)]
Fixed problemed showed on a number of systems on the buildfarm.
Problem shows up as perl error related to config.pm in reality
this was related to the ECHO_C variable. Added test to skip that
variable as no perl module is using it.
Torgeir
Signed-off-by: Torgeir Lerkerod <Torgeir.Lerkerod@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Jeremy Allison [Tue, 13 Jan 2009 23:42:56 +0000 (15:42 -0800)]
From boyang - ensure we never "return" from a forked child, always _exit().
Jeremy.
Jeremy Allison [Tue, 13 Jan 2009 23:36:09 +0000 (15:36 -0800)]
Only call sendfile_short_read() if we need it.
Jeremy.
Jeremy Allison [Tue, 13 Jan 2009 21:02:44 +0000 (13:02 -0800)]
Fix bug noticed by Volker - if sendfile returns zero then
we might have to handle a short send by filling with zeros.
Jeremy.
Jeremy Allison [Tue, 13 Jan 2009 19:19:11 +0000 (11:19 -0800)]
Fix bug #6019 File corruption in Clustered SMB/NFS environment managed via CTDB
Jeremy.
Stefan Metzmacher [Tue, 13 Jan 2009 12:01:36 +0000 (13:01 +0100)]
pidl: remove references to EJS and SWIG code
This fixes 'make install'.
metze
Steven Danneman [Mon, 12 Jan 2009 06:56:48 +0000 (22:56 -0800)]
Covert several persistant tdb files to use state_path() instead of lock_path()
Steven Danneman [Mon, 12 Jan 2009 06:44:10 +0000 (22:44 -0800)]
Audit usage of get_dyn_STATEDIR() and replace with state_path()
The state directory is now run-time configurable through loadparm, so all
references to it should be done through state_path() or lp_statedir().
Jeremy Allison [Tue, 13 Jan 2009 00:25:03 +0000 (16:25 -0800)]
Deprecate the "share modes" parameter to address bug #6024, swat disagrees with smbstatus as to share mode with share modes = No set in samba.
Jeremy.
Günther Deschner [Mon, 12 Jan 2009 17:00:33 +0000 (18:00 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Mon, 12 Jan 2009 15:16:24 +0000 (16:16 +0100)]
s3-rpcclient: some cleanup for eventlog client.
Guenther
Günther Deschner [Mon, 12 Jan 2009 12:45:38 +0000 (13:45 +0100)]
eventlog: some fixes for eventlog_Record struct.
* make reserved field always have value 0x654c664C ("eLfL").
* add missing sid entry
* add padding and 2nd size counter.
* use time_t in eventlog_Record.
Guenther
Günther Deschner [Mon, 12 Jan 2009 12:45:04 +0000 (13:45 +0100)]
eventlog: make out pointer a ref pointer in eventlog_GetNumRecords.
Guenther
Stefan Metzmacher [Mon, 12 Jan 2009 11:32:46 +0000 (12:32 +0100)]
s3:libsmb: handle the smb signing states the same in the krb5 and ntlmssp cases
SMB signing works the same regardless of the used auth mech.
We need to start with the temp signing ("BSRSPYL ")
and the session setup response with NT_STATUS_OK
is the first signed packet.
Now we set the krb5 session key if we got the NT_STATUS_OK
from the server and then recheck the packet.
All this is needed to make the fallback from krb5 to
ntlmssp possible. This commit also resets the cli->vuid
value to 0, if the krb5 auth didn't succeed. Otherwise
the server handles NTLMSSP packets as krb5 packets.
The restructuring of the SMB signing code is needed to
make sure the krb5 code only starts the signing engine
on success. Otherwise the NTLMSSP fallback could not initialize
the signing engine (again).
metze
Michael Adam [Mon, 12 Jan 2009 12:04:40 +0000 (13:04 +0100)]
nss_wrapper.pl: fix "Use of uninitialized value $i in array element" messages
I just saw this in "make test" after "SMBD OUTPUT:"...
Michael
Steven Danneman [Thu, 8 Jan 2009 19:18:13 +0000 (11:18 -0800)]
Make STATEDIR and CACHEDIR configurable through ./configure and loadparm.c
If they are not explicitely set in either place both will default to LOCKDIR.
Signed-off-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Sat, 10 Jan 2009 16:59:43 +0000 (17:59 +0100)]
Even for srclen == 0 we have to return something
This fixes a regression reported by Corinna Vinschen <corinna@vinschen.de>
Thanks,
Volker
Stefan Metzmacher [Mon, 12 Jan 2009 08:20:57 +0000 (09:20 +0100)]
tevent: use for() loops instead of while() loops
metze
Tim Prouty [Mon, 12 Jan 2009 07:16:37 +0000 (23:16 -0800)]
s3: Fix uninitialized variable in OneFS streams
Tim Prouty [Sat, 3 Jan 2009 01:35:04 +0000 (17:35 -0800)]
s3: Differentiate between posix files with colons and actual streams
It is possible for a posix file created locally or over nfs to have a
":" in the name. Since ":" is a reserved character in windows,
filenames containing a colon must be mangled in a directory listing.
Right now files containing colons will not even be displayed in
directory listings if streams modules are in use. During the
directory listing the file will be detected as a stream because of the
colon, but the streams module will fail to find the stream since it
doesn't exist. This fix adds a step to is_ntfs_stream_name that stats
the filename to differentiate between actual streams and files
containing colons.
While this is an improvement, it isn't perfect. Consider the case
where there is a file on disk called "a.txt:s1" and also a file called
"a.txt" that has a stream called "s1". This patch will always
preference "a.txt:s1" over a.txt's s1 stream.
The real issue is that at the vfs level, the vfs modules have no way
to tell between a demangled name with a colon and an actual stream. A
more invasive, but better, long-term fix would be to add all paths
that come over the wire into a struct containing metadata about the
path. This metadata could include a flag to indicate whether the path
came over the wire with a colon ":" (guaranteeing that the client is
requesting a stream). Passing this struct down to the lower levels,
including all path-based vfs calls, would allow the above case to be
handled correctly in all cases.
Tim Prouty [Fri, 12 Dec 2008 22:32:48 +0000 (14:32 -0800)]
s3: Add OneFS alternate data streams implementation
Tim Prouty [Wed, 31 Dec 2008 01:17:24 +0000 (17:17 -0800)]
s3: General cleanup of the open path in the OneFS vfs module
Volker Lendecke [Sun, 11 Jan 2009 10:17:26 +0000 (11:17 +0100)]
Move cli_api_pipe() to its only user cli_pipe.c
Tim Prouty [Sun, 11 Jan 2009 19:00:50 +0000 (11:00 -0800)]
tevent: Fix build break
Bo Yang [Sat, 10 Jan 2009 05:46:50 +0000 (13:46 +0800)]
Fix tevent_common_context_destructor to remove all events instead of just the first one
Signed-off-by: Bo Yang <boyang@novell.com>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Bo Yang [Sat, 10 Jan 2009 22:12:08 +0000 (14:12 -0800)]
Don't set child->requests to NULL in parent after fork
Volker Lendecke [Sat, 10 Jan 2009 12:04:33 +0000 (13:04 +0100)]
Fix a type-punned error
Volker Lendecke [Sat, 10 Jan 2009 12:02:43 +0000 (13:02 +0100)]
Fix a C++ warning
Jeremy Allison [Sat, 10 Jan 2009 03:40:09 +0000 (19:40 -0800)]
Minor tidyup of unix account missing code.
Jeremy.
Volker Lendecke [Tue, 6 Jan 2009 22:46:05 +0000 (23:46 +0100)]
Remove the rpc_srv_register wrapper around rpc_pipe_register_commands
Volker Lendecke [Tue, 6 Jan 2009 22:39:09 +0000 (23:39 +0100)]
Call rpc_srv_register instead of rpc_pipe_register_commands in eventlog and svcctl
Volker Lendecke [Tue, 6 Jan 2009 22:37:09 +0000 (23:37 +0100)]
Fake up ndr_table_spoolss
Volker Lendecke [Tue, 6 Jan 2009 22:29:25 +0000 (23:29 +0100)]
Pass the full ndr_interface_table into the s3 rpcserver when registering
Volker Lendecke [Fri, 9 Jan 2009 17:32:20 +0000 (18:32 +0100)]
Add derpc_transport_string_by_transport(), apply some const
Volker Lendecke [Tue, 6 Jan 2009 18:09:57 +0000 (19:09 +0100)]
start rpcclient epmapper
Volker Lendecke [Tue, 6 Jan 2009 20:28:44 +0000 (21:28 +0100)]
Fix some nonempty blank lines
Volker Lendecke [Tue, 6 Jan 2009 10:32:46 +0000 (11:32 +0100)]
Simplify find_pipe_fns_by_context slightly
Volker Lendecke [Tue, 6 Jan 2009 10:32:07 +0000 (11:32 +0100)]
Fix some nonempty blank lines
Tim Prouty [Fri, 9 Jan 2009 19:50:28 +0000 (11:50 -0800)]
s3: Remove rendundant op_tuple entry in xattr streams
Tim Prouty [Fri, 9 Jan 2009 19:07:45 +0000 (11:07 -0800)]
s3: Fix open path to delete streams depending on the create disposition
The new create disposition test in smbtorture RAW-STREAMS verifies
this fix.
Tim Prouty [Sun, 21 Dec 2008 23:49:46 +0000 (15:49 -0800)]
s3: Add delete_all_streams to proto.h
Tim Prouty [Fri, 9 Jan 2009 19:38:58 +0000 (11:38 -0800)]
s4 torture: Add new create disposition test to RAW-STREAMS
Günther Deschner [Fri, 9 Jan 2009 15:25:47 +0000 (16:25 +0100)]
s3-svcctl: remove last traces of hand-marshalled svcctl code.
Guenther
Günther Deschner [Fri, 9 Jan 2009 15:22:03 +0000 (16:22 +0100)]
s3-svcctl: remove old marshalling of svcctl_EnumServicesStatusW.
Guenther
Günther Deschner [Fri, 9 Jan 2009 15:20:09 +0000 (16:20 +0100)]
s3-svcctl: build svcctl marshalling helper.
Guenther
Günther Deschner [Fri, 9 Jan 2009 15:19:37 +0000 (16:19 +0100)]
s3-svcctl: use pidl for _svcctl_EnumServicesStatusW.
Guenther
Günther Deschner [Fri, 9 Jan 2009 15:18:51 +0000 (16:18 +0100)]
s3-net: use rpccli_svcctl_EnumServicesStatusW.
Guenther
Günther Deschner [Fri, 9 Jan 2009 15:16:11 +0000 (16:16 +0100)]
s4-smbtorture: print hand-decoded service status array in svcctl torture test.
Guenther
Karolin Seeger [Fri, 9 Jan 2009 15:52:12 +0000 (16:52 +0100)]
s3/net: Display error message if user does not exist.
net rpc rights grant: Verify if the username can be resolved to a SID and
display a proper error message if it does not. Otherwise users might think
setting privileges worked fine, but in fact it does not.
Karolin
Günther Deschner [Fri, 9 Jan 2009 15:17:35 +0000 (16:17 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Fri, 9 Jan 2009 15:17:03 +0000 (16:17 +0100)]
svcctl: include hand marshalling helper in idl.
Guenther
Günther Deschner [Fri, 9 Jan 2009 13:36:13 +0000 (14:36 +0100)]
svcctl: add ndr_push/pull_ENUM_SERVICE_STATUSW_array helper.
Thanks metze for helping here.
Guenther
Günther Deschner [Fri, 9 Jan 2009 13:32:39 +0000 (14:32 +0100)]
s3-svcctl: use pidl defined constants in services implementation.
Guenther
Günther Deschner [Fri, 9 Jan 2009 13:30:56 +0000 (14:30 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Fri, 9 Jan 2009 13:29:40 +0000 (14:29 +0100)]
svcctl: add SERVICE_TYPE_INTERACTIVE_PROCESS define.
Guenther
Karolin Seeger [Fri, 9 Jan 2009 14:54:16 +0000 (15:54 +0100)]
s3/smbpasswd: Check if Unix account exists before asking for the password.
Admins shouldn't have to type in the password twice when the passdb account
cannot be created because the Unix account is missing.
Karolin
Stefan Metzmacher [Fri, 9 Jan 2009 12:10:07 +0000 (13:10 +0100)]
s4:debug: make setup_logging() a bit more compatible with samba3
In samba3 the 2nd argument is bool interactive.
E.g ndrdump uses true there which used to map to DEBUG_FILE
in samba4, it maps to DEBUG_STDOUT now, which is better.
In the end end samba3 should also use the samba4 version of
setup_logging()
metze
Stefan Metzmacher [Fri, 9 Jan 2009 11:23:11 +0000 (12:23 +0100)]
Revert "quote ' inside '...' and make sure shell isn't eating \ by using perl here."
This reverts commit
2a52b059ce44403ff6ced066e0bb23fa6cc66a73.
It breaks the build on ubuntu.
metze
Björn Jacke [Fri, 9 Jan 2009 11:05:55 +0000 (12:05 +0100)]
quote ' inside '...' and make sure shell isn't eating \ by using perl here.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Karolin Seeger [Fri, 9 Jan 2009 10:22:00 +0000 (11:22 +0100)]
docs: Improve man mount.cifs.
Add hint about specifying the workgroup in the credentials file.
Whitespace cleanup.
This fixes bug #4541.
Patch based on proposed patch from Christian Perrier <bubulle@debian.org>.
Thanks for reporting and providing a patch!
Karolin
Björn Jacke [Thu, 8 Jan 2009 18:14:48 +0000 (19:14 +0100)]
fix syntax error in case statement
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Thu, 8 Jan 2009 14:38:47 +0000 (15:38 +0100)]
s3:smbd: handle incoming smb requests via event handlers
We use a fd event and receive incoming smb requests
when the fd becomes readable. It's not completely
nonblocking yet, but it should behave like the old code.
We use timed events to trigger retries for deferred open calls.
metze
Stefan Metzmacher [Thu, 8 Jan 2009 18:45:13 +0000 (19:45 +0100)]
s3:events: debug sys_select() errors
metze
Stefan Metzmacher [Thu, 8 Jan 2009 14:16:51 +0000 (15:16 +0100)]
s3:events: install a tevent debug handler that calls DEBUG()
metze
Andrew Bartlett [Fri, 9 Jan 2009 01:06:18 +0000 (12:06 +1100)]
Only do special DN tracking for normal DNs in OpenLDAP backend.
This means trying (again, harder), not to do this for DN+Binary and
DN+String attributes.
Andrew Bartlett
Jeremy Allison [Thu, 8 Jan 2009 23:41:49 +0000 (15:41 -0800)]
Fix bug #6021 - smbclient du command does not recuse properly
Jeremy.
Volker Lendecke [Wed, 7 Jan 2009 17:44:52 +0000 (18:44 +0100)]
Now that all policy_handle free_fn's are just TALLOC_FREE, dump free_fn
Volker Lendecke [Wed, 7 Jan 2009 17:11:24 +0000 (18:11 +0100)]
Use TALLOC for struct lsa_info
Volker Lendecke [Wed, 7 Jan 2009 17:06:21 +0000 (18:06 +0100)]
Make use of a talloc_destructor for free_printer_entry
Volker Lendecke [Wed, 7 Jan 2009 16:56:08 +0000 (17:56 +0100)]
Make use of a talloc_destructor for free_eventlog_info()
Volker Lendecke [Wed, 7 Jan 2009 16:48:10 +0000 (17:48 +0100)]
Make samr_info a talloc context of its own
Volker Lendecke [Wed, 7 Jan 2009 16:36:54 +0000 (17:36 +0100)]
Simplify init_pipe_handle_list a bit