Björn Baumbach [Fri, 22 Jul 2011 08:48:35 +0000 (10:48 +0200)]
s3-torture: introduce test_cli_read()
test_cli_read calls cli_read and returns success or failure
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Fri, 22 Jul 2011 11:43:02 +0000 (13:43 +0200)]
s3:libsmb: move cli_state->{src_ss,dest_ss} to cli_state->conn.{local_ss,remote_ss}
metze
Stefan Metzmacher [Fri, 22 Jul 2011 11:42:38 +0000 (13:42 +0200)]
s3:net_rpc_printer: make use of cli_state_remote_sockaddr()
metze
Stefan Metzmacher [Fri, 22 Jul 2011 11:42:20 +0000 (13:42 +0200)]
s3:net_rpc: make use of cli_state_remote_sockaddr()
metze
Stefan Metzmacher [Fri, 22 Jul 2011 11:44:36 +0000 (13:44 +0200)]
s3:net_rpc_join: make use of cli_state_remote_sockaddr()
metze
Stefan Metzmacher [Fri, 22 Jul 2011 11:41:09 +0000 (13:41 +0200)]
s3:net_rpc_join: pass const sockaddr_storage to net_rpc_join_ok()
metze
Stefan Metzmacher [Fri, 22 Jul 2011 11:40:19 +0000 (13:40 +0200)]
s3:net_util: pass const sockaddr_storage to net_make_ipc_connection_ex()
metze
Stefan Metzmacher [Fri, 22 Jul 2011 11:05:43 +0000 (13:05 +0200)]
s3:net_util: add some const to sockaddr_storage
metze
Stefan Metzmacher [Fri, 22 Jul 2011 11:04:32 +0000 (13:04 +0200)]
s3:auth_domain: add some const to sockaddr_storage
metze
Stefan Metzmacher [Fri, 22 Jul 2011 11:03:19 +0000 (13:03 +0200)]
s3:libsmb: only pass const sockaddr_storage to cli_full_connection()
No direct or indirect caller needs this to be set.
metze
Stefan Metzmacher [Fri, 22 Jul 2011 10:31:05 +0000 (12:31 +0200)]
s3:smbcquotas: pass down NULL instead of a zero sockaddr_storage
metze
Stefan Metzmacher [Fri, 22 Jul 2011 10:29:57 +0000 (12:29 +0200)]
s3:smbcacls: pass down NULL instead of a zero sockaddr_storage
metze
Stefan Metzmacher [Fri, 22 Jul 2011 10:25:44 +0000 (12:25 +0200)]
s3:libsmb_server: pass NULL instead of a zero sockaddr_storage
metze
Stefan Metzmacher [Fri, 22 Jul 2011 10:01:27 +0000 (12:01 +0200)]
s3:libsmb: only pass a const sockaddr_storage to cli_start_connection()
Let the caller use cli_state_remote_sockaddr() if needed.
metze
Stefan Metzmacher [Fri, 22 Jul 2011 09:56:14 +0000 (11:56 +0200)]
s3:net_time: expect const sockaddr_storage in cli_servertime()
We don't want to modify the value.
metze
Stefan Metzmacher [Fri, 22 Jul 2011 09:54:03 +0000 (11:54 +0200)]
s3:libsmb: let cli_connect_nb() only expect a const sockaddr_storage *dest_ss
Only one caller expects this value to be set,
which now calls cli_state_remote_sockaddr() to get the value.
metze
Stefan Metzmacher [Fri, 22 Jul 2011 09:24:45 +0000 (11:24 +0200)]
s3:libsmb: use cli_state_remote_sockaddr() in smb2cli_tcon_send()
metze
Stefan Metzmacher [Fri, 22 Jul 2011 09:23:48 +0000 (11:23 +0200)]
s3:libnet: use cli_state_remote_sockaddr() in libnet_DomainJoin()
metze
Stefan Metzmacher [Fri, 22 Jul 2011 09:21:29 +0000 (11:21 +0200)]
s3:winbindd_cm: use cli_state_[local|remote]_sockaddr()
metze
Stefan Metzmacher [Fri, 22 Jul 2011 08:29:18 +0000 (10:29 +0200)]
s3:libsmb: add cli_state_[local|remote]_sockaddr()
metze
Stefan Metzmacher [Fri, 22 Jul 2011 07:39:52 +0000 (09:39 +0200)]
s3:libsmb: move cli_state->fd to cli_state->conn.fd
metze
Stefan Metzmacher [Fri, 22 Jul 2011 07:39:23 +0000 (09:39 +0200)]
s3:libsmb: make use of cli_state_disconnect()
metze
Stefan Metzmacher [Fri, 22 Jul 2011 07:38:42 +0000 (09:38 +0200)]
s3:libsmb: make use of cli_state_is_connected()
metze
Stefan Metzmacher [Fri, 22 Jul 2011 07:34:29 +0000 (09:34 +0200)]
s3:torture: use cli_state_disconnect() to close the socket on SIGALRM
metze
Stefan Metzmacher [Fri, 22 Jul 2011 10:48:09 +0000 (12:48 +0200)]
s3:smbtree: try to fix completely broken logic in get_workgroups()
metze
Michael Adam [Fri, 22 Jul 2011 08:11:52 +0000 (10:11 +0200)]
s3:loadparm: fix the reload of the configuration: also reload activated registry shares
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri Jul 22 16:53:49 CEST 2011 on sn-devel-104
Michael Adam [Fri, 22 Jul 2011 08:10:43 +0000 (10:10 +0200)]
s3:loadparm: add reload_registry_shares() - reload only those shares already loaded
Michael Adam [Fri, 22 Jul 2011 13:38:38 +0000 (15:38 +0200)]
s3:smbclient: print nt status code when smb echo fails
Michael Adam [Fri, 22 Jul 2011 12:12:13 +0000 (14:12 +0200)]
s3:smbclient: add a "tdis" command to view and change the tree id (tid).
This low level command can be used to switch between tree connects in one
session.
Michael Adam [Fri, 22 Jul 2011 12:11:34 +0000 (14:11 +0200)]
s3:smbclient: add a "tdis" command to do a tree disconnect (close a connection to a share)
Michael Adam [Fri, 22 Jul 2011 12:10:38 +0000 (14:10 +0200)]
s3:smbclient: add a "tcon" command to do a tree connect (connect to a share)
Michael Adam [Fri, 22 Jul 2011 12:08:03 +0000 (14:08 +0200)]
s3:smbclient: add "logoff" command to close the session
Stefan Metzmacher [Fri, 22 Jul 2011 06:41:20 +0000 (08:41 +0200)]
s3:libsmb: move cli_state->outgoing to cli_state->conn.outgoing
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Jul 22 09:53:59 CEST 2011 on sn-devel-104
Stefan Metzmacher [Fri, 22 Jul 2011 06:38:59 +0000 (08:38 +0200)]
s3:libsmb: move cli_state->pending to cli_state->conn.pending
metze
Stefan Metzmacher [Fri, 22 Jul 2011 06:38:02 +0000 (08:38 +0200)]
s3:libsmb: fix compiler warnings in cli_state_create()
metze
Andrew Tridgell [Fri, 22 Jul 2011 04:55:32 +0000 (14:55 +1000)]
s4-messaging: fixed the removal of messaging sockets in child tasks
when a child task exits we were firing a destructor on any inherited
messaging contexts, which could trigger a removal of the parents
message socket and messaging database entry.
This adds a new auto_remove flag to imessaging_init(), and exposes the
cleanup code for use by the stream service.
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Fri Jul 22 08:09:06 CEST 2011 on sn-devel-104
Jeremy Allison [Thu, 21 Jul 2011 21:02:10 +0000 (14:02 -0700)]
Fix const warning.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Jul 22 01:58:39 CEST 2011 on sn-devel-104
Simo Sorce [Thu, 21 Jul 2011 21:10:06 +0000 (17:10 -0400)]
s3-rpc_server: Do not set msg_ctx twice
msg_ctx was already passed to make_base_pipes_struct,
no need to set it again.
Autobuild-User: Simo Sorce <idra@samba.org>
Autobuild-Date: Fri Jul 22 00:47:28 CEST 2011 on sn-devel-104
Stefan Metzmacher [Thu, 21 Jul 2011 19:51:11 +0000 (21:51 +0200)]
s3:winbindd_cm: remove unused checks for address family
If we got a connection, we don't need to check what
address family it uses.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Jul 21 23:33:48 CEST 2011 on sn-devel-104
Stefan Metzmacher [Thu, 21 Jul 2011 19:47:36 +0000 (21:47 +0200)]
s3:libsmb: replace cli_initialise[_ex]() by cli_state_create()
This makes sure cli_state->src_ss and cli_state->dest_ss are always
initialized.
metze
Stefan Metzmacher [Thu, 21 Jul 2011 19:18:27 +0000 (21:18 +0200)]
s3:include: remove unused cli_state->called and cli_state->calling
metze
Stefan Metzmacher [Thu, 21 Jul 2011 19:15:38 +0000 (21:15 +0200)]
s3:libsmb: don't pass cli->called.name to NTLMv2_generate_names_blob()
cli->called.name is never initialized, so this change doesn't change
the behavior. And this behavior seems to be correct, see
commit
29c0c37691da10bf061ba90a5b31482bda2fa486
s4/libcli: do not use netbios name in NTLMv2 blobs w/o spnego.
metze
Stefan Metzmacher [Thu, 21 Jul 2011 07:20:43 +0000 (09:20 +0200)]
s3:libsmb: move cli->vuid to cli->smb1.uid and hide it behind cli_state_[g|s]et_uid()
metze
Stefan Metzmacher [Mon, 18 Jul 2011 17:46:59 +0000 (19:46 +0200)]
s3:libsmb: add cli_state_encryption_on()
metze
Andreas Schneider [Thu, 21 Jul 2011 17:54:01 +0000 (19:54 +0200)]
s3-rpc_server: Pass msg_ctx to make_base_pipes_struct().
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Thu Jul 21 21:08:32 CEST 2011 on sn-devel-104
Simo Sorce [Thu, 21 Jul 2011 15:02:59 +0000 (11:02 -0400)]
s3-rpc_server: Create common function to allocate pipes_struct
Avoid code duplication and fix bug where a new pipe was not added to
InternalPipes upon creation in make_server_pipes_struct()
Signed-off-by: Andreas Schneider <asn@samba.org>
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Thu Jul 21 19:50:02 CEST 2011 on sn-devel-104
Simo Sorce [Thu, 21 Jul 2011 13:53:10 +0000 (09:53 -0400)]
s3-rpc_server: Move pipe/handles functions
Put InternalPipes related functions in rpc_handles.c and out of rpc_ncacn_np.c
rpc_handles.c is the only file that really uses them after all and ncacn_np.c
is the wrong place for that stuff.
While ther remove unnecessary wrapper functions now that the InternalPipes
static variable is directly accessible.
Also move all pipes_struct related header stuff in its own rpc_pipes.h header.
Signed-off-by: Andreas Schneider <asn@samba.org>
Andreas Schneider [Fri, 27 May 2011 09:55:41 +0000 (11:55 +0200)]
s3-rpc_server: Fixed header define.
Andreas Schneider [Fri, 15 Jul 2011 16:03:47 +0000 (18:03 +0200)]
s3-rpc_server: Remove unused endpoint information.
Andreas Schneider [Thu, 21 Jul 2011 15:58:41 +0000 (17:58 +0200)]
s3-rpc_server: We need to copy the session_info for external pipes.
Andrew please check!
Andreas Schneider [Thu, 21 Jul 2011 09:21:30 +0000 (11:21 +0200)]
s3-rpc_server: Duplicate the pipe name.
Andreas Schneider [Thu, 21 Jul 2011 09:11:51 +0000 (11:11 +0200)]
s3-rpc_server: Free the np dir.
Andreas Schneider [Thu, 21 Jul 2011 08:43:56 +0000 (10:43 +0200)]
s3-rpc_server: Fix messaging context in the pipes struct.
Andreas Schneider [Thu, 21 Jul 2011 11:13:35 +0000 (13:13 +0200)]
s3-rpc_server: Add my copyright.
Michael Adam [Thu, 21 Jul 2011 15:22:22 +0000 (17:22 +0200)]
s3:loadparm: fix an implicit cast warning in string intialization in init_globals()
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Thu Jul 21 18:39:15 CEST 2011 on sn-devel-104
Michael Adam [Thu, 21 Jul 2011 15:20:16 +0000 (17:20 +0200)]
s3:loadparm: add support for P_BYTES to lp_do_parameter() - fix a build warning
(taken from s4 loadparm)
Michael Adam [Thu, 21 Jul 2011 15:18:40 +0000 (17:18 +0200)]
s3:loadparm: add support for P_CMDLIST to lp_do_parameter - fix a build warning
Michael Adam [Thu, 21 Jul 2011 15:15:31 +0000 (17:15 +0200)]
s3:loadparm: add support for P_CMDLIST to lp_save_defaults() - fix build warning
Michael Adam [Thu, 21 Jul 2011 15:14:56 +0000 (17:14 +0200)]
s3:loadparm: add support for P_BYTES to lp_save_defaults - fix build warning
Michael Adam [Thu, 21 Jul 2011 15:13:44 +0000 (17:13 +0200)]
s3:loadparm: add support for P_CMDLIST to is_default() - fix build warning
Michael Adam [Thu, 21 Jul 2011 15:13:24 +0000 (17:13 +0200)]
s3:loadparm: add support for P_BYTES to is_default() - fix build warning
Michael Adam [Thu, 21 Jul 2011 15:11:44 +0000 (17:11 +0200)]
s3:loadparm: add support for P_CMDLIST to print_parameter - fix build warning.
Michael Adam [Thu, 21 Jul 2011 15:05:46 +0000 (17:05 +0200)]
s3:loadparm: add support for P_BYTES to print_parameter() - fix build warning.
Michael Adam [Thu, 21 Jul 2011 15:04:16 +0000 (17:04 +0200)]
s3:loadparm: add support for P_CMDLIST to equal_parameter() - fix build warning
Michael Adam [Thu, 21 Jul 2011 15:03:58 +0000 (17:03 +0200)]
s3:loadparm: add suppor for P_BYTES to equal_parameter() - fix build warning
Michael Adam [Thu, 21 Jul 2011 15:02:14 +0000 (17:02 +0200)]
s3:loadparm: szNetbiosAliases is now a const char ** - cast properly
Michael Adam [Thu, 21 Jul 2011 15:01:38 +0000 (17:01 +0200)]
s3:loadparm: szWinbindNssInfo is now a const char ** instead of a char ** - cast properly
Michael Adam [Thu, 21 Jul 2011 12:10:50 +0000 (14:10 +0200)]
s3:loadparm: fix a check that was accidentially an assignment in lp_servicebynum()
Michael Adam [Wed, 20 Jul 2011 14:48:07 +0000 (16:48 +0200)]
s3:loadparm: untangle assignment from check in do_section()
Christian Ambach [Thu, 21 Jul 2011 12:13:20 +0000 (14:13 +0200)]
s3-waf: fix a libcrypto configure check
the parameters to conf.CHECK_FUNCS_IN were in the wrong order
Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Thu Jul 21 16:49:52 CEST 2011 on sn-devel-104
Christian Ambach [Thu, 21 Jul 2011 12:48:24 +0000 (14:48 +0200)]
s3:winbindd remove an unused variable
fixes a compiler warning
Christian Ambach [Thu, 21 Jul 2011 12:47:38 +0000 (14:47 +0200)]
s3:utils fix a compiler warning
fix a compiler warning about missing prototypes
Christian Ambach [Fri, 15 Jul 2011 14:16:11 +0000 (16:16 +0200)]
s3:modules/vfs_afsacl fix a compiler warning
Christian Ambach [Fri, 15 Jul 2011 14:14:33 +0000 (16:14 +0200)]
s3:afs make path argument to afs_syscall const
Christian Ambach [Fri, 15 Jul 2011 14:12:46 +0000 (16:12 +0200)]
s3:modules/vfs_afsacl fix a compiler warning
Christian Ambach [Fri, 15 Jul 2011 13:58:40 +0000 (15:58 +0200)]
s3:modules/vfs_afsacl use stdbool types
Christian Ambach [Fri, 15 Jul 2011 13:57:26 +0000 (15:57 +0200)]
s3:modules/vfs_afsacl remove some unnecessary whitespace
Christian Ambach [Fri, 15 Jul 2011 13:54:25 +0000 (15:54 +0200)]
s3:lib/afs fix the build with --with-vfs-afsacl
This fixes the second piece of Bug #8263
Christian Ambach [Fri, 15 Jul 2011 13:35:18 +0000 (15:35 +0200)]
s3:lib/afs use stdbool types
Christian Ambach [Fri, 15 Jul 2011 13:44:36 +0000 (15:44 +0200)]
s3:utils/net_afs fix compiler warnings
Christian Ambach [Fri, 15 Jul 2011 13:34:29 +0000 (15:34 +0200)]
s3:lib/afs_settoken fix some compiler warnings
Christian Ambach [Fri, 15 Jul 2011 13:30:14 +0000 (15:30 +0200)]
s3:lib/afs fix some compiler warnings
Christian Ambach [Fri, 15 Jul 2011 13:27:07 +0000 (15:27 +0200)]
s3:lib/afs fix the build with --with-fake-kaserver
This fixes one piece of Bug #8263
Björn Baumbach [Wed, 20 Jul 2011 11:02:22 +0000 (13:02 +0200)]
selftest: use "state directory" and "cache directory" options
instead of "state dir" and "cache dir"
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Jul 21 10:06:32 CEST 2011 on sn-devel-104
Björn Baumbach [Wed, 20 Jul 2011 10:56:22 +0000 (12:56 +0200)]
s4-param: use "state directory" and "cache directory" options
instead of "state dir" and "cache dir" in order be compatible
with the source3 code.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Tridgell [Thu, 21 Jul 2011 00:29:21 +0000 (10:29 +1000)]
samba-tool: make sure we exit with an error on a bad command
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Jul 21 04:58:01 CEST 2011 on sn-devel-104
Andrew Tridgell [Tue, 19 Jul 2011 02:57:59 +0000 (12:57 +1000)]
dbcheck: mark the dbcheck as known-fail
this will fail till we correctly update backlinks to deleted objects
Andrew Tridgell [Tue, 19 Jul 2011 02:54:37 +0000 (12:54 +1000)]
samba-tool: fixed some more calls to samba_tool join to be 'domain join'
Andrew Tridgell [Thu, 14 Jul 2011 04:03:53 +0000 (14:03 +1000)]
s4-selftest: added undump.sh script
used to unpack a dumped set of provision files for selftest
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 14 Jul 2011 04:03:15 +0000 (14:03 +1000)]
tdb: remove 'EOF' print from tdbrestore
the EOF message is pointless, and makes for noisy scripts
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 14 Jul 2011 04:02:38 +0000 (14:02 +1000)]
dbcheck: use string DN in delete when fixing broken strings DNs
this prevents the extended_dn_in module from 'fixing' the DN for us
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 14 Jul 2011 03:35:14 +0000 (13:35 +1000)]
s4-provision: run dbcheck on a minimal set of objects in provision
this speeds up the dbcheck in provision to fix only the objects that
we know will need fixing
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 14 Jul 2011 03:18:48 +0000 (13:18 +1000)]
s4-kcc: use dsdb_delete() instead of ldb_delete()
this adds the DSDB_SEARCH_SHOW_DELETED flag, which fixes deletion of
deleted objects
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 14 Jul 2011 03:18:17 +0000 (13:18 +1000)]
s4-dsdb: added dsdb_delete() function
this gives us a delete function that takes the standard set of dsdb
flags
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 14 Jul 2011 03:17:49 +0000 (13:17 +1000)]
pyldb: use dn.is_child_of() instead of dn.compare_base()
the compare_base() C API doesn't really fit well in python, as it
returns 0 for true. Better to have a boolean function for the python
interface.
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Matthieu Patou [Sat, 11 Jun 2011 20:40:31 +0000 (00:40 +0400)]
samba_backup: check that directory really exists
Matthieu Patou [Wed, 8 Jun 2011 21:01:25 +0000 (01:01 +0400)]
tests: Add alpha13 dumped provision
Matthieu Patou [Wed, 8 Jun 2011 08:20:32 +0000 (12:20 +0400)]
s4-dsdb: Use controls provided during the request while searching for object to delete
If the parent request specify the show_deleted control we must use it in
order to be able to see the deleted objects.
Also we just allow to trusted connections with the system account to
remove deleted objects, others receive an unwilling to perform.
Matthieu Patou [Sat, 4 Jun 2011 20:42:35 +0000 (00:42 +0400)]
s4-dsdb: check group membership only for non deleted objects
Group membership has been already removed on deleted objects so there is
no mean doing something on this kind of object.
Andrew Tridgell [Wed, 20 Jul 2011 05:31:42 +0000 (15:31 +1000)]
s4-dsdb: change the samba3sam test to add the show_deleted module
this is needed now that the samldb module adds the show deleted
control
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>