obnox/wireshark/wip.git
13 years agoFix warning.
cmaynard [Tue, 16 Nov 2010 16:40:16 +0000 (16:40 +0000)]
Fix warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34904 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUpdate the description of the temporary file name.
cmaynard [Tue, 16 Nov 2010 16:15:04 +0000 (16:15 +0000)]
Update the description of the temporary file name.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34903 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse more meaningful temp file name. Fixes bug 1882.
cmaynard [Tue, 16 Nov 2010 15:37:37 +0000 (15:37 +0000)]
Use more meaningful temp file name.  Fixes bug 1882.
Template chosen is: wireshark_<iface>_YYYYmmddHHMMSS_XXXXXX ... where
    <iface> is the interface name (or UUID part of the interface if applicable)
    YYYYmmddHHMMSS are as described in "man strftime".
    XXXXXX is a template filled in with random characters.  See "man mkstemp".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34902 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoModify 'compare_files' target: ignore #line changes; compare from epan\dissectors...
wmeier [Tue, 16 Nov 2010 15:24:51 +0000 (15:24 +0000)]
Modify 'compare_files' target: ignore #line changes; compare from epan\dissectors to asn1\...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34901 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse value_string_ext fcns to access several value_string arrays;
wmeier [Tue, 16 Nov 2010 15:20:33 +0000 (15:20 +0000)]
Use value_string_ext fcns to access several value_string arrays;
Minor whitespace cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34900 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Yaniv Kaul via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5400 :
morriss [Tue, 16 Nov 2010 15:01:43 +0000 (15:01 +0000)]
From Yaniv Kaul via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5400 :

The attached patch adds many more DAAP codes to be parsed properly by the DAAP
dissector.
In addition, it fixes some prints.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34899 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoTry to clean up the makefile a bit.
etxrab [Tue, 16 Nov 2010 09:15:15 +0000 (09:15 +0000)]
Try to clean up the makefile a bit.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34898 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAccomodate older flex versions.
jake [Tue, 16 Nov 2010 06:46:12 +0000 (06:46 +0000)]
Accomodate older flex versions.
Make scanner compilation more environment agnostic.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34897 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFirst try to install docbook stuff as well - not yet working
jmayer [Tue, 16 Nov 2010 00:20:31 +0000 (00:20 +0000)]
First try to install docbook stuff as well - not yet working

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34896 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAnother unused function with MAIN_MENU_USE_UIMANAGER
jmayer [Tue, 16 Nov 2010 00:18:54 +0000 (00:18 +0000)]
Another unused function with MAIN_MENU_USE_UIMANAGER

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34895 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse value_string_ext fcns to access several value_string arrays.
wmeier [Mon, 15 Nov 2010 23:53:25 +0000 (23:53 +0000)]
Use value_string_ext fcns to access several value_string arrays.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34894 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAssert was firing while working out sequence length for user plane frames.
martinm [Mon, 15 Nov 2010 23:32:34 +0000 (23:32 +0000)]
Assert was firing while working out sequence length for user plane frames.
Treat signalling plane case separately.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34893 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse value_string_ext fcns to access several value_string arrays.
wmeier [Mon, 15 Nov 2010 22:37:35 +0000 (22:37 +0000)]
Use value_string_ext fcns to access several value_string arrays.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34891 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse value_string_ext fcns to access several value_string arrays.
wmeier [Mon, 15 Nov 2010 22:00:33 +0000 (22:00 +0000)]
Use value_string_ext fcns to access several value_string arrays.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34890 f5534014-38df-0310-8fa8-9805f1628bb7

13 years ago"Fill" value_strings.
etxrab [Mon, 15 Nov 2010 21:32:27 +0000 (21:32 +0000)]
"Fill" value_strings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34888 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse value_string ext for address family.
etxrab [Mon, 15 Nov 2010 21:05:03 +0000 (21:05 +0000)]
Use value_string ext for address family.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34887 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Fred Fierling via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5395 :
morriss [Mon, 15 Nov 2010 20:52:41 +0000 (20:52 +0000)]
From Fred Fierling via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5395 :

The ZigBee security dissector was not recording the short to long address
mappings in Security Headers, preventing the decryption of some payloads. This
patch eliminates the Undecoded warnings in packets 1 and 19 in this test
capture: https://bugs.wireshark.org/bugzilla/attachment.cgi?id=5457

The keys to decrypt these packets are listed in the bug.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34886 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agocmake stuff:
jmayer [Mon, 15 Nov 2010 20:25:28 +0000 (20:25 +0000)]
cmake stuff:
- Fix fallout from gtk/text_import_scanner.l patch: Wireshark will
  build with cmake again.
- Update README.cmake a bit
- Running "cmake -DUI_MANAGER=ON" will give you the new ui-manager.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34885 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse value_string_ext fcns to access a value_string array.
wmeier [Mon, 15 Nov 2010 19:46:07 +0000 (19:46 +0000)]
Use value_string_ext fcns to access a value_string array.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34884 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse value_string_ext fcns to access a value_string array.
wmeier [Mon, 15 Nov 2010 19:15:34 +0000 (19:15 +0000)]
Use value_string_ext fcns to access a value_string array.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34883 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse value_string_ext fcns to access certain value_string arrays;
wmeier [Mon, 15 Nov 2010 19:08:12 +0000 (19:08 +0000)]
Use value_string_ext fcns to access certain value_string arrays;
Whitespace cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34882 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUpdate package_name_vals[] value_string array:
wmeier [Mon, 15 Nov 2010 19:00:16 +0000 (19:00 +0000)]
Update package_name_vals[] value_string array:
- Add new entries based on: http://www.iana.org/assignments/megaco-h248 last updated 2010-10-01;
- Fix a typo (incorrect value for an entry);
- Switch values between two entries to match the IANA list;
- Switch two entries so list is in ascending order by value.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34881 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Gerhard Gappmeier via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5406 :
morriss [Mon, 15 Nov 2010 18:52:41 +0000 (18:52 +0000)]
From Gerhard Gappmeier via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5406 :

I attached a patch which fixes some problems in the array handling of OPC UA
data when the array length is zero or -1 which is a Null-Array.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34880 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoSkip reserved word in ANCP OAM-Loopback-Test-Parameters TLV.
jake [Mon, 15 Nov 2010 18:28:36 +0000 (18:28 +0000)]
Skip reserved word in ANCP OAM-Loopback-Test-Parameters TLV.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34879 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Shoichi Sakane via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5270 :
morriss [Mon, 15 Nov 2010 18:01:19 +0000 (18:01 +0000)]
From Shoichi Sakane via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5270 :

I improved the coap dissector.  It is resulted by the 2nd coap test event.
This patch is diff from 34794.  The fuzzying test passed more than 62000.

Changed:
- removed "#if 0", and expanded exp2().
- added new error codes.
- improved looks of the block options
- renamed to "token" from "opaque_bytes" according to new draft.

From me: Use a use a left shift operation instead of multiplying by 2 many
times.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34878 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Fred Fierling via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5403 :
morriss [Mon, 15 Nov 2010 16:56:54 +0000 (16:56 +0000)]
From Fred Fierling via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5403 :

Fix recent fuzz failures.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34877 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRegenerate packet-nbap.c now that asn2wrs sorts value_string arrays used with value_s...
wmeier [Mon, 15 Nov 2010 16:46:14 +0000 (16:46 +0000)]
Regenerate packet-nbap.c now that asn2wrs sorts value_string arrays used with value_string_ext fcns;
Change nbap.cnf to use val_to_str_ext to access protocolIE_ID value_string array.
Also: Minor whitespace cleanup in nbap.cnf.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34876 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFill value_strings.
etxrab [Mon, 15 Nov 2010 16:46:07 +0000 (16:46 +0000)]
Fill value_strings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34875 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoSort value_string array by value if used with value_str_ext fcns;
wmeier [Sun, 14 Nov 2010 23:48:07 +0000 (23:48 +0000)]
Sort value_string array by value if used with value_str_ext fcns;

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34874 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoIgnore generated text_import_scanner_lex.h and text_import_scanner.c
stig [Sun, 14 Nov 2010 21:59:57 +0000 (21:59 +0000)]
Ignore generated text_import_scanner_lex.h and text_import_scanner.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34873 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoExtend value_strings to make full use of value_string_ext.
etxrab [Sun, 14 Nov 2010 20:53:15 +0000 (20:53 +0000)]
Extend value_strings to make full use of value_string_ext.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34872 f5534014-38df-0310-8fa8-9805f1628bb7

13 years ago'tshark -G values' - Validate (somewhat) value_string_ext before use to prevent a...
wmeier [Sun, 14 Nov 2010 16:30:56 +0000 (16:30 +0000)]
'tshark -G values' - Validate (somewhat) value_string_ext before use to prevent a crash.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34869 f5534014-38df-0310-8fa8-9805f1628bb7

13 years ago[Automatic manuf, services and enterprise-numbers update for 2010-11-14]
gerald [Sun, 14 Nov 2010 16:03:37 +0000 (16:03 +0000)]
[Automatic manuf, services and enterprise-numbers update for 2010-11-14]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34868 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd proto_item_append_string() to exported functions per:
sfisher [Sun, 14 Nov 2010 15:53:41 +0000 (15:53 +0000)]
Add proto_item_append_string() to exported functions per:

  http://www.wireshark.org/lists/wireshark-dev/201011/msg00153.html

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34867 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix a cut-n-paste error.
etxrab [Sun, 14 Nov 2010 14:13:52 +0000 (14:13 +0000)]
Fix a cut-n-paste error.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34866 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix a couple of cut-n-paste errors.
etxrab [Sun, 14 Nov 2010 09:57:42 +0000 (09:57 +0000)]
Fix a couple of cut-n-paste errors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34865 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Fred Fierling:
etxrab [Sat, 13 Nov 2010 20:13:30 +0000 (20:13 +0000)]
From Fred Fierling:
Patch to fix dissector bug noticed in ZigBee APS commands with null payload.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5384

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34864 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix a typo.
etxrab [Sat, 13 Nov 2010 20:09:01 +0000 (20:09 +0000)]
Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34863 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoTry to fix the build for text_import_scanner.
etxrab [Sat, 13 Nov 2010 16:47:57 +0000 (16:47 +0000)]
Try to fix the build for text_import_scanner.
Please check if the compile flags are OK...
3:d time lucky ?

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34862 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoTry to fix the build for text_import_scanner.
etxrab [Sat, 13 Nov 2010 16:24:14 +0000 (16:24 +0000)]
Try to fix the build for text_import_scanner.
Please check if the compile flags are OK...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34861 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd newline at end of file.
martinm [Sat, 13 Nov 2010 16:04:00 +0000 (16:04 +0000)]
Add newline at end of file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34860 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Pascal Quantin:
martinm [Sat, 13 Nov 2010 15:32:29 +0000 (15:32 +0000)]
From Pascal Quantin:

- Set a default RNTI value for each type, in case optional RNTI value isn't supplied.
- Improve range checking of given type against acceptable range of values
- fix misplaced return (this fixed bug 5392)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34859 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoTry to fix the build for text_import_scanner,
etxrab [Sat, 13 Nov 2010 14:47:53 +0000 (14:47 +0000)]
Try to fix the build for text_import_scanner,
not sure if it's correct but now it builds text_import_scanner.c
but still fails with:

c:\wireshark\gtk\text_import.h(34) : fatal error C1083: Cannot open include file
: 'glib.h': No such file or directory
NMAKE : fatal error U1077: '"c:\Program Files (x86)\Microsoft Visual Studio 9.0\
VC\BIN\x86_amd64\cl.EXE"' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"c:\Program Files (x86)\Microsoft Visual Studio 9.0\
VC\BIN\nmake.exe"' : return code '0x2'
Stop.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34858 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoGet the build going again from the source distribution, with text import.
jake [Sat, 13 Nov 2010 11:35:21 +0000 (11:35 +0000)]
Get the build going again from the source distribution, with text import.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34857 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd text import capability, like text2pcap, directly into the GUI.
jake [Fri, 12 Nov 2010 22:20:12 +0000 (22:20 +0000)]
Add text import capability, like text2pcap, directly into the GUI.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34856 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agozbee_mfr_code_names: sort so in ascending order by value; add dummy "Unknown" entries...
wmeier [Fri, 12 Nov 2010 21:47:41 +0000 (21:47 +0000)]
zbee_mfr_code_names: sort so in ascending order by value; add dummy "Unknown" entries for missing values.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34855 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoEnhance 'tshark -G values': Add info about extended value strings (including acess...
wmeier [Fri, 12 Nov 2010 19:48:30 +0000 (19:48 +0000)]
Enhance 'tshark -G values': Add info about extended value strings (including acess method).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34854 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix a crash I introduced in SVN #34692: A value_string ext referenced smb_cmd_vals...
wmeier [Fri, 12 Nov 2010 17:28:01 +0000 (17:28 +0000)]
Fix a crash I introduced in SVN #34692: A value_string ext referenced smb_cmd_vals rather than smb_cmd_vals_ext.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34853 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoCheck given RNTI value is consistent with given RNTI-type.
martinm [Fri, 12 Nov 2010 16:59:22 +0000 (16:59 +0000)]
Check given RNTI value is consistent with given RNTI-type.

As suggested in bug 5382.  The reported crash didn't happen for me...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34852 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix a column typo, and give them different menu accelerator keys.
martinm [Fri, 12 Nov 2010 16:14:09 +0000 (16:14 +0000)]
Fix a column typo, and give them different menu accelerator keys.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34851 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse val_to_str_const & val_to_str_ext_const where appropriate.
wmeier [Fri, 12 Nov 2010 15:34:30 +0000 (15:34 +0000)]
Use val_to_str_const & val_to_str_ext_const where appropriate.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34850 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUpdate Camel to TS 29.078 9.2.0 (2010-06)
etxrab [Fri, 12 Nov 2010 14:50:58 +0000 (14:50 +0000)]
Update Camel to TS 29.078 9.2.0 (2010-06)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34849 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse python comments in python code.
stig [Fri, 12 Nov 2010 13:32:04 +0000 (13:32 +0000)]
Use python comments in python code.

Reported by Emil Wojak in bug 5389.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34848 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoGetting wrong addr_type from the packet is not a dissector bug.
stig [Fri, 12 Nov 2010 07:54:39 +0000 (07:54 +0000)]
Getting wrong addr_type from the packet is not a dissector bug.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34847 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUpdate from IANA records.
etxrab [Thu, 11 Nov 2010 21:18:46 +0000 (21:18 +0000)]
Update from IANA records.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34846 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse value_string_ext.
etxrab [Thu, 11 Nov 2010 21:18:15 +0000 (21:18 +0000)]
Use value_string_ext.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34845 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse value_string_ext.
etxrab [Thu, 11 Nov 2010 17:24:11 +0000 (17:24 +0000)]
Use value_string_ext.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34844 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUpdate AVP:s
etxrab [Thu, 11 Nov 2010 16:33:47 +0000 (16:33 +0000)]
Update AVP:s

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34843 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix indentation.
etxrab [Thu, 11 Nov 2010 07:37:43 +0000 (07:37 +0000)]
Fix indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34842 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoOS X 10.6.5 is out, and it re-incorporates the libpcap workaround for
guy [Thu, 11 Nov 2010 07:34:12 +0000 (07:34 +0000)]
OS X 10.6.5 is out, and it re-incorporates the libpcap workaround for
the BPF BIOCSRTIMEOUT bug in 64-bit mode, so we don't need to do our own
workaround in 10.6.5 or later.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34841 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Andrew Feren:
etxrab [Thu, 11 Nov 2010 07:34:07 +0000 (07:34 +0000)]
From Andrew Feren:
sflow decode error for some extended formats.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5379

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34840 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agofollow up commit 34838 (get rid of packet-vlan.?
jmayer [Wed, 10 Nov 2010 23:27:10 +0000 (23:27 +0000)]
follow up commit 34838 (get rid of packet-vlan.?

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34839 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoResolve bug #2254: Migrate the 802.1q VLAN dissector into the Ethernet II.
sfisher [Wed, 10 Nov 2010 22:37:30 +0000 (22:37 +0000)]
Resolve bug #2254: Migrate the 802.1q VLAN dissector into the Ethernet II.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34838 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoConvert host name to UTF8 before displaying to info column or in tree.
cmaynard [Wed, 10 Nov 2010 21:41:10 +0000 (21:41 +0000)]
Convert host name to UTF8 before displaying to info column or in tree.
Fixes bug 1867.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34837 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFill up enums, whitespace changes.
etxrab [Wed, 10 Nov 2010 20:48:10 +0000 (20:48 +0000)]
Fill up enums, whitespace changes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34836 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoMake value_string_ext for all AVP:s with enums.
etxrab [Wed, 10 Nov 2010 20:11:38 +0000 (20:11 +0000)]
Make value_string_ext for all AVP:s with enums.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34835 f5534014-38df-0310-8fa8-9805f1628bb7

13 years ago[Automatic manuf, services and enterprise-numbers update for 2010-11-10]
gerald [Wed, 10 Nov 2010 15:25:11 +0000 (15:25 +0000)]
[Automatic manuf, services and enterprise-numbers update for 2010-11-10]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34832 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoMake a more descriptive name for the per vendor avp value_string_ext.
etxrab [Wed, 10 Nov 2010 14:43:20 +0000 (14:43 +0000)]
Make a more descriptive name for the per vendor avp value_string_ext.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34831 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdded hint about "TCP segmentation offload" when IP length == 0.
stig [Wed, 10 Nov 2010 13:49:55 +0000 (13:49 +0000)]
Added hint about "TCP segmentation offload" when IP length == 0.
Added expert info item for bogus IP length.
Added hint about "IP checksum offload" for invalid IP checksum.
Describe TSO in the preference setting.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34830 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Michael Wells: Fix "missing path seperator in config.nmake"
wmeier [Tue, 9 Nov 2010 23:03:47 +0000 (23:03 +0000)]
From Michael Wells: Fix "missing path seperator in config.nmake"
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5378

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34829 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix a few typos in two value_string arrays ....
wmeier [Tue, 9 Nov 2010 22:58:17 +0000 (22:58 +0000)]
Fix a few typos in two value_string arrays ....

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34828 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFill th Q.850 tables.
etxrab [Tue, 9 Nov 2010 21:13:28 +0000 (21:13 +0000)]
Fill th Q.850 tables.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34827 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRemove comments.
etxrab [Tue, 9 Nov 2010 17:26:34 +0000 (17:26 +0000)]
Remove comments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34826 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd a value_string_ext.
etxrab [Tue, 9 Nov 2010 17:24:45 +0000 (17:24 +0000)]
Add a value_string_ext.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34825 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoDefine unused AVP:s to make it possible to use value_string_ext for
etxrab [Tue, 9 Nov 2010 17:23:57 +0000 (17:23 +0000)]
Define unused AVP:s to make it possible to use value_string_ext for
common AVP:s.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34824 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoBugfix from Irene Ruengeler to improve the TSN plot for SCTP
tuexen [Tue, 9 Nov 2010 16:29:15 +0000 (16:29 +0000)]
Bugfix from Irene Ruengeler to improve the TSN plot for SCTP
when large gap reports are present.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34823 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoPython 2.7 is now the current Production version of Python.
wmeier [Tue, 9 Nov 2010 15:47:41 +0000 (15:47 +0000)]
Python 2.7 is now the current Production version of Python.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34822 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdded check for valid finfo->ds_tvb in packet_hex_print(), as we do not
stig [Tue, 9 Nov 2010 12:31:50 +0000 (12:31 +0000)]
Added check for valid finfo->ds_tvb in packet_hex_print(), as we do not
always have finfo->ds_tvb.

This bug was introdused in revision 34796.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34821 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdded an expert info for illegal integer length.
stig [Tue, 9 Nov 2010 12:17:11 +0000 (12:17 +0000)]
Added an expert info for illegal integer length.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34820 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRemoved calls to proto_item_set_expert_flags(), as this will be called
stig [Tue, 9 Nov 2010 12:15:55 +0000 (12:15 +0000)]
Removed calls to proto_item_set_expert_flags(), as this will be called
in expert_add_info_format().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34819 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse value_string_ext for gsm_a_rr_rxlev_vals.
etxrab [Tue, 9 Nov 2010 07:28:04 +0000 (07:28 +0000)]
Use value_string_ext for gsm_a_rr_rxlev_vals.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34818 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFixed typos.
cmaynard [Tue, 9 Nov 2010 03:30:55 +0000 (03:30 +0000)]
Fixed typos.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34817 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFixed typos.
cmaynard [Tue, 9 Nov 2010 03:20:15 +0000 (03:20 +0000)]
Fixed typos.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34816 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFixed typos.
cmaynard [Tue, 9 Nov 2010 02:50:29 +0000 (02:50 +0000)]
Fixed typos.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34815 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUpdate to 3GPP TS 29.002 V9.3.0 (2010-09)
etxrab [Mon, 8 Nov 2010 23:15:16 +0000 (23:15 +0000)]
Update to 3GPP TS 29.002 V9.3.0 (2010-09)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34814 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse value_string_ext fcns to access certain value_string arrays;
wmeier [Mon, 8 Nov 2010 21:59:39 +0000 (21:59 +0000)]
Use value_string_ext fcns to access certain value_string arrays;
Sort a few value_string arrays to be in ascending order by value;
Do minor reformatting and whitespace cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34813 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRemove two duplicate values from rtp_payload_type_short_vals value_string array.
wmeier [Mon, 8 Nov 2010 21:35:14 +0000 (21:35 +0000)]
Remove two duplicate values from rtp_payload_type_short_vals value_string array.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34812 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRemove two duplicate entries from rtp_payload_type_vals array.
wmeier [Mon, 8 Nov 2010 21:24:10 +0000 (21:24 +0000)]
Remove two duplicate entries from rtp_payload_type_vals array.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34811 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoTweek dns_types.
etxrab [Mon, 8 Nov 2010 18:05:42 +0000 (18:05 +0000)]
Tweek dns_types.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34810 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix gcc warning. (Sorry, but VS2008EE complains a LOT less.)
cmaynard [Mon, 8 Nov 2010 17:54:32 +0000 (17:54 +0000)]
Fix gcc warning.  (Sorry, but VS2008EE complains a LOT less.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34809 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoMake maxlen a gsize instead of a guint.
cmaynard [Mon, 8 Nov 2010 17:53:13 +0000 (17:53 +0000)]
Make maxlen a gsize instead of a guint.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34808 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoIf svn not found, print "Unknown" revision message.
cmaynard [Mon, 8 Nov 2010 17:10:35 +0000 (17:10 +0000)]
If svn not found, print "Unknown" revision message.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34807 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoEnsure strings are properly quoted for CSV output. Fixes bug 1297.
cmaynard [Mon, 8 Nov 2010 17:05:30 +0000 (17:05 +0000)]
Ensure strings are properly quoted for CSV output.  Fixes bug 1297.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34806 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAllow objects to be saved that otherwise couldn't be due to invalid characters
cmaynard [Mon, 8 Nov 2010 16:53:11 +0000 (16:53 +0000)]
Allow objects to be saved that otherwise couldn't be due to invalid characters
in the filename, excessive filename lengths or duplicate filenames.  Fixes
bug 1671.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34805 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse value_string_ext for RTP payload types.
etxrab [Mon, 8 Nov 2010 14:43:59 +0000 (14:43 +0000)]
Use value_string_ext for RTP payload types.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34804 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoMake the changes from:
etxrab [Sun, 7 Nov 2010 20:51:16 +0000 (20:51 +0000)]
Make the changes from:
Use value_string_ext fcns to access certain value_string arrays;
Sort certain value_string arrays so the values are in ascending order;
Use val_to_str_ext() instead of for loops to do value_string array lookups (voip_calls.c).
Minor whitespace cleanup.
In the source files of the as2wrs generated dissectors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34803 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoThe PEN field is 32 bits.
gerald [Sun, 7 Nov 2010 18:21:22 +0000 (18:21 +0000)]
The PEN field is 32 bits.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34802 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agodisplay the the PDU length as "cut short"if it crosses the boundary of the
etxrab [Sat, 6 Nov 2010 21:05:45 +0000 (21:05 +0000)]
display the the PDU length as "cut short"if it crosses the boundary of the
 * packet and no more packets are available.
Based on the patch from Alexander Koeppe in
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5285

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34799 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse guint16 after all, to avoid breaking the UDP framing protocol.
martinm [Sat, 6 Nov 2010 19:22:16 +0000 (19:22 +0000)]
Use guint16 after all, to avoid breaking the UDP framing protocol.
8 bits are enough though...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34798 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoTry to fix by making both use guint8, rather than guint16.
martinm [Sat, 6 Nov 2010 18:51:08 +0000 (18:51 +0000)]
Try to fix by making both use guint8, rather than guint16.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34797 f5534014-38df-0310-8fa8-9805f1628bb7