add some comments re desirability of renaming fields

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24059 f5534014-38df-0310-8fa8-9805f1628bb7

diff --git a/asn1/gsmmap/packet-gsmmap-template.c b/asn1/gsmmap/packet-gsmmap-template.c
index bdc3ac43755c0e669902feedc9acea2c2bc0065c..3ed508439d771de5062ee48469a37173c88bf60b 100644 (file)
--- a/asn1/gsmmap/packet-gsmmap-template.c
+++ b/asn1/gsmmap/packet-gsmmap-template.c
@@ -1,3 +1,14 @@
+/* XXX see bug 1852:
+ *
+ * packet-gsm_map.c: There are 1174 display filter fields registered.  Most are
+ * prefixed appropriately as "gsm_map", but many others are prefixed as
+ * "gsm_old", or even "gad", "gsm_ss", or with no prefix at all.  I don't know
+ * if the ones with "gsm_old" are simply obsolete display filter fields or if
+ * they should be prefixed as "gsm_map.old." or what.  Similar uncertainties
+ * for the others. Someone more knowledgeable than I am with respect to this
+ * dissector should provide a patch for it.
+ */
+
 /* packet-gsm_map-template.c
  * Routines for GSM MobileApplication packet dissection
  * including GSM SS.

diff --git a/epan/dissectors/packet-gsm_a.c b/epan/dissectors/packet-gsm_a.c
index c8634b8f04badc9624fedf096c43c6599abed41e..6bdf0d4e085e907d5c9002f219c3eb861415be29 100644 (file)
--- a/epan/dissectors/packet-gsm_a.c
+++ b/epan/dissectors/packet-gsm_a.c
@@ -1,3 +1,16 @@
+/*
+ * XXX: The size of this file is ludicrous; if anybody is working on it, it
+ * would be good to split it up.
+ *
+ * See also bug 1852:
+ * packet-gsm_a.c: gsm_a_bssmap has 121 registered fields.  Only a limited
+ * few are prefixed to match the PROTOABBREV.  Some of the fields seem as
+ * though they would be more appropriately registered under either gsm_a_dtap
+ * or possibly gsm_a_rp.  I don't have the expertise with these dissectors to
+ * provide an appropriate patch to reconcile these problems.
+ *
+ */
+
 /* packet-gsm_a.c
  * Routines for GSM A Interface (BSSMAP/DTAP) dissection
  *