Don't assign to an unused 'proto_item *': Coverity 939 [UNUSED];
authorwmeier <wmeier@f5534014-38df-0310-8fa8-9805f1628bb7>
Wed, 18 May 2011 16:52:45 +0000 (16:52 +0000)
committerwmeier <wmeier@f5534014-38df-0310-8fa8-9805f1628bb7>
Wed, 18 May 2011 16:52:45 +0000 (16:52 +0000)
Don't create a subtree which is never used: Coverity 940 [UNUSED].

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37243 f5534014-38df-0310-8fa8-9805f1628bb7

epan/dissectors/packet-isis-clv.c

index 093b55ae94b8e8c2aed4339c1039353abf28c935..61a6e2d708401a5d7527ec618568e84ab6c5a03e 100644 (file)
@@ -74,7 +74,7 @@ isis_dissect_area_address_clv(tvbuff_t *tvb, proto_tree *tree, int offset,
 
                if ( tree ) {
                        proto_item *ti;
-       
+
                        /*
                         * Throw an exception rather than putting in a
                         * partial address.
@@ -172,7 +172,7 @@ isis_dissect_authentication_clv(tvbuff_t *tvb, proto_tree *tree, int offset,
                }
                break;
        default:
-               ti = proto_tree_add_text ( tree, tvb, offset - 1, length + 1,
+               proto_tree_add_text ( tree, tvb, offset - 1, length + 1,
                    "type 0x%02x (0x%02x): ", pw_type, length );
                auth_unsupported=TRUE;
                break;
@@ -553,6 +553,7 @@ isis_dissect_clvs(tvbuff_t *tvb, proto_tree *tree, int offset,
                        opts[q].dissect(tvb, clv_tree, offset,
                                id_length, length);
                } else {
+#if 0 /* XXX: Left as commented out in case info about "unknown code" is ever to be displayed under a sub-tree */
                        if (tree) {
                                ti = proto_tree_add_text(tree, tvb, offset - 2,
                                        length + 2, "Unknown code %u (%u)",
@@ -562,6 +563,13 @@ isis_dissect_clvs(tvbuff_t *tvb, proto_tree *tree, int offset,
                        } else {
                                clv_tree = NULL;
                        }
+#else
+                       if (tree) {
+                               ti = proto_tree_add_text(tree, tvb, offset - 2,
+                                       length + 2, "Unknown code %u (%u)",
+                                       code, length);
+                       }
+#endif
                }
                offset += length;
        }